[code-reflection] RFR: Beef up reference resolution code and test [v2]

Paul Sandoz psandoz at openjdk.org
Thu Nov 13 19:28:42 UTC 2025


On Thu, 13 Nov 2025 18:36:19 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:

>> This PR improves the code for method/field/constructor resolution. To resolve fields and methods we have to perform two MH lookups, and find if any of them succeds. Since to code to do this is a bit convoluted, I have reimplemented the resolution support to use a more functional style (inspired by `Either` type).
>> 
>> I have also added several tests to make sure we test several lookup combinations, for instance/static method/fields, and also for super method resolution.
>> 
>> We will probably need more tests to cover the entire spectrum, but this should be at least a start.
>> 
>> I found 2 (!!) JDK issues when writing these tests, so some of the new tests contain workarounds.
>
> Maurizio Cimadamore has updated the pull request incrementally with one additional commit since the last revision:
> 
>   recordify RecordTypeRef
>   drop redundant instanceof

Marked as reviewed by psandoz (Lead).

-------------

PR Review: https://git.openjdk.org/babylon/pull/682#pullrequestreview-3461336765


More information about the babylon-dev mailing list