[code-reflection] RFR: OpBuilder optimizations - part 1. [v12]
Mourad Abbay
mabbay at openjdk.org
Wed Nov 19 12:18:39 UTC 2025
On Wed, 19 Nov 2025 09:57:34 GMT, Adam Sotona <asotona at openjdk.org> wrote:
>> This PR include following changes:
>>
>> - op-building methods delegate to a synthetic inner class
>> - fixed boxing in `OpBuilder`
>> - op-building methods are generated by `BytecodeGenerator` and support wide range of ops
>> - `CodeModelTranslator` is deleted
>> - synthetic op-building method overrides significantly reduce overhead (by 60% on `TestBytecode`)
>> - refactored `OpBuilder` to build `ModuleOp` instead of individual `FuncCallOp`s
>> - fixed `BytecodeGenerator` to support `ModuleOp` and `FuncCallOp`
>
> Adam Sotona has updated the pull request incrementally with one additional commit since the last revision:
>
> fixed javadoc
src/jdk.incubator.code/share/classes/jdk/incubator/code/internal/ReflectMethods.java line 378:
> 376:
> 377: private JCMethodDecl opMethodDecl(Name methodName) {
> 378: // Create the method that constructs the code model stored in the class file
Is this comment outdated ? can we remove it ?
-------------
PR Review Comment: https://git.openjdk.org/babylon/pull/679#discussion_r2541758589
More information about the babylon-dev
mailing list