[code-reflection] RFR: Drop Quotable type [v2]

Maurizio Cimadamore mcimadamore at openjdk.org
Wed Nov 19 13:34:28 UTC 2025


On Wed, 19 Nov 2025 13:06:37 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:

>> Maurizio Cimadamore has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Further simplify code
>
> src/jdk.incubator.code/share/classes/jdk/incubator/code/internal/ReflectMethods.java line 371:
> 
>> 369:     }
>> 370: 
>> 371:     class BodyScanner extends TreeScannerPrev {
> 
> Note: `BodyScanner` also defines a `currentNode` field to keep track of the node being visited. Unfortunately, this field is also used _outside_ the scanning process -- e.g. before (at construction) and after (to finish up things). This means it is currently very hard to merge this field with `TreeScannerPrev.currentNode`. Maybe this is something we can look again in a separate PR.

Ok, NVM, I think I found a good way to consolidate the code and get rid of that field.

-------------

PR Review Comment: https://git.openjdk.org/babylon/pull/685#discussion_r2542022231


More information about the babylon-dev mailing list