[code-reflection] RFR: Add support for other onnx providers (CoreML) [v4]
Ana Maria Mihalceanu
duke at openjdk.org
Mon Oct 20 16:12:33 UTC 2025
On Mon, 20 Oct 2025 15:25:23 GMT, Adam Pocock <duke at openjdk.org> wrote:
>> Ana Maria Mihalceanu has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Remove tabs and convert to whitespaces only.
>
> cr-examples/onnx/src/main/java/oracle/code/onnx/provider/CoreMLProvider.java line 38:
>
>> 36: private int flag;
>> 37:
>> 38: public CoreMLProvider(int flag) {
>
> This is a small thing, but I'd probably call this `flags` as it's really a set of bits, so you can or the flags together to get a set of things to turn on.
Done 🫡
-------------
PR Review Comment: https://git.openjdk.org/babylon/pull/618#discussion_r2445467905
More information about the babylon-dev
mailing list