[code-reflection] RFR: Upgrade ONNX runtime to use API version 1.23.1 [v3]
Adam Sotona
asotona at openjdk.org
Wed Oct 29 18:48:05 UTC 2025
On Mon, 27 Oct 2025 21:59:52 GMT, Ana Maria Mihalceanu <duke at openjdk.org> wrote:
>> This PR contains the following:
>>
>> - [x] Upgrade to version 1.23.1 ONNX runtime API.
>> - [x] Refactoring of the python script as `AttributeProto` is now in `onnx` (I used version `1.19.1` which is the latest)
>> - [x] Regeneration of tensors and tensor operations.
>> - [x] Regeneration of the runtime API based on `onnxruntime_c_api.h`.
>> - [x] Appends execution provider options to runtime, as shown in the [new API](https://onnxruntime.ai/docs/execution-providers/CoreML-ExecutionProvider.html).
>> - [x] Allows users to append execution providers like `WebGpuExecutionProvider` and `CpuExecutionProvider` through `OnnxRuntime.appendExecutionProvider_V2` method.
>>
>> CC @LizeRaes
>
> Ana Maria Mihalceanu has updated the pull request incrementally with one additional commit since the last revision:
>
> Allow low-precision accumulation on a GPU.
>
> Signed-off-by: ammbra <mihalceanuana at gmail.com>
It looks and works great!
I found just some NITs.
cr-examples/onnx/src/main/java/oracle/code/onnx/OnnxProvider.java line 1:
> 1: package oracle.code.onnx;
Missing copyright header
cr-examples/onnx/src/test/java/oracle/code/onnx/fer/FERInference.java line 35:
> 33: import java.lang.foreign.Arena;
> 34: import java.net.URL;
> 35: import java.util.Map;
unused imports?
cr-examples/onnx/src/test/java/oracle/code/onnx/fer/FERInference.java line 39:
> 37:
> 38: import static oracle.code.onnx.fer.FERCoreMLDemo.IMAGE_SIZE;
> 39: import static oracle.code.onnx.foreign.onnxruntime_c_api_h.*;
unused imports?
-------------
Marked as reviewed by asotona (Reviewer).
PR Review: https://git.openjdk.org/babylon/pull/645#pullrequestreview-3395251346
PR Review Comment: https://git.openjdk.org/babylon/pull/645#discussion_r2474595088
PR Review Comment: https://git.openjdk.org/babylon/pull/645#discussion_r2474677780
PR Review Comment: https://git.openjdk.org/babylon/pull/645#discussion_r2474681806
More information about the babylon-dev
mailing list