[code-reflection] RFR: Float4 arrayView support
Juan Fumero
jfumero at openjdk.org
Fri Oct 31 22:04:56 UTC 2025
On Tue, 28 Oct 2025 18:13:01 GMT, Ruby Chen <duke at openjdk.org> wrote:
>> hat/core/src/main/java/hat/phases/HATDialectifyArrayViewPhase.java line 165:
>>
>>> 163: }
>>> 164: // handles only 1D and 2D arrays
>>> 165: case JavaOp.ArrayAccessOp.ArrayLoadOp alop -> {
>>
>> My take is that this phase is hitting this `case` for all the actual array view. If the prev. block still insert the dialect ops for vectors, we could substitute the prev.. pipeline of hat phases with this one.
>
> Oh interesting, are you proposing combining some of the hat phases into one larger overall phase using this `case` logic?
If the whole logic works, then yes, we can condense it in one phase. I personally prefer different compiler phases, so if something goes wrong, or we find a new use-case that does not match the patterns for one of the phases, we can easily detect phases involved. But not strong opinion.
-------------
PR Review Comment: https://git.openjdk.org/babylon/pull/646#discussion_r2472259888
More information about the babylon-dev
mailing list