[code-reflection] RFR: Fix SSABraun bug and add SSA tests [v2]

[Ruby Chen]

On Wed, 10 Sep 2025 19:32:57 GMT, Ruby Chen <duke at openjdk.org> wrote:

>> src/jdk.incubator.code/share/classes/jdk/incubator/code/analysis/SSABraun.java line 200:
>> 
>>> 198:         for (Phi user : phiUsers) {
>>> 199:             Val res = tryRemoveTrivialPhi(user);
>>> 200:             if (same.equals(user)) {
>> 
>> For consistency, could you also use `==` here?
>
> Actually, I'm looking into that right now! I'm not sure if that might cause some issues if there are two var stores that use the same operand - doing some testing atm
> Can I ask why you chose to use `==` instead of `.equals()` when comparing Vals/Phis?

I think for now, I'll move forward with `==` but I'll also keep an eye out in case it causes any issues 👍

-------------

PR Review Comment: https://git.openjdk.org/babylon/pull/542#discussion_r2341952953