[code-reflection] RFR: Use JUnit instead of TestNG
Maurizio Cimadamore
mcimadamore at openjdk.org
Mon Sep 15 12:26:35 UTC 2025
On Fri, 12 Sep 2025 17:42:38 GMT, Mourad Abbay <mabbay at openjdk.org> wrote:
> Use JUnit instead of TestNG
Aside from @PaulSandoz comment, PR looks good
test/langtools/tools/javac/reflect/TestIRFromAnnotation.java line 68:
> 66: // in method superInterfaceMethodInvocation
> 67: "LocalClassTest.java", // name of local classes is not stable at annotation processing time
> 68: "TestLocalCapture.java", // plain junit test
When looking again at this, it would perhaps be beneficial to put all the IR tests in a separate folder. It seems a bit sad that whenever we add a "plain" test we have to come back and list it here.
The exclusion for `SuperTest`/`LocalClassTest` of course make more sense, so it's ok for them to stay.
-------------
Marked as reviewed by mcimadamore (Reviewer).
PR Review: https://git.openjdk.org/babylon/pull/566#pullrequestreview-3224337709
PR Review Comment: https://git.openjdk.org/babylon/pull/566#discussion_r2348821943
More information about the babylon-dev
mailing list