[code-reflection] RFR: Improved error message if Reflect annotation is missing on transitive methods from kernel method [v5]
Nadeesh TV
ntv at openjdk.org
Thu Jan 8 21:53:08 UTC 2026
> **Description**
> Currently, if we miss the @**Reflect** annotation on methods called from kernel functions, no method is generated for them in the corresponding backend. This causes an error like:
>
> `> error: implicit declaration of function 'squareitWithoutReflectAnnotation' is invalid...
> `
> **Solution**
> - Throw error if Reflect annotation is missing on all methods called from the kernel function that are defined in the same class as the kernel function.
>
> **Test**
> - A new test is added at **hat.test.TestMissingReflectAnnotation#testTransitiveMethodFromKernelWithoutReflectAnnotation**
Nadeesh TV has updated the pull request incrementally with 21 additional commits since the last revision:
- rebase
- Remove files which was accidentally added back during rebase
- Removed previous transformer patter experiments
- More FP16Phase cleanup. Leveraging Invoke helper
- rebase
- se
- 8374550: API for casting Value to Op.Result and Block.Parameter
Reviewed-by: psandoz
- Added config bit help also forced txfmr to take a lookup
- More OpHelper maintenance
- Adding more support to the JavaCodeBuilder
- ... and 11 more: https://git.openjdk.org/babylon/compare/5febeee5...70498f17
-------------
Changes:
- all: https://git.openjdk.org/babylon/pull/798/files
- new: https://git.openjdk.org/babylon/pull/798/files/5febeee5..70498f17
Webrevs:
- full: https://webrevs.openjdk.org/?repo=babylon&pr=798&range=04
- incr: https://webrevs.openjdk.org/?repo=babylon&pr=798&range=03-04
Stats: 6085 lines in 70 files changed: 2386 ins; 2920 del; 779 mod
Patch: https://git.openjdk.org/babylon/pull/798.diff
Fetch: git fetch https://git.openjdk.org/babylon.git pull/798/head:pull/798
PR: https://git.openjdk.org/babylon/pull/798
More information about the babylon-dev
mailing list