[code-reflection] RFR: Make Quoted generic [v2]

Maurizio Cimadamore mcimadamore at openjdk.org
Thu Jan 15 11:31:45 UTC 2026


On Thu, 15 Jan 2026 00:25:18 GMT, Paul Sandoz <psandoz at openjdk.org> wrote:

>> Make `Quoted` generic with an upper bound of `Op`. Modify `Op.ofLambda` to return `Quoted<JavaOp.LambdaOp>`.
>
> Paul Sandoz has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Cleaning up remaining references to quotable.

Nice, most of the usages are simpler -- and I like that now we check that the nested op is a `LambdaOp` inside `Op.ofLambda`, instead of leaving that to clients

src/jdk.incubator.code/share/classes/jdk/incubator/code/dialect/core/CoreOp.java line 469:

> 467:         @Override
> 468:         public TypeElement resultType() {
> 469:             return QUOTED_OP_TYPE;

Should this type be parameterized by the actual op wrapped by this quoted op?

-------------

Marked as reviewed by mcimadamore (Reviewer).

PR Review: https://git.openjdk.org/babylon/pull/845#pullrequestreview-3665160898
PR Review Comment: https://git.openjdk.org/babylon/pull/845#discussion_r2694002859


More information about the babylon-dev mailing list