From alexander.v.stepanov at oracle.com Tue Aug 4 10:22:53 2015 From: alexander.v.stepanov at oracle.com (Alexander Stepanov) Date: Tue, 04 Aug 2015 13:22:53 +0300 Subject: [9] Review Request: 8131055 bean annotations: add a test checking if a user-defined BeanInfo is top-priority as compared with the annotations In-Reply-To: <55AE665B.3080009@oracle.com> References: <55AE665B.3080009@oracle.com> Message-ID: <55C0927D.7090604@oracle.com> Sorry, just a reminder. Thanks, Alexander On 7/21/2015 6:33 PM, alexander stepanov wrote: > Hello, > > Could you please review the following fix: > http://cr.openjdk.java.net/~avstepan/8131055/webrev.00/ > for the test bug > https://bugs.openjdk.java.net/browse/JDK-8131055 > > Just a single test added to the existing portion of unit tests for > JDK-4058433. Checked with JDK9 b73 (Ubuntu 14.04 Linux, Windows 7). > > Thanks, > Alexander From alexandr.scherbatiy at oracle.com Tue Aug 4 10:31:19 2015 From: alexandr.scherbatiy at oracle.com (Alexander Scherbatiy) Date: Tue, 04 Aug 2015 13:31:19 +0300 Subject: [9] Review Request: 8131055 bean annotations: add a test checking if a user-defined BeanInfo is top-priority as compared with the annotations In-Reply-To: <55C0927D.7090604@oracle.com> References: <55AE665B.3080009@oracle.com> <55C0927D.7090604@oracle.com> Message-ID: <55C09477.7080805@oracle.com> The fix looks good to me. Thanks, Alexandr. On 8/4/2015 1:22 PM, Alexander Stepanov wrote: > Sorry, just a reminder. > > Thanks, > Alexander > > On 7/21/2015 6:33 PM, alexander stepanov wrote: >> Hello, >> >> Could you please review the following fix: >> http://cr.openjdk.java.net/~avstepan/8131055/webrev.00/ >> for the test bug >> https://bugs.openjdk.java.net/browse/JDK-8131055 >> >> Just a single test added to the existing portion of unit tests for >> JDK-4058433. Checked with JDK9 b73 (Ubuntu 14.04 Linux, Windows 7). >> >> Thanks, >> Alexander > From alexander.v.stepanov at oracle.com Tue Aug 4 10:36:48 2015 From: alexander.v.stepanov at oracle.com (Alexander Stepanov) Date: Tue, 04 Aug 2015 13:36:48 +0300 Subject: [9] Review Request: 8131055 bean annotations: add a test checking if a user-defined BeanInfo is top-priority as compared with the annotations In-Reply-To: <55C09477.7080805@oracle.com> References: <55AE665B.3080009@oracle.com> <55C0927D.7090604@oracle.com> <55C09477.7080805@oracle.com> Message-ID: <55C095C0.4030002@oracle.com> Thanks! On 8/4/2015 1:31 PM, Alexander Scherbatiy wrote: > > The fix looks good to me. > > Thanks, > Alexandr. > > On 8/4/2015 1:22 PM, Alexander Stepanov wrote: >> Sorry, just a reminder. >> >> Thanks, >> Alexander >> >> On 7/21/2015 6:33 PM, alexander stepanov wrote: >>> Hello, >>> >>> Could you please review the following fix: >>> http://cr.openjdk.java.net/~avstepan/8131055/webrev.00/ >>> for the test bug >>> https://bugs.openjdk.java.net/browse/JDK-8131055 >>> >>> Just a single test added to the existing portion of unit tests for >>> JDK-4058433. Checked with JDK9 b73 (Ubuntu 14.04 Linux, Windows 7). >>> >>> Thanks, >>> Alexander >> > From Sergey.Bylokhov at oracle.com Tue Aug 4 10:58:51 2015 From: Sergey.Bylokhov at oracle.com (Sergey Bylokhov) Date: Tue, 4 Aug 2015 13:58:51 +0300 Subject: [9] Review Request: 8131055 bean annotations: add a test checking if a user-defined BeanInfo is top-priority as compared with the annotations In-Reply-To: <55C095C0.4030002@oracle.com> References: <55AE665B.3080009@oracle.com> <55C0927D.7090604@oracle.com> <55C09477.7080805@oracle.com> <55C095C0.4030002@oracle.com> Message-ID: <55C09AEB.3060409@oracle.com> +1 On 04.08.15 13:36, Alexander Stepanov wrote: > Thanks! > > On 8/4/2015 1:31 PM, Alexander Scherbatiy wrote: >> >> The fix looks good to me. >> >> Thanks, >> Alexandr. >> >> On 8/4/2015 1:22 PM, Alexander Stepanov wrote: >>> Sorry, just a reminder. >>> >>> Thanks, >>> Alexander >>> >>> On 7/21/2015 6:33 PM, alexander stepanov wrote: >>>> Hello, >>>> >>>> Could you please review the following fix: >>>> http://cr.openjdk.java.net/~avstepan/8131055/webrev.00/ >>>> for the test bug >>>> https://bugs.openjdk.java.net/browse/JDK-8131055 >>>> >>>> Just a single test added to the existing portion of unit tests for >>>> JDK-4058433. Checked with JDK9 b73 (Ubuntu 14.04 Linux, Windows 7). >>>> >>>> Thanks, >>>> Alexander >>> >> > -- Best regards, Sergey. From alexander.v.stepanov at oracle.com Tue Aug 4 12:49:57 2015 From: alexander.v.stepanov at oracle.com (Alexander Stepanov) Date: Tue, 04 Aug 2015 15:49:57 +0300 Subject: [9] Review Request: 8132566 [TESTBUG] add regression test for inherited classes with the new bean annotations Message-ID: <55C0B4F5.1070209@oracle.com> Hello, Could you please review the following fix: http://cr.openjdk.java.net/~avstepan/8132566/webrev.00/ for https://bugs.openjdk.java.net/browse/JDK-8132566 At the moment 'OverridePropertyInfoTest.java' will fail because of https://bugs.openjdk.java.net/browse/JDK-8132565 (and, additionally, both of them, - because of https://bugs.openjdk.java.net/browse/JDK-8131939). If something like, e.g., (ClassProperty.isExpert() || BaseClassProperty.isExpert()) is indeed should be returned when requesting ClassProperty.isExpert(), then please let me know. Thanks, Alexander From alexander.v.stepanov at oracle.com Wed Aug 5 13:56:54 2015 From: alexander.v.stepanov at oracle.com (Alexander Stepanov) Date: Wed, 05 Aug 2015 16:56:54 +0300 Subject: [9] Review Request: 8132566 [TESTBUG] add regression test for inherited classes with the new bean annotations In-Reply-To: <55C0B4F5.1070209@oracle.com> References: <55C0B4F5.1070209@oracle.com> Message-ID: <55C21626.6040806@oracle.com> Could you please review the updated webrev: http://cr.openjdk.java.net/~avstepan/8132566/webrev.01/ A new test was added to cover JDK-8132669 (and now is failing because of it): http://cr.openjdk.java.net/~avstepan/8132566/webrev.01/test/java/beans/Introspector/8132566/OverrideUserDefPropertyInfoTest.java.html On 8/4/2015 3:49 PM, Alexander Stepanov wrote: > Hello, > > Could you please review the following fix: > http://cr.openjdk.java.net/~avstepan/8132566/webrev.00/ > for > https://bugs.openjdk.java.net/browse/JDK-8132566 > > At the moment 'OverridePropertyInfoTest.java' will fail because of > https://bugs.openjdk.java.net/browse/JDK-8132565 > (and, additionally, both of them, - because of > https://bugs.openjdk.java.net/browse/JDK-8131939). > > If something like, e.g., (ClassProperty.isExpert() || > BaseClassProperty.isExpert()) is indeed should be returned when > requesting ClassProperty.isExpert(), then please let me know. > > Thanks, > Alexander From alexandr.scherbatiy at oracle.com Wed Aug 5 15:27:32 2015 From: alexandr.scherbatiy at oracle.com (Alexander Scherbatiy) Date: Wed, 05 Aug 2015 18:27:32 +0300 Subject: [9] Review Request: 8132566 [TESTBUG] add regression test for inherited classes with the new bean annotations In-Reply-To: <55C0B4F5.1070209@oracle.com> References: <55C0B4F5.1070209@oracle.com> Message-ID: <55C22B64.6090803@oracle.com> The fix looks good to me. Thanks, Alexandr. On 8/4/2015 3:49 PM, Alexander Stepanov wrote: > Hello, > > Could you please review the following fix: > http://cr.openjdk.java.net/~avstepan/8132566/webrev.00/ > for > https://bugs.openjdk.java.net/browse/JDK-8132566 > > At the moment 'OverridePropertyInfoTest.java' will fail because of > https://bugs.openjdk.java.net/browse/JDK-8132565 > (and, additionally, both of them, - because of > https://bugs.openjdk.java.net/browse/JDK-8131939). > > If something like, e.g., (ClassProperty.isExpert() || > BaseClassProperty.isExpert()) is indeed should be returned when > requesting ClassProperty.isExpert(), then please let me know. > > Thanks, > Alexander From alexander.v.stepanov at oracle.com Wed Aug 5 15:37:42 2015 From: alexander.v.stepanov at oracle.com (Alexander Stepanov) Date: Wed, 05 Aug 2015 18:37:42 +0300 Subject: [9] Review Request: 8132566 [TESTBUG] add regression test for inherited classes with the new bean annotations In-Reply-To: <55C22B64.6090803@oracle.com> References: <55C0B4F5.1070209@oracle.com> <55C22B64.6090803@oracle.com> Message-ID: <55C22DC6.3080908@oracle.com> Thanks! On 8/5/2015 6:27 PM, Alexander Scherbatiy wrote: > > The fix looks good to me. > > Thanks, > Alexandr. > > On 8/4/2015 3:49 PM, Alexander Stepanov wrote: >> Hello, >> >> Could you please review the following fix: >> http://cr.openjdk.java.net/~avstepan/8132566/webrev.00/ >> for >> https://bugs.openjdk.java.net/browse/JDK-8132566 >> >> At the moment 'OverridePropertyInfoTest.java' will fail because of >> https://bugs.openjdk.java.net/browse/JDK-8132565 >> (and, additionally, both of them, - because of >> https://bugs.openjdk.java.net/browse/JDK-8131939). >> >> If something like, e.g., (ClassProperty.isExpert() || >> BaseClassProperty.isExpert()) is indeed should be returned when >> requesting ClassProperty.isExpert(), then please let me know. >> >> Thanks, >> Alexander > From alexander.v.stepanov at oracle.com Wed Aug 5 15:40:24 2015 From: alexander.v.stepanov at oracle.com (Alexander Stepanov) Date: Wed, 05 Aug 2015 18:40:24 +0300 Subject: [9] Review Request: 8132566 [TESTBUG] add regression test for inherited classes with the new bean annotations In-Reply-To: <55C22B64.6090803@oracle.com> References: <55C0B4F5.1070209@oracle.com> <55C22B64.6090803@oracle.com> Message-ID: <55C22E68.3030606@oracle.com> Alexander, Sorry, could you please look at the updated version? http://cr.openjdk.java.net/~avstepan/8132566/webrev.01/ A new test was added to cover JDK-8132669 (and now is failing because of it): http://cr.openjdk.java.net/~avstepan/8132566/webrev.01/test/java/beans/Introspector/8132566/OverrideUserDefPropertyInfoTest.java.html It was sent to the mailing list a couple of hours ago... Thanks, Alexander On 8/5/2015 6:27 PM, Alexander Scherbatiy wrote: > > The fix looks good to me. > > Thanks, > Alexandr. > > On 8/4/2015 3:49 PM, Alexander Stepanov wrote: >> Hello, >> >> Could you please review the following fix: >> http://cr.openjdk.java.net/~avstepan/8132566/webrev.00/ >> for >> https://bugs.openjdk.java.net/browse/JDK-8132566 >> >> At the moment 'OverridePropertyInfoTest.java' will fail because of >> https://bugs.openjdk.java.net/browse/JDK-8132565 >> (and, additionally, both of them, - because of >> https://bugs.openjdk.java.net/browse/JDK-8131939). >> >> If something like, e.g., (ClassProperty.isExpert() || >> BaseClassProperty.isExpert()) is indeed should be returned when >> requesting ClassProperty.isExpert(), then please let me know. >> >> Thanks, >> Alexander > From alexandr.scherbatiy at oracle.com Wed Aug 5 15:39:13 2015 From: alexandr.scherbatiy at oracle.com (Alexander Scherbatiy) Date: Wed, 05 Aug 2015 18:39:13 +0300 Subject: [9] Review Request: 8132566 [TESTBUG] add regression test for inherited classes with the new bean annotations In-Reply-To: <55C22E68.3030606@oracle.com> References: <55C0B4F5.1070209@oracle.com> <55C22B64.6090803@oracle.com> <55C22E68.3030606@oracle.com> Message-ID: <55C22E21.2060204@oracle.com> The fix looks good to me. Thanks, Alexandr. On 8/5/2015 6:40 PM, Alexander Stepanov wrote: > Alexander, > > Sorry, could you please look at the updated version? > http://cr.openjdk.java.net/~avstepan/8132566/webrev.01/ > > A new test was added to cover JDK-8132669 (and now is failing because > of it): > http://cr.openjdk.java.net/~avstepan/8132566/webrev.01/test/java/beans/Introspector/8132566/OverrideUserDefPropertyInfoTest.java.html > > > It was sent to the mailing list a couple of hours ago... > > Thanks, > Alexander > > > On 8/5/2015 6:27 PM, Alexander Scherbatiy wrote: >> >> The fix looks good to me. >> >> Thanks, >> Alexandr. >> >> On 8/4/2015 3:49 PM, Alexander Stepanov wrote: >>> Hello, >>> >>> Could you please review the following fix: >>> http://cr.openjdk.java.net/~avstepan/8132566/webrev.00/ >>> for >>> https://bugs.openjdk.java.net/browse/JDK-8132566 >>> >>> At the moment 'OverridePropertyInfoTest.java' will fail because of >>> https://bugs.openjdk.java.net/browse/JDK-8132565 >>> (and, additionally, both of them, - because of >>> https://bugs.openjdk.java.net/browse/JDK-8131939). >>> >>> If something like, e.g., (ClassProperty.isExpert() || >>> BaseClassProperty.isExpert()) is indeed should be returned when >>> requesting ClassProperty.isExpert(), then please let me know. >>> >>> Thanks, >>> Alexander >> > From Sergey.Bylokhov at oracle.com Tue Aug 11 13:51:20 2015 From: Sergey.Bylokhov at oracle.com (Sergey Bylokhov) Date: Tue, 11 Aug 2015 16:51:20 +0300 Subject: [9] Review Request: 8131926 java/beans/SimpleBeanInfo/LoadingStandardIcons/LoadingStandardIcons.java failure with modular JDK Message-ID: <55C9FDD8.6060005@oracle.com> Hello. Please review the fix for jdk9. This is the same bug as was described in [1] and [2] but this time in beans area. So in the fix the usage of getResource was changed to getResourceAsStream. Bug: https://bugs.openjdk.java.net/browse/JDK-8131926 Webrev can be found at: http://cr.openjdk.java.net/~serb/8131926/webrev.00 [1] https://bugs.openjdk.java.net/browse/JDK-8078658 [2] http://mail.openjdk.java.net/pipermail/awt-dev/2015-May/009431.html -- Best regards, Sergey. From alexandr.scherbatiy at oracle.com Tue Aug 11 14:05:40 2015 From: alexandr.scherbatiy at oracle.com (Alexander Scherbatiy) Date: Tue, 11 Aug 2015 17:05:40 +0300 Subject: [9] Review Request: 8131926 java/beans/SimpleBeanInfo/LoadingStandardIcons/LoadingStandardIcons.java failure with modular JDK In-Reply-To: <55C9FDD8.6060005@oracle.com> References: <55C9FDD8.6060005@oracle.com> Message-ID: <55CA0134.2020202@oracle.com> Is it possible to put the InputStream definition into the first try block? Something like: public Image loadImage(final String resourceName) { final Toolkit toolkit = Toolkit.getDefaultToolkit(); try (InputStream in = getClass().getResourceAsStream(resourceName)) { return toolkit.createImage(in.readAllBytes()); } catch (final Exception ignored) { } return null; } Thanks, Alexandr. On 8/11/2015 4:51 PM, Sergey Bylokhov wrote: > Hello. > Please review the fix for jdk9. > This is the same bug as was described in [1] and [2] but this time in > beans area. > So in the fix the usage of getResource was changed to > getResourceAsStream. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8131926 > Webrev can be found at: > http://cr.openjdk.java.net/~serb/8131926/webrev.00 > > [1] https://bugs.openjdk.java.net/browse/JDK-8078658 > [2] http://mail.openjdk.java.net/pipermail/awt-dev/2015-May/009431.html > From Sergey.Bylokhov at oracle.com Tue Aug 11 14:27:19 2015 From: Sergey.Bylokhov at oracle.com (Sergey Bylokhov) Date: Tue, 11 Aug 2015 17:27:19 +0300 Subject: [9] Review Request: 8131926 java/beans/SimpleBeanInfo/LoadingStandardIcons/LoadingStandardIcons.java failure with modular JDK In-Reply-To: <55CA0134.2020202@oracle.com> References: <55C9FDD8.6060005@oracle.com> <55CA0134.2020202@oracle.com> Message-ID: <55CA0647.3000604@oracle.com> You are right! Thanks. An updated version: http://cr.openjdk.java.net/~serb/8131926/webrev.02 On 11.08.15 17:05, Alexander Scherbatiy wrote: > > Is it possible to put the InputStream definition into the first try > block? > Something like: > > public Image loadImage(final String resourceName) { > final Toolkit toolkit = Toolkit.getDefaultToolkit(); > try (InputStream in = > getClass().getResourceAsStream(resourceName)) { > return toolkit.createImage(in.readAllBytes()); > } catch (final Exception ignored) { > } > return null; > } > > Thanks, > Alexandr. > > On 8/11/2015 4:51 PM, Sergey Bylokhov wrote: >> Hello. >> Please review the fix for jdk9. >> This is the same bug as was described in [1] and [2] but this time in >> beans area. >> So in the fix the usage of getResource was changed to >> getResourceAsStream. >> >> Bug: https://bugs.openjdk.java.net/browse/JDK-8131926 >> Webrev can be found at: >> http://cr.openjdk.java.net/~serb/8131926/webrev.00 >> >> [1] https://bugs.openjdk.java.net/browse/JDK-8078658 >> [2] http://mail.openjdk.java.net/pipermail/awt-dev/2015-May/009431.html >> > -- Best regards, Sergey. From alexandr.scherbatiy at oracle.com Tue Aug 11 14:38:28 2015 From: alexandr.scherbatiy at oracle.com (Alexander Scherbatiy) Date: Tue, 11 Aug 2015 17:38:28 +0300 Subject: [9] Review Request: 8131926 java/beans/SimpleBeanInfo/LoadingStandardIcons/LoadingStandardIcons.java failure with modular JDK In-Reply-To: <55CA0647.3000604@oracle.com> References: <55C9FDD8.6060005@oracle.com> <55CA0134.2020202@oracle.com> <55CA0647.3000604@oracle.com> Message-ID: <55CA08E4.2010200@oracle.com> The fix looks good to me. Thanks, Alexandr. On 8/11/2015 5:27 PM, Sergey Bylokhov wrote: > You are right! Thanks. > An updated version: > http://cr.openjdk.java.net/~serb/8131926/webrev.02 > > On 11.08.15 17:05, Alexander Scherbatiy wrote: >> >> Is it possible to put the InputStream definition into the first try >> block? >> Something like: >> >> public Image loadImage(final String resourceName) { >> final Toolkit toolkit = Toolkit.getDefaultToolkit(); >> try (InputStream in = >> getClass().getResourceAsStream(resourceName)) { >> return toolkit.createImage(in.readAllBytes()); >> } catch (final Exception ignored) { >> } >> return null; >> } >> >> Thanks, >> Alexandr. >> >> On 8/11/2015 4:51 PM, Sergey Bylokhov wrote: >>> Hello. >>> Please review the fix for jdk9. >>> This is the same bug as was described in [1] and [2] but this time >>> in beans area. >>> So in the fix the usage of getResource was changed to >>> getResourceAsStream. >>> >>> Bug: https://bugs.openjdk.java.net/browse/JDK-8131926 >>> Webrev can be found at: >>> http://cr.openjdk.java.net/~serb/8131926/webrev.00 >>> >>> [1] https://bugs.openjdk.java.net/browse/JDK-8078658 >>> [2] http://mail.openjdk.java.net/pipermail/awt-dev/2015-May/009431.html >>> >> > > From Sergey.Bylokhov at oracle.com Mon Aug 17 15:08:56 2015 From: Sergey.Bylokhov at oracle.com (Sergey Bylokhov) Date: Mon, 17 Aug 2015 18:08:56 +0300 Subject: [9] Review Request: 8077270 Missed test data in the test on java.beans.BeanProperty Message-ID: <55D1F908.8050309@oracle.com> Hello. Please review the fix for a typo in jdk9. Description: The test TestBeanProperty.java contains the check which never executed: if ((R.class == type) == !Boolean.TRUE.equals(pd.getValue("required"))) { BeanUtils.reportPropertyDescriptor(pd); throw new Error("required"); } since R.class is missing in the Class[] types. Instead, Class[] types contains D.class which is not used in the checks. In the fix R.class was added to the tested types and an additional check was added to the D.class. Bug: https://bugs.openjdk.java.net/browse/JDK-8077270 Webrev can be found at: http://cr.openjdk.java.net/~serb/8077270/webrev.00 -- Best regards, Sergey. From alexandr.scherbatiy at oracle.com Tue Aug 18 07:54:00 2015 From: alexandr.scherbatiy at oracle.com (Alexander Scherbatiy) Date: Tue, 18 Aug 2015 10:54:00 +0300 Subject: [9] Review Request: 8077270 Missed test data in the test on java.beans.BeanProperty In-Reply-To: <55D1F908.8050309@oracle.com> References: <55D1F908.8050309@oracle.com> Message-ID: <55D2E498.2040706@oracle.com> The fix looks good to me. Thanks, Alexandr. On 8/17/2015 6:08 PM, Sergey Bylokhov wrote: > Hello. > Please review the fix for a typo in jdk9. > > Description: > The test TestBeanProperty.java contains the check which never executed: > > if ((R.class == type) == !Boolean.TRUE.equals(pd.getValue("required"))) { > BeanUtils.reportPropertyDescriptor(pd); > throw new Error("required"); > } > > since R.class is missing in the Class[] types. Instead, Class[] > types contains D.class which is not used in the checks. > > In the fix R.class was added to the tested types and an additional > check was added to the D.class. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8077270 > Webrev can be found at: > http://cr.openjdk.java.net/~serb/8077270/webrev.00 > From Sergey.Bylokhov at oracle.com Tue Aug 25 12:37:08 2015 From: Sergey.Bylokhov at oracle.com (Sergey Bylokhov) Date: Tue, 25 Aug 2015 15:37:08 +0300 Subject: [9] Review Request: 8060027 Tests java/beans/XMLEncoder/Test4903007.java and java/beans/XMLEncoder/java_awt_GridBagLayout.java Message-ID: <55DC6174.1000804@oracle.com> Hello. Please review the fix for jdk9. Short description: XMLEncoder incorrectly reference a non-static fields, when these fields were assigned to some other fields. The bug was uncovered by some existing tests after the fix for [1]. Long description: The next code is serialized incorrectly: public static final class Test { public Integer integer_10_default = new Integer(10); public Integer integer_10_set1; // will be set to the same as default } Result: