<Beans Dev> [9] Review Request: 8130937 Several methods in BeanProperty return null instead of boolean value

Alexander Scherbatiy alexandr.scherbatiy at oracle.com
Fri Jul 17 15:25:00 UTC 2015


   The fix looks good to me.

   Thanks,
   Alexandr.

On 7/14/2015 3:07 PM, Sergey Bylokhov wrote:
> Hello.
> Please review the fix for jdk9.
> Problem description:
>  - The new "required" annotation was added in JDK-4058433, but this 
> annotation was ignored by the PropertyDescriptor.
>  - The new "expert", "hidden" annotations return null via getValue 
> method, if were set to false, and this doesn't correspond to the 
> similar isExpert,isHidden methods which return false. For example code 
> below do not initialize the value to false, and its default value is 
> null, but default value for expert is false:
>
> -        if (info.is(PropertyInfo.Name.expert)) {
> -            setValue(PropertyInfo.Name.expert.name(), Boolean.TRUE); 
> // compatibility
> -            setExpert(true);
> -        }
>
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8130937
> Webrev can be found at: 
> http://cr.openjdk.java.net/~serb/8130937/webrev.00
>



More information about the beans-dev mailing list