From alexandr.scherbatiy at oracle.com  Mon Jun  1 13:57:50 2015
From: alexandr.scherbatiy at oracle.com (Alexander Scherbatiy)
Date: Mon, 01 Jun 2015 16:57:50 +0300
Subject: <Beans Dev> [9] Review Request: 8079084 Behavior of
 BeanProperty.enumerationValues() contradicts spec
In-Reply-To: <CANTFZ2hcbfq_=7h4_CaYBbmq2MjQAQ0k_tV39uA0+oTcBBDHWg@mail.gmail.com>
References: <5563463B.8050601@oracle.com> <5565B376.3030604@oracle.com>
	<CANTFZ2hQU9CV9LA=72G7rn9TTWdTr3brNPy3ze_OizyZb3wsaA@mail.gmail.com>
	<5565DE32.20505@oracle.com>
	<CANTFZ2hcbfq_=7h4_CaYBbmq2MjQAQ0k_tV39uA0+oTcBBDHWg@mail.gmail.com>
Message-ID: <556C64DE.8000508@oracle.com>


   The fix looks good to me.

   Thanks,
   Alexandr.

On 5/27/2015 8:13 PM, Sergey Malenkov wrote:
> I approve.
>
> On Wed, May 27, 2015 at 6:09 PM, Sergey Bylokhov
> <Sergey.Bylokhov at oracle.com> wrote:
>> On 27.05.15 16:30, Sergey Malenkov wrote:
>>> Exactly!
>> The new version:
>> http://cr.openjdk.java.net/~serb/8079084/webrev.01/
>>
>>> On Wed, May 27, 2015 at 3:07 PM, Alexander Scherbatiy
>>> <alexandr.scherbatiy at oracle.com> wrote:
>>>> On 5/25/2015 6:56 PM, Sergey Bylokhov wrote:
>>>>> Hello.
>>>>> Please review the fix for jdk9.
>>>>>
>>>>> This is similar to the issue described here:
>>>>> http://mail.openjdk.java.net/pipermail/beans-dev/2015-May/000138.html
>>>>>
>>>>> The problem is that PropertyDescriptor.getValue() for
>>>>> "enumerationValues"
>>>>> return null, when default enumerationValues is assumed or an empty array
>>>>> was
>>>>> provided by the user.
>>>>> There are a different ways to fix the issue but I select this, because
>>>>> of
>>>>> assumption that @BeanProperty(enumerationValues = {}) should not return
>>>>> null, and we have no way to detect: it was set by the user or by
>>>>> default.
>>>>>
>>>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8079084
>>>>> Webrev can be found at:
>>>>> http://cr.openjdk.java.net/~serb/8079084/webrev.00
>>>> 128                 if (0 <= values.length) {
>>>>
>>>> It looks like the condition is always true and the 'if' statement can be
>>>> omitted.
>>>>
>>>> Thanks,
>>>> Alexandr.
>>>>
>>>
>>
>> --
>> Best regards, Sergey.
>>
>
>


From alexandr.scherbatiy at oracle.com  Wed Jun  3 12:18:39 2015
From: alexandr.scherbatiy at oracle.com (Alexander Scherbatiy)
Date: Wed, 03 Jun 2015 15:18:39 +0300
Subject: <Beans Dev> [9] Review Request: 8076312 The behavior of the
 javax.swing.SwingContainer.delegate contradicts spec
In-Reply-To: <55631B55.4090701@oracle.com>
References: <55631B55.4090701@oracle.com>
Message-ID: <556EF09F.60609@oracle.com>


   The fix looks good to me.

   Thanks,
   Alexandr.

On 5/25/2015 3:53 PM, Sergey Bylokhov wrote:
> Hello.
> Please review the fix for jdk9.
>
> The problem is that BeanDescriptor.getBeanDescriptor.getValue() for 
> "containerDelegate" return null, when default delegate is assumed or 
> an empty delegate was provided by the user.
> There are a different ways to fix the issue but I select this, because 
> of assumption that @SwingContainer(delegate = "") should not return 
> null, and we have no way to detect it was set by the user or by default.
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8076312
> Webrev can be found at: 
> http://cr.openjdk.java.net/~serb/8076312/webrev.00
>


From joe.darcy at oracle.com  Wed Jun 24 23:47:18 2015
From: joe.darcy at oracle.com (Joseph D. Darcy)
Date: Wed, 24 Jun 2015 16:47:18 -0700
Subject: <Beans Dev> JDK 9 RFR of JDK-8129822: Define "headful" jtreg
	keyword
In-Reply-To: <558B4076.2080008@oracle.com>
References: <558B4076.2080008@oracle.com>
Message-ID: <558B4186.1000204@oracle.com>

PS Discussion of the next iteration of tiered testing:

http://mail.openjdk.java.net/pipermail/jdk9-dev/2015-June/002325.html

Thanks,

-Joe

On 6/24/2015 4:42 PM, joe darcy wrote:
> Hello,
>
> To support the next iteration of tiered testing in JDK 9, with an eye 
> toward running client library tests, please review the patch below 
> which addresses
>
>     JDK-8129822: Define "headful" jtreg keyword
>
> Some test environments are headless, including test environments often 
> used for the tier 1 and tier 2 tests. The jdk_desktop test group is 
> defined as follows:
>
> jdk_desktop = \
>     :jdk_awt \
>     :jdk_2d \
>     :jdk_beans \
>     :jdk_swing \
>     :jdk_sound \
>     :jdk_imageio
>
> Of those constituent test groups, nearly all of the tests in 
> jdk_beans, jdk_sound, and jdk_imageio can be successfully run in a 
> *headless* environment. Therefore, I'd like to be able to tag the 
> handful of tests that need a head with "@key headful"  so they can be 
> excluded from test runs in a headless environment.
>
> Future changesets will add the keyword to the appropriate tests.
>
> Thanks,
>
> -Joe
>
> diff -r db09207cc779 test/TEST.ROOT
> --- a/test/TEST.ROOT    Wed Jun 24 15:15:10 2015 -0700
> +++ b/test/TEST.ROOT    Wed Jun 24 16:33:09 2015 -0700
> @@ -8,8 +8,11 @@
>  # would not count as "randomness" by this definition.) Extra care
>  # should be taken to handle test failures of intermittent or
>  # randomness tests.
> +#
> +# A "headful" test requires a graphical environment to meaningfully
> +# run. Tests that are not headful are "headless."
>
> -keys=2d dnd i18n intermittent randomness
> +keys=2d dnd i18n intermittent randomness headful
>
>  # Tests that must run in othervm mode
>  othervm.dirs=java/awt java/beans javax/accessibility javax/imageio 
> javax/sound javax/print javax/management com/sun/awt sun/awt 
> sun/java2d sun/pisces javax/xml/jaxp/testng/validation 
> java/lang/ProcessHandle
>


From joe.darcy at oracle.com  Mon Jun 29 23:16:45 2015
From: joe.darcy at oracle.com (Joseph D. Darcy)
Date: Mon, 29 Jun 2015 16:16:45 -0700
Subject: <Beans Dev> JDK 9 RFR of 8081547: Prepare client libs regression
 tests for running in a concurrent, headless jtreg environment
Message-ID: <5591D1DD.6030107@oracle.com>

Hello,

Please review the proposed fix for

     8081547: Prepare client libs regression tests for running in a 
concurrent, headless jtreg environment
     http://cr.openjdk.java.net/~darcy/8081547.1/

This fix takes advantage of the recently added "headful" jtreg keyword 
(JDK-8129822: Define "headful" jtreg keyword). Patch below.

Some long-standing test failures are added to the problem list, 
including one in sound; hence the cc to sound-dev.

With the modifications, the the follow test run now passes for me:

     jtreg [...] -agentvm -conc:2 -exclude:ProblemList.txt 
-Djava.awt.headless=true -k:'!headful'  :jdk_beans

Likewise, the test invocation

     jtreg [...] -agentvm -conc:2 -exclude:ProblemList.txt :jdk_beans

also succeeds when a headful environment is indeed present with the 
additional 11 tests passing.

Thanks,

-Joe

--- old/test/ProblemList.txt    2015-06-29 15:57:08.822250552 -0700
+++ new/test/ProblemList.txt    2015-06-29 15:57:08.654250549 -0700
@@ -116,6 +116,13 @@

  # jdk_beans

+# 8060027
+
+java/beans/XMLEncoder/Test4903007.java generic-all
+java/beans/XMLEncoder/java_awt_GridBagLayout.java generic-all
+java/beans/XMLDecoder/8028054/TestConstructorFinder.java generic-all
+java/beans/XMLDecoder/8028054/TestMethodFinder.java generic-all
+
  ############################################################################

  # jdk_lang
@@ -293,6 +300,10 @@

  # jdk_sound

+# 8059743
+
+javax/sound/midi/Gervill/SoftProvider/GetDevice.java generic-all
+
  ############################################################################

  # jdk_swing
--- old/test/java/beans/PropertyEditor/6380849/TestPropertyEditor.java 
2015-06-29 15:57:09.298250559 -0700
+++ new/test/java/beans/PropertyEditor/6380849/TestPropertyEditor.java 
2015-06-29 15:57:09.130250556 -0700
@@ -1,5 +1,5 @@
-/**
- * Copyright (c) 2009, 2012, Oracle and/or its affiliates. All rights 
reserved.
+/*
+ * Copyright (c) 2009, 2015, Oracle and/or its affiliates. All rights 
reserved.
   * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
   *
   * This code is free software; you can redistribute it and/or modify it
@@ -28,6 +28,7 @@
   * @author Sergey Malenkov
   * @compile -XDignore.symbol.file TestPropertyEditor.java
   * @run main TestPropertyEditor
+ * @key headful
   */

  import editors.SecondBeanEditor;
--- old/test/java/beans/PropertyEditor/TestColorClass.java 2015-06-29 
15:57:09.770250566 -0700
+++ new/test/java/beans/PropertyEditor/TestColorClass.java 2015-06-29 
15:57:09.598250563 -0700
@@ -26,6 +26,7 @@
   * @bug 4506596 6258510
   * @summary Tests PropertyEditor for value of type Color with security 
manager
   * @author Sergey Malenkov
+ * @key headful
   */

  import java.awt.Color;
--- old/test/java/beans/PropertyEditor/TestColorClassJava.java 
2015-06-29 15:57:10.230250573 -0700
+++ new/test/java/beans/PropertyEditor/TestColorClassJava.java 
2015-06-29 15:57:10.062250570 -0700
@@ -26,6 +26,7 @@
   * @bug 4506596
   * @summary Tests PropertyEditor for value of type Color
   * @author Sergey Malenkov
+ * @key headful
   */

  import java.awt.Color;
--- old/test/java/beans/PropertyEditor/TestColorClassNull.java 
2015-06-29 15:57:10.694250580 -0700
+++ new/test/java/beans/PropertyEditor/TestColorClassNull.java 
2015-06-29 15:57:10.522250577 -0700
@@ -26,6 +26,7 @@
   * @bug 4506596 6498171
   * @summary Tests PropertyEditor for null value of type Color
   * @author Sergey Malenkov
+ * @key headful
   */

  import java.awt.Color;
--- old/test/java/beans/PropertyEditor/TestColorClassValue.java 
2015-06-29 15:57:11.162250587 -0700
+++ new/test/java/beans/PropertyEditor/TestColorClassValue.java 
2015-06-29 15:57:10.994250584 -0700
@@ -26,6 +26,7 @@
   * @bug 4222827 4506596
   * @summary Tests PropertyEditor for value of type Color
   * @author Sergey Malenkov
+ * @key headful
   */

  import java.awt.Color;
--- old/test/java/beans/PropertyEditor/TestFontClass.java 2015-06-29 
15:57:11.630250594 -0700
+++ new/test/java/beans/PropertyEditor/TestFontClass.java 2015-06-29 
15:57:11.458250591 -0700
@@ -26,6 +26,7 @@
   * @bug 4506596 6258510 6538853
   * @summary Tests PropertyEditor for value of type Font with security 
manager
   * @author Sergey Malenkov
+ * @key headful
   */

  import java.awt.Font;
--- old/test/java/beans/PropertyEditor/TestFontClassJava.java 2015-06-29 
15:57:12.098250601 -0700
+++ new/test/java/beans/PropertyEditor/TestFontClassJava.java 2015-06-29 
15:57:11.930250598 -0700
@@ -26,6 +26,7 @@
   * @bug 4506596 6538853
   * @summary Tests PropertyEditor for value of type Font
   * @author Sergey Malenkov
+ * @key headful
   */

  import java.awt.Font;
--- old/test/java/beans/PropertyEditor/TestFontClassNull.java 2015-06-29 
15:57:12.566250608 -0700
+++ new/test/java/beans/PropertyEditor/TestFontClassNull.java 2015-06-29 
15:57:12.394250605 -0700
@@ -26,6 +26,7 @@
   * @bug 4506596 6498171 6538853
   * @summary Tests PropertyEditor for null value of type Font
   * @author Sergey Malenkov
+ * @key headful
   */

  import java.awt.Font;
--- old/test/java/beans/PropertyEditor/TestFontClassValue.java 
2015-06-29 15:57:13.030250615 -0700
+++ new/test/java/beans/PropertyEditor/TestFontClassValue.java 
2015-06-29 15:57:12.862250612 -0700
@@ -26,6 +26,7 @@
   * @bug 4222827 4506596 6538853
   * @summary Tests PropertyEditor for value of type Font
   * @author Sergey Malenkov
+ * @key headful
   */

  import java.awt.Font;
--- old/test/java/beans/XMLEncoder/java_awt_ScrollPane.java 2015-06-29 
15:57:13.486250622 -0700
+++ new/test/java/beans/XMLEncoder/java_awt_ScrollPane.java 2015-06-29 
15:57:13.322250619 -0700
@@ -25,6 +25,7 @@
   * @test
   * @bug 6402062 6487891
   * @summary Tests ScrollPane encoding
+ * @key headful
   * @author Sergey Malenkov
   */



From Alan.Bateman at oracle.com  Tue Jun 30 07:09:45 2015
From: Alan.Bateman at oracle.com (Alan Bateman)
Date: Tue, 30 Jun 2015 08:09:45 +0100
Subject: <Beans Dev> JDK 9 RFR of 8081547: Prepare client libs
 regression tests for running in a concurrent, headless jtreg environment
In-Reply-To: <5591D1DD.6030107@oracle.com>
References: <5591D1DD.6030107@oracle.com>
Message-ID: <559240B9.3050603@oracle.com>



On 30/06/2015 00:16, Joseph D. Darcy wrote:
> Hello,
>
> Please review the proposed fix for
>
>     8081547: Prepare client libs regression tests for running in a 
> concurrent, headless jtreg environment
>     http://cr.openjdk.java.net/~darcy/8081547.1/
>
> This fix takes advantage of the recently added "headful" jtreg keyword 
> (JDK-8129822: Define "headful" jtreg keyword). Patch below.
>
> Some long-standing test failures are added to the problem list, 
> including one in sound; hence the cc to sound-dev.
This looks okay to me. A minor nit is that we've tended not to leave a 
blank line between # <BUGID> and the tests, mostly to make it clear 
which tests are listed for the bug number. The right thing in the medium 
term is of course to convert the ProblemList file to jtreg format.

-Alan

From joe.darcy at oracle.com  Tue Jun 30 16:32:56 2015
From: joe.darcy at oracle.com (joe darcy)
Date: Tue, 30 Jun 2015 09:32:56 -0700
Subject: <Beans Dev> JDK 9 RFR of 8081547: Prepare client libs
 regression tests for running in a concurrent, headless jtreg environment
In-Reply-To: <559240B9.3050603@oracle.com>
References: <5591D1DD.6030107@oracle.com> <559240B9.3050603@oracle.com>
Message-ID: <5592C4B8.50703@oracle.com>

Hi Alan,

On 6/30/2015 12:09 AM, Alan Bateman wrote:
>
>
> On 30/06/2015 00:16, Joseph D. Darcy wrote:
>> Hello,
>>
>> Please review the proposed fix for
>>
>>     8081547: Prepare client libs regression tests for running in a 
>> concurrent, headless jtreg environment
>>     http://cr.openjdk.java.net/~darcy/8081547.1/
>>
>> This fix takes advantage of the recently added "headful" jtreg 
>> keyword (JDK-8129822: Define "headful" jtreg keyword). Patch below.
>>
>> Some long-standing test failures are added to the problem list, 
>> including one in sound; hence the cc to sound-dev.
> This looks okay to me. A minor nit is that we've tended not to leave a 
> blank line between # <BUGID> and the tests, mostly to make it clear 
> which tests are listed for the bug number. The right thing in the 
> medium term is of course to convert the ProblemList file to jtreg format.
>

Okay; I'll tighten up the bug number placement before I push.

To provide some context on the jtreg format, the ProblemList file 
support a syntax where the bug number can be placed on the same line as 
a failing test and be printed out in a report. At some point we should 
switch the ProblemList to use that format, but I wanted to keep these 
additions consistent with the current practice in the file.

Thanks,

-Joe