<Beans Dev> [9] RFR 4763438: Replace uses of @beaninfo with meta facility in core j2se

[Sergey Bylokhov]

On 22.09.15 16:06, Semyon Sadetsky wrote:
> Hi Sergey,
>
> I found that visualUpdate=true is not added for many setters  and
> bound=false should be added for number of methods

This is because it was not there before the fix. This change did not add 
anything new to the properties descriptions. The goal is to replace the 
old @tag with a new annotation.

>
> For example JTable.java:
>
> visualUpdate=true
> 1918     @BeanProperty(description
> 1919             = "The table's RowSorter")
> 1920     public void setRowSorter(RowSorter<? extends TableModel> sorter) {
> 1921         RowSorter<? extends TableModel> oldRowSorter = null;
> 1922         if (sortManager != null) {
> 1923             oldRowSorter = sortManager.sorter;
> 1924             sortManager.dispose();
> 1925             sortManager = null;
> 1926         }
> 1927         rowModel = null;
> 1928         clearSelectionAndLeadAnchor();
> 1929         if (sorter != null) {
> 1930             sortManager = new SortManager(sorter);
> 1931         }
> 1932         resizeAndRepaint();
> 1933         firePropertyChange("rowSorter", oldRowSorter, sorter);
> 1934         firePropertyChange("sorter", oldRowSorter, sorter);
> 1935     }
>
> bound=false
> @BeanProperty(description
>   982             = "The height in pixels of the cells in
> <code>row</code>")
>   983     public void setRowHeight(int row, int rowHeight) {
>   984         if (rowHeight <= 0) {
>   985             throw new IllegalArgumentException("New row height
> less than 1");
>   986         }
>   987         getRowModel().setSize(row, rowHeight);
>   988         if (sortManager != null) {
>   989             sortManager.setViewRowHeight(row, rowHeight);
>   990         }
>   991         resizeAndRepaint();
>   992     }
>
> --Semyon
>
>
> On 9/22/2015 3:46 PM, Alexander Scherbatiy wrote:
>>
>>   The fix looks good to me.
>>
>>   Thanks,
>>   Alexandr.
>>
>> On 9/20/2015 12:39 AM, Sergey Bylokhov wrote:
>>> Hi, Sergey, Alexander.
>>> Please review an updated version of this fix:
>>> http://cr.openjdk.java.net/~serb/4763438/webrev.00
>>> ccc request will be filed after the technical review.
>>>
>>> In this version
>>>  - The new make file is updated
>>>  - SimpleBeanInfo.java is updated to the current state of template bean.
>>>  - AbstractColorChooserPanel.java is updated to the current state.
>>>
>>> Note that additional cleanup of make folder for the bean area will be
>>> done in JDK-7179078.
>>>
>>> Note that this fix is a part of JEP 256: BeanInfo Annotations.
>>>
>>> On 12.09.14 13:18, Alexander Scherbatiy wrote:
>>>>
>>>>    The fix looks good to me.
>>>>
>>>>   Thanks,
>>>>   Alexandr.
>>>>
>>>> On 8/20/2014 12:45 PM, Sergey Malenkov wrote:
>>>>> Hello,
>>>>>
>>>>> Could you please review the following fix:
>>>>> http://cr.openjdk.java.net/~serb/sam/4763438/webrev.00/
>>>>> http://bugs.openjdk.java.net/browse/JDK-4763438
>>>>>
>>>>> This is the second step needed for 7179078. It removes class files
>>>>> from dt.jar and replaces them with BeanInfo generated at runtime
>>>>> according to the specified annotations.
>>>>>
>>>>> Thanks,
>>>>> SAM
>>>>
>>>
>>>
>>
>


-- 
Best regards, Sergey.