From joe.darcy at oracle.com  Sat Mar 12 03:28:15 2016
From: joe.darcy at oracle.com (joe darcy)
Date: Fri, 11 Mar 2016 19:28:15 -0800
Subject: <Beans Dev> JDK 9 RFR of JDK-8151763;
 Use more informative format for problem list
Message-ID: <56E38CCF.8080004@oracle.com>

Hello,

As Jon Gibbons has noted off-list, the problem list entries can directly 
include the bug number associated with the test in question, enabling 
better reporting. This format should be used rather than the current 
convention of putting the bug number in a comment.

Please review the webrev to adopt the revised format for the problem list:

     http://cr.openjdk.java.net/~darcy/8151763.0/

I've verified jtreg produces the same test list with the old and new 
versions of the problem list.

Thanks,

-Joe

From Sergey.Bylokhov at oracle.com  Sat Mar 12 16:05:51 2016
From: Sergey.Bylokhov at oracle.com (Sergey Bylokhov)
Date: Sat, 12 Mar 2016 19:05:51 +0300
Subject: <Beans Dev> JDK 9 RFR of JDK-8151763;
 Use more informative format for problem list
In-Reply-To: <56E38CCF.8080004@oracle.com>
References: <56E38CCF.8080004@oracle.com>
Message-ID: <56E43E5F.80503@oracle.com>

Looks fine.

On 12.03.16 6:28, joe darcy wrote:
> Hello,
>
> As Jon Gibbons has noted off-list, the problem list entries can directly
> include the bug number associated with the test in question, enabling
> better reporting. This format should be used rather than the current
> convention of putting the bug number in a comment.
>
> Please review the webrev to adopt the revised format for the problem list:
>
>      http://cr.openjdk.java.net/~darcy/8151763.0/
>
> I've verified jtreg produces the same test list with the old and new
> versions of the problem list.
>
> Thanks,
>
> -Joe


-- 
Best regards, Sergey.

From chris.hegarty at oracle.com  Sat Mar 12 21:28:40 2016
From: chris.hegarty at oracle.com (Chris Hegarty)
Date: Sat, 12 Mar 2016 16:28:40 -0500
Subject: <Beans Dev> JDK 9 RFR of JDK-8151763;
	Use more informative format for problem list
In-Reply-To: <56E38CCF.8080004@oracle.com>
References: <56E38CCF.8080004@oracle.com>
Message-ID: <A5282289-6630-47E8-8413-CC2940B7BE35@oracle.com>

Looks good Joe.

-Chris

> On 11 Mar 2016, at 22:28, joe darcy <joe.darcy at oracle.com> wrote:
> 
> Hello,
> 
> As Jon Gibbons has noted off-list, the problem list entries can directly include the bug number associated with the test in question, enabling better reporting. This format should be used rather than the current convention of putting the bug number in a comment.
> 
> Please review the webrev to adopt the revised format for the problem list:
> 
>    http://cr.openjdk.java.net/~darcy/8151763.0/
> 
> I've verified jtreg produces the same test list with the old and new versions of the problem list.
> 
> Thanks,
> 
> -Joe

From joe.darcy at oracle.com  Wed Mar 16 23:43:13 2016
From: joe.darcy at oracle.com (Joseph D. Darcy)
Date: Wed, 16 Mar 2016 16:43:13 -0700
Subject: <Beans Dev> JDK 9 RFR of JDK-8151763;
 Use more informative format for problem list
In-Reply-To: <A5282289-6630-47E8-8413-CC2940B7BE35@oracle.com>
References: <56E38CCF.8080004@oracle.com>
	<A5282289-6630-47E8-8413-CC2940B7BE35@oracle.com>
Message-ID: <56E9EF91.8050901@oracle.com>

Just a follow-up, to avoid causing additional merge headaches, I'll 
revise the patch to make this change once the next round of Jigsaw 
changes get back in jdk9/dev 
(http://mail.openjdk.java.net/pipermail/jdk9-dev/2016-March/003877.html).

Thanks,

-Joe

On 3/12/2016 1:28 PM, Chris Hegarty wrote:
> Looks good Joe.
>
> -Chris
>
>> On 11 Mar 2016, at 22:28, joe darcy <joe.darcy at oracle.com> wrote:
>>
>> Hello,
>>
>> As Jon Gibbons has noted off-list, the problem list entries can directly include the bug number associated with the test in question, enabling better reporting. This format should be used rather than the current convention of putting the bug number in a comment.
>>
>> Please review the webrev to adopt the revised format for the problem list:
>>
>>     http://cr.openjdk.java.net/~darcy/8151763.0/
>>
>> I've verified jtreg produces the same test list with the old and new versions of the problem list.
>>
>> Thanks,
>>
>> -Joe


From joe.darcy at oracle.com  Wed Mar 16 23:52:01 2016
From: joe.darcy at oracle.com (Joseph D. Darcy)
Date: Wed, 16 Mar 2016 16:52:01 -0700
Subject: <Beans Dev> JDK 9 RFR of JDK-8151763;
 Use more informative format for problem list
In-Reply-To: <56E9F15F.2050002@oracle.com>
References: <56E38CCF.8080004@oracle.com> <56E9F15F.2050002@oracle.com>
Message-ID: <56E9F1A1.3040309@oracle.com>

Hi Jon,

Noted; I'll make that improvement in the next round.

Thanks for pointing this out,

-Joe

On 3/16/2016 4:50 PM, Jonathan Gibbons wrote:
>
>
> On 03/11/2016 07:28 PM, joe darcy wrote:
>> Hello,
>>
>> As Jon Gibbons has noted off-list, the problem list entries can 
>> directly include the bug number associated with the test in question, 
>> enabling better reporting. This format should be used rather than the 
>> current convention of putting the bug number in a comment.
>>
>> Please review the webrev to adopt the revised format for the problem 
>> list:
>>
>>     http://cr.openjdk.java.net/~darcy/8151763.0/
>>
>> I've verified jtreg produces the same test list with the old and new 
>> versions of the problem list.
>>
>> Thanks,
>>
>> -Joe
>
>
> Joe,
>
> You can use a comma-separated list when multiple bugs are involved.   
> The only restriction is,  no embedded whitespace within the list
>
>  342 # Also 8080165
>  343 java/util/Arrays/ParallelPrefix.java   8085982 generic-all
>
> can be
>
>  343 java/util/Arrays/ParallelPrefix.java   8085982,8080165 generic-all
>
>
> -- Jon


From sean.mullan at oracle.com  Mon Mar 14 12:49:50 2016
From: sean.mullan at oracle.com (Sean Mullan)
Date: Mon, 14 Mar 2016 08:49:50 -0400
Subject: <Beans Dev> JDK 9 RFR of JDK-8151763;
 Use more informative format for problem list
In-Reply-To: <56E38CCF.8080004@oracle.com>
References: <56E38CCF.8080004@oracle.com>
Message-ID: <56E6B36E.8090806@oracle.com>

Looks good to me.

--Sean

On 03/11/2016 10:28 PM, joe darcy wrote:
> Hello,
>
> As Jon Gibbons has noted off-list, the problem list entries can directly
> include the bug number associated with the test in question, enabling
> better reporting. This format should be used rather than the current
> convention of putting the bug number in a comment.
>
> Please review the webrev to adopt the revised format for the problem list:
>
>      http://cr.openjdk.java.net/~darcy/8151763.0/
>
> I've verified jtreg produces the same test list with the old and new
> versions of the problem list.
>
> Thanks,
>
> -Joe

From jonathan.gibbons at oracle.com  Wed Mar 16 23:50:55 2016
From: jonathan.gibbons at oracle.com (Jonathan Gibbons)
Date: Wed, 16 Mar 2016 16:50:55 -0700
Subject: <Beans Dev> JDK 9 RFR of JDK-8151763;
 Use more informative format for problem list
In-Reply-To: <56E38CCF.8080004@oracle.com>
References: <56E38CCF.8080004@oracle.com>
Message-ID: <56E9F15F.2050002@oracle.com>



On 03/11/2016 07:28 PM, joe darcy wrote:
> Hello,
>
> As Jon Gibbons has noted off-list, the problem list entries can 
> directly include the bug number associated with the test in question, 
> enabling better reporting. This format should be used rather than the 
> current convention of putting the bug number in a comment.
>
> Please review the webrev to adopt the revised format for the problem 
> list:
>
>     http://cr.openjdk.java.net/~darcy/8151763.0/
>
> I've verified jtreg produces the same test list with the old and new 
> versions of the problem list.
>
> Thanks,
>
> -Joe


Joe,

You can use a comma-separated list when multiple bugs are involved.   
The only restriction is,  no embedded whitespace within the list

  342 # Also 8080165
  343 java/util/Arrays/ParallelPrefix.java   8085982 generic-all

can be

  343 java/util/Arrays/ParallelPrefix.java   8085982,8080165 generic-all


-- Jon

From Sergey.Bylokhov at oracle.com  Fri Mar 25 17:37:09 2016
From: Sergey.Bylokhov at oracle.com (Sergey Bylokhov)
Date: Fri, 25 Mar 2016 20:37:09 +0300
Subject: <Beans Dev> [9] Review Request: 7179078 Remove @beaninfo processing
 from the makefiles
Message-ID: <56F57745.2000704@oracle.com>

Hello,
Please review the fix for jdk9.

Before the JEP 256 [1], we generated beanInfo classes + copied some 
other resources during the build. After the jep was integrated these 
files became obsolete and can be removed.
  - Utility classes were removed.(see [2] how they were used before)
  - The images were moved from the make folder to the src, so they will 
be copied using standard mechanism.

[1] https://bugs.openjdk.java.net/browse/JDK-8044826
[2] 
http://cr.openjdk.java.net/~serb/4763438/webrev.00/make/gensrc/GensrcSwing.gmk.sdiff.html

Bug: https://bugs.openjdk.java.net/browse/JDK-7179078
Webrevs can be found at:
http://cr.openjdk.java.net/~serb/7179078/jdk.00
http://cr.openjdk.java.net/~serb/7179078/root.00

-- 
Best regards, Sergey.

From joe.darcy at oracle.com  Tue Mar 29 00:03:49 2016
From: joe.darcy at oracle.com (Joseph D. Darcy)
Date: Mon, 28 Mar 2016 17:03:49 -0700
Subject: <Beans Dev> JDK 9 RFR of JDK-8151763;
 Use more informative format for problem list
In-Reply-To: <56E9F1A1.3040309@oracle.com>
References: <56E38CCF.8080004@oracle.com> <56E9F15F.2050002@oracle.com>
	<56E9F1A1.3040309@oracle.com>
Message-ID: <56F9C665.7070706@oracle.com>

Hello,

New iteration of the webrev updated after the Jigsaw integration and 
incorporating the earlier feedback.

     http://cr.openjdk.java.net/~darcy/8151763.1

Thanks,

-Joe

On 3/16/2016 4:52 PM, Joseph D. Darcy wrote:
> Hi Jon,
>
> Noted; I'll make that improvement in the next round.
>
> Thanks for pointing this out,
>
> -Joe
>
> On 3/16/2016 4:50 PM, Jonathan Gibbons wrote:
>>
>>
>> On 03/11/2016 07:28 PM, joe darcy wrote:
>>> Hello,
>>>
>>> As Jon Gibbons has noted off-list, the problem list entries can 
>>> directly include the bug number associated with the test in 
>>> question, enabling better reporting. This format should be used 
>>> rather than the current convention of putting the bug number in a 
>>> comment.
>>>
>>> Please review the webrev to adopt the revised format for the problem 
>>> list:
>>>
>>>     http://cr.openjdk.java.net/~darcy/8151763.0/
>>>
>>> I've verified jtreg produces the same test list with the old and new 
>>> versions of the problem list.
>>>
>>> Thanks,
>>>
>>> -Joe
>>
>>
>> Joe,
>>
>> You can use a comma-separated list when multiple bugs are involved.   
>> The only restriction is,  no embedded whitespace within the list
>>
>>  342 # Also 8080165
>>  343 java/util/Arrays/ParallelPrefix.java   8085982 generic-all
>>
>> can be
>>
>>  343 java/util/Arrays/ParallelPrefix.java   8085982,8080165 generic-all
>>
>>
>> -- Jon
>


From mandy.chung at oracle.com  Tue Mar 29 03:48:34 2016
From: mandy.chung at oracle.com (Mandy Chung)
Date: Mon, 28 Mar 2016 20:48:34 -0700
Subject: <Beans Dev> JDK 9 RFR of JDK-8151763;
	Use more informative format for problem list
In-Reply-To: <56F9C665.7070706@oracle.com>
References: <56E38CCF.8080004@oracle.com> <56E9F15F.2050002@oracle.com>
	<56E9F1A1.3040309@oracle.com> <56F9C665.7070706@oracle.com>
Message-ID: <BE7A108F-B5FA-4891-911D-1CFD4DC399B0@oracle.com>


> On Mar 28, 2016, at 5:03 PM, Joseph D. Darcy <joe.darcy at oracle.com> wrote:
> 
> Hello,
> 
> New iteration of the webrev updated after the Jigsaw integration and incorporating the earlier feedback.
> 
>    http://cr.openjdk.java.net/~darcy/8151763.1
> 

# tools/jimage/JImageTest.java                                    linux-i586,windows-i586

Is this test accidentally removed?  Other than this, looks okay.

Nit: it?d be good to have most of bug ids aligned in the same column start.
Here are a few ones:

 210 sun/security/krb5/auto/Unreachable.java     7164518 macosx-all no PortUnreachableException on Mac
 212 java/security/KeyPairGenerator/SolarisShortDSA.java 7041639 solaris-all Solaris DSA keypair generation bug
 213 sun/security/tools/keytool/standard.sh              7041639 solaris-all Solaris DSA keypair generation bug
 346 java/util/Arrays/ParallelPrefix.java 8080165,8085982 generic-all
 348 java/util/BitSet/BitSetStreamTest.java 8079538 generic-all
 360 sun/tools/jmap/heapconfig/JMapHeapConfigTest.java 8072131,8132452 generic-all
 370 sun/tools/jinfo/JInfoSanityTest.java                           8059035 generic-all

Mandy

From erik.joelsson at oracle.com  Tue Mar 29 09:44:50 2016
From: erik.joelsson at oracle.com (Erik Joelsson)
Date: Tue, 29 Mar 2016 11:44:50 +0200
Subject: <Beans Dev> [9] Review Request: 7179078 Remove @beaninfo
 processing from the makefiles
In-Reply-To: <56F57745.2000704@oracle.com>
References: <56F57745.2000704@oracle.com>
Message-ID: <56FA4E92.1080104@oracle.com>

Looks good, nice cleanup!

/Erik

On 2016-03-25 18:37, Sergey Bylokhov wrote:
> Hello,
> Please review the fix for jdk9.
>
> Before the JEP 256 [1], we generated beanInfo classes + copied some 
> other resources during the build. After the jep was integrated these 
> files became obsolete and can be removed.
>  - Utility classes were removed.(see [2] how they were used before)
>  - The images were moved from the make folder to the src, so they will 
> be copied using standard mechanism.
>
> [1] https://bugs.openjdk.java.net/browse/JDK-8044826
> [2] 
> http://cr.openjdk.java.net/~serb/4763438/webrev.00/make/gensrc/GensrcSwing.gmk.sdiff.html
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-7179078
> Webrevs can be found at:
> http://cr.openjdk.java.net/~serb/7179078/jdk.00
> http://cr.openjdk.java.net/~serb/7179078/root.00
>


From alexandr.scherbatiy at oracle.com  Tue Mar 29 12:33:35 2016
From: alexandr.scherbatiy at oracle.com (Alexander Scherbatiy)
Date: Tue, 29 Mar 2016 16:33:35 +0400
Subject: <Beans Dev> [9] Review Request: 7179078 Remove @beaninfo
 processing from the makefiles
In-Reply-To: <56F57745.2000704@oracle.com>
References: <56F57745.2000704@oracle.com>
Message-ID: <56FA761F.4080505@oracle.com>


The fix looks good to me.

Thanks,
Alexandr.

On 25/03/16 21:37, Sergey Bylokhov wrote:
> Hello,
> Please review the fix for jdk9.
>
> Before the JEP 256 [1], we generated beanInfo classes + copied some 
> other resources during the build. After the jep was integrated these 
> files became obsolete and can be removed.
>  - Utility classes were removed.(see [2] how they were used before)
>  - The images were moved from the make folder to the src, so they will 
> be copied using standard mechanism.
>
> [1] https://bugs.openjdk.java.net/browse/JDK-8044826
> [2] 
> http://cr.openjdk.java.net/~serb/4763438/webrev.00/make/gensrc/GensrcSwing.gmk.sdiff.html
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-7179078
> Webrevs can be found at:
> http://cr.openjdk.java.net/~serb/7179078/jdk.00
> http://cr.openjdk.java.net/~serb/7179078/root.00
>


From joe.darcy at oracle.com  Tue Mar 29 19:15:54 2016
From: joe.darcy at oracle.com (joe darcy)
Date: Tue, 29 Mar 2016 12:15:54 -0700
Subject: <Beans Dev> JDK 9 RFR of JDK-8151763;
 Use more informative format for problem list
In-Reply-To: <BE7A108F-B5FA-4891-911D-1CFD4DC399B0@oracle.com>
References: <56E38CCF.8080004@oracle.com> <56E9F15F.2050002@oracle.com>
	<56E9F1A1.3040309@oracle.com> <56F9C665.7070706@oracle.com>
	<BE7A108F-B5FA-4891-911D-1CFD4DC399B0@oracle.com>
Message-ID: <56FAD46A.4080803@oracle.com>

Hi Mandy,

On 3/28/2016 8:48 PM, Mandy Chung wrote:
>> On Mar 28, 2016, at 5:03 PM, Joseph D. Darcy <joe.darcy at oracle.com> wrote:
>>
>> Hello,
>>
>> New iteration of the webrev updated after the Jigsaw integration and incorporating the earlier feedback.
>>
>>     http://cr.openjdk.java.net/~darcy/8151763.1
>>
> # tools/jimage/JImageTest.java                                    linux-i586,windows-i586
>
> Is this test accidentally removed?  Other than this, looks okay.

The "#" lines are comments so I was removing a commented out line. (I 
assumed, but did not verify, the line for this test was a leftover 
artifact of the recent Jigsaw merge.)

>
> Nit: it?d be good to have most of bug ids aligned in the same column start.
> Here are a few ones:
>
>   210 sun/security/krb5/auto/Unreachable.java     7164518 macosx-all no PortUnreachableException on Mac
>   212 java/security/KeyPairGenerator/SolarisShortDSA.java 7041639 solaris-all Solaris DSA keypair generation bug
>   213 sun/security/tools/keytool/standard.sh              7041639 solaris-all Solaris DSA keypair generation bug
>   346 java/util/Arrays/ParallelPrefix.java 8080165,8085982 generic-all
>   348 java/util/BitSet/BitSetStreamTest.java 8079538 generic-all
>   360 sun/tools/jmap/heapconfig/JMapHeapConfigTest.java 8072131,8132452 generic-all
>   370 sun/tools/jinfo/JInfoSanityTest.java                           8059035 generic-all
>
>

I was trying to avoid introducing lots of spacing changes in an attempt 
to make the patch easier to review, but I can look over these cases again.

Thanks,

-Joe

From mandy.chung at oracle.com  Tue Mar 29 19:31:21 2016
From: mandy.chung at oracle.com (Mandy Chung)
Date: Tue, 29 Mar 2016 12:31:21 -0700
Subject: <Beans Dev> JDK 9 RFR of JDK-8151763;
	Use more informative format for problem list
In-Reply-To: <56FAD46A.4080803@oracle.com>
References: <56E38CCF.8080004@oracle.com> <56E9F15F.2050002@oracle.com>
	<56E9F1A1.3040309@oracle.com> <56F9C665.7070706@oracle.com>
	<BE7A108F-B5FA-4891-911D-1CFD4DC399B0@oracle.com>
	<56FAD46A.4080803@oracle.com>
Message-ID: <45FA671B-7243-46ED-8772-10818F3276F6@oracle.com>


> On Mar 29, 2016, at 12:15 PM, joe darcy <joe.darcy at oracle.com> wrote:
> 
> Hi Mandy,
> 
> On 3/28/2016 8:48 PM, Mandy Chung wrote:
>>> On Mar 28, 2016, at 5:03 PM, Joseph D. Darcy <joe.darcy at oracle.com> wrote:
>>> 
>>> Hello,
>>> 
>>> New iteration of the webrev updated after the Jigsaw integration and incorporating the earlier feedback.
>>> 
>>>    http://cr.openjdk.java.net/~darcy/8151763.1
>>> 
>> # tools/jimage/JImageTest.java                                    linux-i586,windows-i586
>> 
>> Is this test accidentally removed?  Other than this, looks okay.
> 
> The "#" lines are comments so I was removing a commented out line. (I assumed, but did not verify, the line for this test was a leftover artifact of the recent Jigsaw merge.)

I missed ?#? since this test should be excluded (some error might have been creeped in before the integration)

This test needs to be added back in the problem list.  I?ll create a changeset.

> 
>> 
>> Nit: it?d be good to have most of bug ids aligned in the same column start.
>> Here are a few ones:
>> 
>>  210 sun/security/krb5/auto/Unreachable.java     7164518 macosx-all no PortUnreachableException on Mac
>>  212 java/security/KeyPairGenerator/SolarisShortDSA.java 7041639 solaris-all Solaris DSA keypair generation bug
>>  213 sun/security/tools/keytool/standard.sh              7041639 solaris-all Solaris DSA keypair generation bug
>>  346 java/util/Arrays/ParallelPrefix.java 8080165,8085982 generic-all
>>  348 java/util/BitSet/BitSetStreamTest.java 8079538 generic-all
>>  360 sun/tools/jmap/heapconfig/JMapHeapConfigTest.java 8072131,8132452 generic-all
>>  370 sun/tools/jinfo/JInfoSanityTest.java                           8059035 generic-all
>> 
>> 
> 
> I was trying to avoid introducing lots of spacing changes in an attempt to make the patch easier to review, but I can look over these cases again.

That?d be good.  Thanks
Mandy

From joe.darcy at oracle.com  Wed Mar 30 23:48:27 2016
From: joe.darcy at oracle.com (Joseph D. Darcy)
Date: Wed, 30 Mar 2016 16:48:27 -0700
Subject: <Beans Dev> JDK 9 RFR of JDK-8151763;
 Use more informative format for problem list
In-Reply-To: <45FA671B-7243-46ED-8772-10818F3276F6@oracle.com>
References: <56E38CCF.8080004@oracle.com> <56E9F15F.2050002@oracle.com>
	<56E9F1A1.3040309@oracle.com> <56F9C665.7070706@oracle.com>
	<BE7A108F-B5FA-4891-911D-1CFD4DC399B0@oracle.com>
	<56FAD46A.4080803@oracle.com>
	<45FA671B-7243-46ED-8772-10818F3276F6@oracle.com>
Message-ID: <56FC65CB.2060904@oracle.com>

Hi Mandy,

Hopefully the third time will be the charm for this changeset after your 
correction to the commented-out test:

     http://cr.openjdk.java.net/~darcy/8151763.2

I aligned the bug number in column 64 unless the test name took more 
characters. (This isn't as evident in the webrev since the tab expansion 
is different than in a text editor.)

Thanks,

-Joe

On 3/29/2016 12:31 PM, Mandy Chung wrote:
>> On Mar 29, 2016, at 12:15 PM, joe darcy <joe.darcy at oracle.com> wrote:
>>
>> Hi Mandy,
>>
>> On 3/28/2016 8:48 PM, Mandy Chung wrote:
>>>> On Mar 28, 2016, at 5:03 PM, Joseph D. Darcy <joe.darcy at oracle.com> wrote:
>>>>
>>>> Hello,
>>>>
>>>> New iteration of the webrev updated after the Jigsaw integration and incorporating the earlier feedback.
>>>>
>>>>     http://cr.openjdk.java.net/~darcy/8151763.1
>>>>
>>> # tools/jimage/JImageTest.java                                    linux-i586,windows-i586
>>>
>>> Is this test accidentally removed?  Other than this, looks okay.
>> The "#" lines are comments so I was removing a commented out line. (I assumed, but did not verify, the line for this test was a leftover artifact of the recent Jigsaw merge.)
> I missed ?#? since this test should be excluded (some error might have been creeped in before the integration)
>
> This test needs to be added back in the problem list.  I?ll create a changeset.
>
>>> Nit: it?d be good to have most of bug ids aligned in the same column start.
>>> Here are a few ones:
>>>
>>>   210 sun/security/krb5/auto/Unreachable.java     7164518 macosx-all no PortUnreachableException on Mac
>>>   212 java/security/KeyPairGenerator/SolarisShortDSA.java 7041639 solaris-all Solaris DSA keypair generation bug
>>>   213 sun/security/tools/keytool/standard.sh              7041639 solaris-all Solaris DSA keypair generation bug
>>>   346 java/util/Arrays/ParallelPrefix.java 8080165,8085982 generic-all
>>>   348 java/util/BitSet/BitSetStreamTest.java 8079538 generic-all
>>>   360 sun/tools/jmap/heapconfig/JMapHeapConfigTest.java 8072131,8132452 generic-all
>>>   370 sun/tools/jinfo/JInfoSanityTest.java                           8059035 generic-all
>>>
>>>
>> I was trying to avoid introducing lots of spacing changes in an attempt to make the patch easier to review, but I can look over these cases again.
> That?d be good.  Thanks
> Mandy


From Sergey.Bylokhov at oracle.com  Thu Mar 31 00:02:09 2016
From: Sergey.Bylokhov at oracle.com (Sergey Bylokhov)
Date: Thu, 31 Mar 2016 03:02:09 +0300
Subject: <Beans Dev> JDK 9 RFR of JDK-8151763;
 Use more informative format for problem list
In-Reply-To: <56FC65CB.2060904@oracle.com>
References: <56E38CCF.8080004@oracle.com> <56E9F15F.2050002@oracle.com>
	<56E9F1A1.3040309@oracle.com> <56F9C665.7070706@oracle.com>
	<BE7A108F-B5FA-4891-911D-1CFD4DC399B0@oracle.com>
	<56FAD46A.4080803@oracle.com>
	<45FA671B-7243-46ED-8772-10818F3276F6@oracle.com>
	<56FC65CB.2060904@oracle.com>
Message-ID: <56FC6901.7050106@oracle.com>

The fix looks fine to me. can you please clarify what "enabling better 
reporting" from the bug description means? Where this information will 
be reported?

On 31.03.16 2:48, Joseph D. Darcy wrote:
> Hi Mandy,
>
> Hopefully the third time will be the charm for this changeset after your
> correction to the commented-out test:
>
>      http://cr.openjdk.java.net/~darcy/8151763.2
>
> I aligned the bug number in column 64 unless the test name took more
> characters. (This isn't as evident in the webrev since the tab expansion
> is different than in a text editor.)
>
> Thanks,
>
> -Joe
>
> On 3/29/2016 12:31 PM, Mandy Chung wrote:
>>> On Mar 29, 2016, at 12:15 PM, joe darcy <joe.darcy at oracle.com> wrote:
>>>
>>> Hi Mandy,
>>>
>>> On 3/28/2016 8:48 PM, Mandy Chung wrote:
>>>>> On Mar 28, 2016, at 5:03 PM, Joseph D. Darcy <joe.darcy at oracle.com>
>>>>> wrote:
>>>>>
>>>>> Hello,
>>>>>
>>>>> New iteration of the webrev updated after the Jigsaw integration
>>>>> and incorporating the earlier feedback.
>>>>>
>>>>>     http://cr.openjdk.java.net/~darcy/8151763.1
>>>>>
>>>> # tools/jimage/JImageTest.java
>>>> linux-i586,windows-i586
>>>>
>>>> Is this test accidentally removed?  Other than this, looks okay.
>>> The "#" lines are comments so I was removing a commented out line. (I
>>> assumed, but did not verify, the line for this test was a leftover
>>> artifact of the recent Jigsaw merge.)
>> I missed ?#? since this test should be excluded (some error might have
>> been creeped in before the integration)
>>
>> This test needs to be added back in the problem list.  I?ll create a
>> changeset.
>>
>>>> Nit: it?d be good to have most of bug ids aligned in the same column
>>>> start.
>>>> Here are a few ones:
>>>>
>>>>   210 sun/security/krb5/auto/Unreachable.java     7164518 macosx-all
>>>> no PortUnreachableException on Mac
>>>>   212 java/security/KeyPairGenerator/SolarisShortDSA.java 7041639
>>>> solaris-all Solaris DSA keypair generation bug
>>>>   213 sun/security/tools/keytool/standard.sh              7041639
>>>> solaris-all Solaris DSA keypair generation bug
>>>>   346 java/util/Arrays/ParallelPrefix.java 8080165,8085982 generic-all
>>>>   348 java/util/BitSet/BitSetStreamTest.java 8079538 generic-all
>>>>   360 sun/tools/jmap/heapconfig/JMapHeapConfigTest.java
>>>> 8072131,8132452 generic-all
>>>>   370 sun/tools/jinfo/JInfoSanityTest.java
>>>> 8059035 generic-all
>>>>
>>>>
>>> I was trying to avoid introducing lots of spacing changes in an
>>> attempt to make the patch easier to review, but I can look over these
>>> cases again.
>> That?d be good.  Thanks
>> Mandy
>


-- 
Best regards, Sergey.

From joe.darcy at oracle.com  Thu Mar 31 00:06:40 2016
From: joe.darcy at oracle.com (Joseph D. Darcy)
Date: Wed, 30 Mar 2016 17:06:40 -0700
Subject: <Beans Dev> JDK 9 RFR of JDK-8151763;
 Use more informative format for problem list
In-Reply-To: <56FC6901.7050106@oracle.com>
References: <56E38CCF.8080004@oracle.com> <56E9F15F.2050002@oracle.com>
	<56E9F1A1.3040309@oracle.com> <56F9C665.7070706@oracle.com>
	<BE7A108F-B5FA-4891-911D-1CFD4DC399B0@oracle.com>
	<56FAD46A.4080803@oracle.com>
	<45FA671B-7243-46ED-8772-10818F3276F6@oracle.com>
	<56FC65CB.2060904@oracle.com> <56FC6901.7050106@oracle.com>
Message-ID: <56FC6A10.4000406@oracle.com>

Hi Sergey,

The thinking is the reformatted file, with the bug on the same line as 
the test, will allow in the future better reporting and analysis of 
problem list entries with information from the bug database.

Thanks for the review; HTH,

-Joe

On 3/30/2016 5:02 PM, Sergey Bylokhov wrote:
> The fix looks fine to me. can you please clarify what "enabling better 
> reporting" from the bug description means? Where this information will 
> be reported?
>
> On 31.03.16 2:48, Joseph D. Darcy wrote:
>> Hi Mandy,
>>
>> Hopefully the third time will be the charm for this changeset after your
>> correction to the commented-out test:
>>
>>      http://cr.openjdk.java.net/~darcy/8151763.2
>>
>> I aligned the bug number in column 64 unless the test name took more
>> characters. (This isn't as evident in the webrev since the tab expansion
>> is different than in a text editor.)
>>
>> Thanks,
>>
>> -Joe
>>
>> On 3/29/2016 12:31 PM, Mandy Chung wrote:
>>>> On Mar 29, 2016, at 12:15 PM, joe darcy <joe.darcy at oracle.com> wrote:
>>>>
>>>> Hi Mandy,
>>>>
>>>> On 3/28/2016 8:48 PM, Mandy Chung wrote:
>>>>>> On Mar 28, 2016, at 5:03 PM, Joseph D. Darcy <joe.darcy at oracle.com>
>>>>>> wrote:
>>>>>>
>>>>>> Hello,
>>>>>>
>>>>>> New iteration of the webrev updated after the Jigsaw integration
>>>>>> and incorporating the earlier feedback.
>>>>>>
>>>>>>     http://cr.openjdk.java.net/~darcy/8151763.1
>>>>>>
>>>>> # tools/jimage/JImageTest.java
>>>>> linux-i586,windows-i586
>>>>>
>>>>> Is this test accidentally removed?  Other than this, looks okay.
>>>> The "#" lines are comments so I was removing a commented out line. (I
>>>> assumed, but did not verify, the line for this test was a leftover
>>>> artifact of the recent Jigsaw merge.)
>>> I missed ?#? since this test should be excluded (some error might have
>>> been creeped in before the integration)
>>>
>>> This test needs to be added back in the problem list.  I?ll create a
>>> changeset.
>>>
>>>>> Nit: it?d be good to have most of bug ids aligned in the same column
>>>>> start.
>>>>> Here are a few ones:
>>>>>
>>>>>   210 sun/security/krb5/auto/Unreachable.java     7164518 macosx-all
>>>>> no PortUnreachableException on Mac
>>>>>   212 java/security/KeyPairGenerator/SolarisShortDSA.java 7041639
>>>>> solaris-all Solaris DSA keypair generation bug
>>>>>   213 sun/security/tools/keytool/standard.sh 7041639
>>>>> solaris-all Solaris DSA keypair generation bug
>>>>>   346 java/util/Arrays/ParallelPrefix.java 8080165,8085982 
>>>>> generic-all
>>>>>   348 java/util/BitSet/BitSetStreamTest.java 8079538 generic-all
>>>>>   360 sun/tools/jmap/heapconfig/JMapHeapConfigTest.java
>>>>> 8072131,8132452 generic-all
>>>>>   370 sun/tools/jinfo/JInfoSanityTest.java
>>>>> 8059035 generic-all
>>>>>
>>>>>
>>>> I was trying to avoid introducing lots of spacing changes in an
>>>> attempt to make the patch easier to review, but I can look over these
>>>> cases again.
>>> That?d be good.  Thanks
>>> Mandy
>>
>
>


From mandy.chung at oracle.com  Thu Mar 31 00:34:09 2016
From: mandy.chung at oracle.com (Mandy Chung)
Date: Wed, 30 Mar 2016 17:34:09 -0700
Subject: <Beans Dev> JDK 9 RFR of JDK-8151763;
	Use more informative format for problem list
In-Reply-To: <56FC65CB.2060904@oracle.com>
References: <56E38CCF.8080004@oracle.com> <56E9F15F.2050002@oracle.com>
	<56E9F1A1.3040309@oracle.com> <56F9C665.7070706@oracle.com>
	<BE7A108F-B5FA-4891-911D-1CFD4DC399B0@oracle.com>
	<56FAD46A.4080803@oracle.com>
	<45FA671B-7243-46ED-8772-10818F3276F6@oracle.com>
	<56FC65CB.2060904@oracle.com>
Message-ID: <A9A236B0-933C-40B7-91D2-F588D589AA54@oracle.com>


> On Mar 30, 2016, at 4:48 PM, Joseph D. Darcy <joe.darcy at oracle.com> wrote:
> 
> Hi Mandy,
> 
> Hopefully the third time will be the charm for this changeset after your correction to the commented-out test:
> 
>    http://cr.openjdk.java.net/~darcy/8151763.2
> 
> I aligned the bug number in column 64 unless the test name took more characters. (This isn't as evident in the webrev since the tab expansion is different than in a text editor.)
> 

Thanks for doing it.  Looks fine with me.

Just to mention it: these few lines are somewhat strange (shorter test name has more whitespace) that you may want to double check.  Ok to push what you have.

! java/nio/file/WatchService/Basic.java                                       7158947 solaris-all Solaris 11
! java/nio/file/WatchService/MayFlies.java                                    7158947 solaris-all Solaris 11
! java/nio/file/WatchService/LotsOfEvents.java                            7158947 solaris-all Solaris 11

Mandy

From joe.darcy at oracle.com  Thu Mar 31 01:15:29 2016
From: joe.darcy at oracle.com (joe darcy)
Date: Wed, 30 Mar 2016 18:15:29 -0700
Subject: <Beans Dev> JDK 9 RFR of JDK-8151763;
 Use more informative format for problem list
In-Reply-To: <A9A236B0-933C-40B7-91D2-F588D589AA54@oracle.com>
References: <56E38CCF.8080004@oracle.com> <56E9F15F.2050002@oracle.com>
	<56E9F1A1.3040309@oracle.com> <56F9C665.7070706@oracle.com>
	<BE7A108F-B5FA-4891-911D-1CFD4DC399B0@oracle.com>
	<56FAD46A.4080803@oracle.com>
	<45FA671B-7243-46ED-8772-10818F3276F6@oracle.com>
	<56FC65CB.2060904@oracle.com>
	<A9A236B0-933C-40B7-91D2-F588D589AA54@oracle.com>
Message-ID: <56FC7A31.7090802@oracle.com>

On 3/30/2016 5:34 PM, Mandy Chung wrote:
>> On Mar 30, 2016, at 4:48 PM, Joseph D. Darcy <joe.darcy at oracle.com> wrote:
>>
>> Hi Mandy,
>>
>> Hopefully the third time will be the charm for this changeset after your correction to the commented-out test:
>>
>>     http://cr.openjdk.java.net/~darcy/8151763.2
>>
>> I aligned the bug number in column 64 unless the test name took more characters. (This isn't as evident in the webrev since the tab expansion is different than in a text editor.)
>>
> Thanks for doing it.  Looks fine with me.
>
> Just to mention it: these few lines are somewhat strange (shorter test name has more whitespace) that you may want to double check.  Ok to push what you have.
>
> ! java/nio/file/WatchService/Basic.java                                       7158947 solaris-all Solaris 11
> ! java/nio/file/WatchService/MayFlies.java                                    7158947 solaris-all Solaris 11
> ! java/nio/file/WatchService/LotsOfEvents.java                            7158947 solaris-all Solaris 11
>

Pushed after a de-tabbification and verifying the set of tests to run 
was the same before and after the update.

Thanks,

-Joe


From mandy.chung at oracle.com  Thu Mar 31 01:24:44 2016
From: mandy.chung at oracle.com (Mandy Chung)
Date: Wed, 30 Mar 2016 18:24:44 -0700
Subject: <Beans Dev> JDK 9 RFR of JDK-8151763;
	Use more informative format for problem list
In-Reply-To: <56FC7A31.7090802@oracle.com>
References: <56E38CCF.8080004@oracle.com> <56E9F15F.2050002@oracle.com>
	<56E9F1A1.3040309@oracle.com> <56F9C665.7070706@oracle.com>
	<BE7A108F-B5FA-4891-911D-1CFD4DC399B0@oracle.com>
	<56FAD46A.4080803@oracle.com>
	<45FA671B-7243-46ED-8772-10818F3276F6@oracle.com>
	<56FC65CB.2060904@oracle.com>
	<A9A236B0-933C-40B7-91D2-F588D589AA54@oracle.com>
	<56FC7A31.7090802@oracle.com>
Message-ID: <C1EEC134-3A43-4F49-9FCE-481CF473E481@oracle.com>


> On Mar 30, 2016, at 6:15 PM, joe darcy <joe.darcy at oracle.com> wrote:
> 
> Pushed after a de-tabbification and verifying the set of tests to run was the same before and after the update.

It looks good.

Mandy