<Beans Dev> [9] Review Request: 8165263 Remove code in MetaData that hacks into private fields of Collections implementation classes

Mandy Chung mandy.chung at oracle.com
Thu Sep 29 17:14:55 UTC 2016


> On Sep 29, 2016, at 9:48 AM, Sergey Bylokhov <Sergey.Bylokhov at oracle.com> wrote:
> 
> Hello.
> 
> Please review the fix for jdk9.
> 
> Some of JavaBeans persistence delegates tries to access the private data in the java.base module. This functionality does not work on the latest jigsaw build. So such delegates should be removed. The possible solution for applications is to provide this delegates ourself. For example CheckedList_PersistenceDelegate tries to access the "type" which was passed to the constructor of CheckedList. So the user who create this CheckedList should provide delagate which will know what "type" should be used.
> 
> A separate bug was filed [1] to check is it possible to provide this via JavaBeans or not. The fix will be pushed to the client ws.
> 
> Bug: https://bugs.openjdk.java.net/browse/JDK-8165263
> Webrev can be found at: http://cr.openjdk.java.net/~serb/8165263/webrev.00

I think it’s a reasonable plan to revert the fix for JDK-6505888 and follow up the issue reported by JDK-6505888 as a separate issue.

The change looks okay.  Can this change go to jdk9/dev rather than jdk9/client?

Mandy


More information about the beans-dev mailing list