<Beans Dev> RFR: 8221244: behavior of PropertyDescription.getReadMethod when is/get getters are provided

[Sergey Bylokhov]

Hi, Dmitry.

Looks like the patch is empty:
http://cr.openjdk.java.net/~dcherepanov/8221244/webrev.01/jdk.patch

BTW please note that this change should be pushed to the
http://hg.openjdk.java.net/jdk/client

On 26/03/2019 03:40, Dmitry Cherepanov wrote:
> Hi Sergey,
> 
> Thanks for the review. Yes, this issue is specific to boolean properties only.  Updated the test to cover cases you suggested. The test passes for 8u as well.
> 
> http://cr.openjdk.java.net/~dcherepanov/8221244/webrev.01/
> 
> Dmitry
> 
>> On Mar 25, 2019, at 9:36 PM, Sergey Bylokhov <sergey.bylokhov at oracle.com> wrote:
>>
>> Hi, Dmitry.
>>
>> Can you please confirm that we will return "isXXX" getter for boolean properties only?
>> Also it would be good to cover additional checks in the test(and confirm that it works in the same way as in jdk8):
>> - if isXXX returns boolean
>> - if isXXX returns Boolean
>> - if isXXX returns Integer
>>
>> On 25/03/2019 04:27, Dmitry Cherepanov wrote:
>>> Hello,
>>> Please review the following fix
>>> JBS: https://bugs.openjdk.java.net/browse/JDK-8221244
>>> Webrev: http://cr.openjdk.java.net/~dcherepanov/8221244/webrev.00/
>>> The fix restores the code that took care of “not-replacing” the “is” getter with the “get” getters. The same check is already implemented in Introspector.processPropertyDescriptors [1] but after [2] the check is not longer working as PropertyDescriptor is now created from PropertyInfo that accumulates information about getters. The fix slightly adjusts PropertyInfo.initialize so that it doesn’t overwrite the “is” getter.
>>> Testing: added new regression test, tested with test/jdk/java/beans - no new failures found
>>> Thanks,
>>> Dmitry
>>> [1] https://hg.openjdk.java.net/jdk/jdk/file/d25b24c70126/src/java.desktop/share/classes/java/beans/Introspector.java#l637
>>> [2] https://bugs.openjdk.java.net/browse/JDK-4058433
>>
>>
>> -- 
>> Best regards, Sergey.
> 


-- 
Best regards, Sergey.