<Beans Dev> RFR: 8251123: doclint warnings about missing javadoc tags and comments [v2]

Phil Race prr at openjdk.java.net
Sat Oct 3 19:36:38 UTC 2020


On Sat, 3 Oct 2020 00:31:48 GMT, Sergey Bylokhov <serb at openjdk.org> wrote:

>> We have a number of missing javadoc tags and comments in the desktop module.
>> Most of the missing comments are related to the serialized form.
>> 
>> The fix:
>>   - Adds missing comments to the non-static/non-transient fields(even private) of the "serializable" classes
>>   - Adds comments to the "serializable" classes even if those classes are non-public
>>   - Fixes references/adds missing tags to the special methods(like readObject/writeObject)
>>   - Delete the java.awt.PeerFixer class.
>> 
>> I need advice about what exact change should be reviewed in  the CSR(except PeerFixer removal)
>> 
>> Note that in some cases I added the comments to the "implementation details", so I did not specify it fully.
>> 
>> The old review request:
>> https://mail.openjdk.java.net/pipermail/beans-dev/2020-August/000423.html
>
> Sergey Bylokhov has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Update ScrollPane.java
>  - Update based on the feedback

Marked as reviewed by prr (Reviewer).

-------------

PR: https://git.openjdk.java.net/jdk/pull/369


More information about the beans-dev mailing list