Patch to build 64 bit VM

Xiaobin Lu Xiaobin.Lu at Sun.COM
Mon Dec 22 11:06:30 PST 2008


Hi Greg,

I am attaching the patch to make the VM build pass on Mac OS 64 bit.  
Here is some explanation on the change:

bytes_bsd_x86.inline.cpp:

Change bswap16(x) to bswap_16(x) and the similar, I believe there was a 
typo for this. When some ported this to Apple platform, they missed a 
underscore.

os_bsd_x86.cpp

There was a "}" missing for 64 bit build.

Other changes to make the build pass will be covered by my fix to 
6787106 which I am going to put back to open JDK 7 tree soon.

Please help me review the patch and feel free to let me know if there 
was anything wrong.

-Xiaobin

Greg Lewis wrote:
> G'day Xiaobin,
>
> On Wed, Dec 17, 2008 at 09:14:16PM -0800, Xiaobin Lu wrote:
>   
>> I am attaching the patch for building 64 bit VM. They are BSD specific 
>> files.  Would someone review it and help me check it in?
>>     
>
> Sure.  Can you comment a little on the changes to
> src/os_cpu/bsd_x86/vm/bytes_bsd_x86.inline.hpp?  It seems like the diff is
> bigger than the changes if that makes sense (i.e. there are some whitespace
> changes due to control flow changes which are hiding those).
>
>   

-------------- next part --------------
A non-text attachment was scrubbed...
Name: patch_12_19_amd64
Type: video/x-flv
Size: 1624 bytes
Desc: not available
Url : http://mail.openjdk.java.net/pipermail/bsd-port-dev/attachments/20081222/86f99d30/patch_12_19_amd64.bin 


More information about the bsd-port-dev mailing list