How to differentiate between BSD and OSX and POST_STRIP_PROCESS

[Kelly O'Hair]

Could we do something like this instead?

ifeq ($(OS_VENDOR), Apple)
   STRIP_G_OPTION =
else
   # strip option that leaves local function Elf symbols (better stack traces)
   STRIP_G_OPTION = -g
endif

ifeq ($(VARIANT), OPT)
   ifneq ($(NO_STRIP), true)
     # Debug 'strip -g' leaves local function Elf symbols (better stack traces)
     POST_STRIP_PROCESS = $(STRIP) $(STRIP_G_OPTION)
   endif
endif



-kto


Michael Franz wrote:
> I have this small patch to fix the strip -g not being valid on OS X.
> 
> diff -r 3057550cd8b4 make/common/Defs-bsd.gmk
> --- a/make/common/Defs-bsd.gmk    Wed Aug 20 21:22:02 2008 -0700
> +++ b/make/common/Defs-bsd.gmk    Sat Oct 04 23:12:10 2008 -0400
> @@ -209,8 +209,12 @@ AUTOMATIC_PCH_OPTION =
>  #
>  ifeq ($(VARIANT), OPT)
>    ifneq ($(NO_STRIP), true)
> -    # Debug 'strip -g' leaves local function Elf symbols (better stack 
> traces)
> -    POST_STRIP_PROCESS = $(STRIP) -g
> +    ifneq ($(OS_VENDOR), Apple)
> +      # Debug 'strip -g' leaves local function Elf symbols (better 
> stack traces)
> +      POST_STRIP_PROCESS = $(STRIP) -g
> +    else
> +     POST_STRIP_PROCESS = $(STRIP)
> +    endif
>    endif
>  endif
> 
> Michael
> 
> On Sun, Sep 28, 2008 at 3:16 PM, Kelly O'Hair <Kelly.Ohair at sun.com 
> <mailto:Kelly.Ohair at sun.com>> wrote:
> 
>     Maybe something along the lines of this?
> 
>     UNAME_S := $(shell uname -s)
>     POST_STRIP_PROCESS-Darwin= ...
>     POST_STRIP_PROCESS-Linux= ...
>     POST_STRIP_PROCESS-SunOS= ...
>     ...
>     POST_STRIP_PROCESS=$(POST_STRIP_PROCESS-$(UNAME_S))
> 
>     -kto
> 
> 
> ------------------------------------------------------------------------
> 
>