Fixes for Head...

[Christos Zoulas]

On Jun 2,  7:55pm, kurt at intricatesoftware.com (Kurt Miller) wrote:
-- Subject: Re: Fixes for Head...

| > For jdk:
| > 
| > 1. Prefer hw.physmem64 if it exists.
| 
| OpenBSD's sysctl doesn't error out when presented with bad data it
| just warns and continues to parse arguments so I'll special case
| it. FreeBSD and OS X/Darwin do error out like NetBSD.

Ok, thanks.

| > 2..(n-1): jibx 1.2.1 needs an isExtension(String) implemented.
| 
| I prefer these not to be committed. We're trying to keep changes to
| a minimum and the build docs require a specific version of jibx. See
| 
| README-builds.html: JIBX libraries version 1.1.5 is required for
| building the OpenJDK.

Fine with me (the change actually future proofs the code, so both 1.1.5
and 1.2.1 work with it; eventually OpenJDK will have to add it).

| > n. - NetBSD does not have statfs, it has statvfs.
| >    - Don't cast malloc return; it is bad form (and it will hide errors
| >      from not including <stdlib.h>).
| >    - NULL is not 0, could be (void *)0
| 
| Whoops - sorry. I swear I checked NetBSD's online man pages, but now
| I see it isn't there.

Great, thanks.

| > For corba [the last patch], same as [1]:
| 
| Will handle same as [1]

Thank you!

christos