Extra Zero/Shark patches for review

[Greg Lewis]

G'day Christos,

On Sun, Nov 15, 2009 at 05:03:20PM -0500, Christos Zoulas wrote:
> On Nov 15,  1:06pm, glewis at eyesbeyond.com (Greg Lewis) wrote:
> -- Subject: Extra Zero/Shark patches for review
> 
> | G'day all,
> | 
> | I just committed a few patches for Zero support on BSD which should be
> | fairly safe.  I've got a couple more that I'd like to get some review
> | on before committing.  So far I've tested them on FreeBSD 7.x/i386 (single
> | processor machine) and I'm able to run a few simple Java programmes with
> | the resulting JDK:
> | 
> | > ./build/bsd-i586/bin/java -version
> | openjdk version "1.7.0-internal"
> | OpenJDK Runtime Environment (build 1.7.0-internal-glewis_2009_11_15_11_42-b00)
> | OpenJDK Zero VM (build 17.0-b05, interpreted mode)
> | 
> | These are the extra settings I'm using to build Zero:
> | 
> | ZERO_BUILD=true
> | ZERO_ENDIANNESS=little
> | ZERO_LIBARCH=i386
> | ZERO_ARCHDEF=IA32
> | 
> | It doesn't really seem like I should have to set the latter three, but they
> | don't seem to get set otherwise for the HotSpot build.  It really seems
> | like the build should run something like jdk/make/jdk_generic_profile.sh
> | which seems to set up things for Zero.
> | 
> | Anyway, in terms of the patches, I'd like some opinions on whether the
> | atomic changes are portable across the different BSDs (and whether they
> | do the right thing :).  Note that the changes to os_bsd_zero.cpp are fairly
> | minimal.  I suspect a careful review of the file may identify more changes
> | that should be made.
> 
> The store_rel and cmpset ones are not on NetBSD. We have atomic_swap and
> atomic_cas. We also have <sys/atomic.h>...
> 
> | I'll include the patches inline and also attach them since I'm not sure on
> | the mailing list policy regarding attachments.
> 
> Thanks,
> 
> I can create a patch for NetBSD... But as usual, I can't commit it.

I'd be more than happy to commit it.  Getting Zero working has the biggest
benefit for NetBSD since it support the most platforms :).

-- 
Greg Lewis                          Email   : glewis at eyesbeyond.com
Eyes Beyond                         Web     : http://www.eyesbeyond.com
Information Technology              FreeBSD : glewis at FreeBSD.org