Printf changes

[Alexander Strange]

On Jan 24, 2011, at 5:40 PM, Alexander Strange wrote:

> 
> On Jan 24, 2011, at 3:18 AM, Greg Lewis wrote:
> 
>> G'day all,
>> 
>> I'd like to commit the included changes to how things are printed within
>> HotSpot.  The current version seems to cause problems on MacOS X (or at
>> least I ran into problems compiling a 64 bit version of OpenJDK7).
>> 
>> I've changed the format specifications to use the C99 printf format
>> definitions, which should make things more portable.  I've tested things
>> on FreeBSD/i386 and MacOS X/x86_64.  I'd appreciate some wider testing
>> (particularly MacOS X/i386).
> 
> macosx-port, of course, contains changes which work on OS X i386 and x86-64.
> 
> The bits you want are src/cpu/x86/vm/jni_x86.h, src/share/vm/utilities/globalDefinitions.hpp, and the changes after that here:
> http://hg.openjdk.java.net/macosx-port/macosx-port/hotspot/rev/5df62246ab09
> 
> That said, I'll try this one out since avoiding #ifdef __APPLE__ sections is good for maintainability.

It works on i386. (which is good, since I see you committed it)

I seem to remember Windows C++ compilers not shipping inttypes.h, though, so I wonder if this won't cause problems in the future. This can always be fixed by shipping an internal copy of course.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/bsd-port-dev/attachments/20110128/fb970d48/attachment.html