hg: bsd-port/bsd-port/hotspot: . OpenBSD nm(1) doesn't have -U or -j, so provide an OpenBSD specific

Jung-uk Kim jkim at FreeBSD.org
Mon May 5 17:27:44 UTC 2014


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 2014-05-05 13:05:56 -0400, ?? wrote:
> On Mon, 2014-05-05 at 12:42 -0400, Jung-uk Kim wrote:
>> On 2014-05-05 02:37:38 -0400, ?? wrote:
>>> Hi,
>>> 
>>> Thus wrote kurt at intricatesoftware.com 
>>> (kurt at intricatesoftware.com):
>>> 
>>>> . OpenBSD nm(1) doesn't have -U or -j, so provide an OpenBSD 
>>>> specific
>>> 
>>> neither have NetBSD's nor FreeBSD's. Generalization would be 
>>> appreciated.
>> 
>> FYI, this is what I did in FreeBSD port for jdk8.
>> 
>> /head/java/openjdk8/files/patch-bsd?revision=352721&view=markup#l155
>>
>>
>> 
Jung-uk Kim
> 
> Thanks. OpenBSD doesn't have --defined-only. I believe the
> following change will work for *BSD:

I see.

> diff -r 0d6f95e05945 make/bsd/makefiles/build_vm_def.sh ---
> a/make/bsd/makefiles/build_vm_def.sh	Mon Apr 28 12:29:31 2014
> -0400 +++ b/make/bsd/makefiles/build_vm_def.sh	Mon May 05 12:50:51
> 2014 -0400 @@ -7,7 +7,10 @@ NM=nm fi
> 
> -if [ `uname` == "OpenBSD" ] ; then

Please note '==' is a Linuxism/Bashism.  '=' is Posixly-correct
equivalent.

> +OS_NAME=`uname -s` +BSD_OS=${OS_NAME##${OS_NAME%BSD}} + +if [
> "$BSD_OS" == "BSD" ] ; then $NM $* \ | awk '{ if ($2 != "U") if ($3
> ~ /^_ZTV/ || $3 ~ /^gHotSpotVM/) print "\t" $3 ";"
...

This file is just for *BSDs and Mac but Mac's toolchains are always
special.  Therefore, Darwin should be specialized, not ours.

Also, I am not sure why 'if ($2 != "U")' was repeated three times.
awk(1) is not that dumb. ;-)

Jung-uk Kim
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.22 (FreeBSD)

iQEcBAEBAgAGBQJTZ8oQAAoJEHyflib82/FGz54IAIJeYo7A8aT3LVgI6m7kZWkX
WDl7fKYO1uY9PL5dTLAaqeUKZJyxFTgLS+If7Tl5e2UFYDXnzs9cYHfKhAgnEz1m
FtbYd/1x+GDF6dUNBIX5tVW/dHbe70OBEQUrHUsplhhq3EX8eRH4waeMW/7UgIaC
3vFQ+pxJ5SB/8ORziSf0eTtSKegxuLGUnZsxBPiKS0J/lOVAuH4inKLHjsfknVg3
7+6MQExpt8FB2Y75nNuh4cSUEvyB0qe4v0D09lgZHHmqc/3rheBINMLp+p6OJNrg
OAhGidB/U5NhRR0eu+h32gLI8UM4QN/f5nzTJOo/yxKCvegQpflQkWHEu2pmZBY=
=xODX
-----END PGP SIGNATURE-----


More information about the bsd-port-dev mailing list