Building on Fedora 6

[Kelly O'Hair]

Adding the unset LD_LIBRARY_PATH and the export LANG=C to this file
makse sense, I'll take care of that. This .sh file is only for use when
building the jdk, so it seems reasonable to change this file.

The LANG setting is necessary to prevent builds from  getting locked
into the wrong locale, I forget the details, but builds with ja locale
fail as I recall, and I decided that only C locale builds made sense.

The LD_LIBRARY_PATH unset might be a problem for some, not for me, but
in general you don't want stray libraries loaded from this PATH.
The build should only rely on the libraries in /lib and /usr/lib.
There have been numerous build failures in the past related to this.

The ALT_CLOSED_JDK_IMPORT_PATH setting is something that depends on where
the binary plugs got downloaded, so it depends on the builder.
It was intended that this be manually set and specifically, it needs to be
pointing at one of the Binary Plugs provided on the openjdk.java.net site.
Legal issues involved here, e.g. great pains. :^(

A builder could just add this one to their own ENV variables, or create
a my_jdk_profile.sh file that just does:

   . j2se/make/jdk_generic_profile.sh
   export ALT_CLOSED_JDK_IMPORT_PATH=/home/aph/openjdk/jdk1.7.0/

Hope this helps. When JavaOne is over and I recover from all this
openjsk mania, I'll get the LANG/LD_LIBRARY_PATH changes in.

-kto


Andrew Haley wrote:
> Phil Race writes:
>  > This very probably should be sent to the build-dev list instead but ..
>  > 
>  > 
>  > Andrew Haley wrote:
>  > > openjdk-7-ea-src-b12-06_may_2007.zip built on Fedora Core 6 AMD64 with
>  > > apparently no problems.  Changes to jdk_generic_profile.sh control
>  > > were needed as below:
>  > >
>  > > --- j2se/make/jdk_generic_profile.sh    2007-05-06 10:03:44.000000000 +0100
>  > > +++ control/jdk_generic_profile.sh      2007-05-09 11:06:18.000000000 +0100
>  > > @@ -109,8 +109,12 @@
>  > >  fi
>  > >  export COMPUTERNAME
>  > >  
>  > > +unset LD_LIBRARY_PATH
>  > >   
>  > 
>  > We generally consider any shell setting of   LD_LIBRARY_PATH to be evil
>  > I don't mean JDK I mean much more generally than that
>  > Having said that I haven't heard of it causing build problems before.
>  > What is the problem it caused you?
> 
> None at all, except that the sanity check whined about it.
> 
>  > +export LANG=C
>  > I think Kelly mentioned some problems in some locales .. is that what 
>  > this is for?
> 
> As above.
> 
>  > > +
>  > >  # Boot jdk
>  > > -bootjdk=jdk1.6.0
>  > > +bootjdk=jdk1.6.0_01
>  > > +ALT_CLOSED_JDK_IMPORT_PATH=/home/aph/openjdk/jdk1.7.0/
>  > 
>  > these are intended to be changed/set via  envt variables  passed to make
> 
> Well, yes, but dk_generic_profile.sh sets those environment variables.
> I'm presuming that you're not saying that there should be yet another
> variable-setting script that should be run before running this script.
> :-)
> 
> Andrew.
>