Makefile patch needed when building the b20 OpenJDK source drop

[Ted Neward]

Here's potentially a dumb question: is there any chance of putting the
BinaryPlugs into the source repository? I pulled down b20, didn't check to
see if the binary plugs had changed and kicked off a build, and it failed
due to some changes in the binary plugs directory structure (AFAICT).

(1) Am I correct in thinking the binary plugs stuff changed around a touch,
and
(2) If that is the case, is there any chance of putting them into the SVN
(or Mercurial) repository, so when I do a source refresh, I'll get the right
bits even as they're changing around?

Ted Neward
Java, .NET, XML Services
Consulting, Teaching, Speaking, Writing
http://www.tedneward.com
 

> -----Original Message-----
> From: build-dev-bounces at openjdk.java.net [mailto:build-dev-
> bounces at openjdk.java.net] On Behalf Of Tim Bell
> Sent: Saturday, September 15, 2007 2:45 PM
> To: build-dev at openjdk.java.net
> Subject: Re: Makefile patch needed when building the b20 OpenJDK source
> drop
> 
> Xiomara.Jayasena at Sun.COM wrote:
> >
> > Building the b20 OpenJDK source drop will fail, as follows:
> >
> >   gnumake[3]: Entering directory
> > `/BUILD_AREA/openjdk/b20/openjdk/j2se/make/javax/sound'
> >   Makefile:64: ../../common/BinaryPlugs.gmk: No such file or
> directory
> >   gnumake[3]: *** No rule to make target
> > `../../common/BinaryPlugs.gmk'.  Stop.
> 
> As it turns out we missed two files.  Here is the patch information.
> You will need this if you are building JDK b20:
> 
> --- old/make/javax/sound/jsoundhs/Makefile	Fri Sep 14 13:40:16
> 2007
> +++ new/make/javax/sound/jsoundhs/Makefile	Fri Sep 14 13:40:16
> 2007
> @@ -39,7 +39,7 @@
> 
>   build: import-binary-plug-jsound-library
> 
> -include $(BUILDDIR)/common/BinaryPlugs.gmk
> +include $(BUILDDIR)/common/internal/BinaryPlugs.gmk
> 
>   else # OPENJDK
> 
> --- old/make/javax/sound/Makefile	Fri Sep 14 13:40:17 2007
> +++ new/make/javax/sound/Makefile	Fri Sep 14 13:40:17 2007
> @@ -61,7 +61,7 @@
>   # copy closed .class files
>   build: import-binary-plug-sound-classes
> 
> -include $(BUILDDIR)/common/BinaryPlugs.gmk
> +include $(BUILDDIR)/common/internal/BinaryPlugs.gmk
> 
>   endif # OPENJDK
> 
> 
> 
> Hope this helps-
> 
> Tim
> 
> No virus found in this incoming message.
> Checked by AVG Free Edition.
> Version: 7.5.487 / Virus Database: 269.13.16/1005 - Release Date:
> 9/13/2007 11:45 AM
> 

No virus found in this outgoing message.
Checked by AVG Free Edition. 
Version: 7.5.487 / Virus Database: 269.13.27/1020 - Release Date: 9/20/2007
12:07 PM