splashscreen.so is missing pnggccrd.c

Mark Wielaard mark at klomp.org
Thu Aug 28 17:35:32 UTC 2008


Hi Anthony,

On Thu, 2008-08-28 at 14:23 +0400, Anthony Petrov wrote:
> 1. The patch cuts off the embedded versions of these libraries from 
> OpenJDK source code. In fact, there may exist systems where these 
> libraries are not installed. And currently OpenJDK runs perfectly on 
> these systems since it have the libraries compiled in.

Yes it does remove the upstream sources. But I admit to be slightly
confused about this practice of embedding upstream source code into your
own code repository. If we want to support static linking of libraries
wouldn't it be enough to configure and detect the static library .a
versions and link against those?

> 2. The system libraries may contain issues/errors/bugs/whatever which 
> our code cannot deal with (I think Java2D folks may collaborate on 
> this). Throwing the libraries away from the OpenJDK code may reveal some 
> of the issues, but we obviously can't fix the libraries as fast as our 
> code. And also, we do guarantee some behavior (like understanding file 
> format versions or whatever) that we wouldn't be able to guarantee if we 
> can't ship our copies of the libraries.

It would be good to have a list of the guarantees so we can write tests
and configure checks to make sure only correct libraries are linked in.

Cheers,

Mark




More information about the build-dev mailing list