jdk7 build issue with GNU make 3.81

Kelly O'Hair Kelly.Ohair at Sun.COM
Wed Feb 6 23:44:14 UTC 2008


FYI...  patch for bug 6638060 attached.

The latest GNU make 3.81 has changed the way it deals with the SHELL env
variable, brought out this issue in the makefiles.

-kto



-------------- next part --------------
# HG changeset patch
# User ohair
# Date 1200095095 28800
# Node ID 4a2f3f213b505a804aa059ab68a11e91bb45f9f6
# Parent  99a06bc7fdb5bd70a3b23f68fcd428e99da1dbba
6638060: Build failed with GNU make 3.81 (part of latest Solaris 'gmake')

diff -r 99a06bc7fdb5 -r 4a2f3f213b50 make/java/nio/Makefile
--- a/make/java/nio/Makefile	Tue Dec 04 16:28:33 2007 -0800
+++ b/make/java/nio/Makefile	Fri Jan 11 15:44:55 2008 -0800
@@ -191,7 +191,7 @@ sources: $(SPP) $(FILES_genout)
 
 GEN_BUFFER_SH = genBuffer.sh
 
-GEN_BUFFER_CMD = SPP="$(SPP_CMD)" NAWK=$(NAWK) SED=$(SED) \
+GEN_BUFFER_CMD = SPP="$(SPP_CMD)" NAWK=$(NAWK) SED=$(SED) SH=$(SH) \
                  $(SH) $(GEN_BUFFER_SH)
 
 # Public abstract buffer classes
@@ -582,7 +582,7 @@ GEN_BUFFER_CMD = SPP="$(SPP_CMD)" NAWK=$
 
 GEN_CODER_SH = genCoder.sh
 
-GEN_CODER_CMD = SPP="$(SPP_CMD)" SED=$(SED) NAWK=$(NAWK) $(SH) $(GEN_CODER_SH)
+GEN_CODER_CMD = SPP="$(SPP_CMD)" SED=$(SED) NAWK=$(NAWK) SH=$(SH) $(SH) $(GEN_CODER_SH)
 
 $(CS_GEN)/CharsetDecoder.java: $(CS_SRC)/Charset-X-Coder.java $(GEN_CODER_SH)
 	$(prep-target)
@@ -602,7 +602,7 @@ GEN_CODER_CMD = SPP="$(SPP_CMD)" SED=$(S
 
 GEN_EX_SH = genExceptions.sh
  
-GEN_EX_CMD = NAWK=$(NAWK) $(SHELL) $(GEN_EX_SH)
+GEN_EX_CMD = NAWK=$(NAWK) SH=$(SH) $(SH) $(GEN_EX_SH)
 
 $(CH_GEN)/%Exception.java: genExceptions.sh $(CH_SRC)/exceptions
 	$(prep-target)
@@ -635,8 +635,8 @@ HASHER_JARFILE = $(BUILDTOOLJARDIR)/hash
     $(HASHER_JARFILE) $(SCS_SRC)/standard-charsets
 	$(prep-target)
 	@$(RM) $@.temp
-	NAWK=$(NAWK) TEMPDIR=$(TEMPDIR) \
+	NAWK=$(NAWK) TEMPDIR=$(TEMPDIR) SH=$(SH) \
 	  HASHER="$(BOOT_JAVA_CMD) -jar $(HASHER_JARFILE)" \
-	  $(SHELL) -e genCharsetProvider.sh $(SCS_SRC)/standard-charsets $(SCS_GEN)
+	  $(SH) -e genCharsetProvider.sh $(SCS_SRC)/standard-charsets $(SCS_GEN)
 
 .PHONY: sources 
diff -r 99a06bc7fdb5 -r 4a2f3f213b50 make/java/nio/genCharsetProvider.sh
--- a/make/java/nio/genCharsetProvider.sh	Tue Dec 04 16:28:33 2007 -0800
+++ b/make/java/nio/genCharsetProvider.sh	Fri Jan 11 15:44:55 2008 -0800
@@ -48,7 +48,7 @@ echo '-->' $OUT
 # Header
 #
 
-$SHELL addNotices.sh "$COPYRIGHT_YEARS" > $OUT
+$SH ./addNotices.sh "$COPYRIGHT_YEARS" > $OUT
 
 cat <<__END__ >>$OUT
 
diff -r 99a06bc7fdb5 -r 4a2f3f213b50 make/java/nio/genExceptions.sh
--- a/make/java/nio/genExceptions.sh	Tue Dec 04 16:28:33 2007 -0800
+++ b/make/java/nio/genExceptions.sh	Fri Jan 11 15:44:55 2008 -0800
@@ -41,7 +41,7 @@ gen() {
   echo '-->' $DST/$ID.java
   out=$DST/${ID}.java
 
-  $SHELL addNotices.sh "$COPYRIGHT_YEARS" > $out
+  $SH ./addNotices.sh "$COPYRIGHT_YEARS" > $out
 
 cat >>$out <<__END__
 


More information about the build-dev mailing list