RFC: architecture define probably masks variable names in header files

[Ted Neward]

This may be an area where you have to implement the fix and submit it as a
patch, because I can see the developers at Sun not having the bandwidth to
take time away from the other things they're working on to take care of this
themselves--they're horribly underresourced (if you'll pardon the
verbization) from what I understand.

What change would you suggest, and how deeply would it ripple through the
code base?

Ted Neward
Java, .NET, XML Services
Consulting, Teaching, Speaking, Writing
http://www.tedneward.com 

> -----Original Message-----
> From: build-dev-bounces at openjdk.java.net [mailto:build-dev-
> bounces at openjdk.java.net] On Behalf Of Christian Thalinger
> Sent: Monday, January 21, 2008 8:37 AM
> To: build-dev
> Subject: Re: RFC: architecture define probably masks variable names in
> header files
> 
> On Wed, 2008-01-16 at 23:04 +0100, Christian Thalinger wrote:
> > Hi!
> >
> > Today I noticed that it's not a good idea to use an architecture
> define
> > as done in OpenJDK:
> >
> > CPPFLAGS_COMMON = -D$(ARCH) -DARCH='"$(ARCH)"' -DLINUX
> $(VERSION_DEFINES) \
> > 		  -D_LARGEFILE64_SOURCE -D_GNU_SOURCE -D_REENTRANT
> >
> > The -D$(ARCH) e.g. on an Alpha system makes big problems because a
> lot
> > of variables are called "alpha" in GUI code.
> >
> > I tried to patch the OpenJDK code in IcedTea but then I reached a
> point
> > where it's not possible to fix the issue:
> >
> > /usr/include/png.h:
> >
> > typedef struct png_color_8_struct
> > {
> >    png_byte red;   /* for use in red green blue files */
> >    png_byte green;
> >    png_byte blue;
> >    png_byte gray;  /* for use in grayscale files */
> >    png_byte alpha; /* for alpha channel files */
> > } png_color_8;
> >
> > This won't work.
> >
> > Normally build systems use architecture defines as __ALPHA__ or
> > __alpha__ (these are also defined by the C compiler).
> >
> > Any chance to get this thing changed/fixed upstream in the OpenJDK
> code?
> > As I can't think of another solution of that problem...
> >
> > Probably someone decides to name a function argument "sparc"
> > someday... ;-)
> 
> So... noone cares?
> 
> - twisti
> 
> No virus found in this incoming message.
> Checked by AVG Free Edition.
> Version: 7.5.516 / Virus Database: 269.19.7/1232 - Release Date:
> 1/18/2008 7:32 PM
> 

No virus found in this outgoing message.
Checked by AVG Free Edition. 
Version: 7.5.516 / Virus Database: 269.19.9/1237 - Release Date: 1/22/2008
11:04 AM