javax.script rhino (javascript) support added

[Mark Wielaard]

Hi David,

On Mon, 2008-06-23 at 11:43 -0700, David Herron wrote:
> Mark Wielaard wrote:
> In my JavaOne talk Sandeep and I had worked up a hack with the same 
> purpose.  He's been busy enough that he hadn't had a chance to turn the 
> hack into an official proposal like this.. 

That is cool, I didn't know that.
Is your presentation online somewhere?

> This patch puts a hard dependency on having rhino in your environment.  
> Maybe this is okay for IcedTea but in OpenJDK's makefiles I'd rather it 
> be a loose dependency (if RHINO_JAR is in the environment, that should 
> trigger makefile rules to include RHINO support).

Yes, we can do that. My thinking was that if it is always included in
closedjdk6 we want to also always provide it in the free version.

> A lot of the changes are in com/sun/script/javascript files to change 
> imports from sun.org.mozilla.xyzzy to org.mozilla.xyzzy ... we've been 
> following a practice for a long time of munging the package names of 
> imported packages, and this came from issues which arose when we 
> imported Xerces XML code and people started using some of the Xerces 
> API's ...

hmmm, that seems not the right thing to do for the free version that
gets integrated with the various GNU/Linux distros. The patch
deliberately makes it so that the code isn't actually imported and
emedded , but that it uses the system provided rhino. The idea is that
these kind of external dependencies are provided by the distribution.
That way a user automatically gets bug fixes or security updates without
having to audit every package which might have integrated an old
(renamed) library.

I would like to find a way to do this cleaner though. But the current
code relies on being on the bootclasspath which makes things a little
tricky.

Cheers,

Mark