From Xiomara.Jayasena at Sun.COM Wed Apr 1 02:14:13 2009 From: Xiomara.Jayasena at Sun.COM (Xiomara.Jayasena at Sun.COM) Date: Tue, 31 Mar 2009 19:14:13 -0700 Subject: Round two Re: Please review fix for 6819847 [Re: [Fwd: Problems with building jmx for OpenJDK.]] In-Reply-To: <49D27C8A.7050304@sun.com> References: <49C2AE84.3080709@sun.com> <49C2B8B5.9020305@sun.com> <49C2BDD6.2020602@sun.com> <49C36D66.9050203@sun.com> <49C3D5F1.30206@sun.com> <49D223E9.1050609@sun.com> <49D27C8A.7050304@sun.com> Message-ID: <49D2CDF5.5060406@Sun.COM> Thumbs down -- sorry Tim, this fix breaks the product build. -Xiomara On 03/31/09 13:26, Tim Bell wrote: > I wrote: > >> One question - if the user goes to the trouble to set any of >> ALT_BINARY_PLUGS_JARFILE, ALT_BINARY_PLUGS_PATH, >> ALT_BUILD_BINARY_PLUGS_PATH, ALT_CLOSED_JDK_IMPORT_PATH >> (See the comments in jdk/make/common/Defs.gmk starting at line 127), >> should we assume they must really, really want the binary plugs and >> force IMPORT_BINARY_PLUGS=true? Or have them set it as well? > > >> I am thinking we shouldn't do this automatically. I notice in the >> logs that JPRT is setting these even when IMPORT_BINARY_PLUGS=false. > > Review feedback convinced me to reverse that last statement. > > Here is round two - please take a look: > > http://cr.openjdk.java.net/~tbell/6819847/webrev.01/ > > With these changes the default behavior is as if > IMPORT_BINARY_PLUGS=false > > Unless the user explicitly sets any of the PLUGS variables: > ALT_BINARY_PLUGS_JARFILE, ALT_BINARY_PLUGS_PATH, > ALT_BUILD_BINARY_PLUGS_PATH, ALT_CLOSED_JDK_IMPORT_PATH > > Setting these will force IMPORT_BINARY_PLUGS=true > > The other case is if a user outside the Sun network sets > IMPORT_BINARY_PLUGS=true. Here they will need to set one of the > ALT_..._BINARY_PLUGS variables to point to the plugs anyway. > > Thanks in advance for feedback- > > Tim Bell From Tim.Bell at Sun.COM Wed Apr 1 02:19:17 2009 From: Tim.Bell at Sun.COM (Tim Bell) Date: Tue, 31 Mar 2009 19:19:17 -0700 Subject: Round two Re: Please review fix for 6819847 [Re: [Fwd: Problems with building jmx for OpenJDK.]] In-Reply-To: <49D2CDF5.5060406@Sun.COM> References: <49C2AE84.3080709@sun.com> <49C2B8B5.9020305@sun.com> <49C2BDD6.2020602@sun.com> <49C36D66.9050203@sun.com> <49C3D5F1.30206@sun.com> <49D223E9.1050609@sun.com> <49D27C8A.7050304@sun.com> <49D2CDF5.5060406@Sun.COM> Message-ID: <49D2CF25.2050703@sun.com> Xiomara.Jayasena at Sun.COM wrote: > > Thumbs down -- sorry Tim, this fix breaks the product build. Indeed it did. Sigh. I am working on a fix under bug-ID 6824595 "OpenJDK fix breaks product build for jdk7". No wonder everyone is afraid to touch these Makefiles. My build checklist just got twice as long. :-/ Tim From g.koppen at jondos.de Wed Apr 1 08:09:38 2009 From: g.koppen at jondos.de (Georg Koppen) Date: Wed, 01 Apr 2009 10:09:38 +0200 Subject: OpenJDK6: Bug in genlocales.gmk Message-ID: <49D32142.8030608@jondos.de> Hi, some days ago I dwonloaded the OpenJDK6 sources from http://download.java.net/openjdk/jdk6/ and tried to compile it on my Windows XP. Well, I succeeded finally but I found a bug in ~/jdk/make/java/java/genlocales.gmk. There "NAWK=$(NAWK)" should be changed to "NAWK="$(NAWK)"". Otherwise I get an error during compiling like "/bin/sh -v command not found". I don't know whether this problem still exists (didn't try mercurial) and I found no comment about it on the mailing list. If that's the case just ignore the mail and sorry for bothering you. But if not it would be nice if the one in charge for this part of the code corrects it, although it's not a major thing. Georg From tim.bell at sun.com Wed Apr 1 11:50:17 2009 From: tim.bell at sun.com (tim.bell at sun.com) Date: Wed, 01 Apr 2009 11:50:17 +0000 Subject: hg: jdk7/build/jdk: 6824595: OpenJDK fix breaks product build for jdk7 Message-ID: <20090401115044.B1667EE2B@hg.openjdk.java.net> Changeset: ecb7723aaa7c Author: tbell Date: 2009-04-01 04:44 -0700 URL: http://hg.openjdk.java.net/jdk7/build/jdk/rev/ecb7723aaa7c 6824595: OpenJDK fix breaks product build for jdk7 Reviewed-by: xdono, ohair ! make/Makefile From xiomara.jayasena at sun.com Wed Apr 1 16:05:26 2009 From: xiomara.jayasena at sun.com (xiomara.jayasena at sun.com) Date: Wed, 01 Apr 2009 16:05:26 +0000 Subject: hg: jdk7/build: 2 new changesets Message-ID: <20090401160526.417ADEE43@hg.openjdk.java.net> Changeset: 4264c2fe6649 Author: xdono Date: 2009-03-19 13:25 -0700 URL: http://hg.openjdk.java.net/jdk7/build/rev/4264c2fe6649 Added tag jdk7-b51 for changeset 0f0189d55ce4 ! .hgtags Changeset: c235f4a8559d Author: xdono Date: 2009-03-27 14:11 -0700 URL: http://hg.openjdk.java.net/jdk7/build/rev/c235f4a8559d Added tag jdk7-b52 for changeset 4264c2fe6649 ! .hgtags From aph at redhat.com Wed Apr 1 16:08:27 2009 From: aph at redhat.com (Andrew Haley) Date: Wed, 01 Apr 2009 17:08:27 +0100 Subject: New project: getting rid of IcedTea local patches Message-ID: <49D3917B.2010907@redhat.com> We at Red Hat have noticed that the list of IcedTea local patches has been getting large, with some local patches that should have been pushed upstream. Also, some IcedTea patches have been committed to OpenJDK 7 but not OpenJDK 6. So, we're going to have a serious attempt to minimize the number of IcedTea patches. We'll create a Wiki page at icedtea.classpath.org that is a list of the patches, and for every one we're going to discuss whether it should stay IcedTea local, be pushed upstream to OpenJDK, or be deleted altogether. Then we will create OpenJDK bugzilla entries for the patches that we think should be integrated upstream and work with Sun engineers to get that done. I hope that it will be possible to reduce the number of patches to a fraction of what we have at the moment, while improving the quality of the upstream product. This is going to be quite a lot of work, so we'd appreciate help from anyone. I hope this will meet with everyone's approval. Andrew. From xiomara.jayasena at sun.com Wed Apr 1 16:08:41 2009 From: xiomara.jayasena at sun.com (xiomara.jayasena at sun.com) Date: Wed, 01 Apr 2009 16:08:41 +0000 Subject: hg: jdk7/build/corba: 5 new changesets Message-ID: <20090401160845.DB024EE48@hg.openjdk.java.net> Changeset: bec82237d694 Author: xdono Date: 2009-03-19 13:25 -0700 URL: http://hg.openjdk.java.net/jdk7/build/corba/rev/bec82237d694 Added tag jdk7-b51 for changeset 3eb8f1047a74 ! .hgtags Changeset: 126389a38e7d Author: tbell Date: 2009-03-23 17:43 -0700 URL: http://hg.openjdk.java.net/jdk7/build/corba/rev/126389a38e7d 6695776: corba jscheme jar files in repository could be built from source Summary: Forward port of changes from the 6-open train. Reviewed-by: darcy, ohair, tbell Contributed-by: Andrew John Hughes ! make/com/sun/corba/se/sources/Makefile ! make/sun/rmi/corbalogsources/Makefile ! make/tools/Makefile + make/tools/logutil/Makefile ! src/share/classes/com/sun/tools/corba/se/logutil/IndentingPrintWriter.java + src/share/classes/com/sun/tools/corba/se/logutil/Input.java + src/share/classes/com/sun/tools/corba/se/logutil/InputCode.java + src/share/classes/com/sun/tools/corba/se/logutil/InputException.java + src/share/classes/com/sun/tools/corba/se/logutil/MC.java - src/share/classes/com/sun/tools/corba/se/logutil/lib/jscheme.jar - src/share/classes/com/sun/tools/corba/se/logutil/lib/jschemelogutil.jar - src/share/classes/com/sun/tools/corba/se/logutil/scripts/mc - src/share/classes/com/sun/tools/corba/se/logutil/scripts/mc.scm - src/share/classes/com/sun/tools/corba/se/logutil/scripts/run Changeset: 61116c9789b9 Author: tbell Date: 2009-03-23 17:58 -0700 URL: http://hg.openjdk.java.net/jdk7/build/corba/rev/61116c9789b9 Merge Changeset: 2e02b4137dad Author: xdono Date: 2009-03-27 14:11 -0700 URL: http://hg.openjdk.java.net/jdk7/build/corba/rev/2e02b4137dad Added tag jdk7-b52 for changeset bec82237d694 ! .hgtags Changeset: 3c4d73194f6f Author: xdono Date: 2009-03-31 08:53 -0700 URL: http://hg.openjdk.java.net/jdk7/build/corba/rev/3c4d73194f6f Merge - src/share/classes/com/sun/tools/corba/se/logutil/lib/jscheme.jar - src/share/classes/com/sun/tools/corba/se/logutil/lib/jschemelogutil.jar - src/share/classes/com/sun/tools/corba/se/logutil/scripts/mc - src/share/classes/com/sun/tools/corba/se/logutil/scripts/mc.scm - src/share/classes/com/sun/tools/corba/se/logutil/scripts/run From xiomara.jayasena at sun.com Wed Apr 1 16:14:50 2009 From: xiomara.jayasena at sun.com (xiomara.jayasena at sun.com) Date: Wed, 01 Apr 2009 16:14:50 +0000 Subject: hg: jdk7/build/hotspot: 2 new changesets Message-ID: <20090401161457.671C6EE55@hg.openjdk.java.net> Changeset: 1b1e8f1a4fe8 Author: xdono Date: 2009-03-19 13:25 -0700 URL: http://hg.openjdk.java.net/jdk7/build/hotspot/rev/1b1e8f1a4fe8 Added tag jdk7-b51 for changeset 2581d90c6c9b ! .hgtags Changeset: 6e56a851ccaa Author: xdono Date: 2009-03-27 14:11 -0700 URL: http://hg.openjdk.java.net/jdk7/build/hotspot/rev/6e56a851ccaa Added tag jdk7-b52 for changeset 1b1e8f1a4fe8 ! .hgtags From gnu_andrew at member.fsf.org Wed Apr 1 16:15:01 2009 From: gnu_andrew at member.fsf.org (Andrew John Hughes) Date: Wed, 1 Apr 2009 16:15:01 +0000 Subject: New project: getting rid of IcedTea local patches In-Reply-To: <49D3917B.2010907@redhat.com> References: <49D3917B.2010907@redhat.com> Message-ID: <17c6771e0904010915o7f1355cbv29e75c1e79d4ed2c@mail.gmail.com> 2009/4/1 Andrew Haley : > We at Red Hat have noticed that the list of IcedTea local patches has > been getting large, with some local patches that should have been > pushed upstream. ?Also, some IcedTea patches have been committed to > OpenJDK 7 but not OpenJDK 6. > > So, we're going to have a serious attempt to minimize the number of > IcedTea patches. ?We'll create a Wiki page at icedtea.classpath.org > that is a list of the patches, and for every one we're going to > discuss whether it should stay IcedTea local, be pushed upstream to > OpenJDK, or be deleted altogether. ?Then we will create OpenJDK > bugzilla entries for the patches that we think should be integrated > upstream and work with Sun engineers to get that done. > > I hope that it will be possible to reduce the number of patches to a > fraction of what we have at the moment, while improving the quality of > the upstream product. > > This is going to be quite a lot of work, so we'd appreciate help from > anyone. > > I hope this will meet with everyone's approval. > > Andrew. > Great idea! -- Andrew :-) Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) Support Free Java! Contribute to GNU Classpath and the OpenJDK http://www.gnu.org/software/classpath http://openjdk.java.net PGP Key: 94EFD9D8 (http://subkeys.pgp.net) Fingerprint: F8EF F1EA 401E 2E60 15FA 7927 142C 2591 94EF D9D8 From xiomara.jayasena at sun.com Wed Apr 1 16:21:23 2009 From: xiomara.jayasena at sun.com (xiomara.jayasena at sun.com) Date: Wed, 01 Apr 2009 16:21:23 +0000 Subject: hg: jdk7/build/jaxp: 3 new changesets Message-ID: <20090401162128.BAA24EE5A@hg.openjdk.java.net> Changeset: 69ad87dc25cb Author: xdono Date: 2009-03-19 13:25 -0700 URL: http://hg.openjdk.java.net/jdk7/build/jaxp/rev/69ad87dc25cb Added tag jdk7-b51 for changeset ae890d80d5df ! .hgtags Changeset: 30e3f9614f07 Author: xdono Date: 2009-03-27 14:11 -0700 URL: http://hg.openjdk.java.net/jdk7/build/jaxp/rev/30e3f9614f07 Added tag jdk7-b52 for changeset 69ad87dc25cb ! .hgtags Changeset: e8837366d3fd Author: xdono Date: 2009-04-01 08:58 -0700 URL: http://hg.openjdk.java.net/jdk7/build/jaxp/rev/e8837366d3fd Merge From xiomara.jayasena at sun.com Wed Apr 1 16:24:48 2009 From: xiomara.jayasena at sun.com (xiomara.jayasena at sun.com) Date: Wed, 01 Apr 2009 16:24:48 +0000 Subject: hg: jdk7/build/jaxws: 3 new changesets Message-ID: <20090401162453.0E387EE5F@hg.openjdk.java.net> Changeset: e646890d18b7 Author: xdono Date: 2009-03-19 13:25 -0700 URL: http://hg.openjdk.java.net/jdk7/build/jaxws/rev/e646890d18b7 Added tag jdk7-b51 for changeset 41a66a42791b ! .hgtags Changeset: 2c10f0cbb34e Author: xdono Date: 2009-03-27 14:11 -0700 URL: http://hg.openjdk.java.net/jdk7/build/jaxws/rev/2c10f0cbb34e Added tag jdk7-b52 for changeset e646890d18b7 ! .hgtags Changeset: b250218eb2e5 Author: xdono Date: 2009-04-01 08:58 -0700 URL: http://hg.openjdk.java.net/jdk7/build/jaxws/rev/b250218eb2e5 Merge From xiomara.jayasena at sun.com Wed Apr 1 16:29:08 2009 From: xiomara.jayasena at sun.com (xiomara.jayasena at sun.com) Date: Wed, 01 Apr 2009 16:29:08 +0000 Subject: hg: jdk7/build/jdk: 25 new changesets Message-ID: <20090401163417.66AA7EE64@hg.openjdk.java.net> Changeset: bcbeadb4a5d7 Author: xdono Date: 2009-03-19 13:25 -0700 URL: http://hg.openjdk.java.net/jdk7/build/jdk/rev/bcbeadb4a5d7 Added tag jdk7-b51 for changeset fea0898259ae ! .hgtags Changeset: e1064300e0f6 Author: mchung Date: 2009-03-12 10:27 -0700 URL: http://hg.openjdk.java.net/jdk7/build/jdk/rev/e1064300e0f6 6810254: Lazily instantiate the shared secret access objects Summary: Register the shutdown hooks only when needed and remove JavaIODeleteOnExitAccess Reviewed-by: alanb ! make/java/java/FILES_java.gmk ! src/share/classes/java/io/Console.java ! src/share/classes/java/io/DeleteOnExitHook.java ! src/share/classes/java/io/File.java ! src/share/classes/java/lang/ApplicationShutdownHooks.java ! src/share/classes/java/lang/Shutdown.java ! src/share/classes/java/lang/System.java ! src/share/classes/sun/misc/JavaIOAccess.java - src/share/classes/sun/misc/JavaIODeleteOnExitAccess.java ! src/share/classes/sun/misc/JavaLangAccess.java ! src/share/classes/sun/misc/SharedSecrets.java Changeset: fdb1567ea28c Author: mchung Date: 2009-03-12 10:32 -0700 URL: http://hg.openjdk.java.net/jdk7/build/jdk/rev/fdb1567ea28c 6813240: Remove dead code in sun.misc.FormattedFloatingDecimal class Summary: Remove unused methods from FormattedFloatingDecimal that were originally copied from FloatingDecimal Reviewed-by: darcy ! src/share/classes/sun/misc/FormattedFloatingDecimal.java Changeset: 9d5cce463fa0 Author: weijun Date: 2009-03-13 09:20 +0800 URL: http://hg.openjdk.java.net/jdk7/build/jdk/rev/9d5cce463fa0 6815182: GSSAPI/SPNEGO does not work with server using MIT Kerberos library Reviewed-by: valeriep ! src/share/classes/sun/security/jgss/spnego/NegTokenInit.java ! src/share/classes/sun/security/jgss/spnego/SpNegoContext.java + test/sun/security/krb5/auto/SpnegoReqFlags.java Changeset: ef3eba839fb7 Author: weijun Date: 2009-03-13 09:21 +0800 URL: http://hg.openjdk.java.net/jdk7/build/jdk/rev/ef3eba839fb7 6550221: jaas, jgss and smartcardio javadoc files do not contain Copyrights Reviewed-by: ohair ! make/docs/Makefile Changeset: f381e737916d Author: xuelei Date: 2009-03-13 12:59 +0800 URL: http://hg.openjdk.java.net/jdk7/build/jdk/rev/f381e737916d 6798714: OCSPResponse class has to check the validity of signing certificate for OCSP response Summary: checking validity and ocsp-nocheck extension. Reviewed-by: mullan, vinnie ! src/share/classes/sun/security/provider/certpath/OCSPResponse.java + src/share/classes/sun/security/x509/OCSPNoCheckExtension.java ! src/share/classes/sun/security/x509/OIDMap.java ! src/share/classes/sun/security/x509/PKIXExtensions.java Changeset: c2ca4a97ba86 Author: tbell Date: 2009-03-13 15:26 -0700 URL: http://hg.openjdk.java.net/jdk7/build/jdk/rev/c2ca4a97ba86 Merge - src/share/classes/sun/misc/JavaIODeleteOnExitAccess.java Changeset: 181472dbbebb Author: xuelei Date: 2009-03-17 11:54 +0800 URL: http://hg.openjdk.java.net/jdk7/build/jdk/rev/181472dbbebb 6383095: CRL revoked certificate failures masked by OCSP failures Summary: remove the mask if certificate revoked Reviewed-by: mullan ! src/share/classes/sun/security/provider/certpath/PKIXMasterCertPathValidator.java + test/java/security/cert/CertPathValidator/OCSP/FailoverToCRL.java Changeset: 171dc1779708 Author: tbell Date: 2009-03-17 13:20 -0700 URL: http://hg.openjdk.java.net/jdk7/build/jdk/rev/171dc1779708 6814587: Legal notice repair needed in jdk/src/share/classes/java/nio 6814590: Legal notice repair needed in jdk/test/java/awt/Frame/FrameSize/TestFrameSize.java 6814591: Legal notice repair needed in jdk/test/javax/script/Test3.java Reviewed-by: alanb, xdono ! src/share/classes/java/nio/file/SecureDirectoryStream.java ! src/solaris/classes/sun/nio/ch/UnixAsynchronousSocketChannelImpl.java ! src/windows/classes/sun/nio/ch/WindowsAsynchronousSocketChannelImpl.java ! test/java/awt/Frame/FrameSize/TestFrameSize.java ! test/javax/script/Test3.java Changeset: fa87de6b1ac3 Author: dfuchs Date: 2009-03-12 15:36 +0100 URL: http://hg.openjdk.java.net/jdk7/build/jdk/rev/fa87de6b1ac3 6661448: Make the SNMP agent optional when OPENJDK=true and IMPORT_BINARY_PLUGS=false Reviewed-by: mchung, ohair ! make/com/sun/jmx/Makefile ! make/java/management/Makefile ! make/javax/management/Makefile ! make/sun/management/Makefile ! src/share/classes/sun/management/Agent.java ! test/com/sun/jmx/snmp/SnmpOidHashCode.java ! test/com/sun/jmx/snmp/TimeTicksWrapping.java Changeset: e90ce2ac06a8 Author: dfuchs Date: 2009-03-13 14:25 +0100 URL: http://hg.openjdk.java.net/jdk7/build/jdk/rev/e90ce2ac06a8 Merge - src/share/classes/sun/misc/JavaIODeleteOnExitAccess.java Changeset: ef27484bbd7f Author: dfuchs Date: 2009-03-18 18:55 +0100 URL: http://hg.openjdk.java.net/jdk7/build/jdk/rev/ef27484bbd7f Merge Changeset: 392cd358db5d Author: mchung Date: 2009-03-18 17:37 -0700 URL: http://hg.openjdk.java.net/jdk7/build/jdk/rev/392cd358db5d 6817246: Redundant call to set InetAddressCachePolicy to FOREVER if not set during initialization Summary: Remove InetAddressCachePolicy.setIfNotSet call from System.setSecurityManager0 Reviewed-by: alanb, jccollet ! src/share/classes/java/lang/System.java Changeset: 87acd36bd847 Author: weijun Date: 2009-03-19 11:17 +0800 URL: http://hg.openjdk.java.net/jdk7/build/jdk/rev/87acd36bd847 6819272: keytool -importcert should read the whole input Reviewed-by: xuelei ! src/share/classes/sun/security/tools/KeyTool.java + test/sun/security/tools/keytool/importreadall.sh Changeset: 3b6d7e15ccd9 Author: sherman Date: 2009-03-20 16:22 -0700 URL: http://hg.openjdk.java.net/jdk7/build/jdk/rev/3b6d7e15ccd9 6817475: named-capturing group name started with digit causes PSE exception Summary: Need accept the digit as the first char of the group name Reviewed-by: alanb ! src/share/classes/java/util/regex/Pattern.java ! test/java/util/regex/RegExTest.java Changeset: c6b37e92e387 Author: sherman Date: 2009-03-20 17:40 -0700 URL: http://hg.openjdk.java.net/jdk7/build/jdk/rev/c6b37e92e387 Merge ! src/share/classes/java/util/regex/Pattern.java - src/share/classes/sun/misc/JavaIODeleteOnExitAccess.java Changeset: cc8ffb0fc1a4 Author: tbell Date: 2009-03-21 13:52 -0700 URL: http://hg.openjdk.java.net/jdk7/build/jdk/rev/cc8ffb0fc1a4 Merge - src/share/classes/sun/misc/JavaIODeleteOnExitAccess.java Changeset: 74fe20f0e49b Author: weijun Date: 2009-03-23 17:05 +0800 URL: http://hg.openjdk.java.net/jdk7/build/jdk/rev/74fe20f0e49b 6820606: keytool can generate serialno more randomly Reviewed-by: xuelei ! src/share/classes/sun/security/tools/KeyTool.java ! src/share/classes/sun/security/x509/CertAndKeyGen.java Changeset: 4faf788c4949 Author: sherman Date: 2009-03-23 09:19 -0700 URL: http://hg.openjdk.java.net/jdk7/build/jdk/rev/4faf788c4949 6636323: Optimize handling of builtin charsets 6636319: Encoders should implement isLegalReplacement(byte[] repl) Summary: optimized new String(byte[], cs/csn) and String.getBytes(cs/csn) for speed and memory consumption in singlebyte case. Reviewed-by: alanb ! make/java/nio/FILES_java.gmk ! src/share/classes/java/lang/StringCoding.java + src/share/classes/sun/nio/cs/ArrayDecoder.java + src/share/classes/sun/nio/cs/ArrayEncoder.java ! src/share/classes/sun/nio/cs/ISO_8859_1.java ! src/share/classes/sun/nio/cs/SingleByte.java ! src/share/classes/sun/nio/cs/US_ASCII.java ! test/sun/nio/cs/FindEncoderBugs.java + test/sun/nio/cs/StrCodingBenchmark.java + test/sun/nio/cs/TestStringCoding.java Changeset: b9cc5da6c516 Author: sherman Date: 2009-03-23 09:34 -0700 URL: http://hg.openjdk.java.net/jdk7/build/jdk/rev/b9cc5da6c516 Merge Changeset: 13cd6eb34cfa Author: tbell Date: 2009-03-23 17:43 -0700 URL: http://hg.openjdk.java.net/jdk7/build/jdk/rev/13cd6eb34cfa 6695776: corba jscheme jar files in repository could be built from source Summary: Forward port of changes from the 6-open train. Reviewed-by: darcy, ohair, tbell Contributed-by: Andrew John Hughes ! THIRD_PARTY_README Changeset: 8306f3df15ff Author: tbell Date: 2009-03-23 17:57 -0700 URL: http://hg.openjdk.java.net/jdk7/build/jdk/rev/8306f3df15ff Merge - make/common/shared/Compiler.gmk Changeset: 3501cc282cd2 Author: xdono Date: 2009-03-27 14:11 -0700 URL: http://hg.openjdk.java.net/jdk7/build/jdk/rev/3501cc282cd2 Added tag jdk7-b52 for changeset bcbeadb4a5d7 ! .hgtags Changeset: 1bbbd1bf9be3 Author: xdono Date: 2009-03-31 08:53 -0700 URL: http://hg.openjdk.java.net/jdk7/build/jdk/rev/1bbbd1bf9be3 Merge - src/share/classes/sun/misc/JavaIODeleteOnExitAccess.java Changeset: deced414c8e4 Author: xdono Date: 2009-04-01 08:58 -0700 URL: http://hg.openjdk.java.net/jdk7/build/jdk/rev/deced414c8e4 Merge - src/share/classes/sun/misc/JavaIODeleteOnExitAccess.java From xiomara.jayasena at sun.com Wed Apr 1 16:45:01 2009 From: xiomara.jayasena at sun.com (xiomara.jayasena at sun.com) Date: Wed, 01 Apr 2009 16:45:01 +0000 Subject: hg: jdk7/build/langtools: 8 new changesets Message-ID: <20090401164515.93737EE69@hg.openjdk.java.net> Changeset: 29329051d483 Author: xdono Date: 2009-03-19 13:25 -0700 URL: http://hg.openjdk.java.net/jdk7/build/langtools/rev/29329051d483 Added tag jdk7-b51 for changeset 8c55d5b0ed71 ! .hgtags Changeset: 889ec3ddc91b Author: tbell Date: 2009-03-17 11:28 -0700 URL: http://hg.openjdk.java.net/jdk7/build/langtools/rev/889ec3ddc91b 6814592: Legal notice repair needed in langtools/test/tools/javap/T4884240.java Reviewed-by: jjg ! test/tools/javap/T4884240.java Changeset: edd944553131 Author: bpatel Date: 2009-03-19 19:00 -0700 URL: http://hg.openjdk.java.net/jdk7/build/langtools/rev/edd944553131 6786688: Javadoc HTML WCAG 2.0 accessibility issues in standard doclet - Table must have captions and headers Reviewed-by: jjg ! src/share/classes/com/sun/tools/doclets/formats/html/AbstractMemberWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/AbstractPackageIndexWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/AnnotationTypeOptionalMemberWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/AnnotationTypeRequiredMemberWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/ClassUseWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/ConstantsSummaryWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/ConstructorWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/DeprecatedListWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/EnumConstantWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/FieldWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlDocletWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/MethodWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/NestedClassWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/PackageIndexFrameWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/PackageIndexWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/PackageUseWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/PackageWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/StylesheetWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/SubWriterHolderWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/resources/standard.properties ! src/share/classes/com/sun/tools/doclets/internal/toolkit/PackageSummaryWriter.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/PackageSummaryBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/resources/doclets.properties ! test/com/sun/javadoc/testHeadings/TestHeadings.java ! test/com/sun/javadoc/testHtmlStrongTag/TestHtmlStrongTag.java + test/com/sun/javadoc/testHtmlTableTags/TestHtmlTableTags.java + test/com/sun/javadoc/testHtmlTableTags/pkg1/C1.java + test/com/sun/javadoc/testHtmlTableTags/pkg1/I1.java + test/com/sun/javadoc/testHtmlTableTags/pkg1/package-info.java + test/com/sun/javadoc/testHtmlTableTags/pkg2/C2.java + test/com/sun/javadoc/testHtmlTableTags/pkg2/C3.java + test/com/sun/javadoc/testHtmlTableTags/pkg2/C4.java + test/com/sun/javadoc/testHtmlTableTags/pkg2/package-info.java ! test/com/sun/javadoc/testNewLanguageFeatures/TestNewLanguageFeatures.java ! test/com/sun/javadoc/testSummaryHeading/TestSummaryHeading.java Changeset: b000f7c728ae Author: bpatel Date: 2009-03-20 15:50 -0700 URL: http://hg.openjdk.java.net/jdk7/build/langtools/rev/b000f7c728ae 6820360: Fix for definition list tags nesting adds an extra list tag for package summary page. Reviewed-by: jjg ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlDocletWriter.java ! test/com/sun/javadoc/testHtmlDefinitionListTag/TestHtmlDefinitionListTag.java + test/com/sun/javadoc/testHtmlDefinitionListTag/pkg1/package-info.java Changeset: 3bf905cb80e7 Author: tbell Date: 2009-03-21 13:53 -0700 URL: http://hg.openjdk.java.net/jdk7/build/langtools/rev/3bf905cb80e7 Merge Changeset: 1ec9ff434ce2 Author: xdono Date: 2009-03-27 14:11 -0700 URL: http://hg.openjdk.java.net/jdk7/build/langtools/rev/1ec9ff434ce2 Added tag jdk7-b52 for changeset 29329051d483 ! .hgtags Changeset: 72c2df1a2b5a Author: xdono Date: 2009-03-31 08:54 -0700 URL: http://hg.openjdk.java.net/jdk7/build/langtools/rev/72c2df1a2b5a Merge Changeset: dbdeb4a7581b Author: xdono Date: 2009-04-01 08:58 -0700 URL: http://hg.openjdk.java.net/jdk7/build/langtools/rev/dbdeb4a7581b Merge From Kelly.Ohair at Sun.COM Wed Apr 1 17:02:14 2009 From: Kelly.Ohair at Sun.COM (Kelly O'Hair) Date: Wed, 01 Apr 2009 10:02:14 -0700 Subject: OpenJDK6: Bug in genlocales.gmk In-Reply-To: <49D32142.8030608@jondos.de> References: <49D32142.8030608@jondos.de> Message-ID: <49D39E16.6000703@sun.com> I'll get it. Can someone in the OpenJDK commit list (http://db.openjdk.java.net/people) review this minor change for jdk6: diff --git a/make/java/java/genlocales.gmk b/make/java/java/genlocales.gmk --- a/make/java/java/genlocales.gmk +++ b/make/java/java/genlocales.gmk @@ -80,7 +80,7 @@ RESOURCE_NAMES="FormatData CollationData @$(ECHO) $(subst .java,'\n',$(Euro_Resources_java)) >> $@.tmp.euro; @$(ECHO) $(subst .properties,'\n',$(NonEuro_Resources_properties)) > $@.tmp.noneuro; @$(ECHO) $(subst .java,'\n',$(NonEuro_Resources_java)) >> $@.tmp.noneuro; - NAWK=$(NAWK) SED=$(SED) $(SH) $(LOCALEGEN_SH) $(RESOURCE_NAMES) $@.tmp.euro \ + NAWK="$(NAWK)" SED="$(SED)" $(SH) $(LOCALEGEN_SH) $(RESOURCE_NAMES) $@.tmp.euro \ $@.tmp.noneuro $< $@ @$(RM) $@.tmp.euro $@.tmp.noneuro; -kto Georg Koppen wrote: > Hi, > > some days ago I dwonloaded the OpenJDK6 sources from > http://download.java.net/openjdk/jdk6/ and tried to compile it on my > Windows XP. Well, I succeeded finally but I found a bug in > ~/jdk/make/java/java/genlocales.gmk. There "NAWK=$(NAWK)" should be > changed to "NAWK="$(NAWK)"". Otherwise I get an error during compiling > like "/bin/sh -v command not found". > I don't know whether this problem still exists (didn't try mercurial) > and I found no comment about it on the mailing list. If that's the case > just ignore the mail and sorry for bothering you. But if not it would be > nice if the one in charge for this part of the code corrects it, > although it's not a major thing. > > Georg > From Joe.Darcy at Sun.COM Wed Apr 1 17:26:27 2009 From: Joe.Darcy at Sun.COM (Joseph D. Darcy) Date: Wed, 01 Apr 2009 10:26:27 -0700 Subject: New project: getting rid of IcedTea local patches In-Reply-To: <49D3917B.2010907@redhat.com> References: <49D3917B.2010907@redhat.com> Message-ID: <49D3A3C3.9090104@sun.com> Andrew Haley wrote: > We at Red Hat have noticed that the list of IcedTea local patches has > been getting large, with some local patches that should have been > pushed upstream. Also, some IcedTea patches have been committed to > OpenJDK 7 but not OpenJDK 6. > > So, we're going to have a serious attempt to minimize the number of > IcedTea patches. We'll create a Wiki page at icedtea.classpath.org > that is a list of the patches, and for every one we're going to > discuss whether it should stay IcedTea local, be pushed upstream to > OpenJDK, or be deleted altogether. Then we will create OpenJDK > bugzilla entries for the patches that we think should be integrated > upstream and work with Sun engineers to get that done. > > I hope that it will be possible to reduce the number of patches to a > fraction of what we have at the moment, while improving the quality of > the upstream product. > > This is going to be quite a lot of work, so we'd appreciate help from > anyone. > > I hope this will meet with everyone's approval. > Sounds good to me! -Joe From Joe.Darcy at Sun.COM Wed Apr 1 17:28:53 2009 From: Joe.Darcy at Sun.COM (Joseph D. Darcy) Date: Wed, 01 Apr 2009 10:28:53 -0700 Subject: OpenJDK6: Bug in genlocales.gmk In-Reply-To: <49D39E16.6000703@sun.com> References: <49D32142.8030608@jondos.de> <49D39E16.6000703@sun.com> Message-ID: <49D3A455.7030703@sun.com> Kelly O'Hair wrote: > I'll get it. > > Can someone in the OpenJDK commit list > (http://db.openjdk.java.net/people) > review this minor change for jdk6: Approved. -Joe > > diff --git a/make/java/java/genlocales.gmk > b/make/java/java/genlocales.gmk > --- a/make/java/java/genlocales.gmk > +++ b/make/java/java/genlocales.gmk > @@ -80,7 +80,7 @@ RESOURCE_NAMES="FormatData CollationData > @$(ECHO) $(subst .java,'\n',$(Euro_Resources_java)) >> > $@.tmp.euro; > @$(ECHO) $(subst > .properties,'\n',$(NonEuro_Resources_properties)) > $@.tmp.noneuro; > @$(ECHO) $(subst .java,'\n',$(NonEuro_Resources_java)) >> > $@.tmp.noneuro; > - NAWK=$(NAWK) SED=$(SED) $(SH) $(LOCALEGEN_SH) > $(RESOURCE_NAMES) $@.tmp.euro \ > + NAWK="$(NAWK)" SED="$(SED)" $(SH) $(LOCALEGEN_SH) > $(RESOURCE_NAMES) $@.tmp.euro \ > $@.tmp.noneuro $< $@ > @$(RM) $@.tmp.euro $@.tmp.noneuro; > > > -kto > > > Georg Koppen wrote: >> Hi, >> >> some days ago I dwonloaded the OpenJDK6 sources from >> http://download.java.net/openjdk/jdk6/ and tried to compile it on my >> Windows XP. Well, I succeeded finally but I found a bug in >> ~/jdk/make/java/java/genlocales.gmk. There "NAWK=$(NAWK)" should be >> changed to "NAWK="$(NAWK)"". Otherwise I get an error during compiling >> like "/bin/sh -v command not found". >> I don't know whether this problem still exists (didn't try mercurial) >> and I found no comment about it on the mailing list. If that's the case >> just ignore the mail and sorry for bothering you. But if not it would be >> nice if the one in charge for this part of the code corrects it, >> although it's not a major thing. >> >> Georg >> From Kelly.Ohair at Sun.COM Wed Apr 1 17:47:29 2009 From: Kelly.Ohair at Sun.COM (Kelly O'Hair) Date: Wed, 01 Apr 2009 10:47:29 -0700 Subject: New project: getting rid of IcedTea local patches In-Reply-To: <49D3917B.2010907@redhat.com> References: <49D3917B.2010907@redhat.com> Message-ID: <49D3A8B1.4040201@sun.com> Andrew Haley wrote: > We at Red Hat have noticed that the list of IcedTea local patches has > been getting large, with some local patches that should have been > pushed upstream. Also, some IcedTea patches have been committed to > OpenJDK 7 but not OpenJDK 6. > > So, we're going to have a serious attempt to minimize the number of > IcedTea patches. We'll create a Wiki page at icedtea.classpath.org > that is a list of the patches, and for every one we're going to > discuss whether it should stay IcedTea local, be pushed upstream to > OpenJDK, or be deleted altogether. Then we will create OpenJDK > bugzilla entries for the patches that we think should be integrated > upstream and work with Sun engineers to get that done. > > I hope that it will be possible to reduce the number of patches to a > fraction of what we have at the moment, while improving the quality of > the upstream product. > > This is going to be quite a lot of work, so we'd appreciate help from > anyone. > > I hope this will meet with everyone's approval. > > Andrew. Sounds great. I can certainly help out with any build related (makefiles etc.) changes. -kto From gnu_andrew at member.fsf.org Wed Apr 1 17:55:11 2009 From: gnu_andrew at member.fsf.org (Andrew John Hughes) Date: Wed, 1 Apr 2009 17:55:11 +0000 Subject: New project: getting rid of IcedTea local patches In-Reply-To: <49D3A8B1.4040201@sun.com> References: <49D3917B.2010907@redhat.com> <49D3A8B1.4040201@sun.com> Message-ID: <17c6771e0904011055nfa6a0a5pec140dd568cc63e0@mail.gmail.com> 2009/4/1 Kelly O'Hair : > Andrew Haley wrote: >> >> We at Red Hat have noticed that the list of IcedTea local patches has >> been getting large, with some local patches that should have been >> pushed upstream. ?Also, some IcedTea patches have been committed to >> OpenJDK 7 but not OpenJDK 6. >> >> So, we're going to have a serious attempt to minimize the number of >> IcedTea patches. ?We'll create a Wiki page at icedtea.classpath.org >> that is a list of the patches, and for every one we're going to >> discuss whether it should stay IcedTea local, be pushed upstream to >> OpenJDK, or be deleted altogether. ?Then we will create OpenJDK >> bugzilla entries for the patches that we think should be integrated >> upstream and work with Sun engineers to get that done. >> >> I hope that it will be possible to reduce the number of patches to a >> fraction of what we have at the moment, while improving the quality of >> the upstream product. >> >> This is going to be quite a lot of work, so we'd appreciate help from >> anyone. >> >> I hope this will meet with everyone's approval. >> >> Andrew. > > Sounds great. > > I can certainly help out with any build related (makefiles etc.) > changes. > > -kto > > Good, because to my knowledge, those form the majority :) However, my guess would also be that some require extensive reworking to be generally acceptable (e.g. providing the option to build using system libraries rather than forcing it). -- Andrew :-) Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) Support Free Java! Contribute to GNU Classpath and the OpenJDK http://www.gnu.org/software/classpath http://openjdk.java.net PGP Key: 94EFD9D8 (http://subkeys.pgp.net) Fingerprint: F8EF F1EA 401E 2E60 15FA 7927 142C 2591 94EF D9D8 From aph at redhat.com Wed Apr 1 17:58:09 2009 From: aph at redhat.com (Andrew Haley) Date: Wed, 01 Apr 2009 18:58:09 +0100 Subject: New project: getting rid of IcedTea local patches In-Reply-To: <17c6771e0904011055nfa6a0a5pec140dd568cc63e0@mail.gmail.com> References: <49D3917B.2010907@redhat.com> <49D3A8B1.4040201@sun.com> <17c6771e0904011055nfa6a0a5pec140dd568cc63e0@mail.gmail.com> Message-ID: <49D3AB31.200@redhat.com> Andrew John Hughes wrote: > 2009/4/1 Kelly O'Hair : >> >> I can certainly help out with any build related (makefiles etc.) >> changes. > > Good, because to my knowledge, those form the majority :) > However, my guess would also be that some require extensive reworking > to be generally acceptable (e.g. providing the option to build using > system libraries rather than forcing it). Those *may* be exactly the kind of patches we want to keep in IcedTea. We'll have to see. Andrew. From gnu_andrew at member.fsf.org Wed Apr 1 18:03:24 2009 From: gnu_andrew at member.fsf.org (Andrew John Hughes) Date: Wed, 1 Apr 2009 18:03:24 +0000 Subject: New project: getting rid of IcedTea local patches In-Reply-To: <17c6771e0904011055nfa6a0a5pec140dd568cc63e0@mail.gmail.com> References: <49D3917B.2010907@redhat.com> <49D3A8B1.4040201@sun.com> <17c6771e0904011055nfa6a0a5pec140dd568cc63e0@mail.gmail.com> Message-ID: <17c6771e0904011103j78adad05h59960f37ed2c32a2@mail.gmail.com> 2009/4/1 Andrew John Hughes : > 2009/4/1 Kelly O'Hair : >> Andrew Haley wrote: >>> >>> We at Red Hat have noticed that the list of IcedTea local patches has >>> been getting large, with some local patches that should have been >>> pushed upstream. ?Also, some IcedTea patches have been committed to >>> OpenJDK 7 but not OpenJDK 6. >>> >>> So, we're going to have a serious attempt to minimize the number of >>> IcedTea patches. ?We'll create a Wiki page at icedtea.classpath.org >>> that is a list of the patches, and for every one we're going to >>> discuss whether it should stay IcedTea local, be pushed upstream to >>> OpenJDK, or be deleted altogether. ?Then we will create OpenJDK >>> bugzilla entries for the patches that we think should be integrated >>> upstream and work with Sun engineers to get that done. >>> >>> I hope that it will be possible to reduce the number of patches to a >>> fraction of what we have at the moment, while improving the quality of >>> the upstream product. >>> >>> This is going to be quite a lot of work, so we'd appreciate help from >>> anyone. >>> >>> I hope this will meet with everyone's approval. >>> >>> Andrew. >> >> Sounds great. >> >> I can certainly help out with any build related (makefiles etc.) >> changes. >> >> -kto >> >> > > Good, because to my knowledge, those form the majority :) > However, my guess would also be that some require extensive reworking > to be generally acceptable (e.g. providing the option to build using > system libraries rather than forcing it). > -- > Andrew :-) > > Free Java Software Engineer > Red Hat, Inc. (http://www.redhat.com) > > Support Free Java! > Contribute to GNU Classpath and the OpenJDK > http://www.gnu.org/software/classpath > http://openjdk.java.net > > PGP Key: 94EFD9D8 (http://subkeys.pgp.net) > Fingerprint: F8EF F1EA 401E 2E60 15FA ?7927 142C 2591 94EF D9D8 > On the other hand, there is some low-hanging fruit. Andrew Haley reminded me of this patch earlier today: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6781583 which went into OpenJDK7. The patch itself should be trivial to approve, given it has already been through the process once. The main issue is that it relies on OpenJDK6 being updated to hs14. Is there any news on this and of the public stable branch of this version? As to committing, do those on the OpenJDK commit list have access to all repositories (given patch approval obviously) or is it restricted in some way? As myself, Gary and Andrew Haley all are now on this list, it would be good to start the process of committing patches ourself once approved. Thanks, -- Andrew :-) Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) Support Free Java! Contribute to GNU Classpath and the OpenJDK http://www.gnu.org/software/classpath http://openjdk.java.net PGP Key: 94EFD9D8 (http://subkeys.pgp.net) Fingerprint: F8EF F1EA 401E 2E60 15FA 7927 142C 2591 94EF D9D8 From gnu_andrew at member.fsf.org Wed Apr 1 18:04:21 2009 From: gnu_andrew at member.fsf.org (Andrew John Hughes) Date: Wed, 1 Apr 2009 18:04:21 +0000 Subject: New project: getting rid of IcedTea local patches In-Reply-To: <49D3AB31.200@redhat.com> References: <49D3917B.2010907@redhat.com> <49D3A8B1.4040201@sun.com> <17c6771e0904011055nfa6a0a5pec140dd568cc63e0@mail.gmail.com> <49D3AB31.200@redhat.com> Message-ID: <17c6771e0904011104r392f02b0lac2d1be680ba7f8a@mail.gmail.com> 2009/4/1 Andrew Haley : > Andrew John Hughes wrote: >> 2009/4/1 Kelly O'Hair : >>> >>> I can certainly help out with any build related (makefiles etc.) >>> changes. >> >> Good, because to my knowledge, those form the majority :) >> However, my guess would also be that some require extensive reworking >> to be generally acceptable (e.g. providing the option to build using >> system libraries rather than forcing it). > > Those *may* be exactly the kind of patches we want to keep in IcedTea. > We'll have to see. > > Andrew. > > Yes, maybe I'm being a bit excessive/over-enthusiastic in wanting to get everything upstream... :) -- Andrew :-) Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) Support Free Java! Contribute to GNU Classpath and the OpenJDK http://www.gnu.org/software/classpath http://openjdk.java.net PGP Key: 94EFD9D8 (http://subkeys.pgp.net) Fingerprint: F8EF F1EA 401E 2E60 15FA 7927 142C 2591 94EF D9D8 From Christian.Thalinger at Sun.COM Wed Apr 1 18:05:53 2009 From: Christian.Thalinger at Sun.COM (Christian Thalinger) Date: Wed, 01 Apr 2009 11:05:53 -0700 Subject: New project: getting rid of IcedTea local patches In-Reply-To: <49D3A8B1.4040201@sun.com> References: <49D3917B.2010907@redhat.com> <49D3A8B1.4040201@sun.com> Message-ID: <1238609153.4495.31.camel@localhost.localdomain> On Wed, 2009-04-01 at 10:47 -0700, Kelly O'Hair wrote: > I can certainly help out with any build related (makefiles etc.) > changes. Ohh, that reminds me of this one: https://bugs.openjdk.java.net/show_bug.cgi?id=100011 Because one change touches a jdk Makefile, I didn't push yet. Either someone from the jdk team approves the change and I push it through the hotspot-comp gate or the changes go in as two different changesets. -- Christian From Kelly.Ohair at Sun.COM Wed Apr 1 18:33:40 2009 From: Kelly.Ohair at Sun.COM (Kelly O'Hair) Date: Wed, 01 Apr 2009 11:33:40 -0700 Subject: New project: getting rid of IcedTea local patches In-Reply-To: <1238609153.4495.31.camel@localhost.localdomain> References: <49D3917B.2010907@redhat.com> <49D3A8B1.4040201@sun.com> <1238609153.4495.31.camel@localhost.localdomain> Message-ID: <49D3B384.2010609@sun.com> Christian Thalinger wrote: > On Wed, 2009-04-01 at 10:47 -0700, Kelly O'Hair wrote: >> I can certainly help out with any build related (makefiles etc.) >> changes. > > Ohh, that reminds me of this one: > > https://bugs.openjdk.java.net/show_bug.cgi?id=100011 > > Because one change touches a jdk Makefile, I didn't push yet. Either > someone from the jdk team approves the change and I push it through the > hotspot-comp gate or the changes go in as two different changesets. > > -- Christian > The changes to the jdk files look fine. One question though, does the name "CORE_BUILD" have a meaning to the JDK, or just the VM? Just wondering if a "VM_CORE_BUILD" or "HOTSPOT_CORE_BUILD" might be a better name. Not a big deal. (At some point we should probably be documenting the make variables that form the build interface, or the ones we need to preserve in terms of spelling and meaning. A daunting task I know. :^{ ) If you have changesets I can send them through the jdk7/build forest, with the appropriate jdk test builds (the changes look independent, so should be fine) or you can send them through the hotspot-comp forest. Although you should make sure the hotspot integrators are aware that you have made changes to non-hotspot repositories, just to make sure they don't forget to do a full forest push. -kto From Kelly.Ohair at Sun.COM Wed Apr 1 18:36:06 2009 From: Kelly.Ohair at Sun.COM (Kelly O'Hair) Date: Wed, 01 Apr 2009 11:36:06 -0700 Subject: New project: getting rid of IcedTea local patches In-Reply-To: <17c6771e0904011103j78adad05h59960f37ed2c32a2@mail.gmail.com> References: <49D3917B.2010907@redhat.com> <49D3A8B1.4040201@sun.com> <17c6771e0904011055nfa6a0a5pec140dd568cc63e0@mail.gmail.com> <17c6771e0904011103j78adad05h59960f37ed2c32a2@mail.gmail.com> Message-ID: <49D3B416.4020907@sun.com> Andrew John Hughes wrote: > 2009/4/1 Andrew John Hughes : >> 2009/4/1 Kelly O'Hair : >>> Andrew Haley wrote: >>>> We at Red Hat have noticed that the list of IcedTea local patches has >>>> been getting large, with some local patches that should have been >>>> pushed upstream. Also, some IcedTea patches have been committed to >>>> OpenJDK 7 but not OpenJDK 6. >>>> >>>> So, we're going to have a serious attempt to minimize the number of >>>> IcedTea patches. We'll create a Wiki page at icedtea.classpath.org >>>> that is a list of the patches, and for every one we're going to >>>> discuss whether it should stay IcedTea local, be pushed upstream to >>>> OpenJDK, or be deleted altogether. Then we will create OpenJDK >>>> bugzilla entries for the patches that we think should be integrated >>>> upstream and work with Sun engineers to get that done. >>>> >>>> I hope that it will be possible to reduce the number of patches to a >>>> fraction of what we have at the moment, while improving the quality of >>>> the upstream product. >>>> >>>> This is going to be quite a lot of work, so we'd appreciate help from >>>> anyone. >>>> >>>> I hope this will meet with everyone's approval. >>>> >>>> Andrew. >>> Sounds great. >>> >>> I can certainly help out with any build related (makefiles etc.) >>> changes. >>> >>> -kto >>> >>> >> Good, because to my knowledge, those form the majority :) >> However, my guess would also be that some require extensive reworking >> to be generally acceptable (e.g. providing the option to build using >> system libraries rather than forcing it). >> -- >> Andrew :-) >> >> Free Java Software Engineer >> Red Hat, Inc. (http://www.redhat.com) >> >> Support Free Java! >> Contribute to GNU Classpath and the OpenJDK >> http://www.gnu.org/software/classpath >> http://openjdk.java.net >> >> PGP Key: 94EFD9D8 (http://subkeys.pgp.net) >> Fingerprint: F8EF F1EA 401E 2E60 15FA 7927 142C 2591 94EF D9D8 >> > > On the other hand, there is some low-hanging fruit. Andrew Haley > reminded me of this patch earlier today: > > http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6781583 > > which went into OpenJDK7. The patch itself should be trivial to > approve, given it has already been through the process once. The main > issue is that it relies on OpenJDK6 being updated to hs14. Is there > any news on this and of the public stable branch of this version? > I made sure there is a '6-open' version of this bug. Not sure what the state of hs14 in OpenJDK6 is, but if hs14 is 'done' we may need to apply this patch to OpenJDK6's hotspot, making it a hs14+ kind of. I'll pass this decision onto Joe. ;^) -kto > As to committing, do those on the OpenJDK commit list have access to > all repositories (given patch approval obviously) or is it restricted > in some way? As myself, Gary and Andrew Haley all are now on this > list, it would be good to start the process of committing patches > ourself once approved. > > Thanks, From Tim.Bell at Sun.COM Wed Apr 1 18:58:02 2009 From: Tim.Bell at Sun.COM (Tim Bell) Date: Wed, 01 Apr 2009 11:58:02 -0700 Subject: OpenJDK6: Bug in genlocales.gmk In-Reply-To: <49D32142.8030608@jondos.de> References: <49D32142.8030608@jondos.de> Message-ID: <49D3B93A.4090107@sun.com> Georg Koppen wrote: > There "NAWK=$(NAWK)" should be > changed to "NAWK="$(NAWK)"". Otherwise I get an error during compiling > like "/bin/sh -v command not found". Kelly - thanks for filing 6824976 "Fix NAWK assignment in shell script jdk/make/java/java/genlocales.gmk" It should be visible in a day or two at http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6824976 That 'command not found' error has always been alarming to see in the build logs. Tim From gnu_andrew at member.fsf.org Wed Apr 1 19:27:18 2009 From: gnu_andrew at member.fsf.org (Andrew John Hughes) Date: Wed, 1 Apr 2009 19:27:18 +0000 Subject: New project: getting rid of IcedTea local patches In-Reply-To: <49D3B416.4020907@sun.com> References: <49D3917B.2010907@redhat.com> <49D3A8B1.4040201@sun.com> <17c6771e0904011055nfa6a0a5pec140dd568cc63e0@mail.gmail.com> <17c6771e0904011103j78adad05h59960f37ed2c32a2@mail.gmail.com> <49D3B416.4020907@sun.com> Message-ID: <17c6771e0904011227v201373cbw6bbc8e218fcb2d19@mail.gmail.com> 2009/4/1 Kelly O'Hair : > > Andrew John Hughes wrote: >> >> 2009/4/1 Andrew John Hughes : >>> >>> 2009/4/1 Kelly O'Hair : >>>> >>>> Andrew Haley wrote: >>>>> >>>>> We at Red Hat have noticed that the list of IcedTea local patches has >>>>> been getting large, with some local patches that should have been >>>>> pushed upstream. ?Also, some IcedTea patches have been committed to >>>>> OpenJDK 7 but not OpenJDK 6. >>>>> >>>>> So, we're going to have a serious attempt to minimize the number of >>>>> IcedTea patches. ?We'll create a Wiki page at icedtea.classpath.org >>>>> that is a list of the patches, and for every one we're going to >>>>> discuss whether it should stay IcedTea local, be pushed upstream to >>>>> OpenJDK, or be deleted altogether. ?Then we will create OpenJDK >>>>> bugzilla entries for the patches that we think should be integrated >>>>> upstream and work with Sun engineers to get that done. >>>>> >>>>> I hope that it will be possible to reduce the number of patches to a >>>>> fraction of what we have at the moment, while improving the quality of >>>>> the upstream product. >>>>> >>>>> This is going to be quite a lot of work, so we'd appreciate help from >>>>> anyone. >>>>> >>>>> I hope this will meet with everyone's approval. >>>>> >>>>> Andrew. >>>> >>>> Sounds great. >>>> >>>> I can certainly help out with any build related (makefiles etc.) >>>> changes. >>>> >>>> -kto >>>> >>>> >>> Good, because to my knowledge, those form the majority :) >>> However, my guess would also be that some require extensive reworking >>> to be generally acceptable (e.g. providing the option to build using >>> system libraries rather than forcing it). >>> -- >>> Andrew :-) >>> >>> Free Java Software Engineer >>> Red Hat, Inc. (http://www.redhat.com) >>> >>> Support Free Java! >>> Contribute to GNU Classpath and the OpenJDK >>> http://www.gnu.org/software/classpath >>> http://openjdk.java.net >>> >>> PGP Key: 94EFD9D8 (http://subkeys.pgp.net) >>> Fingerprint: F8EF F1EA 401E 2E60 15FA ?7927 142C 2591 94EF D9D8 >>> >> >> On the other hand, there is some low-hanging fruit. ?Andrew Haley >> reminded me of this patch earlier today: >> >> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6781583 >> >> which went into OpenJDK7. ?The patch itself should be trivial to >> approve, given it has already been through the process once. ?The main >> issue is that it relies on OpenJDK6 being updated to hs14. ?Is there >> any news on this and of the public stable branch of this version? >> > > I made sure there is a '6-open' version of this bug. > Not sure what the state of hs14 in OpenJDK6 is, but if hs14 is > 'done' we may need to apply this patch to OpenJDK6's hotspot, > making it a hs14+ kind of. > I'll pass this decision onto Joe. ;^) > Thanks. To my knowledge, OpenJDK6 is still on hs11. With IcedTea6 (which builds against OpenJDK6 b14), we do an rm -rf hotspot and download the last hs14 changeset to use instead (fc6a5ae3fef5) from http://hg.openjdk.java.net/jdk7/hotspot/hotspot. We then apply three patches to the newly acquired b14 hotspot which achieve the same as the one attached to that bug report (these were developed independently, two of them sometime before that changeset). > -kto > >> As to committing, do those on the OpenJDK commit list have access to >> all repositories (given patch approval obviously) or is it restricted >> in some way? ?As myself, Gary and Andrew Haley all are now on this >> list, it would be good to start the process of committing patches >> ourself once approved. >> >> Thanks, > -- Andrew :-) Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) Support Free Java! Contribute to GNU Classpath and the OpenJDK http://www.gnu.org/software/classpath http://openjdk.java.net PGP Key: 94EFD9D8 (http://subkeys.pgp.net) Fingerprint: F8EF F1EA 401E 2E60 15FA 7927 142C 2591 94EF D9D8 From kelly.ohair at sun.com Wed Apr 1 23:53:51 2009 From: kelly.ohair at sun.com (kelly.ohair at sun.com) Date: Wed, 01 Apr 2009 23:53:51 +0000 Subject: hg: jdk7/build/jdk: 6825175: Remove or disable sanity check on binary plugs Message-ID: <20090401235433.89E8DEEB9@hg.openjdk.java.net> Changeset: a2033addca67 Author: ohair Date: 2009-04-01 16:49 -0700 URL: http://hg.openjdk.java.net/jdk7/build/jdk/rev/a2033addca67 6825175: Remove or disable sanity check on binary plugs Reviewed-by: xdono ! make/common/shared/Sanity.gmk From Christian.Thalinger at Sun.COM Thu Apr 2 05:07:20 2009 From: Christian.Thalinger at Sun.COM (Christian Thalinger) Date: Thu, 02 Apr 2009 07:07:20 +0200 Subject: New project: getting rid of IcedTea local patches In-Reply-To: <49D3B384.2010609@sun.com> References: <49D3917B.2010907@redhat.com> <49D3A8B1.4040201@sun.com> <1238609153.4495.31.camel@localhost.localdomain> <49D3B384.2010609@sun.com> Message-ID: <1238648840.3168.19.camel@localhost.localdomain> On Wed, 2009-04-01 at 11:33 -0700, Kelly O'Hair wrote: > The changes to the jdk files look fine. > One question though, does the name "CORE_BUILD" have a meaning to the > JDK, or just the VM? Just wondering if a "VM_CORE_BUILD" or > "HOTSPOT_CORE_BUILD" might be a better name. Not a big deal. I don't know, but maybe Gary does... > If you have changesets I can send them through the jdk7/build forest, > with the appropriate jdk test builds (the changes look independent, > so should be fine) or you can send them through the hotspot-comp forest. > Although you should make sure the hotspot integrators > are aware that you have made changes to non-hotspot repositories, just > to make sure they don't forget to do a full forest push. I see. Maybe you should do the push :-) Should I prepare a changeset and send it over to you? -- Christian From Kelly.Ohair at Sun.COM Thu Apr 2 21:25:38 2009 From: Kelly.Ohair at Sun.COM (Kelly O'Hair) Date: Thu, 02 Apr 2009 14:25:38 -0700 Subject: New project: getting rid of IcedTea local patches In-Reply-To: <1238648840.3168.19.camel@localhost.localdomain> References: <49D3917B.2010907@redhat.com> <49D3A8B1.4040201@sun.com> <1238609153.4495.31.camel@localhost.localdomain> <49D3B384.2010609@sun.com> <1238648840.3168.19.camel@localhost.localdomain> Message-ID: <49D52D52.4040100@sun.com> Christian Thalinger wrote: > On Wed, 2009-04-01 at 11:33 -0700, Kelly O'Hair wrote: >> The changes to the jdk files look fine. >> One question though, does the name "CORE_BUILD" have a meaning to the >> JDK, or just the VM? Just wondering if a "VM_CORE_BUILD" or >> "HOTSPOT_CORE_BUILD" might be a better name. Not a big deal. > > I don't know, but maybe Gary does... > >> If you have changesets I can send them through the jdk7/build forest, >> with the appropriate jdk test builds (the changes look independent, >> so should be fine) or you can send them through the hotspot-comp forest. >> Although you should make sure the hotspot integrators >> are aware that you have made changes to non-hotspot repositories, just >> to make sure they don't forget to do a full forest push. > > I see. Maybe you should do the push :-) Should I prepare a changeset > and send it over to you? That would be fine. Or point be at some repository I could pull the changeset from. -kto > > -- Christian > From kelly.ohair at sun.com Fri Apr 3 06:04:21 2009 From: kelly.ohair at sun.com (kelly.ohair at sun.com) Date: Fri, 03 Apr 2009 06:04:21 +0000 Subject: hg: jdk7/build/jdk: 9 new changesets Message-ID: <20090403060728.13CB2E19B@hg.openjdk.java.net> Changeset: 6d74c3f22c74 Author: ohair Date: 2009-03-31 16:10 -0700 URL: http://hg.openjdk.java.net/jdk7/build/jdk/rev/6d74c3f22c74 6604458: linux_x64-fastdebug-c2 fails on hyperbolic trig tests Reviewed-by: tbell ! make/common/Defs-linux.gmk ! make/common/Defs-solaris.gmk ! make/common/Defs-windows.gmk ! make/java/fdlibm/Makefile Changeset: 90d1a828b6d1 Author: ohair Date: 2009-03-31 16:11 -0700 URL: http://hg.openjdk.java.net/jdk7/build/jdk/rev/90d1a828b6d1 6745361: Add -XX options to prevent stdout/stderr pollution using fastdebug/debug bootjdk Reviewed-by: tbell ! make/common/shared/Defs-java.gmk Changeset: 43124654f2aa Author: ohair Date: 2009-03-31 16:12 -0700 URL: http://hg.openjdk.java.net/jdk7/build/jdk/rev/43124654f2aa 6502548: test/Makefile needs to be setup to allow for JPRT testrules (NSK and JCK testing too?) Summary: A work in progress on testing additions for JPRT system. Reviewed-by: tbell ! test/Makefile Changeset: b2530d839ecb Author: ohair Date: 2009-03-31 16:14 -0700 URL: http://hg.openjdk.java.net/jdk7/build/jdk/rev/b2530d839ecb 6824012: Add jdk regression tests to default jprt jobs Summary: A work in progress on adding to the jprt testing. Reviewed-by: tbell ! make/jprt.properties ! test/java/io/File/GetXSpace.java ! test/java/lang/Thread/StartOOMTest.java ! test/java/util/logging/LoggingDeadlock2.java Changeset: 70c53bc9a49d Author: ohair Date: 2009-04-01 09:08 -0700 URL: http://hg.openjdk.java.net/jdk7/build/jdk/rev/70c53bc9a49d 6824583: regtest TimeUnit/Basic.java fails intermittently on Windows - again Reviewed-by: dholmes ! test/java/util/concurrent/TimeUnit/Basic.java Changeset: 817bb60fbc26 Author: ohair Date: 2009-04-01 09:10 -0700 URL: http://hg.openjdk.java.net/jdk7/build/jdk/rev/817bb60fbc26 Merge Changeset: f7ca3dad31a2 Author: ohair Date: 2009-04-01 09:44 -0700 URL: http://hg.openjdk.java.net/jdk7/build/jdk/rev/f7ca3dad31a2 Merge - src/share/classes/sun/misc/JavaIODeleteOnExitAccess.java Changeset: ce73dcf13656 Author: ohair Date: 2009-04-01 18:45 -0700 URL: http://hg.openjdk.java.net/jdk7/build/jdk/rev/ce73dcf13656 Merge Changeset: 78fbc0dad111 Author: ohair Date: 2009-04-02 15:04 -0700 URL: http://hg.openjdk.java.net/jdk7/build/jdk/rev/78fbc0dad111 6825765: Further adjustments to regression tests run by jprt Reviewed-by: tbell ! test/java/lang/reflect/Method/InheritedMethods.java From Dalibor.Topic at Sun.COM Fri Apr 3 13:31:35 2009 From: Dalibor.Topic at Sun.COM (Dalibor Topic) Date: Fri, 03 Apr 2009 15:31:35 +0200 Subject: New project: getting rid of IcedTea local patches In-Reply-To: <49D3917B.2010907@redhat.com> References: <49D3917B.2010907@redhat.com> Message-ID: <49D60FB7.9080301@sun.com> Andrew Haley wrote: > We at Red Hat have noticed that the list of IcedTea local patches has > been getting large, with some local patches that should have been > pushed upstream. Also, some IcedTea patches have been committed to > OpenJDK 7 but not OpenJDK 6. > > So, we're going to have a serious attempt to minimize the number of > IcedTea patches. We'll create a Wiki page at icedtea.classpath.org > that is a list of the patches, and for every one we're going to > discuss whether it should stay IcedTea local, be pushed upstream to > OpenJDK, or be deleted altogether. Then we will create OpenJDK > bugzilla entries for the patches that we think should be integrated > upstream and work with Sun engineers to get that done. > > I hope that it will be possible to reduce the number of patches to a > fraction of what we have at the moment, while improving the quality of > the upstream product. > > This is going to be quite a lot of work, so we'd appreciate help from > anyone. Absolutely - thank you very much for pushing for this, Andrew! cheers, dalibor topic > > I hope this will meet with everyone's approval. > > Andrew. -- ******************************************************************* Dalibor Topic Tel: (+49 40) 23 646 738 Java F/OSS Ambassador AIM: robiladonaim Sun Microsystems GmbH Mobile: (+49 177) 2664 192 Nagelsweg 55 http://openjdk.java.net D-20097 Hamburg mailto:Dalibor.Topic at sun.com Sitz der Gesellschaft: Sonnenallee 1, D-85551 Kirchheim-Heimstetten Amtsgericht M?nchen: HRB 161028 Gesch?ftsf?hrer: Thomas Schr?der, Wolfgang Engels, Dr. Roland B?mer Vorsitzender des Aufsichtsrates: Martin H?ring From neale at sinenomine.net Fri Apr 3 15:04:41 2009 From: neale at sinenomine.net (Neale Ferguson) Date: Fri, 03 Apr 2009 11:04:41 -0400 Subject: Make or Makefile problem? Message-ID: I?m building icedtea6-1.4.1 and am encountering the following error: /bin/mkdir -p /home/neale/icedtea6-1.4.1/openjdk-ecj/control/build/linux-s390x/tmp rm -f /home/neale/icedtea6-1.4.1/openjdk-ecj/control/build/linux-s390x/tmp/rt-orig .jar ifneq (,1) /bin/sh: -c: line 0: syntax error near unexpected token `,1' /bin/sh: -c: line 0: `ifneq (,1)' make[2]: *** [/home/neale/icedtea6-1.4.1/openjdk-ecj/control/build/linux-s390x/tmp/rt-ori g.jar] Error 2 make[2]: Leaving directory `/home/neale/icedtea6-1.4.1/openjdk-ecj/jdk/make' It appears due to this part of the recipe: $(RT_JAR): $(if $(JAR_KNOWS_ATFILE),$(RT_JAR_FILELIST),$(RT_JAR_ARGLIST)) \ $(JAR_MANIFEST_FILE) $(prep-target) ifneq (,$(JAR_KNOWS_ATFILE)) (cd $(CLASSBINDIR) && \ $(BOOT_JAR_CMD) c0mf $(JAR_MANIFEST_FILE) $@ \ $(JAR_JFLAGS) @$(RT_JAR_FILELIST)) else : I'm using GNU make 3.81. Neale From neale at sinenomine.net Sat Apr 4 02:30:07 2009 From: neale at sinenomine.net (Neale Ferguson) Date: Fri, 03 Apr 2009 22:30:07 -0400 Subject: Build progressing... Message-ID: After upgrading make from 3.80 to 3.81, my build of icedtea6-1.4.1 is progressing. It runs for a number of hours, completes building in openjdk-ecj and appears to start building within openjdk where it comes to a halt with: make[2]: Entering directory `/home/neale/icedtea6-1.4.1/openjdk/langtools/make' JAVA_HOME=/home/neale/icedtea6-1.4.1/bootstrap/jdk1.6.0 ANT_OPTS=-Djava.io.tmpdir='/home/neale/icedtea6-1.4.1/openjdk/control/build/ linux-s390x/langtools/build/ant-tmp' ant -diagnostics > /home/neale/icedtea6-1.4.1/openjdk/control/build/linux-s390x/langtools/build /ant-diagnostics.log Exception in thread "main" java.lang.NoClassDefFoundError: org/apache/tools/ant/launch/Launcher Caused by: java.lang.ClassNotFoundException: org.apache.tools.ant.launch.Launcher at java.net.URLClassLoader$2.run(URLClassLoader.java:217) at java.security.AccessController.doPrivileged(Native Method) at java.net.URLClassLoader.findClass(URLClassLoader.java:206) at java.lang.ClassLoader.loadClass(ClassLoader.java:323) at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:294) at java.lang.ClassLoader.loadClass(ClassLoader.java:268) at java.lang.ClassLoader.loadClassInternal(ClassLoader.java:336) Could not find the main class: org.apache.tools.ant.launch.Launcher. Program will exit. The difference is now JAVA_HOME is being specified. Obviously it can?t find the ant jar which is lurking in /usr/share/java. So what configuration piece have I missed so that it knows where to look? Neale From Kelly.Ohair at Sun.COM Sat Apr 4 19:05:25 2009 From: Kelly.Ohair at Sun.COM (Kelly O'Hair) Date: Sat, 04 Apr 2009 12:05:25 -0700 Subject: Build progressing... In-Reply-To: References: Message-ID: <49D7AF75.1040105@sun.com> Make sure you can run 'ant -version', and also try: export JAVA_HOME=/home/neale/icedtea6-1.4.1/bootstrap/jdk1.6.0 ant -version If that doesn't work, then you need to track that down. I usually download my own ant 1.7.0 in my home directory and use that. I've had problems with the ant's placed in /usr/bin or /usr/local/bin, I think the ant startup script gets confused sometimes when it doesn't live in it's own 'home' location. -kto Neale Ferguson wrote: > After upgrading make from 3.80 to 3.81, my build of icedtea6-1.4.1 is > progressing. It runs for a number of hours, completes building in > openjdk-ecj and appears to start building within openjdk where it comes to a > halt with: > > make[2]: Entering directory > `/home/neale/icedtea6-1.4.1/openjdk/langtools/make' > JAVA_HOME=/home/neale/icedtea6-1.4.1/bootstrap/jdk1.6.0 > ANT_OPTS=-Djava.io.tmpdir='/home/neale/icedtea6-1.4.1/openjdk/control/build/ > linux-s390x/langtools/build/ant-tmp' ant -diagnostics > > /home/neale/icedtea6-1.4.1/openjdk/control/build/linux-s390x/langtools/build > /ant-diagnostics.log > Exception in thread "main" java.lang.NoClassDefFoundError: > org/apache/tools/ant/launch/Launcher > Caused by: java.lang.ClassNotFoundException: > org.apache.tools.ant.launch.Launcher > at java.net.URLClassLoader$2.run(URLClassLoader.java:217) > at java.security.AccessController.doPrivileged(Native Method) > at java.net.URLClassLoader.findClass(URLClassLoader.java:206) > at java.lang.ClassLoader.loadClass(ClassLoader.java:323) > at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:294) > at java.lang.ClassLoader.loadClass(ClassLoader.java:268) > at java.lang.ClassLoader.loadClassInternal(ClassLoader.java:336) > Could not find the main class: org.apache.tools.ant.launch.Launcher. Program > will exit. > > The difference is now JAVA_HOME is being specified. Obviously it can?t find > the ant jar which is lurking in /usr/share/java. So what configuration piece > have I missed so that it knows where to look? > > Neale > > From gbenson at redhat.com Mon Apr 6 13:04:58 2009 From: gbenson at redhat.com (Gary Benson) Date: Mon, 6 Apr 2009 14:04:58 +0100 Subject: New project: getting rid of IcedTea local patches In-Reply-To: <1238648840.3168.19.camel@localhost.localdomain> References: <49D3917B.2010907@redhat.com> <49D3A8B1.4040201@sun.com> <1238609153.4495.31.camel@localhost.localdomain> <49D3B384.2010609@sun.com> <1238648840.3168.19.camel@localhost.localdomain> Message-ID: <20090406130458.GG3260@redhat.com> Christian Thalinger wrote: > On Wed, 2009-04-01 at 11:33 -0700, Kelly O'Hair wrote: > > The changes to the jdk files look fine. One question though, does > > the name "CORE_BUILD" have a meaning to the JDK, or just the VM? > > Just wondering if a "VM_CORE_BUILD" or "HOTSPOT_CORE_BUILD" might > > be a better name. Not a big deal. > > I don't know, but maybe Gary does... It doesn't have any meaning outside of that used in the jdk makefile it patches, ie that there will be no client libjvm.so. Cheers, Gary -- http://gbenson.net/ From martinrb at google.com Mon Apr 6 21:21:40 2009 From: martinrb at google.com (Martin Buchholz) Date: Mon, 6 Apr 2009 14:21:40 -0700 Subject: jdk-repo-only-build broken in openjdk6 Message-ID: <1ccfd1c10904061421p37271e8ej54414f4d2e9a131@mail.gmail.com> Hi build experts, I tried building just the openjdk6 jdk repo in (more or less) the usual way using 'cd jdk/make && make...' This works in openjdk7 but fails in openjdk6 (and has failed for quite a while) ------------------------------------------------------------ >>>Recursively making smartcardio all @ Sun Apr 5 16:04:57 PDT 2009 ... make[3]: Entering directory `/usr/local/google/home/martin/ws/openjdk6/jdk/make/sun/security/smartcardio' /bin/mkdir -p ../../../../build/linux-i586/tmp/sun/sun.security.smartcardio/j2pcsc/obj_g rm -f ../../../../build/linux-i586/tmp/sun/sun.security.smartcardio/j2pcsc/obj_g/.class.headers.i586 # Running javah: /usr/local/google/SLASH_JAVA/re/openjdk/6/promoted/latest/binaries/linux-i586/bin/javah -bootclasspath ../../../../build/linux-i586/classes -d ../../../../build/linux-i586/tmp/sun/sun.security.smartcardio/j2pcsc/CClassHeaders/ \ sun.security.smartcardio.PCSC sun.security.smartcardio.PlatformPCSC error: cannot access sun.security.smartcardio.PCSC class file for sun.security.smartcardio.PCSC not found javadoc: error - Class sun.security.smartcardio.PCSC not found. error: cannot access sun.security.smartcardio.PlatformPCSC class file for sun.security.smartcardio.PlatformPCSC not found javadoc: error - Class sun.security.smartcardio.PlatformPCSC not found. Error: No classes were specified on the command line. Try -help. make[3]: *** [../../../../build/linux-i586/tmp/sun/sun.security.smartcardio/j2pcsc/obj_g/.class.headers.i586] Error 15 make[3]: Leaving directory `/usr/local/google/home/martin/ws/openjdk6/jdk/make/sun/security/smartcardio' make[2]: *** [all] Error 1 make[2]: Leaving directory `/usr/local/google/home/martin/ws/openjdk6/jdk/make/sun/security' make[1]: *** [all] Error 1 make[1]: Leaving directory `/usr/local/google/home/martin/ws/openjdk6/jdk/make/sun' make: *** [all] Error 1 Command /usr/bin/nice /usr/bin/linux32 make SHELL=/bin/bash VARIANT=DBG sanity all docs images failed: rc=2 ------------------------------------------------------------ It's not obvious why a full control build doesn't encounter this issue. After much frustrating debugging, I found that it's due to the control build passing an absolute JDK_TOPDIR to the jdk repo sub-build. So I have a fine workaround. Define JDK_TOPDIR to the absolute path of the jdk directory. I still don't know where in the makefiles is a dependency on JDK_TOPDIR not being relative. The smartcardio Makefile appears to be blameless. This would be a P2 bug to fix, were it not for the fact that openjdk6 does not see a lot of development. Here's a snippet of perl I use in my build script: { # Work around bug in openjdk6, that requires an absolute JDK_TOPDIR use Cwd 'getcwd'; my $dir = getcwd(); while ($dir ne '') { sub isJdkDir($) { -r "$_[0]/make/common/Program.gmk" } last if isJdkDir "$dir/jdk"; if (isJdkDir $dir) { $ENV{JDK_TOPDIR} = $dir; print "JDK_TOPDIR=$dir\n" if $verbose; last; } $dir =~ s~/[^/]*$~~; } } Hope this helps. Martin From Tim.Bell at Sun.COM Mon Apr 6 21:33:02 2009 From: Tim.Bell at Sun.COM (Tim Bell) Date: Mon, 06 Apr 2009 14:33:02 -0700 Subject: jdk-repo-only-build broken in openjdk6 In-Reply-To: <1ccfd1c10904061421p37271e8ej54414f4d2e9a131@mail.gmail.com> References: <1ccfd1c10904061421p37271e8ej54414f4d2e9a131@mail.gmail.com> Message-ID: <49DA750E.4000204@sun.com> Hi Martin: > I tried building just the openjdk6 jdk repo in (more or less) the usual way > using 'cd jdk/make && make...' > > This works in openjdk7 but fails in openjdk6 (and has failed for quite a while) > > ------------------------------------------------------------ >>>> Recursively making smartcardio all @ Sun Apr 5 16:04:57 PDT 2009 ... > make[3]: Entering directory > `/usr/local/google/home/martin/ws/openjdk6/jdk/make/sun/security/smartcardio' > /bin/mkdir -p ../../../../build/linux-i586/tmp/sun/sun.security.smartcardio/j2pcsc/obj_g > rm -f ../../../../build/linux-i586/tmp/sun/sun.security.smartcardio/j2pcsc/obj_g/.class.headers.i586 > # Running javah: > /usr/local/google/SLASH_JAVA/re/openjdk/6/promoted/latest/binaries/linux-i586/bin/javah > -bootclasspath ../../../../build/linux-i586/classes -d > ../../../../build/linux-i586/tmp/sun/sun.security.smartcardio/j2pcsc/CClassHeaders/ > \ > sun.security.smartcardio.PCSC sun.security.smartcardio.PlatformPCSC > error: cannot access sun.security.smartcardio.PCSC > class file for sun.security.smartcardio.PCSC not found > javadoc: error - Class sun.security.smartcardio.PCSC not found. > error: cannot access sun.security.smartcardio.PlatformPCSC > class file for sun.security.smartcardio.PlatformPCSC not found > javadoc: error - Class sun.security.smartcardio.PlatformPCSC not found. > Error: No classes were specified on the command line. Try -help. > make[3]: *** [../../../../build/linux-i586/tmp/sun/sun.security.smartcardio/j2pcsc/obj_g/.class.headers.i586] > Error 15 > make[3]: Leaving directory > `/usr/local/google/home/martin/ws/openjdk6/jdk/make/sun/security/smartcardio' > make[2]: *** [all] Error 1 > make[2]: Leaving directory > `/usr/local/google/home/martin/ws/openjdk6/jdk/make/sun/security' > make[1]: *** [all] Error 1 > make[1]: Leaving directory > `/usr/local/google/home/martin/ws/openjdk6/jdk/make/sun' > make: *** [all] Error 1 > Command /usr/bin/nice /usr/bin/linux32 make SHELL=/bin/bash > VARIANT=DBG sanity all docs images failed: rc=2 > ------------------------------------------------------------ This fingerprint matches 6668260/6668018 Bug ID: 6668260 build in openjdk/jdk/make fails if openjdk/build exists Bug ID: 6668018 Incremental/partial OpenJDK builds from jdk/make subdirectories do not always work http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6668260 http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6668018 Did you previously do a control build at the top level? If so, another workaround is to rename that output directory. In your case, that would be: mv /usr/local/google/home/martin/ws/openjdk6/build \ /usr/local/google/home/martin/ws/openjdk6/build.ignore HTH - Tim > It's not obvious why a full control build doesn't encounter this issue. > After much frustrating debugging, I found that it's due to the control build > passing an absolute JDK_TOPDIR to the jdk repo sub-build. > > So I have a fine workaround. Define JDK_TOPDIR to the absolute path > of the jdk directory. I still don't know where in the makefiles is a > dependency on JDK_TOPDIR not being relative. The smartcardio Makefile > appears to be blameless. This would be a P2 bug to fix, > were it not for the fact that openjdk6 does not see a lot of development. > > Here's a snippet of perl I use in my build script: > > { > # Work around bug in openjdk6, that requires an absolute JDK_TOPDIR > use Cwd 'getcwd'; > my $dir = getcwd(); > while ($dir ne '') { > sub isJdkDir($) { -r "$_[0]/make/common/Program.gmk" } > last if isJdkDir "$dir/jdk"; > if (isJdkDir $dir) { > $ENV{JDK_TOPDIR} = $dir; > print "JDK_TOPDIR=$dir\n" if $verbose; > last; > } > $dir =~ s~/[^/]*$~~; > } > } > > Hope this helps. > > Martin From martinrb at google.com Mon Apr 6 21:55:03 2009 From: martinrb at google.com (Martin Buchholz) Date: Mon, 6 Apr 2009 14:55:03 -0700 Subject: jdk-repo-only-build broken in openjdk6 In-Reply-To: <49DA750E.4000204@sun.com> References: <1ccfd1c10904061421p37271e8ej54414f4d2e9a131@mail.gmail.com> <49DA750E.4000204@sun.com> Message-ID: <1ccfd1c10904061455o613d25c4p86e2faa6226928f2@mail.gmail.com> On Mon, Apr 6, 2009 at 14:33, Tim Bell wrote: > Hi Martin: > > Bug ID: 6668260 build in openjdk/jdk/make fails if openjdk/build exists > Bug ID: 6668018 Incremental/partial OpenJDK builds from jdk/make > subdirectories do not always work > > http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6668260 > http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6668018 > > Did you previously do a control build at the top level? Ah yes indeed - good clue! ?If so, another > workaround is to rename that output directory. ?In your case, that would be: > ?mv /usr/local/google/home/martin/ws/openjdk6/build \ > ? ? /usr/local/google/home/martin/ws/openjdk6/build.ignore I think my JDK_TOPDIR workaround is another clue, that should be added to the bug report. Since it appears that this bug is also in openjdk7, I would make it a P2, just because of the extreme frustration developers are likely to encounter. The Makefiles could simply make JDK_TOPDIR absolute, but that has the problem that FullPath is defined in a Makefile included using a path that uses JDK_TOPDIR. Martin > > HTH - Tim > > >> It's not obvious why a full control build doesn't encounter this issue. >> After much frustrating debugging, I found that it's due to the control >> build >> passing an absolute JDK_TOPDIR to the jdk repo sub-build. >> >> So I have a fine workaround. ?Define JDK_TOPDIR to the absolute path >> of the jdk directory. ?I still don't know where in the makefiles is a >> dependency on JDK_TOPDIR not being relative. ?The smartcardio Makefile >> appears to be blameless. ?This would be a P2 bug to fix, >> were it not for the fact that openjdk6 does not see a lot of development. >> >> Here's a snippet of perl I use in my build script: >> >> { >> ?# Work around bug in openjdk6, that requires an absolute JDK_TOPDIR >> ?use Cwd 'getcwd'; >> ?my $dir = getcwd(); >> ?while ($dir ne '') { >> ? ?sub isJdkDir($) { -r "$_[0]/make/common/Program.gmk" } >> ? ?last if isJdkDir "$dir/jdk"; >> ? ?if (isJdkDir $dir) { >> ? ? ?$ENV{JDK_TOPDIR} = $dir; >> ? ? ?print "JDK_TOPDIR=$dir\n" if $verbose; >> ? ? ?last; >> ? ?} >> ? ?$dir =~ s~/[^/]*$~~; >> ?} >> } >> >> Hope this helps. >> >> Martin > > From xiomara.jayasena at sun.com Tue Apr 7 18:50:21 2009 From: xiomara.jayasena at sun.com (xiomara.jayasena at sun.com) Date: Tue, 07 Apr 2009 18:50:21 +0000 Subject: hg: jdk7/build: Added tag jdk7-b53 for changeset c235f4a8559d Message-ID: <20090407185022.07F3EE53E@hg.openjdk.java.net> Changeset: 2ef382b1bbd5 Author: xdono Date: 2009-04-02 16:51 -0700 URL: http://hg.openjdk.java.net/jdk7/build/rev/2ef382b1bbd5 Added tag jdk7-b53 for changeset c235f4a8559d ! .hgtags From xiomara.jayasena at sun.com Tue Apr 7 18:54:42 2009 From: xiomara.jayasena at sun.com (xiomara.jayasena at sun.com) Date: Tue, 07 Apr 2009 18:54:42 +0000 Subject: hg: jdk7/build/corba: Added tag jdk7-b53 for changeset 3c4d73194f6f Message-ID: <20090407185443.7AD4AE543@hg.openjdk.java.net> Changeset: 8130ac858d67 Author: xdono Date: 2009-04-02 16:51 -0700 URL: http://hg.openjdk.java.net/jdk7/build/corba/rev/8130ac858d67 Added tag jdk7-b53 for changeset 3c4d73194f6f ! .hgtags From xiomara.jayasena at sun.com Tue Apr 7 19:01:59 2009 From: xiomara.jayasena at sun.com (xiomara.jayasena at sun.com) Date: Tue, 07 Apr 2009 19:01:59 +0000 Subject: hg: jdk7/build/hotspot: 33 new changesets Message-ID: <20090407190304.41559E548@hg.openjdk.java.net> Changeset: ec1a6dc46005 Author: iveresov Date: 2009-03-12 14:01 -0700 URL: http://hg.openjdk.java.net/jdk7/build/hotspot/rev/ec1a6dc46005 6816433: Test G1 and ParOld in JPRT Reviewed-by: jmasa, never, ysr ! make/jprt.properties Changeset: 4018e98c778a Author: tonyp Date: 2009-03-13 16:10 -0400 URL: http://hg.openjdk.java.net/jdk7/build/hotspot/rev/4018e98c778a Merge Changeset: 09f82af55c3e Author: ysr Date: 2009-03-13 13:56 -0700 URL: http://hg.openjdk.java.net/jdk7/build/hotspot/rev/09f82af55c3e 6808322: ParNew, CMS, G1: ParGCAllocBuffer overflow Summary: Correct the overflow check in ParGCAllocBuffer::allocate(); simplify ParGCAllocBuffer::undo_allocation(). Reviewed-by: apetrusenko, jcoomes, jmasa, minqi, phh, tonyp ! src/share/vm/gc_implementation/parNew/parGCAllocBuffer.hpp Changeset: fe2441500281 Author: ysr Date: 2009-03-13 17:06 -0700 URL: http://hg.openjdk.java.net/jdk7/build/hotspot/rev/fe2441500281 Merge Changeset: 6c4cea9bfa11 Author: tonyp Date: 2009-03-15 22:03 -0400 URL: http://hg.openjdk.java.net/jdk7/build/hotspot/rev/6c4cea9bfa11 6604422: G1: re-use half-promoted regions 6728271: G1: Cleanup G1CollectedHeap::get_gc_alloc_regions() Summary: It allows the last half-full region to be allocated to during a GC to be reused during the next GC. Reviewed-by: apetrusenko, jcoomes ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.hpp ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.cpp Changeset: 25e146966e7c Author: iveresov Date: 2009-03-16 08:01 -0700 URL: http://hg.openjdk.java.net/jdk7/build/hotspot/rev/25e146966e7c 6817419: G1: Enable extensive verification for humongous regions Summary: Enabled full verification for humongous regions. Also made sure that the VerifyAfterGC works with deferred updates and G1HRRSFlushLogBuffersOnVerify. Reviewed-by: tonyp ! src/share/vm/gc_implementation/g1/concurrentG1Refine.cpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/g1RemSet.cpp Changeset: 2a5da27ccae9 Author: tonyp Date: 2009-03-16 10:52 -0400 URL: http://hg.openjdk.java.net/jdk7/build/hotspot/rev/2a5da27ccae9 6816154: G1: introduce flags to enable/disable RSet updating and scanning Summary: Introduces two flags, -XX:-/+G1EnableParallelRSetUpdating and -XX:-/+G1EnableParallelRSetScanning, to turn on/off the "band aid" fix that serializes RSet updating / scanning during GCs. Reviewed-by: iveresov ! src/share/vm/gc_implementation/g1/g1RemSet.cpp ! src/share/vm/gc_implementation/g1/g1_globals.hpp Changeset: 922c573ea67d Author: iveresov Date: 2009-03-16 17:48 -0700 URL: http://hg.openjdk.java.net/jdk7/build/hotspot/rev/922c573ea67d 6815683: G1: SEGV during marking Summary: We should mark the regions that continue humongous regions as live if the first region is live. Reviewed-by: tonyp ! src/share/vm/gc_implementation/g1/concurrentMark.cpp Changeset: ba50942c8138 Author: tonyp Date: 2009-03-18 11:37 -0400 URL: http://hg.openjdk.java.net/jdk7/build/hotspot/rev/ba50942c8138 Merge ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.hpp ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.cpp ! src/share/vm/gc_implementation/g1/g1RemSet.cpp ! src/share/vm/gc_implementation/g1/g1_globals.hpp Changeset: 6af0a709d52b Author: twisti Date: 2009-03-11 14:16 -0700 URL: http://hg.openjdk.java.net/jdk7/build/hotspot/rev/6af0a709d52b 6812587: Use auxv to determine SPARC hardware features on Solaris Summary: A similar function to getisax(2) should be used to determine all possible instruction set extensions. Reviewed-by: never, kvn ! src/cpu/sparc/vm/vm_version_sparc.cpp ! src/cpu/sparc/vm/vm_version_sparc.hpp ! src/os/solaris/vm/os_solaris.cpp ! src/os/solaris/vm/os_solaris.hpp ! src/os_cpu/solaris_sparc/vm/vm_version_solaris_sparc.cpp ! src/share/vm/includeDB_core Changeset: 660978a2a31a Author: kvn Date: 2009-03-12 10:37 -0700 URL: http://hg.openjdk.java.net/jdk7/build/hotspot/rev/660978a2a31a 6791178: Specialize for zero as the compressed oop vm heap base Summary: Use zero based compressed oops if java heap is below 32gb and unscaled compressed oops if java heap is below 4gb. Reviewed-by: never, twisti, jcoomes, coleenp ! agent/src/share/classes/sun/jvm/hotspot/debugger/Debugger.java ! agent/src/share/classes/sun/jvm/hotspot/debugger/DebuggerBase.java ! agent/src/share/classes/sun/jvm/hotspot/debugger/JVMDebugger.java ! agent/src/share/classes/sun/jvm/hotspot/debugger/remote/RemoteDebugger.java ! agent/src/share/classes/sun/jvm/hotspot/debugger/remote/RemoteDebuggerClient.java ! agent/src/share/classes/sun/jvm/hotspot/debugger/remote/RemoteDebuggerServer.java ! agent/src/share/classes/sun/jvm/hotspot/memory/Universe.java ! agent/src/share/classes/sun/jvm/hotspot/runtime/VM.java ! src/cpu/sparc/vm/assembler_sparc.cpp ! src/cpu/sparc/vm/sparc.ad ! src/cpu/sparc/vm/stubGenerator_sparc.cpp ! src/cpu/sparc/vm/vm_version_sparc.cpp ! src/cpu/sparc/vm/vtableStubs_sparc.cpp ! src/cpu/x86/vm/assembler_x86.cpp ! src/cpu/x86/vm/assembler_x86.hpp ! src/cpu/x86/vm/x86_64.ad ! src/os/linux/vm/os_linux.cpp ! src/os/solaris/dtrace/generateJvmOffsets.cpp ! src/os/solaris/dtrace/jhelper.d ! src/os/solaris/dtrace/libjvm_db.c ! src/os/solaris/vm/os_solaris.cpp ! src/os/windows/vm/os_windows.cpp ! src/os_cpu/linux_sparc/vm/globals_linux_sparc.hpp ! src/os_cpu/linux_x86/vm/globals_linux_x86.hpp ! src/os_cpu/solaris_sparc/vm/globals_solaris_sparc.hpp ! src/os_cpu/solaris_x86/vm/globals_solaris_x86.hpp ! src/os_cpu/windows_x86/vm/globals_windows_x86.hpp ! src/share/vm/asm/assembler.cpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/parallelScavenge/parallelScavengeHeap.cpp ! src/share/vm/memory/genCollectedHeap.cpp ! src/share/vm/memory/universe.cpp ! src/share/vm/memory/universe.hpp ! src/share/vm/oops/oop.inline.hpp ! src/share/vm/opto/addnode.cpp ! src/share/vm/opto/compile.cpp ! src/share/vm/opto/connode.cpp ! src/share/vm/opto/lcm.cpp ! src/share/vm/opto/matcher.cpp ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/globals.hpp ! src/share/vm/runtime/os.hpp ! src/share/vm/runtime/virtualspace.cpp ! src/share/vm/runtime/virtualspace.hpp ! src/share/vm/runtime/vmStructs.cpp Changeset: c771b7f43bbf Author: twisti Date: 2009-03-13 11:35 -0700 URL: http://hg.openjdk.java.net/jdk7/build/hotspot/rev/c771b7f43bbf 6378821: bitCount() should use POPC on SPARC processors and AMD+10h Summary: bitCount() should use POPC on SPARC processors where POPC is implemented directly in hardware. Reviewed-by: kvn, never ! src/cpu/sparc/vm/sparc.ad ! src/cpu/sparc/vm/vm_version_sparc.cpp ! src/cpu/sparc/vm/vm_version_sparc.hpp ! src/cpu/x86/vm/assembler_x86.cpp ! src/cpu/x86/vm/assembler_x86.hpp ! src/cpu/x86/vm/vm_version_x86.cpp ! src/cpu/x86/vm/vm_version_x86.hpp ! src/cpu/x86/vm/x86_32.ad ! src/cpu/x86/vm/x86_64.ad ! src/os_cpu/solaris_sparc/vm/vm_version_solaris_sparc.cpp ! src/share/vm/classfile/vmSymbols.hpp ! src/share/vm/opto/classes.hpp ! src/share/vm/opto/connode.hpp ! src/share/vm/opto/library_call.cpp ! src/share/vm/runtime/globals.hpp + test/compiler/6378821/Test6378821.java Changeset: c517646eef23 Author: jrose Date: 2009-03-13 18:39 -0700 URL: http://hg.openjdk.java.net/jdk7/build/hotspot/rev/c517646eef23 6813212: factor duplicated assembly code for general subclass check (for 6655638) Summary: Code in interp_masm, stubGenerator, c1_LIRAssembler, and AD files moved into MacroAssembler. Reviewed-by: kvn ! src/cpu/sparc/vm/assembler_sparc.cpp ! src/cpu/sparc/vm/assembler_sparc.hpp ! src/cpu/sparc/vm/c1_LIRAssembler_sparc.cpp ! src/cpu/sparc/vm/c1_Runtime1_sparc.cpp ! src/cpu/sparc/vm/interp_masm_sparc.cpp ! src/cpu/sparc/vm/stubGenerator_sparc.cpp ! src/cpu/x86/vm/assembler_x86.cpp ! src/cpu/x86/vm/assembler_x86.hpp ! src/cpu/x86/vm/c1_LIRAssembler_x86.cpp ! src/cpu/x86/vm/c1_Runtime1_x86.cpp ! src/cpu/x86/vm/interp_masm_x86_32.cpp ! src/cpu/x86/vm/interp_masm_x86_64.cpp ! src/cpu/x86/vm/stubGenerator_x86_32.cpp ! src/cpu/x86/vm/stubGenerator_x86_64.cpp ! src/cpu/x86/vm/x86_32.ad ! src/cpu/x86/vm/x86_64.ad ! src/share/vm/opto/graphKit.cpp Changeset: c3a720eefe82 Author: kvn Date: 2009-03-16 15:06 -0700 URL: http://hg.openjdk.java.net/jdk7/build/hotspot/rev/c3a720eefe82 6816308: Changes to allow builds with latest Windows SDK 6.1 on 64bit Windows 2003 Summary: Allow Hotspot builds with latest Windows SDK 6.1 on 64bit Windows 2003 Reviewed-by: ohair, tbell, jcoomes ! make/windows/get_msc_ver.sh ! make/windows/makefiles/compile.make ! make/windows/makefiles/sa.make ! make/windows/makefiles/sanity.make ! src/cpu/x86/vm/interpreterRT_x86_64.cpp ! src/os_cpu/windows_x86/vm/unwind_windows_x86.hpp ! src/share/vm/adlc/adlc.hpp ! src/share/vm/gc_implementation/g1/concurrentMark.cpp ! src/share/vm/gc_implementation/g1/heapRegionRemSet.cpp ! src/share/vm/memory/blockOffsetTable.hpp ! src/share/vm/runtime/vm_version.cpp ! src/share/vm/utilities/globalDefinitions_visCPP.hpp Changeset: 039a914095f4 Author: kvn Date: 2009-03-18 13:25 -0700 URL: http://hg.openjdk.java.net/jdk7/build/hotspot/rev/039a914095f4 6772368: REGRESSION:tomcat crashed twice with JDK 7 Summary: Call make_block_at() with the original handler limits. Reviewed-by: never ! src/share/vm/ci/ciMethodBlocks.cpp Changeset: bd441136a5ce Author: kvn Date: 2009-03-19 09:13 -0700 URL: http://hg.openjdk.java.net/jdk7/build/hotspot/rev/bd441136a5ce Merge ! src/cpu/sparc/vm/sparc.ad ! src/cpu/x86/vm/assembler_x86.cpp ! src/cpu/x86/vm/c1_LIRAssembler_x86.cpp ! src/cpu/x86/vm/c1_Runtime1_x86.cpp ! src/cpu/x86/vm/interp_masm_x86_32.cpp ! src/cpu/x86/vm/interp_masm_x86_64.cpp ! src/cpu/x86/vm/stubGenerator_x86_32.cpp ! src/cpu/x86/vm/stubGenerator_x86_64.cpp ! src/cpu/x86/vm/x86_32.ad ! src/cpu/x86/vm/x86_64.ad ! src/os/linux/vm/os_linux.cpp ! src/os/solaris/vm/os_solaris.cpp ! src/os/windows/vm/os_windows.cpp ! src/share/vm/classfile/vmSymbols.hpp ! src/share/vm/gc_implementation/g1/concurrentMark.cpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/heapRegionRemSet.cpp ! src/share/vm/includeDB_core ! src/share/vm/memory/genCollectedHeap.cpp ! src/share/vm/memory/universe.cpp ! src/share/vm/memory/universe.hpp ! src/share/vm/oops/oop.inline.hpp ! src/share/vm/opto/classes.hpp ! src/share/vm/opto/compile.cpp ! src/share/vm/opto/graphKit.cpp ! src/share/vm/opto/lcm.cpp ! src/share/vm/opto/matcher.cpp ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/globals.hpp ! src/share/vm/runtime/os.hpp Changeset: 2314b7336582 Author: tonyp Date: 2009-03-21 22:53 -0400 URL: http://hg.openjdk.java.net/jdk7/build/hotspot/rev/2314b7336582 6820321: G1: Error: guarantee(check_nums(total, n, parts), "all seq lengths should match") Summary: Small fixes to sort out some verbosegc-related incorrectness and a failure Reviewed-by: apetrusenko ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.cpp ! src/share/vm/gc_implementation/g1/g1RemSet.cpp Changeset: 59f139e8a8d1 Author: tonyp Date: 2009-03-25 10:36 -0400 URL: http://hg.openjdk.java.net/jdk7/build/hotspot/rev/59f139e8a8d1 Merge Changeset: 54782a4cd321 Author: poonam Date: 2009-03-15 18:11 -0700 URL: http://hg.openjdk.java.net/jdk7/build/hotspot/rev/54782a4cd321 6812971: SA: re-attaching to process fails Summary: After attaching, de-attaching SA from a process, the second time attach() call fails. This happens because in VM.initialize(), Universe does not get re-initialized before it is accessed. Reviewed-by: swamyv ! agent/src/share/classes/sun/jvm/hotspot/runtime/VM.java Changeset: 8ce995316d10 Author: acorn Date: 2009-03-16 08:50 -0400 URL: http://hg.openjdk.java.net/jdk7/build/hotspot/rev/8ce995316d10 Merge Changeset: 4aaa9f5e02a8 Author: acorn Date: 2009-03-18 17:20 -0400 URL: http://hg.openjdk.java.net/jdk7/build/hotspot/rev/4aaa9f5e02a8 4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242. Reviewed-by: kamg, coleenp ! src/share/vm/classfile/classFileParser.cpp ! src/share/vm/oops/instanceKlass.cpp ! src/share/vm/oops/instanceKlass.hpp ! src/share/vm/oops/klassVtable.cpp ! src/share/vm/oops/klassVtable.hpp Changeset: e55bcaf3a6a1 Author: acorn Date: 2009-03-20 11:23 -0400 URL: http://hg.openjdk.java.net/jdk7/build/hotspot/rev/e55bcaf3a6a1 6819853: VM does not detect JDK which supports parallel class loaders Reviewed-by: coleenp, pbk, xlu, alanb ! src/share/vm/classfile/vmSymbols.hpp Changeset: c664a0794f85 Author: coleenp Date: 2009-03-20 22:08 -0400 URL: http://hg.openjdk.java.net/jdk7/build/hotspot/rev/c664a0794f85 6805748: Assertion "don't reset to 0 -- could be mistaken for never-executed" in CompilationPolicy Summary: Resetting the invocation counter for a method invocation event was setting count to zero for CompileThreshold=1, making it look like a never executed method. Reviewed-by: phh, kamg, acorn, never ! src/share/vm/interpreter/invocationCounter.cpp Changeset: 60bfce711da4 Author: acorn Date: 2009-03-23 10:42 -0400 URL: http://hg.openjdk.java.net/jdk7/build/hotspot/rev/60bfce711da4 Merge ! agent/src/share/classes/sun/jvm/hotspot/runtime/VM.java ! src/share/vm/classfile/vmSymbols.hpp Changeset: 6bdd6923ba16 Author: coleenp Date: 2009-03-25 14:19 -0400 URL: http://hg.openjdk.java.net/jdk7/build/hotspot/rev/6bdd6923ba16 6541756: Reduce executable C-heap Summary: Add executable parameters to reserve_memory and commit_memory to reduce executable memory to only the Code Heap. Reviewed-by: xlu, kvn, acorn ! src/os/linux/vm/os_linux.cpp ! src/os/solaris/vm/os_solaris.cpp ! src/os/windows/vm/os_windows.cpp ! src/share/vm/memory/heap.cpp ! src/share/vm/runtime/os.hpp ! src/share/vm/runtime/virtualspace.cpp ! src/share/vm/runtime/virtualspace.hpp Changeset: 715dceaa89b7 Author: acorn Date: 2009-03-25 13:09 -0400 URL: http://hg.openjdk.java.net/jdk7/build/hotspot/rev/715dceaa89b7 6603316: Improve instrumentation for classes loaded at startup Reviewed-by: xlu, mchung ! src/share/vm/classfile/classFileParser.cpp ! src/share/vm/prims/jni.cpp ! src/share/vm/prims/jvm.cpp ! src/share/vm/prims/jvm_misc.hpp Changeset: fe62b51b93f4 Author: acorn Date: 2009-03-26 16:00 -0400 URL: http://hg.openjdk.java.net/jdk7/build/hotspot/rev/fe62b51b93f4 Merge Changeset: 520d43965b1f Author: ikrylov Date: 2009-03-27 01:35 -0500 URL: http://hg.openjdk.java.net/jdk7/build/hotspot/rev/520d43965b1f 6812297: update project creation for Visual Studio 2005-2008 Summary: Add 2 news classes to create VC8 and VC9 projects Reviewed-by: apetrusenko, xlu ! make/windows/build_vm_def.sh ! make/windows/create.bat ! make/windows/makefiles/adlc.make ! make/windows/makefiles/compile.make ! make/windows/makefiles/makedeps.make ! make/windows/makefiles/rules.make ! src/share/tools/MakeDeps/WinGammaPlatformVC7.java + src/share/tools/MakeDeps/WinGammaPlatformVC8.java + src/share/tools/MakeDeps/WinGammaPlatformVC9.java ! src/share/vm/utilities/globalDefinitions_visCPP.hpp Changeset: 0aeec7d15d30 Author: acorn Date: 2009-03-27 14:35 -0400 URL: http://hg.openjdk.java.net/jdk7/build/hotspot/rev/0aeec7d15d30 Merge Changeset: 00bcc4b01dde Author: trims Date: 2009-03-27 16:54 -0700 URL: http://hg.openjdk.java.net/jdk7/build/hotspot/rev/00bcc4b01dde Merge Changeset: 9ab385cb0c42 Author: trims Date: 2009-03-27 16:58 -0700 URL: http://hg.openjdk.java.net/jdk7/build/hotspot/rev/9ab385cb0c42 6823377: Bump HS15 build number to 04 Summary: Update the HS15 Build number to 04 Reviewed-by: jcoomes ! make/hotspot_version Changeset: 032c6af894da Author: trims Date: 2009-04-01 22:31 -0700 URL: http://hg.openjdk.java.net/jdk7/build/hotspot/rev/032c6af894da Merge Changeset: 5450320b9c27 Author: xdono Date: 2009-04-02 16:51 -0700 URL: http://hg.openjdk.java.net/jdk7/build/hotspot/rev/5450320b9c27 Added tag jdk7-b53 for changeset 032c6af894da ! .hgtags From xiomara.jayasena at sun.com Tue Apr 7 19:12:16 2009 From: xiomara.jayasena at sun.com (xiomara.jayasena at sun.com) Date: Tue, 07 Apr 2009 19:12:16 +0000 Subject: hg: jdk7/build/jaxp: Added tag jdk7-b53 for changeset e8837366d3fd Message-ID: <20090407191218.D7AB4E55B@hg.openjdk.java.net> Changeset: 946a9f0c4932 Author: xdono Date: 2009-04-02 16:51 -0700 URL: http://hg.openjdk.java.net/jdk7/build/jaxp/rev/946a9f0c4932 Added tag jdk7-b53 for changeset e8837366d3fd ! .hgtags From xiomara.jayasena at sun.com Tue Apr 7 19:17:06 2009 From: xiomara.jayasena at sun.com (xiomara.jayasena at sun.com) Date: Tue, 07 Apr 2009 19:17:06 +0000 Subject: hg: jdk7/build/jaxws: Added tag jdk7-b53 for changeset b250218eb2e5 Message-ID: <20090407191709.0108CE560@hg.openjdk.java.net> Changeset: 50ea00dc5f14 Author: xdono Date: 2009-04-02 16:51 -0700 URL: http://hg.openjdk.java.net/jdk7/build/jaxws/rev/50ea00dc5f14 Added tag jdk7-b53 for changeset b250218eb2e5 ! .hgtags From xiomara.jayasena at sun.com Tue Apr 7 19:21:30 2009 From: xiomara.jayasena at sun.com (xiomara.jayasena at sun.com) Date: Tue, 07 Apr 2009 19:21:30 +0000 Subject: hg: jdk7/build/jdk: 2 new changesets Message-ID: <20090407192212.71242E571@hg.openjdk.java.net> Changeset: 8536cdffa32e Author: xdono Date: 2009-04-02 16:51 -0700 URL: http://hg.openjdk.java.net/jdk7/build/jdk/rev/8536cdffa32e Added tag jdk7-b53 for changeset a2033addca67 ! .hgtags Changeset: f3381dd0f7cd Author: xdono Date: 2009-04-07 11:43 -0700 URL: http://hg.openjdk.java.net/jdk7/build/jdk/rev/f3381dd0f7cd Merge From xiomara.jayasena at sun.com Tue Apr 7 19:32:43 2009 From: xiomara.jayasena at sun.com (xiomara.jayasena at sun.com) Date: Tue, 07 Apr 2009 19:32:43 +0000 Subject: hg: jdk7/build/langtools: Added tag jdk7-b53 for changeset dbdeb4a7581b Message-ID: <20090407193248.6ED7FE579@hg.openjdk.java.net> Changeset: 197a7f881937 Author: xdono Date: 2009-04-02 16:52 -0700 URL: http://hg.openjdk.java.net/jdk7/build/langtools/rev/197a7f881937 Added tag jdk7-b53 for changeset dbdeb4a7581b ! .hgtags From Kelly.Ohair at Sun.COM Tue Apr 7 21:14:11 2009 From: Kelly.Ohair at Sun.COM (Kelly O'Hair) Date: Tue, 07 Apr 2009 14:14:11 -0700 Subject: Arrgh... more path issues? In-Reply-To: <04ef01c9af73$34277230$9c765690$@com> References: <04ef01c9af73$34277230$9c765690$@com> Message-ID: <49DBC223.9040008@sun.com> Sorry on the slow replies, my mail box is overflowing... comments below... Ted Neward wrote: > Let me guess: this is because the jar utility doesn?t like Cygwin paths?? > Exactly. Nothing using Java will understand CYGWIN paths. That includes java, javah, javac, and ant. That last one 'ant' is important. Any path seen my 'ant' will need to be one that java can understand. I tend to favor the C:/ style paths over C:\. You can translate any path to that style with 'cygpath -m'. The catch-22 is that some GNU make's don't like any of the C: or drive letter paths when used as the target name in a makefile rule. So you get a path to insanity :^( * GNU make doesn't like C: paths in some situations (unless you get the right make.exe, which is what I recommend) * Shell scripts don't like C:\ paths * Ant and Java only like C: paths * Windows exe's only like C: paths * Some Windows exe's only like C:\ paths (like NMAKE.EXE) -kto > > > (cd C:/Prg/jdk1.7.0/build-fastdebug/classes && C:/Prg/jdk1.6.0/bin/jar > xf /cygd > > rive/c/Prg/OpenJDK/openjdk-binary-plugs/jre/lib/rt-closed.jar > @C:/Prg/jdk1.7.0/b > > uild-fastdebug/tmp/java/plugs/jmf.clist -J-client -J-Xmx383m -J-Xms128m > -J-XX:Pe > > rmSize=32m -J-XX:MaxPermSize=160m ) > > java.io.FileNotFoundException: > \cygdrive\c\Prg\OpenJDK\openjdk-binary-plugs\jre\ > > lib\rt-closed.jar (The system cannot find the path specified) > > at java.io.FileInputStream.open(Native Method) > > at java.io.FileInputStream.(FileInputStream.java:106) > > at java.io.FileInputStream.(FileInputStream.java:66) > > at sun.tools.jar.Main.run(Main.java:205) > > at sun.tools.jar.Main.main(Main.java:1022) > > make[5]: *** [import-binary-plug-jmf-classes] Error 1 > > make[5]: Leaving directory > `/cygdrive/c/Prg/OpenJDK/openjdk/jdk/make/java/redist > > ' > > make[4]: *** [all] Error 1 > > > > > > I would suggest, as an RFE or bug, that the various macros used on > Windows have some kind of naming convention to them to indicate where a > Cygwin path is needed, where an MS-style path is needed, and where it > makes no difference. (But I have no offhand suggestions as to what that > naming convention would look like, or how it might interact with the > build macros for other platforms.) There?s just GOT to be some kind of > way to tell these apart, though. :-/ > > > > Ted Neward | Principal Consultant, ThoughtWorks > > Java, .NET, XML Services > > Consulting, Teaching, Speaking, Writing > > http://www.thoughtworks.com | > http://www.tedneward.com > > > > > From xiomara.jayasena at sun.com Tue Apr 7 21:11:53 2009 From: xiomara.jayasena at sun.com (xiomara.jayasena at sun.com) Date: Tue, 07 Apr 2009 21:11:53 +0000 Subject: hg: jdk7/build/jdk: 31 new changesets Message-ID: <20090407212047.0194CE5C0@hg.openjdk.java.net> Changeset: 9d14b0582e1a Author: bae Date: 2008-12-12 17:38 +0300 URL: http://hg.openjdk.java.net/jdk7/build/jdk/rev/9d14b0582e1a 5106550: PNG writer merge standard metadata fails for TextEntry sans #IMPLIED attributes Reviewed-by: igor, prr Contributed-by: Martin von Gagern ! src/share/classes/com/sun/imageio/plugins/png/PNGMetadata.java + test/javax/imageio/plugins/png/MergeStdCommentTest.java Changeset: 11d333de082f Author: igor Date: 2008-12-17 22:00 +0300 URL: http://hg.openjdk.java.net/jdk7/build/jdk/rev/11d333de082f 6761791: Crash in the FontManager code due to use of JNIEnv saved by another thread Reviewed-by: bae, prr ! src/share/native/sun/font/freetypeScaler.c Changeset: feee56c07a8a Author: prr Date: 2008-12-18 11:25 -0800 URL: http://hg.openjdk.java.net/jdk7/build/jdk/rev/feee56c07a8a 6708137: Remove obsolete fontconfig.98.properties from JDK 7 Reviewed-by: jgodinez, naoto ! make/sun/awt/Makefile ! src/windows/classes/sun/awt/windows/WFontConfiguration.java - src/windows/classes/sun/awt/windows/fontconfig.98.properties - src/windows/classes/sun/awt/windows/fontconfig.Me.properties Changeset: f68864fe53d3 Author: prr Date: 2008-12-24 09:53 -0800 URL: http://hg.openjdk.java.net/jdk7/build/jdk/rev/f68864fe53d3 6728838: Native memory leak in StrikeCache.java Reviewed-by: bae, igor ! src/share/classes/sun/font/StrikeCache.java Changeset: 40ec164889bd Author: prr Date: 2008-12-24 09:57 -0800 URL: http://hg.openjdk.java.net/jdk7/build/jdk/rev/40ec164889bd 6752638: java.awt.GraphicsEnvironment.preferLocaleFonts() throws NPE on Linux 6755034: Legal notice repair: jdk/src/solaris/classes/sun/font/FcFontConfiguration.java Reviewed-by: bae, igor ! src/share/classes/java/awt/GraphicsEnvironment.java ! src/share/classes/sun/awt/FontConfiguration.java ! src/solaris/classes/sun/font/FcFontConfiguration.java + test/java/awt/GraphicsEnvironment/PreferLocaleFonts.java Changeset: eaeaacda1c56 Author: prr Date: 2009-01-06 13:52 -0800 URL: http://hg.openjdk.java.net/jdk7/build/jdk/rev/eaeaacda1c56 6785424: SecurityException locating physical fonts on Windows Terminal Server Reviewed-by: campbell, jgodinez ! src/share/classes/sun/font/FontManager.java + test/java/awt/FontClass/FontAccess.java Changeset: 91bc016862c4 Author: prr Date: 2009-01-12 16:02 -0800 URL: http://hg.openjdk.java.net/jdk7/build/jdk/rev/91bc016862c4 6752622: java.awt.Font.getPeer throws "java.lang.InternalError: Not implemented" on Linux Reviewed-by: igor, yan ! src/solaris/classes/sun/awt/X11/XFontPeer.java ! src/solaris/classes/sun/font/FcFontConfiguration.java Changeset: 80fb12052ae4 Author: bae Date: 2009-01-13 16:55 +0300 URL: http://hg.openjdk.java.net/jdk7/build/jdk/rev/80fb12052ae4 5082756: Image I/O plug-ins set metadata boolean attributes to "true" or "false" Reviewed-by: igor, prr Contributed-by: Martin von Gagern ! src/share/classes/com/sun/imageio/plugins/gif/GIFImageMetadata.java ! src/share/classes/com/sun/imageio/plugins/gif/GIFMetadata.java ! src/share/classes/com/sun/imageio/plugins/gif/GIFStreamMetadata.java ! src/share/classes/com/sun/imageio/plugins/jpeg/JPEGMetadata.java ! src/share/classes/com/sun/imageio/plugins/png/PNGMetadata.java ! src/share/classes/javax/imageio/metadata/IIOMetadataFormat.java + test/javax/imageio/metadata/BooleanAttributes.java ! test/javax/imageio/plugins/png/ITXtTest.java Changeset: 62d33a33f9e0 Author: bae Date: 2009-01-13 18:38 +0300 URL: http://hg.openjdk.java.net/jdk7/build/jdk/rev/62d33a33f9e0 6782079: PNG: reading metadata may cause OOM on truncated images. Reviewed-by: igor, prr Contributed-by: Martin von Gagern ! src/share/classes/com/sun/imageio/plugins/png/PNGImageReader.java ! src/share/classes/com/sun/imageio/plugins/png/PNGImageWriter.java ! src/share/classes/com/sun/imageio/plugins/png/PNGMetadata.java + test/javax/imageio/plugins/png/ItxtUtf8Test.java Changeset: 774083387e81 Author: bae Date: 2009-01-15 13:55 +0300 URL: http://hg.openjdk.java.net/jdk7/build/jdk/rev/774083387e81 6788096: ImageIO SreamCloser causes memory leak in FX applets Reviewed-by: igor, prr ! src/share/classes/com/sun/imageio/stream/StreamCloser.java + test/javax/imageio/stream/StreamCloserLeak/run_test.sh + test/javax/imageio/stream/StreamCloserLeak/test/Main.java + test/javax/imageio/stream/StreamCloserLeak/testapp/Main.java Changeset: 828d4d5e7bf8 Author: bae Date: 2009-01-23 17:43 +0300 URL: http://hg.openjdk.java.net/jdk7/build/jdk/rev/828d4d5e7bf8 6795544: GIFImageWriter does not write the subImage of BufferedImage to a file correctly. Reviewed-by: igor, prr ! src/share/classes/com/sun/imageio/plugins/gif/GIFImageWriter.java + test/javax/imageio/plugins/gif/EncodeSubImageTest.java Changeset: 6d343a2795ca Author: bae Date: 2009-01-23 21:14 +0300 URL: http://hg.openjdk.java.net/jdk7/build/jdk/rev/6d343a2795ca 6793818: JpegImageReader is too greedy creating color profiles Reviewed-by: igor, prr ! src/share/classes/java/awt/color/ICC_Profile.java ! src/share/classes/sun/java2d/cmm/ProfileActivator.java ! src/share/classes/sun/java2d/cmm/ProfileDeferralMgr.java Changeset: 65cada5a8497 Author: jgodinez Date: 2009-01-28 09:38 -0800 URL: http://hg.openjdk.java.net/jdk7/build/jdk/rev/65cada5a8497 6793344: BasicStroke's first element dash pattern is not a dash Reviewed-by: igor, flar Contributed-by: Red Hat ! src/share/classes/sun/java2d/pisces/Dasher.java + test/sun/pisces/DashStrokeTest.java Changeset: 36da64dc6545 Author: bae Date: 2009-01-29 13:19 +0300 URL: http://hg.openjdk.java.net/jdk7/build/jdk/rev/36da64dc6545 6631559: Registration of ImageIO plugins should not cause loading of jpeg.dlli and cmm.dll Reviewed-by: igor, prr ! src/share/classes/com/sun/imageio/plugins/jpeg/JFIFMarkerSegment.java ! src/share/classes/com/sun/imageio/plugins/jpeg/JPEG.java ! src/share/classes/com/sun/imageio/plugins/jpeg/JPEGImageReader.java ! src/share/classes/com/sun/imageio/plugins/jpeg/JPEGImageReaderSpi.java ! src/share/classes/com/sun/imageio/plugins/jpeg/JPEGImageWriter.java ! src/share/classes/com/sun/imageio/plugins/jpeg/JPEGImageWriterSpi.java ! src/share/classes/com/sun/imageio/plugins/jpeg/JPEGMetadata.java ! src/share/classes/javax/imageio/ImageTypeSpecifier.java Changeset: a7836e00ad6b Author: lana Date: 2009-01-29 18:33 -0800 URL: http://hg.openjdk.java.net/jdk7/build/jdk/rev/a7836e00ad6b Merge - src/share/classes/com/sun/jmx/namespace/JMXNamespaceUtils.java - src/share/classes/sun/nio/cs/IBM437.java - src/share/classes/sun/nio/cs/IBM737.java - src/share/classes/sun/nio/cs/IBM775.java - src/share/classes/sun/nio/cs/IBM850.java - src/share/classes/sun/nio/cs/IBM852.java - src/share/classes/sun/nio/cs/IBM855.java - src/share/classes/sun/nio/cs/IBM857.java - src/share/classes/sun/nio/cs/IBM858.java - src/share/classes/sun/nio/cs/IBM862.java - src/share/classes/sun/nio/cs/IBM866.java - src/share/classes/sun/nio/cs/IBM874.java - src/share/classes/sun/nio/cs/ISO_8859_13.java - src/share/classes/sun/nio/cs/ISO_8859_15.java - src/share/classes/sun/nio/cs/ISO_8859_2.java - src/share/classes/sun/nio/cs/ISO_8859_4.java - src/share/classes/sun/nio/cs/ISO_8859_5.java - src/share/classes/sun/nio/cs/ISO_8859_7.java - src/share/classes/sun/nio/cs/ISO_8859_9.java - src/share/classes/sun/nio/cs/KOI8_R.java - src/share/classes/sun/nio/cs/KOI8_U.java - src/share/classes/sun/nio/cs/MS1250.java - src/share/classes/sun/nio/cs/MS1251.java - src/share/classes/sun/nio/cs/MS1252.java - src/share/classes/sun/nio/cs/MS1253.java - src/share/classes/sun/nio/cs/MS1254.java - src/share/classes/sun/nio/cs/MS1257.java - src/share/classes/sun/nio/cs/ext/IBM037.java - src/share/classes/sun/nio/cs/ext/IBM1006.java - src/share/classes/sun/nio/cs/ext/IBM1025.java - src/share/classes/sun/nio/cs/ext/IBM1026.java - src/share/classes/sun/nio/cs/ext/IBM1046.java - src/share/classes/sun/nio/cs/ext/IBM1047.java - src/share/classes/sun/nio/cs/ext/IBM1097.java - src/share/classes/sun/nio/cs/ext/IBM1098.java - src/share/classes/sun/nio/cs/ext/IBM1112.java - src/share/classes/sun/nio/cs/ext/IBM1122.java - src/share/classes/sun/nio/cs/ext/IBM1123.java - src/share/classes/sun/nio/cs/ext/IBM1124.java - src/share/classes/sun/nio/cs/ext/IBM1140.java - src/share/classes/sun/nio/cs/ext/IBM1141.java - src/share/classes/sun/nio/cs/ext/IBM1142.java - src/share/classes/sun/nio/cs/ext/IBM1143.java - src/share/classes/sun/nio/cs/ext/IBM1144.java - src/share/classes/sun/nio/cs/ext/IBM1145.java - src/share/classes/sun/nio/cs/ext/IBM1146.java - src/share/classes/sun/nio/cs/ext/IBM1147.java - src/share/classes/sun/nio/cs/ext/IBM1148.java - src/share/classes/sun/nio/cs/ext/IBM1149.java - src/share/classes/sun/nio/cs/ext/IBM273.java - src/share/classes/sun/nio/cs/ext/IBM277.java - src/share/classes/sun/nio/cs/ext/IBM278.java - src/share/classes/sun/nio/cs/ext/IBM280.java - src/share/classes/sun/nio/cs/ext/IBM284.java - src/share/classes/sun/nio/cs/ext/IBM285.java - src/share/classes/sun/nio/cs/ext/IBM297.java - src/share/classes/sun/nio/cs/ext/IBM420.java - src/share/classes/sun/nio/cs/ext/IBM424.java - src/share/classes/sun/nio/cs/ext/IBM500.java - src/share/classes/sun/nio/cs/ext/IBM838.java - src/share/classes/sun/nio/cs/ext/IBM856.java - src/share/classes/sun/nio/cs/ext/IBM860.java - src/share/classes/sun/nio/cs/ext/IBM861.java - src/share/classes/sun/nio/cs/ext/IBM863.java - src/share/classes/sun/nio/cs/ext/IBM864.java - src/share/classes/sun/nio/cs/ext/IBM865.java - src/share/classes/sun/nio/cs/ext/IBM868.java - src/share/classes/sun/nio/cs/ext/IBM869.java - src/share/classes/sun/nio/cs/ext/IBM870.java - src/share/classes/sun/nio/cs/ext/IBM871.java - src/share/classes/sun/nio/cs/ext/IBM875.java - src/share/classes/sun/nio/cs/ext/IBM918.java - src/share/classes/sun/nio/cs/ext/IBM921.java - src/share/classes/sun/nio/cs/ext/IBM922.java - src/share/classes/sun/nio/cs/ext/ISO_8859_11.java - src/share/classes/sun/nio/cs/ext/ISO_8859_3.java - src/share/classes/sun/nio/cs/ext/ISO_8859_6.java - src/share/classes/sun/nio/cs/ext/ISO_8859_8.java - src/share/classes/sun/nio/cs/ext/MS1255.java - src/share/classes/sun/nio/cs/ext/MS1256.java - src/share/classes/sun/nio/cs/ext/MS1258.java - src/share/classes/sun/nio/cs/ext/MS874.java - src/share/classes/sun/nio/cs/ext/MacArabic.java - src/share/classes/sun/nio/cs/ext/MacCentralEurope.java - src/share/classes/sun/nio/cs/ext/MacCroatian.java - src/share/classes/sun/nio/cs/ext/MacCyrillic.java - src/share/classes/sun/nio/cs/ext/MacDingbat.java - src/share/classes/sun/nio/cs/ext/MacGreek.java - src/share/classes/sun/nio/cs/ext/MacHebrew.java - src/share/classes/sun/nio/cs/ext/MacIceland.java - src/share/classes/sun/nio/cs/ext/MacRoman.java - src/share/classes/sun/nio/cs/ext/MacRomania.java - src/share/classes/sun/nio/cs/ext/MacSymbol.java - src/share/classes/sun/nio/cs/ext/MacThai.java - src/share/classes/sun/nio/cs/ext/MacTurkish.java - src/share/classes/sun/nio/cs/ext/MacUkraine.java - src/share/classes/sun/nio/cs/ext/TIS_620.java Changeset: f0978a1137fe Author: bae Date: 2009-01-30 22:30 +0300 URL: http://hg.openjdk.java.net/jdk7/build/jdk/rev/f0978a1137fe 6791502: IIOException "Invalid icc profile" on jpeg after update from JDK5 to JDK6 Reviewed-by: igor, prr ! src/share/native/sun/awt/image/jpeg/imageioJPEG.c Changeset: e0a9038939ee Author: bae Date: 2009-02-04 14:06 +0300 URL: http://hg.openjdk.java.net/jdk7/build/jdk/rev/e0a9038939ee 6799583: LogManager shutdown hook may cause a memory leak. Reviewed-by: igor, swamyv ! src/share/classes/java/util/logging/LogManager.java + test/java/util/logging/ClassLoaderLeakTest.java Changeset: b02162077f24 Author: bae Date: 2009-02-06 20:49 +0300 URL: http://hg.openjdk.java.net/jdk7/build/jdk/rev/b02162077f24 6800846: REGRESSION: Printing quality degraded with Java 6 compared to 5.0 Reviewed-by: igor, prr ! src/share/native/sun/awt/image/dither.c + test/sun/awt/image/DrawByteBinary.java Changeset: ff2afd0551c9 Author: jgodinez Date: 2009-02-24 14:32 -0800 URL: http://hg.openjdk.java.net/jdk7/build/jdk/rev/ff2afd0551c9 6750383: 2D_PrintingTiger\PrintDocOrientationTest fails, wrong orientated images are printed Reviewed-by: campbell, prr ! src/solaris/classes/sun/print/IPPPrintService.java ! src/solaris/classes/sun/print/UnixPrintJob.java Changeset: 0c856354b669 Author: tdv Date: 2009-02-26 13:38 -0800 URL: http://hg.openjdk.java.net/jdk7/build/jdk/rev/0c856354b669 6791612: OGLBat tests are failed in jdk 7 b42 Reviewed-by: tdv Contributed-by: ceisserer ! make/sun/xawt/mapfile-vers Changeset: c32ec45b582d Author: lana Date: 2009-03-04 10:57 -0800 URL: http://hg.openjdk.java.net/jdk7/build/jdk/rev/c32ec45b582d Merge - make/javax/sound/jsoundhs/FILES.gmk - make/javax/sound/jsoundhs/Makefile - make/javax/sound/jsoundhs/mapfile-vers ! make/sun/awt/Makefile ! make/sun/xawt/mapfile-vers - src/share/classes/com/sun/beans/ObjectHandler.java - src/share/lib/audio/soundbank.gm - src/solaris/classes/sun/nio/ch/FileDispatcher.java - src/solaris/native/sun/nio/ch/FileDispatcher.c - src/windows/classes/sun/nio/ch/FileDispatcher.java - src/windows/native/sun/nio/ch/FileDispatcher.c - src/windows/native/sun/windows/UnicowsLoader.cpp - src/windows/native/sun/windows/UnicowsLoader.h - src/windows/native/sun/windows/awt_MMStub.cpp - src/windows/native/sun/windows/awt_MMStub.h - src/windows/native/sun/windows/awt_Multimon.h - src/windows/native/sun/windows/awt_Unicode.cpp - src/windows/native/sun/windows/awt_Unicode.h - src/windows/native/sun/windows/awt_dlls.cpp - src/windows/native/sun/windows/awt_dlls.h Changeset: 8d5144dfc642 Author: jgodinez Date: 2009-03-05 10:56 -0800 URL: http://hg.openjdk.java.net/jdk7/build/jdk/rev/8d5144dfc642 6735296: Regression: Common print dialog does not show the correct page orientation Reviewed-by: tdv, prr ! src/share/classes/sun/print/ServiceDialog.java Changeset: 59696dfd5455 Author: prr Date: 2009-03-12 12:01 -0700 URL: http://hg.openjdk.java.net/jdk7/build/jdk/rev/59696dfd5455 6727719: Performance of TextLayout.getBounds() Reviewed-by: jgodinez, dougfelt ! src/share/classes/sun/font/FileFontStrike.java Changeset: 9318628e8eee Author: jgodinez Date: 2009-03-16 11:46 -0700 URL: http://hg.openjdk.java.net/jdk7/build/jdk/rev/9318628e8eee 6812600: The miter line join decoration isn't rendered properly Reviewed-by: avu, flar Contributed-by: Google ! src/share/classes/sun/java2d/pisces/PiscesRenderingEngine.java + test/sun/pisces/JoinMiterTest.java Changeset: 467e4f25965c Author: avu Date: 2009-03-20 20:05 +0300 URL: http://hg.openjdk.java.net/jdk7/build/jdk/rev/467e4f25965c 6733501: Apply IcedTea little cms patches Reviewed-by: bae, prr ! src/share/native/sun/java2d/cmm/lcms/LCMS.c ! src/share/native/sun/java2d/cmm/lcms/cmsio0.c ! src/share/native/sun/java2d/cmm/lcms/lcms.h + test/sun/java2d/cmm/ProfileOp/ReadWriteProfileTest.java Changeset: e43ea83ca696 Author: prr Date: 2009-03-23 10:40 -0700 URL: http://hg.openjdk.java.net/jdk7/build/jdk/rev/e43ea83ca696 6745225: Memory leak while drawing Attributed String Reviewed-by: jgodinez, dougfelt ! src/share/classes/sun/font/FileFontStrike.java ! src/share/classes/sun/font/GlyphLayout.java + test/java/awt/font/LineBreakMeasurer/FRCTest.java Changeset: e2cc7ffbb355 Author: prr Date: 2009-03-24 09:14 -0700 URL: http://hg.openjdk.java.net/jdk7/build/jdk/rev/e2cc7ffbb355 6821031: Upgrade OpenJDK's LittleCMS version to 1.18 Reviewed-by: bae, igor ! src/share/native/sun/java2d/cmm/lcms/LCMS.c ! src/share/native/sun/java2d/cmm/lcms/cmscam02.c ! src/share/native/sun/java2d/cmm/lcms/cmscam97.c ! src/share/native/sun/java2d/cmm/lcms/cmscgats.c ! src/share/native/sun/java2d/cmm/lcms/cmscnvrt.c ! src/share/native/sun/java2d/cmm/lcms/cmserr.c ! src/share/native/sun/java2d/cmm/lcms/cmsgamma.c ! src/share/native/sun/java2d/cmm/lcms/cmsgmt.c ! src/share/native/sun/java2d/cmm/lcms/cmsintrp.c ! src/share/native/sun/java2d/cmm/lcms/cmsio0.c ! src/share/native/sun/java2d/cmm/lcms/cmsio1.c ! src/share/native/sun/java2d/cmm/lcms/cmslut.c ! src/share/native/sun/java2d/cmm/lcms/cmsmatsh.c ! src/share/native/sun/java2d/cmm/lcms/cmsmtrx.c ! src/share/native/sun/java2d/cmm/lcms/cmsnamed.c ! src/share/native/sun/java2d/cmm/lcms/cmspack.c ! src/share/native/sun/java2d/cmm/lcms/cmspcs.c ! src/share/native/sun/java2d/cmm/lcms/cmsps2.c ! src/share/native/sun/java2d/cmm/lcms/cmssamp.c ! src/share/native/sun/java2d/cmm/lcms/cmsvirt.c ! src/share/native/sun/java2d/cmm/lcms/cmswtpnt.c ! src/share/native/sun/java2d/cmm/lcms/cmsxform.c ! src/share/native/sun/java2d/cmm/lcms/icc34.h ! src/share/native/sun/java2d/cmm/lcms/lcms.h Changeset: 0c69e3ba15f4 Author: prr Date: 2009-03-24 10:53 -0700 URL: http://hg.openjdk.java.net/jdk7/build/jdk/rev/0c69e3ba15f4 6821504: typo in lcmsio.c Reviewed-by: jgodinez ! src/share/native/sun/java2d/cmm/lcms/cmsio0.c Changeset: 8e36b37745d4 Author: lana Date: 2009-03-24 19:12 -0700 URL: http://hg.openjdk.java.net/jdk7/build/jdk/rev/8e36b37745d4 Merge - src/windows/classes/sun/awt/windows/fontconfig.98.properties - src/windows/classes/sun/awt/windows/fontconfig.Me.properties Changeset: 6ee1e2a1a833 Author: lana Date: 2009-04-07 10:04 -0700 URL: http://hg.openjdk.java.net/jdk7/build/jdk/rev/6ee1e2a1a833 Merge - src/windows/classes/sun/awt/windows/fontconfig.98.properties - src/windows/classes/sun/awt/windows/fontconfig.Me.properties Changeset: d1c43d1f5676 Author: xdono Date: 2009-04-07 14:02 -0700 URL: http://hg.openjdk.java.net/jdk7/build/jdk/rev/d1c43d1f5676 Merge - src/windows/classes/sun/awt/windows/fontconfig.98.properties - src/windows/classes/sun/awt/windows/fontconfig.Me.properties From Kelly.Ohair at Sun.COM Tue Apr 7 21:22:41 2009 From: Kelly.Ohair at Sun.COM (Kelly O'Hair) Date: Tue, 07 Apr 2009 14:22:41 -0700 Subject: Where do COMPILER_VERSION and its ilk get set? In-Reply-To: <04c601c9af50$f3e27980$dba76c80$@com> References: <04c601c9af50$f3e27980$dba76c80$@com> Message-ID: <49DBC421.1090903@sun.com> This problem should be fixed with this changeset: http://hg.openjdk.java.net/jdk7/jdk7/hotspot/rev/c3a720eefe82 http://hg.openjdk.java.net/jdk7/build/hotspot/rev/c3a720eefe82 Let me know if it still happens after refreshing from the latest jdk7/jdk7 master or jdk7/build repos. -kto Ted Neward wrote: > Getting > > > > *** WARNING *** unrecognized cl.exe version 1500 (). Use FORCE_MSC_VER > to overri > > de automatic detection. > > *** WARNING *** unrecognized link.exe version 900 (). Use FORCE_LINK_VER > to over > > ride automatic detection. > > > > Warnings from Hotspot make?. Where would I look to fix those? > > > > Ted Neward | Principal Consultant, ThoughtWorks > > Java, .NET, XML Services > > Consulting, Teaching, Speaking, Writing > > http://www.thoughtworks.com | > http://www.tedneward.com > > > > > From lsliu0507 at gmail.com Wed Apr 8 04:17:29 2009 From: lsliu0507 at gmail.com (Liu lianshun) Date: Wed, 8 Apr 2009 12:17:29 +0800 Subject: some puzzles about Openjdk Message-ID: Hi, I've some puzzles from my recent learning about OpenJDK7.0. Firstly, I want to know that whether I can change the java programes' behavior via changing some source files in OpenJDK, for examples, execute the following codes will print "100". int i=100; System.out.println(i); My question is that how to print "200", without changing the source codes. Is it possible? Secondly, the number of files in the OpenJDK project is very large, I want to know how these files are structured. Besides, how can I debug the project? For examples, When I run HelloWorld, I use the command "java HelloWorld", I want to know how the OpenJDK interpret this command, I think the best way is reading the source codes, but I don't know where to start. Best regards, Lianshun Liu -------------- next part -------------- An HTML attachment was scrubbed... URL: From Dalibor.Topic at Sun.COM Wed Apr 8 13:03:59 2009 From: Dalibor.Topic at Sun.COM (Dalibor Topic) Date: Wed, 08 Apr 2009 15:03:59 +0200 Subject: some puzzles about Openjdk In-Reply-To: References: Message-ID: <49DCA0BF.7010002@sun.com> Liu lianshun wrote: > Firstly, I want to know that whether I can change the java programes' > behavior via changing some source files in OpenJDK, for examples, > execute the following codes will print "100". > int i=100; > System.out.println(i); > My question is that how to print "200", without changing the source > codes. Is it possible? Is it possible to change behavior of programs by changing the source code of OpenJDK? Yes. You can make them all crash very fast by doing something bad in the VM for example. ;) Is it possible to change behavior of programs without changing the source code of OpenJDK? Yes, check out aspect oriented programming using, for example, AspectJ. > Secondly, the number of files in the OpenJDK project is very large, I > want to know how these files are structured. Besides, how can I debug > the project? Volker Simonis wrote a couple of blog entries on how to get started hacking on the VM, starting with: http://weblogs.java.net/blog/simonis/archive/2008/01/hotspot_develop.html have fun! dalibor topic -- ******************************************************************* Dalibor Topic Tel: (+49 40) 23 646 738 Java F/OSS Ambassador AIM: robiladonaim Sun Microsystems GmbH Mobile: (+49 177) 2664 192 Nagelsweg 55 http://openjdk.java.net D-20097 Hamburg mailto:Dalibor.Topic at sun.com Sitz der Gesellschaft: Sonnenallee 1, D-85551 Kirchheim-Heimstetten Amtsgericht M?nchen: HRB 161028 Gesch?ftsf?hrer: Thomas Schr?der, Wolfgang Engels, Dr. Roland B?mer Vorsitzender des Aufsichtsrates: Martin H?ring From lsliu0507 at gmail.com Wed Apr 8 14:16:38 2009 From: lsliu0507 at gmail.com (Liu lianshun) Date: Wed, 8 Apr 2009 22:16:38 +0800 Subject: some puzzles about Openjdk References: <49DCA0BF.7010002@sun.com> Message-ID: <34B3D6DE620A4A259DF2D7F3FF20A817@AAA> Hi, Dalibor Topic Thanks very much for your reply. My first question is that, I want to change the java application's behavior, in the other words, manipulate the bytecodes of some class when running the application without changing the class file itself. Is it possible? Can this be done via hacking on the VM, and how? Thanks :) Bestwishes Lianshun Liu ----- Original Message ----- From: "Dalibor Topic" To: "Liu lianshun" Cc: Sent: Wednesday, April 08, 2009 9:03 PM Subject: Re: some puzzles about Openjdk > Liu lianshun wrote: >> Firstly, I want to know that whether I can change the java programes' >> behavior via changing some source files in OpenJDK, for examples, >> execute the following codes will print "100". >> int i=100; >> System.out.println(i); >> My question is that how to print "200", without changing the source >> codes. Is it possible? > > Is it possible to change behavior of programs by changing the > source code of OpenJDK? Yes. You can make them all crash > very fast by doing something bad in the VM for example. ;) > > Is it possible to change behavior of programs without changing the > source code of OpenJDK? Yes, check out aspect oriented programming > using, for example, AspectJ. > >> Secondly, the number of files in the OpenJDK project is very large, I >> want to know how these files are structured. Besides, how can I debug >> the project? > > Volker Simonis wrote a couple of blog entries on how to get started hacking > on the VM, starting with: > > http://weblogs.java.net/blog/simonis/archive/2008/01/hotspot_develop.html > > have fun! > > dalibor topic > > -- > ******************************************************************* > Dalibor Topic Tel: (+49 40) 23 646 738 > Java F/OSS Ambassador AIM: robiladonaim > Sun Microsystems GmbH Mobile: (+49 177) 2664 192 > Nagelsweg 55 http://openjdk.java.net > D-20097 Hamburg mailto:Dalibor.Topic at sun.com > Sitz der Gesellschaft: Sonnenallee 1, D-85551 Kirchheim-Heimstetten > Amtsgericht M?nchen: HRB 161028 > Gesch?ftsf?hrer: Thomas Schr?der, Wolfgang Engels, Dr. Roland B?mer > Vorsitzender des Aufsichtsrates: Martin H?ring > > From Alan.Bateman at Sun.COM Wed Apr 8 14:30:46 2009 From: Alan.Bateman at Sun.COM (Alan Bateman) Date: Wed, 08 Apr 2009 15:30:46 +0100 Subject: some puzzles about Openjdk In-Reply-To: <34B3D6DE620A4A259DF2D7F3FF20A817@AAA> References: <49DCA0BF.7010002@sun.com> <34B3D6DE620A4A259DF2D7F3FF20A817@AAA> Message-ID: <49DCB516.3020309@sun.com> Liu lianshun wrote: > Hi, Dalibor Topic > > Thanks very much for your reply. > My first question is that, I want to change the java application's behavior, in the other words, manipulate the bytecodes of some class when running the application without changing the class file itself. Is it possible? Can this be done via hacking on the VM, and how? Thanks :) > > Bestwishes > Lianshun Liu > An alternative to hacking the VM is to use a java agent (see java.lang.instrument) or a JVM TI agent. These APIs are designed for instrumentation purposes but could be used for load-time hacking or redefining classes at runtime. These APIs are often used in conjunction with bytecode manipulation libraries like BCEL. -Alan. From pdoubleya at gmail.com Wed Apr 8 14:58:49 2009 From: pdoubleya at gmail.com (Patrick Wright) Date: Wed, 8 Apr 2009 16:58:49 +0200 Subject: some puzzles about Openjdk In-Reply-To: <49DCB516.3020309@sun.com> References: <49DCA0BF.7010002@sun.com> <34B3D6DE620A4A259DF2D7F3FF20A817@AAA> <49DCB516.3020309@sun.com> Message-ID: <64efa1ba0904080758k3c70832anb27d119b5324573@mail.gmail.com> On Wed, Apr 8, 2009 at 4:30 PM, Alan Bateman wrote: > Liu lianshun wrote: >> My first question is that, I want to change the java application's >> behavior, in the other words, manipulate the bytecodes of some class when >> running the application without changing the class file itself. Is it >> possible? Can this be done via hacking on the ?VM, and how? Thanks :) > An alternative to hacking the VM is to use a java agent (see > java.lang.instrument) or a JVM TI agent. These APIs are designed for > instrumentation purposes but could be used for load-time hacking or > redefining classes at runtime. These APIs are often used in conjunction with > bytecode manipulation libraries like BCEL. Here's a nice, recent blog entry about various alternatives to manipulating bytecode on-the-fly, might give you some ideas http://weblogs.java.net/blog/simonis/archive/2009/02/we_need_a_dirty_1.html Patrick From lsliu0507 at gmail.com Wed Apr 8 17:32:30 2009 From: lsliu0507 at gmail.com (Liu lianshun) Date: Thu, 9 Apr 2009 01:32:30 +0800 Subject: some puzzles about Openjdk References: <49DCA0BF.7010002@sun.com> <34B3D6DE620A4A259DF2D7F3FF20A817@AAA> <49DCB516.3020309@sun.com> <64efa1ba0904080758k3c70832anb27d119b5324573@mail.gmail.com> Message-ID: <7710D2E6C44C4D0E8AEDC965D8EDF384@AAA> ----- Original Message ----- From: "Patrick Wright" To: "Liu lianshun" ; Sent: Wednesday, April 08, 2009 10:58 PM Subject: Re: some puzzles about Openjdk On Wed, Apr 8, 2009 at 4:30 PM, Alan Bateman wrote: > Liu lianshun wrote: >> My first question is that, I want to change the java application's >> behavior, in the other words, manipulate the bytecodes of some class when >> running the application without changing the class file itself. Is it >> possible? Can this be done via hacking on the VM, and how? Thanks :) > An alternative to hacking the VM is to use a java agent (see > java.lang.instrument) or a JVM TI agent. These APIs are designed for > instrumentation purposes but could be used for load-time hacking or > redefining classes at runtime. These APIs are often used in conjunction with > bytecode manipulation libraries like BCEL. Here's a nice, recent blog entry about various alternatives to manipulating bytecode on-the-fly, might give you some ideas http://weblogs.java.net/blog/simonis/archive/2009/02/we_need_a_dirty_1.html ----- ----- ----- ----- ----- ----- ----- ----- ----- ----- ----- ----- ----- ----- I've read the article written by Simonis. But the question solved in that article is different from mine. I want to change the Java Apps' behavior only via changing the source codes of the openjdk, though it may has some drawbacks, such as will not correctly execute the other apps. I have another question that, when running an app, we type "java app" on command line, I want to know that during the running process, what functions of VM are called, and the call relations. Thanks :) Best regards, Lianshun Liu From aph at redhat.com Thu Apr 9 13:14:46 2009 From: aph at redhat.com (Andrew Haley) Date: Thu, 09 Apr 2009 14:14:46 +0100 Subject: New project: getting rid of IcedTea local patches In-Reply-To: <49D3917B.2010907@redhat.com> References: <49D3917B.2010907@redhat.com> Message-ID: <49DDF4C6.1070602@redhat.com> Andrew Haley wrote: > We at Red Hat have noticed that the list of IcedTea local patches has > been getting large, with some local patches that should have been > pushed upstream. Also, some IcedTea patches have been committed to > OpenJDK 7 but not OpenJDK 6. > > So, we're going to have a serious attempt to minimize the number of > IcedTea patches. We'll create a Wiki page at icedtea.classpath.org > that is a list of the patches, and for every one we're going to > discuss whether it should stay IcedTea local, be pushed upstream to > OpenJDK, or be deleted altogether. Then we will create OpenJDK > bugzilla entries for the patches that we think should be integrated > upstream and work with Sun engineers to get that done. The page is at http://icedtea.classpath.org/wiki/IcedTea_JDK6_Patches These are the patches in icedtea/patches and icedtea/patches/hotspot. * Every patch should be assigned to someone. * Every patch should be discussed. * If we can, we will push a patch upstream. If we can't the discussion should explain why we can't. Here we go... Andrew. From Alan.Bateman at Sun.COM Thu Apr 9 14:20:50 2009 From: Alan.Bateman at Sun.COM (Alan Bateman) Date: Thu, 09 Apr 2009 15:20:50 +0100 Subject: New project: getting rid of IcedTea local patches In-Reply-To: <49DDF4C6.1070602@redhat.com> References: <49D3917B.2010907@redhat.com> <49DDF4C6.1070602@redhat.com> Message-ID: <49DE0442.6060802@sun.com> Andrew Haley wrote: > : > The page is at http://icedtea.classpath.org/wiki/IcedTea_JDK6_Patches > These are the patches in icedtea/patches and icedtea/patches/hotspot. > > > * Every patch should be assigned to someone. > > * Every patch should be discussed. > > * If we can, we will push a patch upstream. If we can't the discussion > should explain why we can't. > > Here we go... > > Andrew. > I'm not very familiar with IcedTea but I cloned the repository to see what these patches are about. Here are a few comments: icedtea-6728542-epoll.patch seems to be a change-set I pushed to jdk7 last year. It seems very reasonable to push this into jdk6/jdk6/jdk. Go for it! icedtea-bytebuffer-compact.patch - this looks to be a partial fix to 6593946. If so, 6593946 is already in jdk6/jdk6/jdk (http://hg.openjdk.java.net/jdk6/jdk6/jdk/rev/3e7bfcdcf96f). icedtea-io_util-overflow.patch - this looks like the initial fix for 6788196. Martin has already pushed this to jdk6/jdk7/jdk (http://hg.openjdk.java.net/jdk6/jdk6/jdk/rev/cc4d93e8ae7d). icedtea-jvmtiEnv.patch - I thought JvmtiEnv::GetLineNumberTable already handled this case so I'm curious why this one is needed. icedtea-network-unreachable.patch - I'm pretty sure net-dev would be open to this because it looks to be cases where the specific exceptions aren't thrown in the timed read case. icedtea-sunsrc.patch - I'm not sure what this is about but it looks like it removes the service configuration files. Does JDI still work? icedtea-testenv.patch - the changes to test/sun/net/InetAddress/nameservice/dns/cname.sh seems reasonable (pilot error is why this one was missed when the other tests were updated). icedtea-jtreg-hatrun.patch - I suspect this is 6545295. We should just fix this test (serviceability-dev). -Alan. PS: I'm not on distro-pkg-dev so this mail might need the moderator to approve. From gnu_andrew at member.fsf.org Thu Apr 9 15:05:09 2009 From: gnu_andrew at member.fsf.org (Andrew John Hughes) Date: Thu, 9 Apr 2009 16:05:09 +0100 Subject: New project: getting rid of IcedTea local patches In-Reply-To: <49DE0442.6060802@sun.com> References: <49D3917B.2010907@redhat.com> <49DDF4C6.1070602@redhat.com> <49DE0442.6060802@sun.com> Message-ID: <17c6771e0904090805y352a1e43nd5de8909f21c63a@mail.gmail.com> 2009/4/9 Alan Bateman : > Andrew Haley wrote: >> >> : >> The page is at http://icedtea.classpath.org/wiki/IcedTea_JDK6_Patches >> These are the patches in icedtea/patches and icedtea/patches/hotspot. >> >> >> * Every patch should be assigned to someone. >> >> * Every patch should be discussed. >> >> * If we can, we will push a patch upstream. ?If we can't the discussion >> ?should explain why we can't. >> >> Here we go... >> >> Andrew. >> > > I'm not very familiar with IcedTea but I cloned the repository to see what > these patches are about. Here are a few comments: > > icedtea-6728542-epoll.patch seems to be a change-set I pushed to jdk7 last > year. It seems very reasonable to push this into jdk6/jdk6/jdk. Go for it! > > icedtea-bytebuffer-compact.patch - this looks to be a partial fix to > 6593946. If so, 6593946 is already in jdk6/jdk6/jdk > (http://hg.openjdk.java.net/jdk6/jdk6/jdk/rev/3e7bfcdcf96f). > > icedtea-io_util-overflow.patch - this looks like the initial fix for > 6788196. Martin has already pushed this to jdk6/jdk7/jdk > (http://hg.openjdk.java.net/jdk6/jdk6/jdk/rev/cc4d93e8ae7d). > > icedtea-jvmtiEnv.patch - I thought JvmtiEnv::GetLineNumberTable already > handled this case so I'm curious why this one is needed. > > icedtea-network-unreachable.patch - I'm pretty sure net-dev would be open to > this because it looks to be cases where the specific exceptions aren't > thrown in the timed read case. > > icedtea-sunsrc.patch - I'm not sure what this is about but it looks like it > removes the service configuration files. Does JDI still work? > > icedtea-testenv.patch - the changes to > test/sun/net/InetAddress/nameservice/dns/cname.sh seems reasonable (pilot > error is why this one was missed when the other tests were updated). > > icedtea-jtreg-hatrun.patch - I suspect this is 6545295. We should just fix > this test (serviceability-dev). > > -Alan. > > PS: I'm not on distro-pkg-dev so this mail might need the moderator to > approve. > > Woah, thanks for the quick response on this :) I'll have a quick look at these after the conf. call but good to know a few are possibles for going in. I've just been trying to write off a few low-hanging fruits that I know are in OpenJDK7, or don't need to be pushed. Thanks again, -- Andrew :-) Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) Support Free Java! Contribute to GNU Classpath and the OpenJDK http://www.gnu.org/software/classpath http://openjdk.java.net PGP Key: 94EFD9D8 (http://subkeys.pgp.net) Fingerprint: F8EF F1EA 401E 2E60 15FA 7927 142C 2591 94EF D9D8 From aph at redhat.com Thu Apr 9 15:17:48 2009 From: aph at redhat.com (Andrew Haley) Date: Thu, 09 Apr 2009 16:17:48 +0100 Subject: New project: getting rid of IcedTea local patches In-Reply-To: <49DE10A2.8090108@ubuntu.com> References: <49D3917B.2010907@redhat.com> <49DDF4C6.1070602@redhat.com> <49DE10A2.8090108@ubuntu.com> Message-ID: <49DE119C.3030802@redhat.com> Matthias Klose wrote: > Andrew Haley schrieb: >> The page is at http://icedtea.classpath.org/wiki/IcedTea_JDK6_Patches > >> SCA: Enter "OK" here if you are certain that all authors of this patch have an >> SCA on file. > > this is not correct. AFAIU all authors of the patch have to submit the patch > under the SCA, just having an SCA on file is not enough. OK. SO, the problem is that maybe the authors of the patch who have signed the SCA might not be willing to submit the same patch upstream? It's not possible for more than one person to submit a particular patch: only one person can do it. Anyway, if any suitable patch hasn't been submitted upstream we'll ask the author. Andrew. From doko at ubuntu.com Thu Apr 9 15:13:38 2009 From: doko at ubuntu.com (Matthias Klose) Date: Thu, 09 Apr 2009 17:13:38 +0200 Subject: New project: getting rid of IcedTea local patches In-Reply-To: <49DDF4C6.1070602@redhat.com> References: <49D3917B.2010907@redhat.com> <49DDF4C6.1070602@redhat.com> Message-ID: <49DE10A2.8090108@ubuntu.com> Andrew Haley schrieb: > The page is at http://icedtea.classpath.org/wiki/IcedTea_JDK6_Patches > SCA: Enter "OK" here if you are certain that all authors of this patch have an > SCA on file. this is not correct. AFAIU all authors of the patch have to submit the patch under the SCA, just having an SCA on file is not enough. Matthias From gnu_andrew at member.fsf.org Thu Apr 9 16:36:20 2009 From: gnu_andrew at member.fsf.org (Andrew John Hughes) Date: Thu, 9 Apr 2009 17:36:20 +0100 Subject: New project: getting rid of IcedTea local patches In-Reply-To: <49D3A3C3.9090104@sun.com> References: <49D3917B.2010907@redhat.com> <49D3A3C3.9090104@sun.com> Message-ID: <17c6771e0904090936j4dbac23mc25b73319e9badfe@mail.gmail.com> 2009/4/1 Joseph D. Darcy : > Andrew Haley wrote: >> >> We at Red Hat have noticed that the list of IcedTea local patches has >> been getting large, with some local patches that should have been >> pushed upstream. ?Also, some IcedTea patches have been committed to >> OpenJDK 7 but not OpenJDK 6. >> >> So, we're going to have a serious attempt to minimize the number of >> IcedTea patches. ?We'll create a Wiki page at icedtea.classpath.org >> that is a list of the patches, and for every one we're going to >> discuss whether it should stay IcedTea local, be pushed upstream to >> OpenJDK, or be deleted altogether. ?Then we will create OpenJDK >> bugzilla entries for the patches that we think should be integrated >> upstream and work with Sun engineers to get that done. >> >> I hope that it will be possible to reduce the number of patches to a >> fraction of what we have at the moment, while improving the quality of >> the upstream product. >> >> This is going to be quite a lot of work, so we'd appreciate help from >> anyone. >> >> I hope this will meet with everyone's approval. >> > > Sounds good to me! > > -Joe > Joe, FWIW, https://bugs.openjdk.java.net/show_bug.cgi?id=100036 is currently the only patch needed for OpenJDK6 to build out of the box on Fedora 10. Would be nice if it was applied. Even nicer if one of us could try and commit it after your approval :) -- Andrew :-) Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) Support Free Java! Contribute to GNU Classpath and the OpenJDK http://www.gnu.org/software/classpath http://openjdk.java.net PGP Key: 94EFD9D8 (http://subkeys.pgp.net) Fingerprint: F8EF F1EA 401E 2E60 15FA 7927 142C 2591 94EF D9D8 From gnu_andrew at member.fsf.org Thu Apr 9 17:55:55 2009 From: gnu_andrew at member.fsf.org (Andrew John Hughes) Date: Thu, 9 Apr 2009 18:55:55 +0100 Subject: New project: getting rid of IcedTea local patches In-Reply-To: <49DE0442.6060802@sun.com> References: <49D3917B.2010907@redhat.com> <49DDF4C6.1070602@redhat.com> <49DE0442.6060802@sun.com> Message-ID: <17c6771e0904091055w7c14a9adg982e0ff37a55e0a4@mail.gmail.com> 2009/4/9 Alan Bateman : > Andrew Haley wrote: >> >> : >> The page is at http://icedtea.classpath.org/wiki/IcedTea_JDK6_Patches >> These are the patches in icedtea/patches and icedtea/patches/hotspot. >> >> >> * Every patch should be assigned to someone. >> >> * Every patch should be discussed. >> >> * If we can, we will push a patch upstream. ?If we can't the discussion >> ?should explain why we can't. >> >> Here we go... >> >> Andrew. >> > > I'm not very familiar with IcedTea but I cloned the repository to see what > these patches are about. Here are a few comments: > > icedtea-6728542-epoll.patch seems to be a change-set I pushed to jdk7 last > year. It seems very reasonable to push this into jdk6/jdk6/jdk. Go for it! > Yes, I've referenced the bug on the wiki now. Joe, can we commit this to 6? > icedtea-bytebuffer-compact.patch - this looks to be a partial fix to > 6593946. If so, 6593946 is already in jdk6/jdk6/jdk > (http://hg.openjdk.java.net/jdk6/jdk6/jdk/rev/3e7bfcdcf96f). > IcedTea6 is still based on the last build drop of jdk6, not the Mercurial repository. So this 6 week old patch won't be in the 25th of November b14 tarball. Interestingly, it also still exists in IcedTea7 as there were cases covered by the patch which didn't make it into the commit. I've attached that version. It was originally added by Keith Seitz while he was working on OpenJDK at Red Hat (according to the ChangeLog). > icedtea-io_util-overflow.patch - this looks like the initial fix for > 6788196. Martin has already pushed this to jdk6/jdk7/jdk > (http://hg.openjdk.java.net/jdk6/jdk6/jdk/rev/cc4d93e8ae7d). > Same case as the epoll patch, not in b14. > icedtea-jvmtiEnv.patch - I thought JvmtiEnv::GetLineNumberTable already > handled this case so I'm curious why this one is needed. > Added by Andrew Haley as part of work on Shark; perhaps he can explain. > icedtea-network-unreachable.patch - I'm pretty sure net-dev would be open to > this because it looks to be cases where the specific exceptions aren't > thrown in the timed read case. > >From our intern, Omair so this is covered by the SCA. Omair, maybe you could file a bug report for this (or link to one here if there is one)? > icedtea-sunsrc.patch - I'm not sure what this is about but it looks like it > removes the service configuration files. Does JDI still work? > Don't know about this one, all I can say is it was added by Joshua Sumali in late 2007. Perhaps someone at Red Hat then can shed some light on it? > icedtea-testenv.patch - the changes to > test/sun/net/InetAddress/nameservice/dns/cname.sh seems reasonable (pilot > error is why this one was missed when the other tests were updated). > Recent patch from Mark Wielaard. Mark? > icedtea-jtreg-hatrun.patch - I suspect this is 6545295. We should just fix > this test (serviceability-dev). > Again, this one is from Omair, so he should be able to provide more detail. > -Alan. > > PS: I'm not on distro-pkg-dev so this mail might need the moderator to > approve. > > Thanks again for the conf. call, very useful! Cheers, -- Andrew :-) Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) Support Free Java! Contribute to GNU Classpath and the OpenJDK http://www.gnu.org/software/classpath http://openjdk.java.net PGP Key: 94EFD9D8 (http://subkeys.pgp.net) Fingerprint: F8EF F1EA 401E 2E60 15FA 7927 142C 2591 94EF D9D8 From gnu_andrew at member.fsf.org Thu Apr 9 18:01:18 2009 From: gnu_andrew at member.fsf.org (Andrew John Hughes) Date: Thu, 9 Apr 2009 19:01:18 +0100 Subject: New project: getting rid of IcedTea local patches In-Reply-To: <17c6771e0904091055w7c14a9adg982e0ff37a55e0a4@mail.gmail.com> References: <49D3917B.2010907@redhat.com> <49DDF4C6.1070602@redhat.com> <49DE0442.6060802@sun.com> <17c6771e0904091055w7c14a9adg982e0ff37a55e0a4@mail.gmail.com> Message-ID: <17c6771e0904091101t634e419ctfaf5cc6c8b264a90@mail.gmail.com> 2009/4/9 Andrew John Hughes : > 2009/4/9 Alan Bateman : >> Andrew Haley wrote: >>> >>> : >>> The page is at http://icedtea.classpath.org/wiki/IcedTea_JDK6_Patches >>> These are the patches in icedtea/patches and icedtea/patches/hotspot. >>> >>> >>> * Every patch should be assigned to someone. >>> >>> * Every patch should be discussed. >>> >>> * If we can, we will push a patch upstream. ?If we can't the discussion >>> ?should explain why we can't. >>> >>> Here we go... >>> >>> Andrew. >>> >> >> I'm not very familiar with IcedTea but I cloned the repository to see what >> these patches are about. Here are a few comments: >> >> icedtea-6728542-epoll.patch seems to be a change-set I pushed to jdk7 last >> year. It seems very reasonable to push this into jdk6/jdk6/jdk. Go for it! >> > > Yes, I've referenced the bug on the wiki now. ?Joe, can we commit this to 6? > >> icedtea-bytebuffer-compact.patch - this looks to be a partial fix to >> 6593946. If so, 6593946 is already in jdk6/jdk6/jdk >> (http://hg.openjdk.java.net/jdk6/jdk6/jdk/rev/3e7bfcdcf96f). >> > > IcedTea6 is still based on the last build drop of jdk6, not the > Mercurial repository. ?So this 6 week old patch won't be in the 25th > of November b14 tarball. > Interestingly, it also still exists in IcedTea7 as there were cases > covered by the patch which didn't make it into the commit. > I've attached that version. ?It was originally added by Keith Seitz > while he was working on OpenJDK at Red Hat (according to the > ChangeLog). > >> icedtea-io_util-overflow.patch - this looks like the initial fix for >> 6788196. Martin has already pushed this to jdk6/jdk7/jdk >> (http://hg.openjdk.java.net/jdk6/jdk6/jdk/rev/cc4d93e8ae7d). >> > > Same case as the epoll patch, not in b14. > >> icedtea-jvmtiEnv.patch - I thought JvmtiEnv::GetLineNumberTable already >> handled this case so I'm curious why this one is needed. >> > > Added by Andrew Haley as part of work on Shark; perhaps he can explain. > >> icedtea-network-unreachable.patch - I'm pretty sure net-dev would be open to >> this because it looks to be cases where the specific exceptions aren't >> thrown in the timed read case. >> > > From our intern, Omair so this is covered by the SCA. ?Omair, maybe > you could file a bug report for this (or link to one here if there is > one)? > >> icedtea-sunsrc.patch - I'm not sure what this is about but it looks like it >> removes the service configuration files. Does JDI still work? >> > > Don't know about this one, all I can say is it was added by Joshua > Sumali in late 2007. ?Perhaps someone at Red Hat then can shed some > light on it? > >> icedtea-testenv.patch - the changes to >> test/sun/net/InetAddress/nameservice/dns/cname.sh seems reasonable (pilot >> error is why this one was missed when the other tests were updated). >> > > Recent patch from Mark Wielaard. ?Mark? > >> icedtea-jtreg-hatrun.patch - I suspect this is 6545295. We should just fix >> this test (serviceability-dev). >> > > Again, this one is from Omair, so he should be able to provide more detail. > >> -Alan. >> >> PS: I'm not on distro-pkg-dev so this mail might need the moderator to >> approve. >> >> > > Thanks again for the conf. call, very useful! > > Cheers, > -- > Andrew :-) > > Free Java Software Engineer > Red Hat, Inc. (http://www.redhat.com) > > Support Free Java! > Contribute to GNU Classpath and the OpenJDK > http://www.gnu.org/software/classpath > http://openjdk.java.net > > PGP Key: 94EFD9D8 (http://subkeys.pgp.net) > Fingerprint: F8EF F1EA 401E 2E60 15FA ?7927 142C 2591 94EF D9D8 > And then forgot the patch! -- Andrew :-) Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) Support Free Java! Contribute to GNU Classpath and the OpenJDK http://www.gnu.org/software/classpath http://openjdk.java.net PGP Key: 94EFD9D8 (http://subkeys.pgp.net) Fingerprint: F8EF F1EA 401E 2E60 15FA 7927 142C 2591 94EF D9D8 -------------- next part -------------- A non-text attachment was scrubbed... Name: icedtea-bytebuffer-compact.patch Type: application/octet-stream Size: 1334 bytes Desc: not available URL: From aph at redhat.com Thu Apr 9 18:04:07 2009 From: aph at redhat.com (Andrew Haley) Date: Thu, 09 Apr 2009 19:04:07 +0100 Subject: New project: getting rid of IcedTea local patches In-Reply-To: <17c6771e0904091055w7c14a9adg982e0ff37a55e0a4@mail.gmail.com> References: <49D3917B.2010907@redhat.com> <49DDF4C6.1070602@redhat.com> <49DE0442.6060802@sun.com> <17c6771e0904091055w7c14a9adg982e0ff37a55e0a4@mail.gmail.com> Message-ID: <49DE3897.5050902@redhat.com> Andrew John Hughes wrote: > 2009/4/9 Alan Bateman : >> icedtea-jvmtiEnv.patch - I thought JvmtiEnv::GetLineNumberTable already >> handled this case so I'm curious why this one is needed. > > Added by Andrew Haley as part of work on Shark; perhaps he can explain. GetLineNumberTable checks for a missing table but not for a zero-length one. I had a crash in Shark, but I can't remember exactly where. Andrew. From Alan.Bateman at Sun.COM Thu Apr 9 19:08:55 2009 From: Alan.Bateman at Sun.COM (Alan Bateman) Date: Thu, 09 Apr 2009 20:08:55 +0100 Subject: New project: getting rid of IcedTea local patches In-Reply-To: <17c6771e0904091055w7c14a9adg982e0ff37a55e0a4@mail.gmail.com> References: <49D3917B.2010907@redhat.com> <49DDF4C6.1070602@redhat.com> <49DE0442.6060802@sun.com> <17c6771e0904091055w7c14a9adg982e0ff37a55e0a4@mail.gmail.com> Message-ID: <49DE47C7.1040908@sun.com> Andrew John Hughes wrote: > : >> icedtea-bytebuffer-compact.patch - this looks to be a partial fix to >> 6593946. If so, 6593946 is already in jdk6/jdk6/jdk >> (http://hg.openjdk.java.net/jdk6/jdk6/jdk/rev/3e7bfcdcf96f). >> >> > > IcedTea6 is still based on the last build drop of jdk6, not the > Mercurial repository. So this 6 week old patch won't be in the 25th > of November b14 tarball. > Interestingly, it also still exists in IcedTea7 as there were cases > covered by the patch which didn't make it into the commit. > I've attached that version. It was originally added by Keith Seitz > while he was working on OpenJDK at Red Hat (according to the > ChangeLog). > Once the fix gets into a build (b16?) then I don't think you'll need the IcedTea6 patch. Also, it does seem that the IcedTea6 patch is only a partial fix in that I don't see the changes for the view buffers. I looked at the patch you attached in the last mail (is this the IcedTea patch to jdk7?). It seems to be a no-op, or at least just replaces setting of mark to -1 with calls to discardMark that does the same thing. Nothing wrong with it, just inconsistent with the existing code. -Alan. From gnu_andrew at member.fsf.org Thu Apr 9 19:27:03 2009 From: gnu_andrew at member.fsf.org (Andrew John Hughes) Date: Thu, 9 Apr 2009 20:27:03 +0100 Subject: New project: getting rid of IcedTea local patches In-Reply-To: <49DE47C7.1040908@sun.com> References: <49D3917B.2010907@redhat.com> <49DDF4C6.1070602@redhat.com> <49DE0442.6060802@sun.com> <17c6771e0904091055w7c14a9adg982e0ff37a55e0a4@mail.gmail.com> <49DE47C7.1040908@sun.com> Message-ID: <17c6771e0904091227rde7ae31g72602473b1bbf786@mail.gmail.com> 2009/4/9 Alan Bateman : > Andrew John Hughes wrote: >> >> : >>> >>> icedtea-bytebuffer-compact.patch - this looks to be a partial fix to >>> 6593946. If so, 6593946 is already in jdk6/jdk6/jdk >>> (http://hg.openjdk.java.net/jdk6/jdk6/jdk/rev/3e7bfcdcf96f). >>> >>> >> >> IcedTea6 is still based on the last build drop of jdk6, not the >> Mercurial repository. ?So this 6 week old patch won't be in the 25th >> of November b14 tarball. >> Interestingly, it also still exists in IcedTea7 as there were cases >> covered by the patch which didn't make it into the commit. >> I've attached that version. ?It was originally added by Keith Seitz >> while he was working on OpenJDK at Red Hat (according to the >> ChangeLog). >> > > Once the fix gets into a build (b16?) then I don't think you'll need the > IcedTea6 patch. Spot on, we need a new build drop (read tarball) to pick up the recent changes. There hasn't been one since Nov. 2008. Also, it does seem that the IcedTea6 patch is only a partial > fix in that I don't see the changes for the view buffers. Yeah, this is an old patch so I don't know all the origins, but it may have been pushed upstream and revised in the process, or even developed separately at Sun. One has clearMark(), one has discardMark IIRC. I looked at the > patch you attached in the last mail (is this the IcedTea patch to jdk7?). Yes, it's the leftovers after I took out the bits in upstream OpenJDK7 (last build against b50). > It > seems to be a no-op, or at least just replaces setting of mark to -1 with > calls to discardMark that does the same thing. Nothing wrong with it, just > inconsistent with the existing code. > Yeah I agree, it's not a must have. I meant to actually raise this at the time, but never got round to it obviously. Using discardMark is perhaps a little cleaner/maintainable, but has the downside of adding an extra method dispatch. > -Alan. > -- Andrew :-) Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) Support Free Java! Contribute to GNU Classpath and the OpenJDK http://www.gnu.org/software/classpath http://openjdk.java.net PGP Key: 94EFD9D8 (http://subkeys.pgp.net) Fingerprint: F8EF F1EA 401E 2E60 15FA 7927 142C 2591 94EF D9D8 From Alan.Bateman at Sun.COM Thu Apr 9 19:57:05 2009 From: Alan.Bateman at Sun.COM (Alan Bateman) Date: Thu, 09 Apr 2009 20:57:05 +0100 Subject: New project: getting rid of IcedTea local patches In-Reply-To: <49DE3897.5050902@redhat.com> References: <49D3917B.2010907@redhat.com> <49DDF4C6.1070602@redhat.com> <49DE0442.6060802@sun.com> <17c6771e0904091055w7c14a9adg982e0ff37a55e0a4@mail.gmail.com> <49DE3897.5050902@redhat.com> Message-ID: <49DE5311.5040108@sun.com> Andrew Haley wrote: > Andrew John Hughes wrote: > >> 2009/4/9 Alan Bateman : >> > > >>> icedtea-jvmtiEnv.patch - I thought JvmtiEnv::GetLineNumberTable already >>> handled this case so I'm curious why this one is needed. >>> >> Added by Andrew Haley as part of work on Shark; perhaps he can explain. >> > > GetLineNumberTable checks for a missing table but not for a zero-length > one. I had a crash in Shark, but I can't remember exactly where. > > Andrew. > I need to double-check the VM and JVM TI specs but off-hand, I believe a zero-length table is possible. I wonder if this was a case of the agent not handling the zero-length case. Anyway, if you do remember the details please send them on to serviceability-dev. -Alan. From lsliu0507 at gmail.com Tue Apr 14 14:53:12 2009 From: lsliu0507 at gmail.com (lianshun Liu) Date: Tue, 14 Apr 2009 22:53:12 +0800 Subject: build problem Message-ID: <40D499FDD4A84216B651AF49AD13BE8E@AAA> Hi, I build OpenJDK on Windows platform, and choose /openjdk as the build dictory. I've a problem that I need to rebuild the whole project everytime when I hack the VM. It is really a long time that I can't use the computer to do anything else. So, is there any ways to solve this? Thanks:) Best regards, Lianshun Liu -------------- next part -------------- An HTML attachment was scrubbed... URL: From aph at redhat.com Tue Apr 14 18:54:35 2009 From: aph at redhat.com (Andrew Haley) Date: Tue, 14 Apr 2009 19:54:35 +0100 Subject: build problem In-Reply-To: <40D499FDD4A84216B651AF49AD13BE8E@AAA> References: <40D499FDD4A84216B651AF49AD13BE8E@AAA> Message-ID: <49E4DBEB.4010203@redhat.com> lianshun Liu wrote: > Hi, > > I build OpenJDK on Windows platform, and choose /openjdk as the build dictory. > I've a problem that I need to rebuild the whole project everytime when I hack the VM. It is really a long time that I can't use the computer to do anything else. So, is there any ways to solve this? Thanks:) "make hostpot" is usually fast for me: it just rebuilds the files that it needs to. Andrew. From aph at redhat.com Tue Apr 14 18:55:16 2009 From: aph at redhat.com (Andrew Haley) Date: Tue, 14 Apr 2009 19:55:16 +0100 Subject: build problem In-Reply-To: <49E4DBEB.4010203@redhat.com> References: <40D499FDD4A84216B651AF49AD13BE8E@AAA> <49E4DBEB.4010203@redhat.com> Message-ID: <49E4DC14.30207@redhat.com> Andrew Haley wrote: > lianshun Liu wrote: >> Hi, >> >> I build OpenJDK on Windows platform, and choose /openjdk as the build dictory. >> I've a problem that I need to rebuild the whole project everytime when I hack the VM. It is really a long time that I can't use the computer to do anything else. So, is there any ways to solve this? Thanks:) > > "make hostpot" is usually fast for me: it just rebuilds the files > that it needs to. Err, "make hotspot". :-) Andrew. From Kelly.Ohair at Sun.COM Tue Apr 14 18:57:07 2009 From: Kelly.Ohair at Sun.COM (Kelly O'Hair) Date: Tue, 14 Apr 2009 11:57:07 -0700 Subject: build problem In-Reply-To: <40D499FDD4A84216B651AF49AD13BE8E@AAA> References: <40D499FDD4A84216B651AF49AD13BE8E@AAA> Message-ID: <49E4DC83.4090901@sun.com> If all you are working on is hotspot, then you can build just hotspot by doing a 'cd hotspot/make && make'. From that same Makefile in hotspot/make you can also try using: make JDK_IMAGE_DIR="../../build/*/j2sdk-image" update_jdk To update a jdk image with your newly build hotspot libraries. But the "../../build/*/j2sdk-image" may need to be a full path, you will need to experiment with this. -kto lianshun Liu wrote: > Hi, > > I build OpenJDK on Windows platform, and choose /openjdk as the build > dictory. > I've a problem that I need to rebuild the whole project everytime when I > hack the VM. It is really a long time that I can't use the computer to > do anything else. So, is there any ways to solve this? Thanks:) > > Best regards, > Lianshun Liu > From Kelly.Ohair at Sun.COM Tue Apr 14 19:00:39 2009 From: Kelly.Ohair at Sun.COM (Kelly O'Hair) Date: Tue, 14 Apr 2009 12:00:39 -0700 Subject: build problem In-Reply-To: <49E4DBEB.4010203@redhat.com> References: <40D499FDD4A84216B651AF49AD13BE8E@AAA> <49E4DBEB.4010203@redhat.com> Message-ID: <49E4DD57.9020700@sun.com> Andrew Haley wrote: > lianshun Liu wrote: >> Hi, >> >> I build OpenJDK on Windows platform, and choose /openjdk as the build dictory. >> I've a problem that I need to rebuild the whole project everytime when I hack the VM. It is really a long time that I can't use the computer to do anything else. So, is there any ways to solve this? Thanks:) > > "make hostpot" is usually fast for me: it just rebuilds the files > that it needs to. That should work, although I'm not sure the newly built hotspot libraries will get copied into the previously built jdk image. You might watch out for that. Normally the jdk repository (specifically jdk/make/redist/Makefile) will copy the hotspot libraries into the jdk build area, depending on what OUTPUTDIR is set to. Kind of a pull or import action. Historic stuff. ;^) -kto > > Andrew. From Kelly.Ohair at Sun.COM Wed Apr 15 15:54:53 2009 From: Kelly.Ohair at Sun.COM (Kelly O'Hair) Date: Wed, 15 Apr 2009 08:54:53 -0700 Subject: Windows Visual Studio and vcvars32.bat Message-ID: <49E6034D.6040107@sun.com> FYI... Anyone wrestling with CYGWIN shells and setting up Windows Visual Studio environment variables may want to take a look at the vsvars.sh script I posted on my blog: http://blogs.sun.com/kto/entry/windows_visual_studio_stupid_pet Not sure yet where it's permanent home will be yet, but I think it will come in handy at some point. -kto From lsliu0507 at gmail.com Thu Apr 16 16:10:12 2009 From: lsliu0507 at gmail.com (lianshun Liu) Date: Fri, 17 Apr 2009 00:10:12 +0800 Subject: puzzles about hotspot interpreter Message-ID: <4FF7CFFC5D0B4B6E93923C66997DB2C1@AAA> Hello, I want to do some experiments with hotspot interpreter, precisely speeking, the C++-interpreter. I set CC_INTERP=1 when making hotspot. To test which interpreter will work, I embeded some codes which will create a file into the function bytecodeInterpreter::run(). But to my surprise, when I run the hotspot, no file will be created, so the function bytecodeInterpreter::run() wasn't invoked. If I didn't set CC_INTERP=1, the result was the same. In order to use C++-interpreter, what else should I do? Any details? Thanks a lot;-) Best regards Lianshun Liu -------------- next part -------------- An HTML attachment was scrubbed... URL: From christopher.hegarty at sun.com Thu Apr 16 16:46:46 2009 From: christopher.hegarty at sun.com (christopher.hegarty at sun.com) Date: Thu, 16 Apr 2009 16:46:46 +0000 Subject: hg: jdk7/build/jdk: 4927640: Implementation of the sctp protocol Message-ID: <20090416164711.6DE7DECF9@hg.openjdk.java.net> Changeset: ffc29fac1330 Author: chegar Date: 2009-04-16 17:42 +0100 URL: http://hg.openjdk.java.net/jdk7/build/jdk/rev/ffc29fac1330 4927640: Implementation of the sctp protocol Summary: An implementation-specific API for the Stream Control Transmission Protocol Reviewed-by: alanb, michaelm, jccollet ! make/com/sun/Makefile + make/com/sun/nio/Makefile + make/com/sun/nio/sctp/Exportedfiles.gmk + make/com/sun/nio/sctp/FILES_c.gmk + make/com/sun/nio/sctp/FILES_java.gmk + make/com/sun/nio/sctp/Makefile + make/com/sun/nio/sctp/mapfile-vers ! make/docs/NON_CORE_PKGS.gmk ! make/java/nio/mapfile-linux ! make/java/nio/mapfile-solaris + src/share/classes/com/sun/nio/sctp/AbstractNotificationHandler.java + src/share/classes/com/sun/nio/sctp/Association.java + src/share/classes/com/sun/nio/sctp/AssociationChangeNotification.java + src/share/classes/com/sun/nio/sctp/HandlerResult.java + src/share/classes/com/sun/nio/sctp/IllegalReceiveException.java + src/share/classes/com/sun/nio/sctp/IllegalUnbindException.java + src/share/classes/com/sun/nio/sctp/InvalidStreamException.java + src/share/classes/com/sun/nio/sctp/MessageInfo.java + src/share/classes/com/sun/nio/sctp/Notification.java + src/share/classes/com/sun/nio/sctp/NotificationHandler.java + src/share/classes/com/sun/nio/sctp/PeerAddressChangeNotification.java + src/share/classes/com/sun/nio/sctp/SctpChannel.java + src/share/classes/com/sun/nio/sctp/SctpMultiChannel.java + src/share/classes/com/sun/nio/sctp/SctpServerChannel.java + src/share/classes/com/sun/nio/sctp/SctpSocketOption.java + src/share/classes/com/sun/nio/sctp/SctpStandardSocketOption.java + src/share/classes/com/sun/nio/sctp/SendFailedNotification.java + src/share/classes/com/sun/nio/sctp/ShutdownNotification.java + src/share/classes/com/sun/nio/sctp/package-info.java + src/share/classes/sun/nio/ch/SctpMessageInfoImpl.java + src/share/classes/sun/nio/ch/SctpStdSocketOption.java + src/solaris/classes/sun/nio/ch/SctpAssocChange.java + src/solaris/classes/sun/nio/ch/SctpAssociationImpl.java + src/solaris/classes/sun/nio/ch/SctpChannelImpl.java + src/solaris/classes/sun/nio/ch/SctpMultiChannelImpl.java + src/solaris/classes/sun/nio/ch/SctpNet.java + src/solaris/classes/sun/nio/ch/SctpNotification.java + src/solaris/classes/sun/nio/ch/SctpPeerAddrChange.java + src/solaris/classes/sun/nio/ch/SctpResultContainer.java + src/solaris/classes/sun/nio/ch/SctpSendFailed.java + src/solaris/classes/sun/nio/ch/SctpServerChannelImpl.java + src/solaris/classes/sun/nio/ch/SctpShutdown.java + src/solaris/classes/sun/nio/ch/SctpSocketDispatcher.java + src/solaris/native/sun/nio/ch/Sctp.h + src/solaris/native/sun/nio/ch/SctpChannelImpl.c + src/solaris/native/sun/nio/ch/SctpNet.c + src/solaris/native/sun/nio/ch/SctpServerChannelImpl.c + src/windows/classes/sun/nio/ch/SctpChannelImpl.java + src/windows/classes/sun/nio/ch/SctpMultiChannelImpl.java + src/windows/classes/sun/nio/ch/SctpServerChannelImpl.java + test/com/sun/nio/sctp/MessageInfoTests.java + test/com/sun/nio/sctp/SctpChannel/Bind.java + test/com/sun/nio/sctp/SctpChannel/Connect.java + test/com/sun/nio/sctp/SctpChannel/Receive.java + test/com/sun/nio/sctp/SctpChannel/Send.java + test/com/sun/nio/sctp/SctpChannel/Shutdown.java + test/com/sun/nio/sctp/SctpChannel/SocketOptionTests.java + test/com/sun/nio/sctp/SctpChannel/Util.java + test/com/sun/nio/sctp/SctpMultiChannel/Send.java + test/com/sun/nio/sctp/SctpMultiChannel/Util.java + test/com/sun/nio/sctp/SctpServerChannel/Accept.java + test/com/sun/nio/sctp/SctpServerChannel/NonBlockingAccept.java + test/com/sun/nio/sctp/SctpServerChannel/Util.java From Kelly.Ohair at Sun.COM Thu Apr 16 17:04:06 2009 From: Kelly.Ohair at Sun.COM (Kelly O'Hair) Date: Thu, 16 Apr 2009 10:04:06 -0700 Subject: puzzles about hotspot interpreter In-Reply-To: <4FF7CFFC5D0B4B6E93923C66997DB2C1@AAA> References: <4FF7CFFC5D0B4B6E93923C66997DB2C1@AAA> Message-ID: <49E76506.5050208@sun.com> You might try the porter alias or one of the hotspot aliases on this. http://mail.openjdk.java.net/mailman/listinfo -kto lianshun Liu wrote: > Hello, > I want to do some experiments with hotspot interpreter, precisely > speeking, the C++-interpreter. I set CC_INTERP=1 when making hotspot. To > test which interpreter will work, I embeded some codes which will create > a file into the function bytecodeInterpreter::run(). But to my surprise, > when I run the hotspot, no file will be created, so the function > bytecodeInterpreter::run() wasn't invoked. If I didn't set CC_INTERP=1, > the result was the same. > In order to use C++-interpreter, what else should I do? Any details? > Thanks a lot;-) > > > Best regards > > Lianshun Liu From xiomara.jayasena at sun.com Fri Apr 17 02:23:03 2009 From: xiomara.jayasena at sun.com (xiomara.jayasena at sun.com) Date: Fri, 17 Apr 2009 02:23:03 +0000 Subject: hg: jdk7/build: 2 new changesets Message-ID: <20090417022303.DCE2CEDC6@hg.openjdk.java.net> Changeset: aea0ace7a1e4 Author: xdono Date: 2009-04-09 10:37 -0700 URL: http://hg.openjdk.java.net/jdk7/build/rev/aea0ace7a1e4 Added tag jdk7-b54 for changeset 2ef382b1bbd5 ! .hgtags Changeset: ba12117a5e6c Author: xdono Date: 2009-04-16 11:22 -0700 URL: http://hg.openjdk.java.net/jdk7/build/rev/ba12117a5e6c Added tag jdk7-b55 for changeset aea0ace7a1e4 ! .hgtags From xiomara.jayasena at sun.com Fri Apr 17 02:26:30 2009 From: xiomara.jayasena at sun.com (xiomara.jayasena at sun.com) Date: Fri, 17 Apr 2009 02:26:30 +0000 Subject: hg: jdk7/build/corba: 2 new changesets Message-ID: <20090417022632.68E44EDCB@hg.openjdk.java.net> Changeset: 7a869f16ba83 Author: xdono Date: 2009-04-09 10:37 -0700 URL: http://hg.openjdk.java.net/jdk7/build/corba/rev/7a869f16ba83 Added tag jdk7-b54 for changeset 8130ac858d67 ! .hgtags Changeset: 553a664b807b Author: xdono Date: 2009-04-16 11:22 -0700 URL: http://hg.openjdk.java.net/jdk7/build/corba/rev/553a664b807b Added tag jdk7-b55 for changeset 7a869f16ba83 ! .hgtags From xiomara.jayasena at sun.com Fri Apr 17 02:32:48 2009 From: xiomara.jayasena at sun.com (xiomara.jayasena at sun.com) Date: Fri, 17 Apr 2009 02:32:48 +0000 Subject: hg: jdk7/build/hotspot: 36 new changesets Message-ID: <20090417023358.70990EDD2@hg.openjdk.java.net> Changeset: c89f86385056 Author: jrose Date: 2009-03-20 23:19 -0700 URL: http://hg.openjdk.java.net/jdk7/build/hotspot/rev/c89f86385056 6814659: separable cleanups and subroutines for 6655638 Summary: preparatory but separable changes for method handles Reviewed-by: kvn, never ! src/cpu/sparc/vm/assembler_sparc.cpp ! src/cpu/sparc/vm/assembler_sparc.hpp ! src/cpu/sparc/vm/assembler_sparc.inline.hpp ! src/cpu/sparc/vm/c1_LIRAssembler_sparc.cpp ! src/cpu/x86/vm/assembler_x86.cpp ! src/cpu/x86/vm/assembler_x86.hpp ! src/share/vm/asm/assembler.hpp ! src/share/vm/classfile/javaClasses.cpp ! src/share/vm/classfile/javaClasses.hpp ! src/share/vm/classfile/loaderConstraints.hpp ! src/share/vm/classfile/symbolTable.cpp ! src/share/vm/classfile/symbolTable.hpp ! src/share/vm/classfile/systemDictionary.cpp ! src/share/vm/classfile/systemDictionary.hpp ! src/share/vm/gc_implementation/parallelScavenge/parallelScavengeHeap.cpp ! src/share/vm/oops/instanceKlass.cpp ! src/share/vm/oops/instanceKlass.hpp ! src/share/vm/oops/instanceKlassKlass.cpp ! src/share/vm/oops/klassVtable.cpp ! src/share/vm/oops/klassVtable.hpp ! src/share/vm/oops/methodKlass.cpp ! src/share/vm/oops/objArrayKlass.cpp ! src/share/vm/oops/oop.cpp ! src/share/vm/prims/jvm.cpp ! src/share/vm/runtime/fieldDescriptor.cpp ! src/share/vm/runtime/handles.hpp ! src/share/vm/runtime/reflection.cpp ! src/share/vm/runtime/reflection.hpp ! src/share/vm/runtime/sharedRuntime.cpp ! src/share/vm/runtime/sharedRuntime.hpp Changeset: ebebd376f657 Author: never Date: 2009-03-23 13:58 -0700 URL: http://hg.openjdk.java.net/jdk7/build/hotspot/rev/ebebd376f657 6805522: Server VM fails with assertion (block1->start() != block2->start(),"successors have unique bcis") Reviewed-by: kvn ! src/share/vm/ci/ciTypeFlow.cpp Changeset: 78af5ae8e731 Author: cfang Date: 2009-03-24 12:19 -0700 URL: http://hg.openjdk.java.net/jdk7/build/hotspot/rev/78af5ae8e731 6636138: UseSuperWord enabled failure Summary: Fixed SuperWord scheduling of memory operations. Reviewed-by: kvn, never ! src/share/vm/opto/superword.cpp ! src/share/vm/opto/superword.hpp + test/compiler/6636138/Test1.java + test/compiler/6636138/Test2.java Changeset: 90a66aa50514 Author: never Date: 2009-03-24 15:09 -0700 URL: http://hg.openjdk.java.net/jdk7/build/hotspot/rev/90a66aa50514 6820510: assertion failure with unloaded class in subnode.cpp Reviewed-by: kvn ! src/share/vm/opto/subnode.cpp Changeset: eca19a8425b5 Author: phh Date: 2009-03-24 21:56 -0400 URL: http://hg.openjdk.java.net/jdk7/build/hotspot/rev/eca19a8425b5 6810653: Change String cache class used by Hotspot from String to StringValue Summary: Change create_vm() to load and initialize StringValue rather than String. Reviewed-by: kvn ! src/share/vm/classfile/vmSymbols.hpp ! src/share/vm/runtime/thread.cpp Changeset: c7bbabdcadfb Author: phh Date: 2009-03-24 19:05 -0700 URL: http://hg.openjdk.java.net/jdk7/build/hotspot/rev/c7bbabdcadfb Merge Changeset: d0994e5bebce Author: never Date: 2009-03-26 14:31 -0700 URL: http://hg.openjdk.java.net/jdk7/build/hotspot/rev/d0994e5bebce 6822204: volatile fences should prefer lock:addl to actual mfence instructions Reviewed-by: kvn, phh ! src/cpu/sparc/vm/stubGenerator_sparc.cpp ! src/cpu/x86/vm/assembler_x86.cpp ! src/cpu/x86/vm/assembler_x86.hpp ! src/cpu/x86/vm/stubGenerator_x86_64.cpp ! src/cpu/x86/vm/x86_32.ad ! src/cpu/x86/vm/x86_64.ad ! src/os_cpu/linux_sparc/vm/os_linux_sparc.hpp ! src/os_cpu/linux_x86/vm/orderAccess_linux_x86.inline.hpp ! src/os_cpu/solaris_sparc/vm/orderAccess_solaris_sparc.inline.hpp ! src/os_cpu/solaris_sparc/vm/os_solaris_sparc.cpp ! src/os_cpu/solaris_sparc/vm/os_solaris_sparc.hpp ! src/os_cpu/solaris_x86/vm/orderAccess_solaris_x86.inline.hpp ! src/os_cpu/solaris_x86/vm/os_solaris_x86.cpp ! src/os_cpu/solaris_x86/vm/os_solaris_x86.hpp ! src/os_cpu/windows_x86/vm/orderAccess_windows_x86.inline.hpp ! src/os_cpu/windows_x86/vm/os_windows_x86.cpp ! src/os_cpu/windows_x86/vm/os_windows_x86.hpp ! src/share/vm/includeDB_core ! src/share/vm/runtime/orderAccess.cpp ! src/share/vm/runtime/orderAccess.hpp Changeset: afd8dfb5c2a6 Author: never Date: 2009-03-26 14:39 -0700 URL: http://hg.openjdk.java.net/jdk7/build/hotspot/rev/afd8dfb5c2a6 Merge Changeset: fbc12e71c476 Author: kvn Date: 2009-03-26 15:04 -0700 URL: http://hg.openjdk.java.net/jdk7/build/hotspot/rev/fbc12e71c476 6810845: Performance regression in mpegaudio on x64 Summary: Used the outer loop frequency in frequencies checks in RA. Reviewed-by: never, twisti ! src/share/vm/opto/block.hpp ! src/share/vm/opto/c2_globals.hpp ! src/share/vm/opto/chaitin.cpp ! src/share/vm/opto/chaitin.hpp ! src/share/vm/opto/coalesce.cpp ! src/share/vm/opto/gcm.cpp ! src/share/vm/opto/machnode.cpp Changeset: 4948e7dd28dc Author: never Date: 2009-03-27 14:37 -0700 URL: http://hg.openjdk.java.net/jdk7/build/hotspot/rev/4948e7dd28dc 6822333: _call_stub_compiled_return address handling in SA is broken causing jstack to hang occasionally Reviewed-by: kvn, twisti ! agent/src/share/classes/sun/jvm/hotspot/runtime/StubRoutines.java Changeset: f6da6f0174ac Author: kvn Date: 2009-03-30 18:19 -0700 URL: http://hg.openjdk.java.net/jdk7/build/hotspot/rev/f6da6f0174ac 6821700: tune VM flags for peak performance Summary: Tune C2 flags default values for performance. Reviewed-by: never, phh, iveresov, jmasa, ysr ! src/cpu/sparc/vm/globals_sparc.hpp ! src/cpu/sparc/vm/vm_version_sparc.cpp ! src/cpu/x86/vm/globals_x86.hpp ! src/share/vm/classfile/vmSymbols.hpp ! src/share/vm/opto/bytecodeInfo.cpp ! src/share/vm/runtime/globals.hpp Changeset: d3676b4cb78c Author: kvn Date: 2009-03-31 10:02 -0700 URL: http://hg.openjdk.java.net/jdk7/build/hotspot/rev/d3676b4cb78c Merge ! src/share/vm/classfile/vmSymbols.hpp ! src/share/vm/oops/instanceKlass.cpp ! src/share/vm/oops/instanceKlass.hpp ! src/share/vm/oops/klassVtable.cpp ! src/share/vm/oops/klassVtable.hpp ! src/share/vm/prims/jvm.cpp Changeset: 96b229c54d1e Author: apetrusenko Date: 2009-03-25 13:10 -0700 URL: http://hg.openjdk.java.net/jdk7/build/hotspot/rev/96b229c54d1e 6543938: G1: remove the concept of popularity Reviewed-by: iveresov, tonyp ! src/cpu/sparc/vm/assembler_sparc.cpp ! src/share/vm/gc_implementation/g1/collectionSetChooser.cpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.hpp ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.cpp ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.hpp ! src/share/vm/gc_implementation/g1/g1MarkSweep.cpp ! src/share/vm/gc_implementation/g1/g1RemSet.cpp ! src/share/vm/gc_implementation/g1/g1RemSet.inline.hpp ! src/share/vm/gc_implementation/g1/g1_globals.hpp ! src/share/vm/gc_implementation/g1/heapRegion.cpp ! src/share/vm/gc_implementation/g1/heapRegion.hpp ! src/share/vm/gc_implementation/g1/heapRegionRemSet.hpp ! src/share/vm/gc_implementation/g1/heapRegionSeq.cpp ! src/share/vm/gc_implementation/g1/heapRegionSeq.hpp ! src/share/vm/gc_implementation/g1/vm_operations_g1.cpp ! src/share/vm/gc_implementation/g1/vm_operations_g1.hpp ! src/share/vm/gc_interface/gcCause.hpp ! src/share/vm/runtime/vm_operations.hpp Changeset: 4ac7d97e6101 Author: iveresov Date: 2009-03-26 08:51 -0700 URL: http://hg.openjdk.java.net/jdk7/build/hotspot/rev/4ac7d97e6101 6822263: G1: JVMTI heap iteration fails Summary: Make object_iterate() traverse the perm gen Reviewed-by: apetrusenko, tonyp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.hpp Changeset: cea947c8a988 Author: ysr Date: 2009-03-28 15:47 -0700 URL: http://hg.openjdk.java.net/jdk7/build/hotspot/rev/cea947c8a988 6819891: ParNew: Fix work queue overflow code to deal correctly with +UseCompressedOops Summary: When using compressed oops, rather than chaining the overflowed grey objects' pre-images through their klass words, we use GC-worker thread-local overflow stacks. Reviewed-by: jcoomes, jmasa ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp ! src/share/vm/gc_implementation/parNew/parNewGeneration.cpp ! src/share/vm/gc_implementation/parNew/parNewGeneration.hpp ! src/share/vm/runtime/globals.hpp Changeset: a80d48f6fde1 Author: apetrusenko Date: 2009-04-02 05:22 -0700 URL: http://hg.openjdk.java.net/jdk7/build/hotspot/rev/a80d48f6fde1 Merge ! src/cpu/sparc/vm/assembler_sparc.cpp ! src/share/vm/runtime/globals.hpp Changeset: fbde8ec322d0 Author: cfang Date: 2009-03-31 14:07 -0700 URL: http://hg.openjdk.java.net/jdk7/build/hotspot/rev/fbde8ec322d0 6761600: Use sse 4.2 in intrinsics Summary: Use SSE 4.2 in intrinsics for String.{compareTo/equals/indexOf} and Arrays.equals. Reviewed-by: kvn, never, jrose ! src/cpu/sparc/vm/sparc.ad ! src/cpu/x86/vm/assembler_x86.cpp ! src/cpu/x86/vm/assembler_x86.hpp ! src/cpu/x86/vm/vm_version_x86.cpp ! src/cpu/x86/vm/x86_32.ad ! src/cpu/x86/vm/x86_64.ad ! src/share/vm/adlc/formssel.cpp ! src/share/vm/classfile/vmSymbols.hpp ! src/share/vm/opto/classes.hpp ! src/share/vm/opto/gcm.cpp ! src/share/vm/opto/lcm.cpp ! src/share/vm/opto/library_call.cpp ! src/share/vm/opto/loopnode.cpp ! src/share/vm/opto/matcher.cpp ! src/share/vm/opto/memnode.cpp ! src/share/vm/opto/memnode.hpp ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/globals.hpp Changeset: 69aefafe69c1 Author: never Date: 2009-03-31 15:09 -0700 URL: http://hg.openjdk.java.net/jdk7/build/hotspot/rev/69aefafe69c1 6824463: deopt blob is testing wrong register on 64-bit x86 Reviewed-by: jrose, phh, kvn ! src/cpu/x86/vm/sharedRuntime_x86_64.cpp Changeset: 90e3155a713d Author: never Date: 2009-03-31 19:20 -0700 URL: http://hg.openjdk.java.net/jdk7/build/hotspot/rev/90e3155a713d Merge Changeset: 7230de7c4610 Author: never Date: 2009-04-01 11:45 -0700 URL: http://hg.openjdk.java.net/jdk7/build/hotspot/rev/7230de7c4610 6823454: Oop-typed loadP yields invalid pointer (0x1) on SPECjbb2005 at OSRed method entry Reviewed-by: kvn, jrose ! src/share/vm/opto/parse1.cpp Changeset: 4e35bfab60a5 Author: never Date: 2009-04-02 10:49 -0700 URL: http://hg.openjdk.java.net/jdk7/build/hotspot/rev/4e35bfab60a5 Merge ! src/share/vm/runtime/globals.hpp Changeset: a9d9d7e06593 Author: trims Date: 2009-04-02 17:01 -0700 URL: http://hg.openjdk.java.net/jdk7/build/hotspot/rev/a9d9d7e06593 Merge Changeset: aa3a6f3eaa43 Author: trims Date: 2009-04-02 17:37 -0700 URL: http://hg.openjdk.java.net/jdk7/build/hotspot/rev/aa3a6f3eaa43 6825815: Bump HS15 build number to 05 and update copyright date of HOTSPOT_VM_COPYRIGHT Summary: Update the HS15 Build number to 05 and fix copyright date of HOTSPOT_VM_COPYRIGHT Reviewed-by: jcoomes ! make/hotspot_version Changeset: 5373f8d7025b Author: trims Date: 2009-04-02 17:37 -0700 URL: http://hg.openjdk.java.net/jdk7/build/hotspot/rev/5373f8d7025b Merge Changeset: f30ba3b36599 Author: poonam Date: 2009-03-27 10:29 -0700 URL: http://hg.openjdk.java.net/jdk7/build/hotspot/rev/f30ba3b36599 6822407: heapOopSize lookup is incorrect in Serviceability Agent. Summary: heapOopSize symbol should be declared as constant in vmStructs and should not be looked up in readVMIntConstants(). Reviewed-by: never, swamyv, coleenp ! agent/src/share/classes/sun/jvm/hotspot/HotSpotTypeDataBase.java ! agent/src/share/classes/sun/jvm/hotspot/runtime/VM.java ! src/share/vm/runtime/vmStructs.cpp Changeset: d142f1feeed5 Author: acorn Date: 2009-03-29 18:19 -0400 URL: http://hg.openjdk.java.net/jdk7/build/hotspot/rev/d142f1feeed5 Merge Changeset: 956304450e80 Author: phh Date: 2009-04-01 16:38 -0400 URL: http://hg.openjdk.java.net/jdk7/build/hotspot/rev/956304450e80 6819213: revive sun.boot.library.path Summary: Support multiplex and mutable sun.boot.library.path Reviewed-by: acorn, dcubed, xlu ! src/os/linux/vm/os_linux.cpp ! src/os/solaris/vm/os_solaris.cpp ! src/os/windows/vm/os_windows.cpp ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/arguments.hpp ! src/share/vm/runtime/hpi.hpp ! src/share/vm/runtime/os.cpp ! src/share/vm/runtime/os.hpp + test/runtime/6819213/TestBootNativeLibraryPath.java Changeset: 23276f80d930 Author: acorn Date: 2009-04-02 14:26 -0400 URL: http://hg.openjdk.java.net/jdk7/build/hotspot/rev/23276f80d930 6825642: nsk sajdi tests fail with NullPointerException Reviewed-by: xlu, coleenp, kamg, swamyv ! agent/src/share/classes/sun/jvm/hotspot/HotSpotTypeDataBase.java ! agent/src/share/classes/sun/jvm/hotspot/runtime/VM.java ! src/share/vm/runtime/vmStructs.cpp Changeset: 2c1dbb844832 Author: acorn Date: 2009-04-02 18:17 -0400 URL: http://hg.openjdk.java.net/jdk7/build/hotspot/rev/2c1dbb844832 Merge ! src/share/vm/runtime/arguments.cpp Changeset: eae95c5579a4 Author: trims Date: 2009-04-03 19:54 -0700 URL: http://hg.openjdk.java.net/jdk7/build/hotspot/rev/eae95c5579a4 Merge Changeset: becb17ad5e51 Author: ysr Date: 2009-04-02 15:57 -0700 URL: http://hg.openjdk.java.net/jdk7/build/hotspot/rev/becb17ad5e51 6824570: ParNew: Fix memory leak introduced in 6819891 Summary: Allocate worker-local overflow stacks, introduced in 6819891, along with ParNewGeneration, rather than with the per-scavenge ParScanThreadState. Reviewed-by: jmasa ! src/share/vm/gc_implementation/parNew/parNewGeneration.cpp ! src/share/vm/gc_implementation/parNew/parNewGeneration.hpp ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/globals.hpp Changeset: f18338cf04b0 Author: jcoomes Date: 2009-03-03 14:23 -0800 URL: http://hg.openjdk.java.net/jdk7/build/hotspot/rev/f18338cf04b0 6810474: par compact - crash in summary_phase with very full heap Reviewed-by: tonyp ! src/share/vm/gc_implementation/parallelScavenge/psParallelCompact.cpp Changeset: 922aedc96ef5 Author: ysr Date: 2009-04-03 15:59 -0700 URL: http://hg.openjdk.java.net/jdk7/build/hotspot/rev/922aedc96ef5 Merge ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/globals.hpp Changeset: fafab5d5349c Author: trims Date: 2009-04-03 20:12 -0700 URL: http://hg.openjdk.java.net/jdk7/build/hotspot/rev/fafab5d5349c Merge Changeset: f8e839c08615 Author: xdono Date: 2009-04-09 10:37 -0700 URL: http://hg.openjdk.java.net/jdk7/build/hotspot/rev/f8e839c08615 Added tag jdk7-b54 for changeset fafab5d5349c ! .hgtags Changeset: bcbec53c367d Author: xdono Date: 2009-04-16 11:22 -0700 URL: http://hg.openjdk.java.net/jdk7/build/hotspot/rev/bcbec53c367d Added tag jdk7-b55 for changeset f8e839c08615 ! .hgtags From xiomara.jayasena at sun.com Fri Apr 17 02:46:30 2009 From: xiomara.jayasena at sun.com (xiomara.jayasena at sun.com) Date: Fri, 17 Apr 2009 02:46:30 +0000 Subject: hg: jdk7/build/jaxp: 2 new changesets Message-ID: <20090417024633.A8A74EDD7@hg.openjdk.java.net> Changeset: 039945fba683 Author: xdono Date: 2009-04-09 10:37 -0700 URL: http://hg.openjdk.java.net/jdk7/build/jaxp/rev/039945fba683 Added tag jdk7-b54 for changeset 946a9f0c4932 ! .hgtags Changeset: c197c6801271 Author: xdono Date: 2009-04-16 11:22 -0700 URL: http://hg.openjdk.java.net/jdk7/build/jaxp/rev/c197c6801271 Added tag jdk7-b55 for changeset 039945fba683 ! .hgtags From xiomara.jayasena at sun.com Fri Apr 17 02:50:05 2009 From: xiomara.jayasena at sun.com (xiomara.jayasena at sun.com) Date: Fri, 17 Apr 2009 02:50:05 +0000 Subject: hg: jdk7/build/jaxws: 2 new changesets Message-ID: <20090417025008.D75DCEDDC@hg.openjdk.java.net> Changeset: e0eebd978b83 Author: xdono Date: 2009-04-09 10:37 -0700 URL: http://hg.openjdk.java.net/jdk7/build/jaxws/rev/e0eebd978b83 Added tag jdk7-b54 for changeset 50ea00dc5f14 ! .hgtags Changeset: 0f7fbf85f7a1 Author: xdono Date: 2009-04-16 11:22 -0700 URL: http://hg.openjdk.java.net/jdk7/build/jaxws/rev/0f7fbf85f7a1 Added tag jdk7-b55 for changeset e0eebd978b83 ! .hgtags From xiomara.jayasena at sun.com Fri Apr 17 02:58:09 2009 From: xiomara.jayasena at sun.com (xiomara.jayasena at sun.com) Date: Fri, 17 Apr 2009 02:58:09 +0000 Subject: hg: jdk7/build/jdk: 80 new changesets Message-ID: <20090417031411.5C357EDE1@hg.openjdk.java.net> Changeset: a43b2c9dad6f Author: xdono Date: 2009-04-09 10:37 -0700 URL: http://hg.openjdk.java.net/jdk7/build/jdk/rev/a43b2c9dad6f Added tag jdk7-b54 for changeset d1c43d1f5676 ! .hgtags Changeset: bccdcd761796 Author: alanb Date: 2009-03-24 14:03 +0000 URL: http://hg.openjdk.java.net/jdk7/build/jdk/rev/bccdcd761796 6819886: System.getProperty("os.name") reports Vista on Windows 7 Reviewed-by: sherman ! src/windows/native/java/lang/java_props_md.c Changeset: 4c3f752993a5 Author: alanb Date: 2009-03-24 14:05 +0000 URL: http://hg.openjdk.java.net/jdk7/build/jdk/rev/4c3f752993a5 6807702: Integer.valueOf cache should be configurable Reviewed-by: darcy ! src/share/classes/java/lang/Integer.java ! src/share/classes/java/lang/Long.java ! src/share/classes/java/lang/System.java + test/java/lang/Integer/ValueOf.java Changeset: 78063cf930e5 Author: alanb Date: 2009-03-24 14:08 +0000 URL: http://hg.openjdk.java.net/jdk7/build/jdk/rev/78063cf930e5 6819689: File.lastModified can return bogus value for remote file accessed as it is being deleted [win] Reviewed-by: sherman Contributed-by: andreas.frischknecht at softwired-inc.com ! src/windows/native/java/io/WinNTFileSystem_md.c Changeset: 52bdf8cec41d Author: alanb Date: 2009-03-24 14:10 +0000 URL: http://hg.openjdk.java.net/jdk7/build/jdk/rev/52bdf8cec41d 6621689: (dc spec) DatagramChannel.receive when channel is not bound is not specified Reviewed-by: sherman ! src/share/classes/java/nio/channels/DatagramChannel.java ! src/share/classes/sun/nio/ch/DatagramChannelImpl.java ! test/java/nio/channels/DatagramChannel/NotBound.java Changeset: 644849201ca6 Author: dl Date: 2009-03-24 19:42 -0700 URL: http://hg.openjdk.java.net/jdk7/build/jdk/rev/644849201ca6 6800572: Removing elements from views of NavigableMap implementations does not always work correctly. Summary: Replace use of new TreeSet with new KeySet Reviewed-by: martin ! src/share/classes/java/util/TreeMap.java ! src/share/classes/java/util/concurrent/ConcurrentSkipListMap.java ! test/java/util/Collection/MOAT.java Changeset: 2dae30c4d687 Author: mchung Date: 2009-03-25 12:24 -0700 URL: http://hg.openjdk.java.net/jdk7/build/jdk/rev/2dae30c4d687 6819122: DefaultProxySelector should lazily initialize the Pattern object and the NonProxyInfo objects Summary: Move two static NonProxyInfo fields into NonProxyInfo class and instantiate Pattern object when needed Reviewed-by: jccollet ! src/share/classes/sun/net/spi/DefaultProxySelector.java Changeset: 5303aece2068 Author: dl Date: 2009-03-26 11:59 -0700 URL: http://hg.openjdk.java.net/jdk7/build/jdk/rev/5303aece2068 6801020: Concurrent Semaphore release may cause some require thread not signaled Summary: Introduce PROPAGATE waitStatus Reviewed-by: martin ! src/share/classes/java/util/concurrent/locks/AbstractQueuedLongSynchronizer.java ! src/share/classes/java/util/concurrent/locks/AbstractQueuedSynchronizer.java + test/java/util/concurrent/Semaphore/RacingReleases.java Changeset: 4a685f3f3ba8 Author: dl Date: 2009-03-26 17:39 -0700 URL: http://hg.openjdk.java.net/jdk7/build/jdk/rev/4a685f3f3ba8 6822903: Reliability and documentation improvements for ReentrantReadWriteLock Summary: Make firstReader a Thread, not a long Reviewed-by: martin ! src/share/classes/java/util/concurrent/locks/ReentrantReadWriteLock.java Changeset: b752110df530 Author: weijun Date: 2009-03-27 11:05 +0800 URL: http://hg.openjdk.java.net/jdk7/build/jdk/rev/b752110df530 6802846: jarsigner needs enhanced cert validation(options) Reviewed-by: xuelei ! src/share/classes/sun/security/tools/JarSigner.java ! src/share/classes/sun/security/tools/JarSignerResources.java ! src/share/classes/sun/security/tools/KeyTool.java + test/sun/security/tools/jarsigner/concise_jarsigner.sh Changeset: 7264cacbddaa Author: alanb Date: 2009-03-27 15:24 +0000 URL: http://hg.openjdk.java.net/jdk7/build/jdk/rev/7264cacbddaa 6693490: (se) select throws "File exists" IOException under load (lnx) Reviewed-by: sherman ! src/share/classes/sun/nio/ch/SelChImpl.java ! src/solaris/classes/sun/nio/ch/EPollArrayWrapper.java ! src/solaris/classes/sun/nio/ch/EPollSelectorImpl.java + test/java/nio/channels/Selector/RegAfterPreClose.java Changeset: 9fa8b6276b31 Author: alanb Date: 2009-03-27 16:04 +0000 URL: http://hg.openjdk.java.net/jdk7/build/jdk/rev/9fa8b6276b31 6772303: (se) IOException: Invalid argument" thrown on a call to Selector.select(value) with -d64 Reviewed-by: sherman ! src/solaris/native/sun/nio/ch/DevPollArrayWrapper.c Changeset: ff0a9e50f033 Author: alanb Date: 2009-03-30 19:22 +0100 URL: http://hg.openjdk.java.net/jdk7/build/jdk/rev/ff0a9e50f033 Merge Changeset: 85a91be56593 Author: mchung Date: 2009-03-31 23:52 -0700 URL: http://hg.openjdk.java.net/jdk7/build/jdk/rev/85a91be56593 6819110: Lazily load Sun digest provider for jar verification Summary: Lazily call Providers.getSunProvider() instead of at static initializer Reviewed-by: mullan ! src/share/classes/sun/security/util/ManifestEntryVerifier.java Changeset: ee75d1fac0ca Author: weijun Date: 2009-04-03 11:36 +0800 URL: http://hg.openjdk.java.net/jdk7/build/jdk/rev/ee75d1fac0ca 6825352: support self-issued certificate in keytool Reviewed-by: xuelei ! src/share/classes/sun/security/tools/KeyTool.java + test/sun/security/tools/keytool/selfissued.sh Changeset: de80210c56a6 Author: sherman Date: 2009-04-02 15:35 -0700 URL: http://hg.openjdk.java.net/jdk7/build/jdk/rev/de80210c56a6 4681995: Add support for large (> 4GB) zip/jar files Summary: The ZIP64 format support is added for > 4GB jar/zip files Reviewed-by: alanb, martin + src/share/classes/java/util/zip/ZipConstants64.java ! src/share/classes/java/util/zip/ZipEntry.java ! src/share/classes/java/util/zip/ZipInputStream.java ! src/share/classes/java/util/zip/ZipOutputStream.java ! src/share/classes/java/util/zip/package.html ! src/share/native/java/util/zip/zip_util.c ! src/share/native/java/util/zip/zip_util.h ! src/share/native/java/util/zip/zlib-1.1.3/zlib.h + test/java/util/zip/LargeZip.java ! test/java/util/zip/ZipFile/LargeZipFile.java Changeset: 030b29ccd0db Author: sherman Date: 2009-04-03 09:51 -0700 URL: http://hg.openjdk.java.net/jdk7/build/jdk/rev/030b29ccd0db Merge Changeset: 17f50ed5fcab Author: tbell Date: 2009-04-03 10:29 -0700 URL: http://hg.openjdk.java.net/jdk7/build/jdk/rev/17f50ed5fcab Merge Changeset: 267d1f8aa82a Author: alanb Date: 2009-04-02 11:13 +0100 URL: http://hg.openjdk.java.net/jdk7/build/jdk/rev/267d1f8aa82a 6824135: (ch) test/java/nio/channels/AsyncCloseAndInterrupt.java fails (lnx) Reviewed-by: sherman ! src/share/classes/sun/nio/ch/FileChannelImpl.java ! test/java/nio/channels/AsyncCloseAndInterrupt.java Changeset: 464727e3afb4 Author: alanb Date: 2009-04-02 11:19 +0100 URL: http://hg.openjdk.java.net/jdk7/build/jdk/rev/464727e3afb4 6666739: (ref) ReferenceQueue.poll() doesn't scale well 6711667: (ref) Update SoftReference timestamp only if clock advances Summary: Forward port from 6u14; originally fixed by Tom Rodriguez in earlier update Reviewed-by: martin ! src/share/classes/java/lang/ref/ReferenceQueue.java ! src/share/classes/java/lang/ref/SoftReference.java Changeset: aed19719b1e9 Author: alanb Date: 2009-04-02 16:31 +0100 URL: http://hg.openjdk.java.net/jdk7/build/jdk/rev/aed19719b1e9 6824141: test/java/rmi/activation/rmidViaInheritedChannel tests fail Reviewed-by: peterjones ! test/java/rmi/activation/rmidViaInheritedChannel/InheritedChannelNotServerSocket.java ! test/java/rmi/activation/rmidViaInheritedChannel/RmidViaInheritedChannel.java Changeset: 4befa480d3c8 Author: alanb Date: 2009-04-02 19:47 +0100 URL: http://hg.openjdk.java.net/jdk7/build/jdk/rev/4befa480d3c8 6824477: (se) Selector.select fails with IOException: "Invalid argument" if maximum file descriptors is low Reviewed-by: sherman ! src/solaris/classes/sun/nio/ch/DevPollArrayWrapper.java + test/java/nio/channels/Selector/LotsOfUpdates.java + test/java/nio/channels/Selector/lots_of_updates.sh Changeset: e50a00095a53 Author: alanb Date: 2009-04-03 22:10 +0100 URL: http://hg.openjdk.java.net/jdk7/build/jdk/rev/e50a00095a53 6823609: (se) Selector.select hangs on Windows under load Reviewed-by: sherman ! src/windows/classes/sun/nio/ch/WindowsSelectorImpl.java + test/java/nio/channels/Selector/HelperSlowToDie.java Changeset: 93d1fbe001b8 Author: alanb Date: 2009-04-06 08:59 +0100 URL: http://hg.openjdk.java.net/jdk7/build/jdk/rev/93d1fbe001b8 4890703: Support SDP (sol) Reviewed-by: michaelm ! make/java/net/FILES_c.gmk ! make/java/net/Makefile ! make/java/net/mapfile-vers ! make/sun/net/FILES_java.gmk ! src/share/classes/java/net/AbstractPlainSocketImpl.java ! src/share/classes/sun/nio/ch/AsynchronousServerSocketChannelImpl.java ! src/share/classes/sun/nio/ch/AsynchronousSocketChannelImpl.java ! src/share/classes/sun/nio/ch/ServerSocketChannelImpl.java ! src/share/classes/sun/nio/ch/SocketChannelImpl.java + src/solaris/classes/sun/net/NetHooks.java + src/solaris/classes/sun/net/spi/SdpProvider.java ! src/solaris/classes/sun/nio/ch/UnixAsynchronousSocketChannelImpl.java + src/solaris/lib/sdp/sdp.conf.template + src/solaris/native/sun/net/spi/SdpProvider.c ! src/solaris/native/sun/nio/ch/FileChannelImpl.c + src/windows/classes/sun/net/NetHooks.java + test/sun/net/sdp/ProbeIB.java + test/sun/net/sdp/Sanity.java + test/sun/net/sdp/sanity.sh Changeset: d89688532509 Author: alanb Date: 2009-04-06 11:29 +0100 URL: http://hg.openjdk.java.net/jdk7/build/jdk/rev/d89688532509 Merge - make/jprt.config Changeset: 45ff1a9d4edb Author: valeriep Date: 2009-04-06 18:46 -0700 URL: http://hg.openjdk.java.net/jdk7/build/jdk/rev/45ff1a9d4edb 4735126: (cl) ClassLoader.loadClass locks all instances in chain when delegating Summary: Added support for parallel-capable class loaders Reviewed-by: alanb ! make/java/java/mapfile-vers ! src/share/classes/java/lang/Class.java ! src/share/classes/java/lang/ClassLoader.java ! src/share/classes/java/net/URLClassLoader.java ! src/share/classes/java/security/SecureClassLoader.java ! src/share/classes/sun/misc/Launcher.java ! src/share/native/java/lang/ClassLoader.c + test/java/lang/ClassLoader/deadlock/Alice.java + test/java/lang/ClassLoader/deadlock/Bob.java + test/java/lang/ClassLoader/deadlock/DelegatingLoader.java + test/java/lang/ClassLoader/deadlock/Starter.java + test/java/lang/ClassLoader/deadlock/SupAlice.java + test/java/lang/ClassLoader/deadlock/SupBob.java + test/java/lang/ClassLoader/deadlock/TestCrossDelegate.sh + test/java/lang/ClassLoader/deadlock/TestOneWayDelegate.sh Changeset: 22b6e09960c1 Author: valeriep Date: 2009-04-06 18:52 -0700 URL: http://hg.openjdk.java.net/jdk7/build/jdk/rev/22b6e09960c1 6440846: (cl) Deadlock between AppClassLoader and ExtClassLoader Summary: Fixed a deadlock between the two class loaders Reviewed-by: alanb ! src/share/classes/sun/security/jca/ProviderConfig.java + test/java/security/Security/ClassLoaderDeadlock/CreateSerialized.java + test/java/security/Security/ClassLoaderDeadlock/Deadlock2.java + test/java/security/Security/ClassLoaderDeadlock/Deadlock2.sh Changeset: 63e460d29580 Author: tbell Date: 2009-04-10 15:30 -0700 URL: http://hg.openjdk.java.net/jdk7/build/jdk/rev/63e460d29580 Merge - src/windows/classes/sun/awt/windows/fontconfig.98.properties - src/windows/classes/sun/awt/windows/fontconfig.Me.properties Changeset: d0b6e69791c8 Author: art Date: 2009-02-11 17:07 +0300 URL: http://hg.openjdk.java.net/jdk7/build/jdk/rev/d0b6e69791c8 6633275: Need to support shaped/translucent windows Summary: forward-port from 6u14, no public API is introduced Reviewed-by: anthony, dcherepanov ! make/sun/awt/FILES_c_windows.gmk ! make/sun/awt/Makefile ! make/sun/awt/make.depend ! make/sun/awt/mapfile-mawt-vers ! make/sun/awt/mapfile-vers-linux ! make/sun/xawt/mapfile-vers ! src/share/classes/com/sun/awt/AWTUtilities.java ! src/share/classes/java/awt/Component.java ! src/share/classes/java/awt/Container.java ! src/share/classes/java/awt/DefaultKeyboardFocusManager.java ! src/share/classes/java/awt/GraphicsConfiguration.java ! src/share/classes/java/awt/GraphicsDevice.java ! src/share/classes/java/awt/KeyboardFocusManager.java ! src/share/classes/java/awt/Window.java ! src/share/classes/java/awt/peer/WindowPeer.java ! src/share/classes/javax/swing/RepaintManager.java ! src/share/classes/sun/awt/AWTAccessor.java ! src/share/classes/sun/awt/EmbeddedFrame.java ! src/share/classes/sun/awt/SunToolkit.java + src/share/native/sun/awt/utility/rect.c ! src/solaris/classes/sun/awt/X11/XNETProtocol.java ! src/solaris/classes/sun/awt/X11/XToolkit.java ! src/solaris/classes/sun/awt/X11/XWindowPeer.java ! src/solaris/classes/sun/awt/X11/generator/WrapperGenerator.java ! src/solaris/classes/sun/awt/X11/generator/xlibtypes.txt ! src/solaris/classes/sun/awt/X11GraphicsConfig.java ! src/solaris/native/sun/awt/awt_GraphicsEnv.c ! src/solaris/native/sun/awt/awt_p.h ! src/windows/classes/sun/awt/Win32GraphicsConfig.java ! src/windows/classes/sun/awt/Win32GraphicsEnvironment.java + src/windows/classes/sun/awt/windows/TranslucentWindowPainter.java ! src/windows/classes/sun/awt/windows/WCanvasPeer.java ! src/windows/classes/sun/awt/windows/WComponentPeer.java ! src/windows/classes/sun/awt/windows/WFileDialogPeer.java ! src/windows/classes/sun/awt/windows/WPrintDialogPeer.java ! src/windows/classes/sun/awt/windows/WToolkit.java ! src/windows/classes/sun/awt/windows/WWindowPeer.java ! src/windows/classes/sun/java2d/opengl/WGLSurfaceData.java ! src/windows/native/sun/awt/utility/rect.h ! src/windows/native/sun/java2d/d3d/D3DSurfaceData.cpp ! src/windows/native/sun/java2d/opengl/WGLSurfaceData.c ! src/windows/native/sun/windows/awt_BitmapUtil.cpp ! src/windows/native/sun/windows/awt_BitmapUtil.h ! src/windows/native/sun/windows/awt_Component.cpp ! src/windows/native/sun/windows/awt_Component.h ! src/windows/native/sun/windows/awt_Window.cpp ! src/windows/native/sun/windows/awt_Window.h + test/com/sun/awt/Translucency/TranslucentJAppletTest/TranslucentJAppletTest.java + test/com/sun/awt/Translucency/TranslucentShapedFrameTest/TSFrame.java + test/com/sun/awt/Translucency/TranslucentShapedFrameTest/TranslucentShapedFrameTest.form + test/com/sun/awt/Translucency/TranslucentShapedFrameTest/TranslucentShapedFrameTest.java + test/com/sun/awt/Translucency/WindowOpacity.java + test/sun/java2d/pipe/RegionOps.java Changeset: d78988dd5659 Author: art Date: 2009-02-12 17:27 +0300 URL: http://hg.openjdk.java.net/jdk7/build/jdk/rev/d78988dd5659 6804680: Solaris AMD64 build fails after the fix for 6633275/7 Summary: addition to the fix for 6633275 Reviewed-by: yan ! src/solaris/classes/sun/awt/X11/generator/sizes.64-solaris-i386 Changeset: 0d01d1f0954d Author: dcherepanov Date: 2009-02-12 18:24 +0300 URL: http://hg.openjdk.java.net/jdk7/build/jdk/rev/0d01d1f0954d 6724890: Deadlock between AWT-EventQueue-1 and AWT-XAWT threads during IDE start Reviewed-by: art, ant ! src/share/classes/java/awt/Frame.java ! src/share/classes/sun/awt/AWTAccessor.java ! src/solaris/classes/sun/awt/X11/XFramePeer.java ! src/windows/classes/sun/awt/windows/WFramePeer.java ! src/windows/native/sun/windows/awt_Frame.cpp ! src/windows/native/sun/windows/awt_Frame.h Changeset: 03276203c39c Author: art Date: 2009-02-17 10:42 +0300 URL: http://hg.openjdk.java.net/jdk7/build/jdk/rev/03276203c39c 6806035: Fix for 6804680 is incomplete Reviewed-by: yan ! src/solaris/classes/sun/awt/X11/generator/sizes.64-solaris-i386 Changeset: 5453a374c1d5 Author: dcherepanov Date: 2009-02-17 14:27 +0300 URL: http://hg.openjdk.java.net/jdk7/build/jdk/rev/5453a374c1d5 6769607: PIT : Modal frame hangs for a while for few seconds in 6u12 b01 pit build Reviewed-by: art, anthony ! src/share/classes/java/awt/Window.java ! src/windows/native/sun/windows/awt_Dialog.cpp ! src/windows/native/sun/windows/awt_Dialog.h Changeset: 9cdba92883bf Author: dcherepanov Date: 2009-02-17 14:30 +0300 URL: http://hg.openjdk.java.net/jdk7/build/jdk/rev/9cdba92883bf 6792023: Print suspends on Windows 2000 Pro since 6u12 b01 Reviewed-by: art, anthony ! src/windows/native/sun/windows/awt_FileDialog.cpp ! src/windows/native/sun/windows/awt_PrintDialog.cpp ! src/windows/native/sun/windows/awt_PrintJob.cpp ! src/windows/native/sun/windows/awt_Window.h Changeset: e03aa9d6b8d5 Author: dcherepanov Date: 2009-02-17 14:44 +0300 URL: http://hg.openjdk.java.net/jdk7/build/jdk/rev/e03aa9d6b8d5 6723941: Crash in sun.awt.windows.WToolkit.eventLoop() Reviewed-by: art, ant ! src/windows/native/sun/windows/awt_Frame.cpp Changeset: 2083f9461cea Author: dcherepanov Date: 2009-02-19 14:10 +0300 URL: http://hg.openjdk.java.net/jdk7/build/jdk/rev/2083f9461cea 6806224: PIT : Getting java.lang.NullPointerException while opening Filedialog Reviewed-by: art, dav ! src/solaris/classes/sun/awt/X11/XComponentPeer.java ! src/solaris/classes/sun/awt/X11/XFileDialogPeer.java Changeset: 66d6db0a1de6 Author: anthony Date: 2009-02-20 17:34 +0300 URL: http://hg.openjdk.java.net/jdk7/build/jdk/rev/66d6db0a1de6 6804747: Ensure consistent graphicsConfig member across components hierarchy Reviewed-by: art, dcherepanov ! src/share/classes/java/awt/Canvas.java ! src/share/classes/java/awt/Component.java ! src/share/classes/java/awt/Container.java ! src/share/classes/java/awt/Window.java ! src/share/classes/java/awt/peer/CanvasPeer.java ! src/share/classes/java/awt/peer/ComponentPeer.java ! src/share/classes/sun/awt/AWTAccessor.java ! src/share/classes/sun/awt/ComponentAccessor.java ! src/share/classes/sun/awt/NullComponentPeer.java ! src/solaris/classes/sun/awt/X11/XCanvasPeer.java ! src/solaris/classes/sun/awt/X11/XComponentPeer.java ! src/solaris/classes/sun/awt/X11/XEmbedChildProxyPeer.java ! src/solaris/classes/sun/awt/X11/XPanelPeer.java ! src/solaris/classes/sun/awt/X11/XWindowPeer.java ! src/solaris/native/sun/awt/awt_Component.h ! src/solaris/native/sun/awt/awt_Window.h ! src/solaris/native/sun/xawt/XToolkit.c ! src/windows/classes/sun/awt/Win32GraphicsDevice.java ! src/windows/classes/sun/awt/windows/WCanvasPeer.java ! src/windows/classes/sun/awt/windows/WComponentPeer.java ! src/windows/classes/sun/awt/windows/WPanelPeer.java ! src/windows/classes/sun/awt/windows/WWindowPeer.java Changeset: b22974c82ca8 Author: lana Date: 2009-02-22 12:26 -0800 URL: http://hg.openjdk.java.net/jdk7/build/jdk/rev/b22974c82ca8 Merge - make/javax/sound/jsoundhs/FILES.gmk - make/javax/sound/jsoundhs/Makefile - make/javax/sound/jsoundhs/mapfile-vers ! make/sun/awt/mapfile-mawt-vers ! make/sun/xawt/mapfile-vers - src/share/classes/com/sun/beans/ObjectHandler.java - src/share/classes/com/sun/jmx/namespace/JMXNamespaceUtils.java ! src/share/classes/javax/swing/RepaintManager.java - src/share/classes/sun/nio/cs/IBM437.java - src/share/classes/sun/nio/cs/IBM737.java - src/share/classes/sun/nio/cs/IBM775.java - src/share/classes/sun/nio/cs/IBM850.java - src/share/classes/sun/nio/cs/IBM852.java - src/share/classes/sun/nio/cs/IBM855.java - src/share/classes/sun/nio/cs/IBM857.java - src/share/classes/sun/nio/cs/IBM858.java - src/share/classes/sun/nio/cs/IBM862.java - src/share/classes/sun/nio/cs/IBM866.java - src/share/classes/sun/nio/cs/IBM874.java - src/share/classes/sun/nio/cs/ISO_8859_13.java - src/share/classes/sun/nio/cs/ISO_8859_15.java - src/share/classes/sun/nio/cs/ISO_8859_2.java - src/share/classes/sun/nio/cs/ISO_8859_4.java - src/share/classes/sun/nio/cs/ISO_8859_5.java - src/share/classes/sun/nio/cs/ISO_8859_7.java - src/share/classes/sun/nio/cs/ISO_8859_9.java - src/share/classes/sun/nio/cs/KOI8_R.java - src/share/classes/sun/nio/cs/KOI8_U.java - src/share/classes/sun/nio/cs/MS1250.java - src/share/classes/sun/nio/cs/MS1251.java - src/share/classes/sun/nio/cs/MS1252.java - src/share/classes/sun/nio/cs/MS1253.java - src/share/classes/sun/nio/cs/MS1254.java - src/share/classes/sun/nio/cs/MS1257.java - src/share/classes/sun/nio/cs/ext/IBM037.java - src/share/classes/sun/nio/cs/ext/IBM1006.java - src/share/classes/sun/nio/cs/ext/IBM1025.java - src/share/classes/sun/nio/cs/ext/IBM1026.java - src/share/classes/sun/nio/cs/ext/IBM1046.java - src/share/classes/sun/nio/cs/ext/IBM1047.java - src/share/classes/sun/nio/cs/ext/IBM1097.java - src/share/classes/sun/nio/cs/ext/IBM1098.java - src/share/classes/sun/nio/cs/ext/IBM1112.java - src/share/classes/sun/nio/cs/ext/IBM1122.java - src/share/classes/sun/nio/cs/ext/IBM1123.java - src/share/classes/sun/nio/cs/ext/IBM1124.java - src/share/classes/sun/nio/cs/ext/IBM1140.java - src/share/classes/sun/nio/cs/ext/IBM1141.java - src/share/classes/sun/nio/cs/ext/IBM1142.java - src/share/classes/sun/nio/cs/ext/IBM1143.java - src/share/classes/sun/nio/cs/ext/IBM1144.java - src/share/classes/sun/nio/cs/ext/IBM1145.java - src/share/classes/sun/nio/cs/ext/IBM1146.java - src/share/classes/sun/nio/cs/ext/IBM1147.java - src/share/classes/sun/nio/cs/ext/IBM1148.java - src/share/classes/sun/nio/cs/ext/IBM1149.java - src/share/classes/sun/nio/cs/ext/IBM273.java - src/share/classes/sun/nio/cs/ext/IBM277.java - src/share/classes/sun/nio/cs/ext/IBM278.java - src/share/classes/sun/nio/cs/ext/IBM280.java - src/share/classes/sun/nio/cs/ext/IBM284.java - src/share/classes/sun/nio/cs/ext/IBM285.java - src/share/classes/sun/nio/cs/ext/IBM297.java - src/share/classes/sun/nio/cs/ext/IBM420.java - src/share/classes/sun/nio/cs/ext/IBM424.java - src/share/classes/sun/nio/cs/ext/IBM500.java - src/share/classes/sun/nio/cs/ext/IBM838.java - src/share/classes/sun/nio/cs/ext/IBM856.java - src/share/classes/sun/nio/cs/ext/IBM860.java - src/share/classes/sun/nio/cs/ext/IBM861.java - src/share/classes/sun/nio/cs/ext/IBM863.java - src/share/classes/sun/nio/cs/ext/IBM864.java - src/share/classes/sun/nio/cs/ext/IBM865.java - src/share/classes/sun/nio/cs/ext/IBM868.java - src/share/classes/sun/nio/cs/ext/IBM869.java - src/share/classes/sun/nio/cs/ext/IBM870.java - src/share/classes/sun/nio/cs/ext/IBM871.java - src/share/classes/sun/nio/cs/ext/IBM875.java - src/share/classes/sun/nio/cs/ext/IBM918.java - src/share/classes/sun/nio/cs/ext/IBM921.java - src/share/classes/sun/nio/cs/ext/IBM922.java - src/share/classes/sun/nio/cs/ext/ISO_8859_11.java - src/share/classes/sun/nio/cs/ext/ISO_8859_3.java - src/share/classes/sun/nio/cs/ext/ISO_8859_6.java - src/share/classes/sun/nio/cs/ext/ISO_8859_8.java - src/share/classes/sun/nio/cs/ext/MS1255.java - src/share/classes/sun/nio/cs/ext/MS1256.java - src/share/classes/sun/nio/cs/ext/MS1258.java - src/share/classes/sun/nio/cs/ext/MS874.java - src/share/classes/sun/nio/cs/ext/MacArabic.java - src/share/classes/sun/nio/cs/ext/MacCentralEurope.java - src/share/classes/sun/nio/cs/ext/MacCroatian.java - src/share/classes/sun/nio/cs/ext/MacCyrillic.java - src/share/classes/sun/nio/cs/ext/MacDingbat.java - src/share/classes/sun/nio/cs/ext/MacGreek.java - src/share/classes/sun/nio/cs/ext/MacHebrew.java - src/share/classes/sun/nio/cs/ext/MacIceland.java - src/share/classes/sun/nio/cs/ext/MacRoman.java - src/share/classes/sun/nio/cs/ext/MacRomania.java - src/share/classes/sun/nio/cs/ext/MacSymbol.java - src/share/classes/sun/nio/cs/ext/MacThai.java - src/share/classes/sun/nio/cs/ext/MacTurkish.java - src/share/classes/sun/nio/cs/ext/MacUkraine.java - src/share/classes/sun/nio/cs/ext/TIS_620.java - src/share/lib/audio/soundbank.gm ! src/windows/classes/sun/awt/Win32GraphicsEnvironment.java Changeset: a2082e850247 Author: anthony Date: 2009-03-03 13:54 +0300 URL: http://hg.openjdk.java.net/jdk7/build/jdk/rev/a2082e850247 6811674: Container.setComponentZOrder throws NPE Reviewed-by: art, dcherepanov ! src/share/classes/java/awt/Container.java Changeset: ae27b7949714 Author: dcherepanov Date: 2009-03-04 13:05 +0300 URL: http://hg.openjdk.java.net/jdk7/build/jdk/rev/ae27b7949714 6809227: poor performance on Panel.Add() method in jdk6 Reviewed-by: art, anthony ! make/sun/xawt/mapfile-vers ! src/share/classes/java/awt/Component.java ! src/share/classes/java/awt/Container.java ! src/share/classes/java/awt/peer/ComponentPeer.java ! src/share/classes/java/awt/peer/ContainerPeer.java ! src/share/classes/sun/awt/NullComponentPeer.java ! src/solaris/classes/sun/awt/X11/XComponentPeer.java ! src/solaris/classes/sun/awt/X11/XEmbedChildProxyPeer.java ! src/solaris/classes/sun/awt/X11/XlibWrapper.java ! src/solaris/native/sun/xawt/XlibWrapper.c ! src/windows/classes/sun/awt/windows/WComponentPeer.java ! src/windows/classes/sun/awt/windows/WFileDialogPeer.java ! src/windows/classes/sun/awt/windows/WPrintDialogPeer.java ! src/windows/classes/sun/awt/windows/WScrollPanePeer.java ! src/windows/native/sun/windows/awt_Component.cpp ! src/windows/native/sun/windows/awt_Component.h ! src/windows/native/sun/windows/awt_Panel.cpp ! src/windows/native/sun/windows/awt_Panel.h Changeset: e7205c5dd3b7 Author: art Date: 2009-03-04 18:10 +0300 URL: http://hg.openjdk.java.net/jdk7/build/jdk/rev/e7205c5dd3b7 6784816: Remove AWT tree lock from Container methods: getComponent, getComponents, getComponentCount Reviewed-by: anthony, dav ! src/share/classes/java/awt/Container.java Changeset: 4dc625187820 Author: ant Date: 2009-03-10 18:33 +0300 URL: http://hg.openjdk.java.net/jdk7/build/jdk/rev/4dc625187820 6806217: implement synthetic focus model for MS Windows Reviewed-by: art, dcherepanov ! make/sun/awt/make.depend ! src/share/classes/java/awt/Component.java ! src/share/classes/java/awt/KeyboardFocusManager.java ! src/share/classes/sun/awt/AWTAccessor.java ! src/share/classes/sun/awt/HeadlessToolkit.java ! src/share/classes/sun/awt/KeyboardFocusManagerPeerImpl.java ! src/share/classes/sun/awt/SunToolkit.java ! src/solaris/classes/sun/awt/X11/XComponentPeer.java ! src/solaris/classes/sun/awt/X11/XEmbedChildProxyPeer.java ! src/solaris/classes/sun/awt/X11/XKeyboardFocusManagerPeer.java ! src/windows/classes/sun/awt/windows/WChoicePeer.java ! src/windows/classes/sun/awt/windows/WComponentPeer.java + src/windows/classes/sun/awt/windows/WKeyboardFocusManagerPeer.java ! src/windows/classes/sun/awt/windows/WToolkit.java ! src/windows/classes/sun/awt/windows/WWindowPeer.java ! src/windows/native/sun/windows/awt_Button.cpp ! src/windows/native/sun/windows/awt_Button.h ! src/windows/native/sun/windows/awt_Canvas.cpp ! src/windows/native/sun/windows/awt_Checkbox.cpp ! src/windows/native/sun/windows/awt_Checkbox.h ! src/windows/native/sun/windows/awt_Choice.cpp ! src/windows/native/sun/windows/awt_Choice.h ! src/windows/native/sun/windows/awt_Component.cpp ! src/windows/native/sun/windows/awt_Component.h ! src/windows/native/sun/windows/awt_Frame.cpp ! src/windows/native/sun/windows/awt_Frame.h ! src/windows/native/sun/windows/awt_KeyboardFocusManager.cpp - src/windows/native/sun/windows/awt_KeyboardFocusManager.h ! src/windows/native/sun/windows/awt_List.cpp ! src/windows/native/sun/windows/awt_List.h ! src/windows/native/sun/windows/awt_PrintDialog.cpp ! src/windows/native/sun/windows/awt_ScrollPane.cpp ! src/windows/native/sun/windows/awt_ScrollPane.h ! src/windows/native/sun/windows/awt_Scrollbar.cpp ! src/windows/native/sun/windows/awt_Scrollbar.h ! src/windows/native/sun/windows/awt_TextArea.cpp ! src/windows/native/sun/windows/awt_TextComponent.cpp ! src/windows/native/sun/windows/awt_TextComponent.h ! src/windows/native/sun/windows/awt_TextField.cpp ! src/windows/native/sun/windows/awt_Window.cpp ! src/windows/native/sun/windows/awt_Window.h ! src/windows/native/sun/windows/awtmsg.h + test/java/awt/Focus/ClearGlobalFocusOwnerTest/ClearGlobalFocusOwnerTest.java ! test/java/awt/Focus/IconifiedFrameFocusChangeTest/IconifiedFrameFocusChangeTest.java + test/java/awt/Focus/RemoveAfterRequest/RemoveAfterRequest.java Changeset: 04b368454df3 Author: ant Date: 2009-03-11 16:11 +0300 URL: http://hg.openjdk.java.net/jdk7/build/jdk/rev/04b368454df3 6815946: regression: failed to build MToolkit Reviewed-by: anthony ! src/share/classes/sun/awt/AWTAccessor.java ! src/solaris/classes/sun/awt/motif/MToolkit.java Changeset: 6df5f5fb5174 Author: dcherepanov Date: 2009-03-13 18:07 +0300 URL: http://hg.openjdk.java.net/jdk7/build/jdk/rev/6df5f5fb5174 6805897: Gap present between the choice and its drop down list in Jdk 7 build for a non resizable frame. Reviewed-by: art, anthony ! src/solaris/classes/sun/awt/X11/XDecoratedPeer.java Changeset: c58f41b4bfbd Author: dcherepanov Date: 2009-03-20 08:41 -0400 URL: http://hg.openjdk.java.net/jdk7/build/jdk/rev/c58f41b4bfbd 6774258: api/java_awt/Component/index.html#PaintUpdate fails randomly Reviewed-by: art ! src/windows/classes/sun/awt/windows/WComponentPeer.java ! src/windows/classes/sun/java2d/d3d/D3DScreenUpdateManager.java + test/java/awt/Component/NoUpdateUponShow/NoUpdateUponShow.java Changeset: 55f02057dc37 Author: dcherepanov Date: 2009-03-23 11:59 +0300 URL: http://hg.openjdk.java.net/jdk7/build/jdk/rev/55f02057dc37 6516404: regression: Choice vertical scrollbar is not seen when the item in the choice is increased more than Reviewed-by: art, dav ! src/windows/native/sun/windows/awt_Choice.cpp Changeset: adaee9531504 Author: dcherepanov Date: 2009-03-23 09:47 -0400 URL: http://hg.openjdk.java.net/jdk7/build/jdk/rev/adaee9531504 6730447: Support for high resolution mouse wheel is still incomplete. AWT panel needs to be supported Reviewed-by: art, dav ! src/windows/native/sun/windows/awt_Component.cpp ! src/windows/native/sun/windows/awt_Component.h + test/java/awt/event/MouseEvent/AWTPanelSmoothWheel/AWTPanelSmoothWheel.html + test/java/awt/event/MouseEvent/AWTPanelSmoothWheel/AWTPanelSmoothWheel.java Changeset: f3ed90be28fc Author: rkennke Date: 2009-03-24 21:57 +0100 URL: http://hg.openjdk.java.net/jdk7/build/jdk/rev/f3ed90be28fc 6809233: Modal dialog blocks calling thread after it is hidden and disposed Summary: Send WakingRunnable to toolkit to prevent early cleanup. Reviewed-by: art, son ! src/share/classes/java/awt/Dialog.java Changeset: a702e8ff83bd Author: anthony Date: 2009-03-25 13:37 +0300 URL: http://hg.openjdk.java.net/jdk7/build/jdk/rev/a702e8ff83bd 6714678: IDE (Netbeans, Eclipse, JDeveloper) Debugger hangs process on Linux Summary: Added the system property sun.awt.disablegrab Reviewed-by: art, dcherepanov ! src/solaris/classes/sun/awt/X11/XBaseWindow.java ! src/solaris/classes/sun/awt/X11/XToolkit.java Changeset: 0cbcc4bdf95a Author: anthony Date: 2009-03-26 14:38 +0300 URL: http://hg.openjdk.java.net/jdk7/build/jdk/rev/0cbcc4bdf95a 6693253: Security Warning appearance requires enhancements 6779717: A Window does not show applet security warning icon on X platforms 6785058: Parent dn't get the focus after dialog is closed if security warning is applied Summary: Forward-port from 6u10-6u14 Reviewed-by: art, dcherepanov ! make/sun/awt/Depend.mak ! make/sun/awt/FILES_c_windows.gmk ! make/sun/awt/README ! make/sun/awt/make.depend ! make/sun/xawt/FILES_c_unix.gmk ! make/sun/xawt/Makefile ! make/sun/xawt/mapfile-vers + src/share/classes/com/sun/awt/SecurityWarning.java ! src/share/classes/java/awt/Component.java ! src/share/classes/java/awt/Window.java ! src/share/classes/java/awt/peer/WindowPeer.java ! src/share/classes/sun/awt/AWTAccessor.java ! src/share/classes/sun/awt/EmbeddedFrame.java + src/solaris/classes/sun/awt/X11/InfoWindow.java ! src/solaris/classes/sun/awt/X11/XDecoratedPeer.java ! src/solaris/classes/sun/awt/X11/XKeyboardFocusManagerPeer.java ! src/solaris/classes/sun/awt/X11/XNETProtocol.java ! src/solaris/classes/sun/awt/X11/XTrayIconPeer.java ! src/solaris/classes/sun/awt/X11/XWM.java ! src/solaris/classes/sun/awt/X11/XWarningWindow.java ! src/solaris/classes/sun/awt/X11/XWindow.java ! src/solaris/classes/sun/awt/X11/XWindowPeer.java ! src/solaris/classes/sun/awt/X11/XlibWrapper.java + src/solaris/classes/sun/awt/X11/security-icon-bw16.png + src/solaris/classes/sun/awt/X11/security-icon-bw24.png + src/solaris/classes/sun/awt/X11/security-icon-bw32.png + src/solaris/classes/sun/awt/X11/security-icon-bw48.png + src/solaris/classes/sun/awt/X11/security-icon-interim16.png + src/solaris/classes/sun/awt/X11/security-icon-interim24.png + src/solaris/classes/sun/awt/X11/security-icon-interim32.png + src/solaris/classes/sun/awt/X11/security-icon-interim48.png + src/solaris/classes/sun/awt/X11/security-icon-yellow16.png + src/solaris/classes/sun/awt/X11/security-icon-yellow24.png + src/solaris/classes/sun/awt/X11/security-icon-yellow32.png + src/solaris/classes/sun/awt/X11/security-icon-yellow48.png ! src/solaris/native/sun/awt/utility/rect.h ! src/solaris/native/sun/xawt/XlibWrapper.c ! src/windows/classes/sun/awt/windows/WWindowPeer.java ! src/windows/native/sun/windows/ComCtl32Util.cpp ! src/windows/native/sun/windows/ComCtl32Util.h + src/windows/native/sun/windows/DllUtil.cpp + src/windows/native/sun/windows/DllUtil.h ! src/windows/native/sun/windows/awt.rc ! src/windows/native/sun/windows/awt_Component.cpp ! src/windows/native/sun/windows/awt_Component.h ! src/windows/native/sun/windows/awt_Dialog.cpp ! src/windows/native/sun/windows/awt_Dialog.h ! src/windows/native/sun/windows/awt_Frame.cpp ! src/windows/native/sun/windows/awt_Frame.h ! src/windows/native/sun/windows/awt_Toolkit.cpp ! src/windows/native/sun/windows/awt_Toolkit.h ! src/windows/native/sun/windows/awt_Win32GraphicsEnv.cpp ! src/windows/native/sun/windows/awt_Window.cpp ! src/windows/native/sun/windows/awt_Window.h + src/windows/native/sun/windows/security_warning.ico + src/windows/native/sun/windows/security_warning_bw.ico + src/windows/native/sun/windows/security_warning_int.ico + test/java/awt/Focus/CloseDialogActivateOwnerTest/CloseDialogActivateOwnerTest.java + test/java/awt/Focus/CloseDialogActivateOwnerTest/java.policy + test/java/awt/Focus/OwnedWindowFocusIMECrashTest/OwnedWindowFocusIMECrashTest.java Changeset: abf3b2ecfa06 Author: yan Date: 2009-03-27 12:01 +0300 URL: http://hg.openjdk.java.net/jdk7/build/jdk/rev/abf3b2ecfa06 6680988: KeyEvent is still missing VK values for many keyboards Summary: 2 new methods and some fields added to KeyEvent, plus hash of constants introduced Reviewed-by: art ! make/sun/awt/FILES_export_unix.gmk ! make/sun/awt/FILES_export_windows.gmk ! make/sun/xawt/mapfile-vers ! src/share/classes/java/awt/AWTKeyStroke.java ! src/share/classes/java/awt/MenuItem.java ! src/share/classes/java/awt/MenuShortcut.java ! src/share/classes/java/awt/event/KeyEvent.java ! src/share/classes/javax/swing/AbstractButton.java ! src/share/classes/javax/swing/Action.java ! src/share/classes/javax/swing/JComponent.java ! src/share/classes/javax/swing/JLabel.java ! src/share/classes/javax/swing/JTabbedPane.java ! src/share/classes/javax/swing/KeyStroke.java ! src/share/classes/javax/swing/KeyboardManager.java ! src/share/classes/javax/swing/SwingUtilities.java + src/share/classes/sun/awt/ExtendedKeyCodes.java ! src/solaris/classes/sun/awt/X11/XConstants.java ! src/solaris/classes/sun/awt/X11/XKeysym.java ! src/solaris/classes/sun/awt/X11/XToolkit.java ! src/solaris/classes/sun/awt/X11/XWindow.java ! src/solaris/classes/sun/awt/X11/XlibWrapper.java ! src/solaris/classes/sun/awt/X11/generator/WrapperGenerator.java ! src/solaris/classes/sun/awt/X11/generator/xlibtypes.txt ! src/solaris/classes/sun/awt/X11/keysym2ucs.h ! src/solaris/native/sun/xawt/XlibWrapper.c ! src/windows/native/sun/windows/awt_Component.cpp ! src/windows/native/sun/windows/awt_Component.h ! src/windows/native/sun/windows/awt_InputMethod.cpp ! src/windows/native/sun/windows/awt_KeyEvent.cpp ! src/windows/native/sun/windows/awt_KeyEvent.h + test/java/awt/event/KeyEvent/AcceleratorTest/AcceleratorTest.html + test/java/awt/event/KeyEvent/AcceleratorTest/AcceleratorTest.java Changeset: 9d26016be6fa Author: yan Date: 2009-03-30 16:33 +0400 URL: http://hg.openjdk.java.net/jdk7/build/jdk/rev/9d26016be6fa 6823589: Remake sizes.64-solaris-i386 with newly added fields 6782746: Keyboard hotkeys don't work in locales where non latin characters are used 6299348: Zero keycode returned in keyPressed and keyReleased for some keys in non-english layout - Win32 6316369: Provide a method to convert a character to VK_* Java keycode, if possible. 6446568: KeyEvent lacks 3 virtual keys of Danish keyboards 6559449: Support for converting from char to KeyEvent VK_ keycode 6182651: Need to identify any key pressed/released with a unique code Summary: Various by-products of 6680988 fix. Reviewed-by: art ! src/solaris/classes/sun/awt/X11/generator/sizes.64-solaris-i386 Changeset: 3a9ae1117c12 Author: anthony Date: 2009-03-31 18:47 +0400 URL: http://hg.openjdk.java.net/jdk7/build/jdk/rev/3a9ae1117c12 6819601: Fix AWT JTReg tests which fail to compile Summary: Fix compilation of tests. Reviewed-by: anthony, son Contributed-by: Andrew John Hughes ! test/java/awt/Component/isLightweightCrash/StubPeerCrash.java ! test/java/awt/EventQueue/6638195/bug6638195.java Changeset: 1cb2e3e0631f Author: anthony Date: 2009-04-01 19:05 +0400 URL: http://hg.openjdk.java.net/jdk7/build/jdk/rev/1cb2e3e0631f 6818312: com.sun.awt.SecurityWarning.getSize() always reports (0, 0) on X11 Summary: The fix got pushed with 6693253. However the test was omitted. Here it comes. Reviewed-by: dcherepanov, art + test/com/sun/awt/SecurityWarning/GetSizeShouldNotReturnZero.java Changeset: c5f1721eebb2 Author: lana Date: 2009-04-09 13:12 -0700 URL: http://hg.openjdk.java.net/jdk7/build/jdk/rev/c5f1721eebb2 Merge ! make/sun/awt/Makefile ! make/sun/xawt/mapfile-vers ! src/windows/native/sun/windows/awt.rc - src/windows/native/sun/windows/awt_KeyboardFocusManager.h Changeset: 73f0e751b669 Author: dcherepanov Date: 2009-04-13 15:22 +0400 URL: http://hg.openjdk.java.net/jdk7/build/jdk/rev/73f0e751b669 6829326: Getting java.lang.NullPointerException: null pData while opening a File,Print,Page Dialog in Win Reviewed-by: art, yan ! src/windows/classes/sun/awt/windows/WFileDialogPeer.java ! src/windows/classes/sun/awt/windows/WPrintDialogPeer.java Changeset: 6a789813407d Author: lana Date: 2009-04-13 15:33 -0700 URL: http://hg.openjdk.java.net/jdk7/build/jdk/rev/6a789813407d Merge Changeset: a5746eca3686 Author: lana Date: 2009-04-13 22:34 -0700 URL: http://hg.openjdk.java.net/jdk7/build/jdk/rev/a5746eca3686 Merge - src/windows/native/sun/windows/awt_KeyboardFocusManager.h Changeset: 442b563e57c6 Author: peterz Date: 2009-02-04 18:48 +0300 URL: http://hg.openjdk.java.net/jdk7/build/jdk/rev/442b563e57c6 6588003: LayoutQueue shares mutable implementation across AppContexts Summary: DefaultQueue property is made per-AppContext Reviewed-by: alexp ! src/share/classes/javax/swing/text/LayoutQueue.java + test/javax/swing/text/LayoutQueue/Test6588003.java Changeset: 62a84e564a8c Author: malenkov Date: 2009-02-05 14:48 +0300 URL: http://hg.openjdk.java.net/jdk7/build/jdk/rev/62a84e564a8c 4769844: classes in java.beans that are serializable but don't define serialVersionUID Reviewed-by: peterz, rupashka ! src/share/classes/java/beans/IndexedPropertyChangeEvent.java ! src/share/classes/java/beans/IntrospectionException.java ! src/share/classes/java/beans/PropertyChangeEvent.java ! src/share/classes/java/beans/PropertyVetoException.java ! src/share/classes/java/beans/beancontext/BeanContextEvent.java ! src/share/classes/java/beans/beancontext/BeanContextMembershipEvent.java ! src/share/classes/java/beans/beancontext/BeanContextServiceAvailableEvent.java ! src/share/classes/java/beans/beancontext/BeanContextServiceRevokedEvent.java ! src/share/classes/java/beans/beancontext/BeanContextServicesSupport.java ! src/share/classes/sun/beans/editors/ColorEditor.java ! src/share/classes/sun/beans/editors/FontEditor.java Changeset: 27dabbdfdcac Author: malenkov Date: 2009-02-05 17:00 +0300 URL: http://hg.openjdk.java.net/jdk7/build/jdk/rev/27dabbdfdcac 6669869: Beans.isDesignTime() and other queries should be per-AppContext Reviewed-by: peterz, rupashka ! src/share/classes/java/beans/Beans.java + test/java/beans/Beans/6669869/TestDesignTime.java + test/java/beans/Beans/6669869/TestGuiAvailable.java Changeset: 0960e96d0de8 Author: peterz Date: 2009-02-05 19:16 +0300 URL: http://hg.openjdk.java.net/jdk7/build/jdk/rev/0960e96d0de8 6801769: 6588003 should be backed out from jdk7 Reviewed-by: alexp ! src/share/classes/javax/swing/text/LayoutQueue.java Changeset: 794e786306c1 Author: art Date: 2009-02-12 14:19 +0300 URL: http://hg.openjdk.java.net/jdk7/build/jdk/rev/794e786306c1 6799345: JFC demos threw exception in the Java Console when applets are closed Reviewed-by: alexp, peterz ! src/share/classes/javax/swing/SwingWorker.java ! src/share/classes/javax/swing/TimerQueue.java + test/javax/swing/system/6799345/TestShutdown.java Changeset: 6b77fbb7e33e Author: lana Date: 2009-02-23 11:16 -0800 URL: http://hg.openjdk.java.net/jdk7/build/jdk/rev/6b77fbb7e33e Merge - src/share/classes/com/sun/jmx/namespace/JMXNamespaceUtils.java ! src/share/classes/javax/swing/TimerQueue.java ! src/share/classes/javax/swing/text/LayoutQueue.java - src/share/classes/org/jcp/xml/dsig/internal/package.html - src/share/classes/sun/launcher/LauncherHelp.java - src/share/classes/sun/nio/cs/IBM437.java - src/share/classes/sun/nio/cs/IBM737.java - src/share/classes/sun/nio/cs/IBM775.java - src/share/classes/sun/nio/cs/IBM850.java - src/share/classes/sun/nio/cs/IBM852.java - src/share/classes/sun/nio/cs/IBM855.java - src/share/classes/sun/nio/cs/IBM857.java - src/share/classes/sun/nio/cs/IBM858.java - src/share/classes/sun/nio/cs/IBM862.java - src/share/classes/sun/nio/cs/IBM866.java - src/share/classes/sun/nio/cs/IBM874.java - src/share/classes/sun/nio/cs/ISO_8859_13.java - src/share/classes/sun/nio/cs/ISO_8859_15.java - src/share/classes/sun/nio/cs/ISO_8859_2.java - src/share/classes/sun/nio/cs/ISO_8859_4.java - src/share/classes/sun/nio/cs/ISO_8859_5.java - src/share/classes/sun/nio/cs/ISO_8859_7.java - src/share/classes/sun/nio/cs/ISO_8859_9.java - src/share/classes/sun/nio/cs/KOI8_R.java - src/share/classes/sun/nio/cs/KOI8_U.java - src/share/classes/sun/nio/cs/MS1250.java - src/share/classes/sun/nio/cs/MS1251.java - src/share/classes/sun/nio/cs/MS1252.java - src/share/classes/sun/nio/cs/MS1253.java - src/share/classes/sun/nio/cs/MS1254.java - src/share/classes/sun/nio/cs/MS1257.java - src/share/classes/sun/nio/cs/ext/IBM037.java - src/share/classes/sun/nio/cs/ext/IBM1006.java - src/share/classes/sun/nio/cs/ext/IBM1025.java - src/share/classes/sun/nio/cs/ext/IBM1026.java - src/share/classes/sun/nio/cs/ext/IBM1046.java - src/share/classes/sun/nio/cs/ext/IBM1047.java - src/share/classes/sun/nio/cs/ext/IBM1097.java - src/share/classes/sun/nio/cs/ext/IBM1098.java - src/share/classes/sun/nio/cs/ext/IBM1112.java - src/share/classes/sun/nio/cs/ext/IBM1122.java - src/share/classes/sun/nio/cs/ext/IBM1123.java - src/share/classes/sun/nio/cs/ext/IBM1124.java - src/share/classes/sun/nio/cs/ext/IBM1140.java - src/share/classes/sun/nio/cs/ext/IBM1141.java - src/share/classes/sun/nio/cs/ext/IBM1142.java - src/share/classes/sun/nio/cs/ext/IBM1143.java - src/share/classes/sun/nio/cs/ext/IBM1144.java - src/share/classes/sun/nio/cs/ext/IBM1145.java - src/share/classes/sun/nio/cs/ext/IBM1146.java - src/share/classes/sun/nio/cs/ext/IBM1147.java - src/share/classes/sun/nio/cs/ext/IBM1148.java - src/share/classes/sun/nio/cs/ext/IBM1149.java - src/share/classes/sun/nio/cs/ext/IBM273.java - src/share/classes/sun/nio/cs/ext/IBM277.java - src/share/classes/sun/nio/cs/ext/IBM278.java - src/share/classes/sun/nio/cs/ext/IBM280.java - src/share/classes/sun/nio/cs/ext/IBM284.java - src/share/classes/sun/nio/cs/ext/IBM285.java - src/share/classes/sun/nio/cs/ext/IBM297.java - src/share/classes/sun/nio/cs/ext/IBM420.java - src/share/classes/sun/nio/cs/ext/IBM424.java - src/share/classes/sun/nio/cs/ext/IBM500.java - src/share/classes/sun/nio/cs/ext/IBM838.java - src/share/classes/sun/nio/cs/ext/IBM856.java - src/share/classes/sun/nio/cs/ext/IBM860.java - src/share/classes/sun/nio/cs/ext/IBM861.java - src/share/classes/sun/nio/cs/ext/IBM863.java - src/share/classes/sun/nio/cs/ext/IBM864.java - src/share/classes/sun/nio/cs/ext/IBM865.java - src/share/classes/sun/nio/cs/ext/IBM868.java - src/share/classes/sun/nio/cs/ext/IBM869.java - src/share/classes/sun/nio/cs/ext/IBM870.java - src/share/classes/sun/nio/cs/ext/IBM871.java - src/share/classes/sun/nio/cs/ext/IBM875.java - src/share/classes/sun/nio/cs/ext/IBM918.java - src/share/classes/sun/nio/cs/ext/IBM921.java - src/share/classes/sun/nio/cs/ext/IBM922.java - src/share/classes/sun/nio/cs/ext/ISO_8859_11.java - src/share/classes/sun/nio/cs/ext/ISO_8859_3.java - src/share/classes/sun/nio/cs/ext/ISO_8859_6.java - src/share/classes/sun/nio/cs/ext/ISO_8859_8.java - src/share/classes/sun/nio/cs/ext/MS1255.java - src/share/classes/sun/nio/cs/ext/MS1256.java - src/share/classes/sun/nio/cs/ext/MS1258.java - src/share/classes/sun/nio/cs/ext/MS874.java - src/share/classes/sun/nio/cs/ext/MacArabic.java - src/share/classes/sun/nio/cs/ext/MacCentralEurope.java - src/share/classes/sun/nio/cs/ext/MacCroatian.java - src/share/classes/sun/nio/cs/ext/MacCyrillic.java - src/share/classes/sun/nio/cs/ext/MacDingbat.java - src/share/classes/sun/nio/cs/ext/MacGreek.java - src/share/classes/sun/nio/cs/ext/MacHebrew.java - src/share/classes/sun/nio/cs/ext/MacIceland.java - src/share/classes/sun/nio/cs/ext/MacRoman.java - src/share/classes/sun/nio/cs/ext/MacRomania.java - src/share/classes/sun/nio/cs/ext/MacSymbol.java - src/share/classes/sun/nio/cs/ext/MacThai.java - src/share/classes/sun/nio/cs/ext/MacTurkish.java - src/share/classes/sun/nio/cs/ext/MacUkraine.java - src/share/classes/sun/nio/cs/ext/TIS_620.java - src/windows/native/sun/windows/UnicowsLoader.cpp - src/windows/native/sun/windows/UnicowsLoader.h - src/windows/native/sun/windows/awt_MMStub.cpp - src/windows/native/sun/windows/awt_MMStub.h - src/windows/native/sun/windows/awt_Multimon.h - src/windows/native/sun/windows/awt_Unicode.cpp - src/windows/native/sun/windows/awt_Unicode.h - src/windows/native/sun/windows/awt_dlls.cpp - src/windows/native/sun/windows/awt_dlls.h - test/sun/net/www/http/ChunkedInputStream/test.txt - test/tools/launcher/Arrrghs.sh Changeset: c466ef3f1ea0 Author: peterz Date: 2009-02-24 19:17 +0300 URL: http://hg.openjdk.java.net/jdk7/build/jdk/rev/c466ef3f1ea0 6804221: Three tests for JTabbedPane produce VM crash on rhel3 Reviewed-by: stayer, campbell ! src/solaris/native/sun/awt/gtk2_interface.c Changeset: 02b64d5fad60 Author: rupashka Date: 2009-02-26 11:44 +0300 URL: http://hg.openjdk.java.net/jdk7/build/jdk/rev/02b64d5fad60 6794831: Infinite loop while painting ticks on Slider with maximum=MAX_INT Reviewed-by: malenkov ! src/share/classes/javax/swing/plaf/basic/BasicSliderUI.java + test/javax/swing/JSlider/6794831/bug6794831.java Changeset: 51148b9aed43 Author: rupashka Date: 2009-03-12 14:00 +0300 URL: http://hg.openjdk.java.net/jdk7/build/jdk/rev/51148b9aed43 6491795: COM should be initialized for Shell API calls in ShellFolder2.cpp Reviewed-by: peterz, loneid ! src/share/classes/javax/swing/plaf/basic/BasicDirectoryModel.java ! src/share/classes/sun/awt/shell/ShellFolder.java ! src/share/classes/sun/awt/shell/ShellFolderManager.java ! src/share/classes/sun/swing/FilePane.java ! src/windows/classes/sun/awt/shell/Win32ShellFolder2.java ! src/windows/classes/sun/awt/shell/Win32ShellFolderManager2.java ! src/windows/native/sun/windows/ShellFolder2.cpp + test/javax/swing/JFileChooser/6570445/bug6570445.java Changeset: 4f7dd74de2e3 Author: peterz Date: 2009-03-13 19:25 +0300 URL: http://hg.openjdk.java.net/jdk7/build/jdk/rev/4f7dd74de2e3 6815767: Bad parameter when calling another method in the class SynthTabbedPaneUI Reviewed-by: alexp, rupashka ! src/share/classes/javax/swing/plaf/synth/SynthTabbedPaneUI.java Changeset: 540c7f47aadf Author: rupashka Date: 2009-03-17 16:06 +0300 URL: http://hg.openjdk.java.net/jdk7/build/jdk/rev/540c7f47aadf 6738668: JFileChooser cannot be created under SecurityManager Reviewed-by: peterz ! src/share/classes/com/sun/java/swing/plaf/windows/WindowsFileChooserUI.java ! src/share/classes/javax/swing/plaf/metal/MetalFileChooserUI.java ! src/share/classes/sun/swing/plaf/synth/SynthFileChooserUIImpl.java + test/javax/swing/JFileChooser/6738668/bug6738668.java + test/javax/swing/JFileChooser/6738668/security.policy Changeset: 4bf886c9df34 Author: peterz Date: 2009-03-23 14:09 +0300 URL: http://hg.openjdk.java.net/jdk7/build/jdk/rev/4bf886c9df34 6653395: Default LAF is set to CrossPlatformLookAndFeel not SystemLookAndFeel Summary: Swing now checks AppContext properties to determine default LAF name. This is needed for plugin to be able to set default LAF w/o loading Swing classes. Reviewed-by: alexp, loneid ! src/share/classes/javax/swing/UIManager.java Changeset: 652e05578a7e Author: peterz Date: 2009-03-23 16:41 +0300 URL: http://hg.openjdk.java.net/jdk7/build/jdk/rev/652e05578a7e 4783068: Components with HTML text should gray out the text when disabled Summary: Views fixed to use different colors when container is disabled Reviewed-by: gsm, rupashka ! src/share/classes/javax/swing/text/GlyphView.java ! src/share/classes/javax/swing/text/html/ImageView.java ! src/share/classes/javax/swing/text/html/StyleSheet.java + test/javax/swing/text/html/Test4783068.java Changeset: b8d8ec2dac68 Author: rupashka Date: 2009-03-26 11:04 +0300 URL: http://hg.openjdk.java.net/jdk7/build/jdk/rev/b8d8ec2dac68 6798062: Memory Leak on using getFiles of FileSystemView Reviewed-by: peterz, malenkov ! src/windows/native/sun/windows/ShellFolder2.cpp + test/javax/swing/JFileChooser/6798062/bug6798062.html + test/javax/swing/JFileChooser/6798062/bug6798062.java Changeset: ce3262ac93fa Author: peterz Date: 2009-04-06 13:06 +0400 URL: http://hg.openjdk.java.net/jdk7/build/jdk/rev/ce3262ac93fa 6635110: GTK problem when testing Sun Studio IDE on snv_77 with jdk1.6 using Gnome window manager Summary: GTKIconFactory icons should protect against null context passed in Reviewed-by: rupashka ! src/share/classes/com/sun/java/swing/plaf/gtk/GTKIconFactory.java + test/com/sun/java/swing/plaf/gtk/Test6635110.java Changeset: be3afc0e5775 Author: peterz Date: 2009-04-07 12:40 +0400 URL: http://hg.openjdk.java.net/jdk7/build/jdk/rev/be3afc0e5775 6740974: api/javax_swing/PopupFactory/index.html#Ctor[PopupFactory2002] fails with NPE Reviewed-by: malenkov ! src/share/classes/javax/swing/PopupFactory.java Changeset: 1729e34a0287 Author: peytoia Date: 2009-04-10 11:51 +0900 URL: http://hg.openjdk.java.net/jdk7/build/jdk/rev/1729e34a0287 6404304: RFE: Unicode 5.1 support Reviewed-by: okutsu, naoto ! make/java/text/FILES_java.gmk ! make/java/text/Makefile ! make/tools/GenerateCharacter/CharacterData00.java.template ! make/tools/GenerateCharacter/CharacterData01.java.template ! make/tools/UnicodeData/SpecialCasing.txt ! make/tools/UnicodeData/UnicodeData.txt + make/tools/UnicodeData/VERSION ! src/share/classes/java/lang/Character.java ! src/share/classes/java/lang/ConditionalSpecialCasing.java ! src/share/classes/java/lang/String.java ! src/share/classes/sun/text/normalizer/CharTrie.java ! src/share/classes/sun/text/normalizer/NormalizerBase.java ! src/share/classes/sun/text/normalizer/NormalizerDataReader.java ! src/share/classes/sun/text/normalizer/NormalizerImpl.java ! src/share/classes/sun/text/normalizer/Trie.java ! src/share/classes/sun/text/normalizer/TrieIterator.java + src/share/classes/sun/text/normalizer/UBiDiProps.java ! src/share/classes/sun/text/normalizer/UCharacter.java ! src/share/classes/sun/text/normalizer/UCharacterProperty.java ! src/share/classes/sun/text/normalizer/UCharacterPropertyReader.java - src/share/classes/sun/text/normalizer/UProperty.java ! src/share/classes/sun/text/normalizer/UTF16.java ! src/share/classes/sun/text/normalizer/UnicodeSet.java ! src/share/classes/sun/text/normalizer/UnicodeSetIterator.java ! src/share/classes/sun/text/normalizer/Utility.java ! src/share/classes/sun/text/normalizer/VersionInfo.java + src/share/classes/sun/text/resources/ubidi.icu ! src/share/classes/sun/text/resources/unorm.icu ! src/share/classes/sun/text/resources/uprops.icu ! test/java/lang/String/ToLowerCase.java Changeset: a54c407c4da3 Author: lana Date: 2009-04-09 20:34 -0700 URL: http://hg.openjdk.java.net/jdk7/build/jdk/rev/a54c407c4da3 Merge - src/share/classes/sun/text/normalizer/UProperty.java Changeset: 2cdf54e6e74c Author: lana Date: 2009-04-14 00:05 -0700 URL: http://hg.openjdk.java.net/jdk7/build/jdk/rev/2cdf54e6e74c Merge - src/share/classes/sun/text/normalizer/UProperty.java Changeset: 522bb5aa17e0 Author: lana Date: 2009-04-14 04:21 -0700 URL: http://hg.openjdk.java.net/jdk7/build/jdk/rev/522bb5aa17e0 Merge - src/windows/native/sun/windows/awt_KeyboardFocusManager.h Changeset: 65095f13b7c4 Author: xdono Date: 2009-04-16 11:22 -0700 URL: http://hg.openjdk.java.net/jdk7/build/jdk/rev/65095f13b7c4 Added tag jdk7-b55 for changeset 522bb5aa17e0 ! .hgtags Changeset: 7fd3bc37afe3 Author: xdono Date: 2009-04-16 19:10 -0700 URL: http://hg.openjdk.java.net/jdk7/build/jdk/rev/7fd3bc37afe3 Merge - src/share/classes/sun/text/normalizer/UProperty.java - src/windows/native/sun/windows/awt_KeyboardFocusManager.h From xiomara.jayasena at sun.com Fri Apr 17 03:26:32 2009 From: xiomara.jayasena at sun.com (xiomara.jayasena at sun.com) Date: Fri, 17 Apr 2009 03:26:32 +0000 Subject: hg: jdk7/build/langtools: 13 new changesets Message-ID: <20090417032654.2D293EDE6@hg.openjdk.java.net> Changeset: 2734c6a91b8b Author: xdono Date: 2009-04-09 10:37 -0700 URL: http://hg.openjdk.java.net/jdk7/build/langtools/rev/2734c6a91b8b Added tag jdk7-b54 for changeset 197a7f881937 ! .hgtags Changeset: 5caa6c45936a Author: mcimadamore Date: 2009-03-25 10:28 +0000 URL: http://hg.openjdk.java.net/jdk7/build/langtools/rev/5caa6c45936a 6182950: methods clash algorithm should not depend on return type Summary: fixed code that checks for duplicate method declarations Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/Check.java + test/tools/javac/generics/6182950/T6182950a.java + test/tools/javac/generics/6182950/T6182950a.out + test/tools/javac/generics/6182950/T6182950b.java + test/tools/javac/generics/6182950/T6182950b.out + test/tools/javac/generics/6182950/T6182950c.java Changeset: 6ce39250fa88 Author: mcimadamore Date: 2009-03-25 10:28 +0000 URL: http://hg.openjdk.java.net/jdk7/build/langtools/rev/6ce39250fa88 6816548: Uninitialized register when performing casting + auto(un)boxing Summary: Constant value of final variable is lost during lowering Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/Lower.java + test/tools/javac/boxing/T6816548.java Changeset: 1ee128971f5d Author: mcimadamore Date: 2009-03-25 10:29 +0000 URL: http://hg.openjdk.java.net/jdk7/build/langtools/rev/1ee128971f5d 6400189: raw types and inference Summary: Fixed resolution problem with raw overriding (CCC) Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/Resolve.java + test/tools/javac/OverrideChecks/6400189/T6400189a.java + test/tools/javac/OverrideChecks/6400189/T6400189a.out + test/tools/javac/OverrideChecks/6400189/T6400189b.java + test/tools/javac/OverrideChecks/6400189/T6400189b.out + test/tools/javac/OverrideChecks/6400189/T6400189c.java + test/tools/javac/OverrideChecks/6400189/T6400189d.java Changeset: 07da2ffbb76b Author: jjg Date: 2009-03-30 15:08 -0700 URL: http://hg.openjdk.java.net/jdk7/build/langtools/rev/07da2ffbb76b 6819246: improve support for decoding instructions in classfile library Reviewed-by: ksrini ! src/share/classes/com/sun/tools/classfile/Code_attribute.java + src/share/classes/com/sun/tools/classfile/Instruction.java - src/share/classes/com/sun/tools/classfile/OpCodes.java + src/share/classes/com/sun/tools/classfile/Opcode.java ! src/share/classes/com/sun/tools/javap/CodeWriter.java Changeset: 89f67512b635 Author: jjg Date: 2009-03-31 11:07 -0700 URL: http://hg.openjdk.java.net/jdk7/build/langtools/rev/89f67512b635 6817950: refactor ClassReader to improve attribute handling Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/jvm/ClassFile.java ! src/share/classes/com/sun/tools/javac/jvm/ClassReader.java Changeset: af10262bd031 Author: jjg Date: 2009-03-31 11:16 -0700 URL: http://hg.openjdk.java.net/jdk7/build/langtools/rev/af10262bd031 6813059: replace use of JavaCompiler.errorCount with shouldContinue Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/main/JavaCompiler.java + test/tools/javac/policy/test3/A.java + test/tools/javac/policy/test3/Test.java Changeset: 3e4038edfcb7 Author: tbell Date: 2009-04-03 10:29 -0700 URL: http://hg.openjdk.java.net/jdk7/build/langtools/rev/3e4038edfcb7 Merge - src/share/classes/com/sun/tools/classfile/OpCodes.java Changeset: 143956db282e Author: tbell Date: 2009-04-10 15:31 -0700 URL: http://hg.openjdk.java.net/jdk7/build/langtools/rev/143956db282e Merge Changeset: 247468a1454b Author: dcherepanov Date: 2009-04-07 10:27 +0400 URL: http://hg.openjdk.java.net/jdk7/build/langtools/rev/247468a1454b 6663040: Using com.sun.awt.AWTUtilities do not give warning while compilation Reviewed-by: yan, anthony ! src/share/classes/com/sun/tools/javac/resources/legacy.properties Changeset: 45be79d8d317 Author: lana Date: 2009-04-09 13:13 -0700 URL: http://hg.openjdk.java.net/jdk7/build/langtools/rev/45be79d8d317 Merge Changeset: 7394a8694ced Author: lana Date: 2009-04-13 22:35 -0700 URL: http://hg.openjdk.java.net/jdk7/build/langtools/rev/7394a8694ced Merge Changeset: 825f23a4f262 Author: xdono Date: 2009-04-16 11:23 -0700 URL: http://hg.openjdk.java.net/jdk7/build/langtools/rev/825f23a4f262 Added tag jdk7-b55 for changeset 7394a8694ced ! .hgtags From Joe.Darcy at Sun.COM Fri Apr 17 04:20:40 2009 From: Joe.Darcy at Sun.COM (Joseph D. Darcy) Date: Thu, 16 Apr 2009 21:20:40 -0700 Subject: New project: getting rid of IcedTea local patches In-Reply-To: <17c6771e0904091055w7c14a9adg982e0ff37a55e0a4@mail.gmail.com> References: <49D3917B.2010907@redhat.com> <49DDF4C6.1070602@redhat.com> <49DE0442.6060802@sun.com> <17c6771e0904091055w7c14a9adg982e0ff37a55e0a4@mail.gmail.com> Message-ID: <49E80398.6090601@sun.com> Catching up on email, Andrew John Hughes wrote: > 2009/4/9 Alan Bateman : > >> Andrew Haley wrote: >> [snip] >> I'm not very familiar with IcedTea but I cloned the repository to see what >> these patches are about. Here are a few comments: >> >> icedtea-6728542-epoll.patch seems to be a change-set I pushed to jdk7 last >> year. It seems very reasonable to push this into jdk6/jdk6/jdk. Go for it! >> >> > > Yes, I've referenced the bug on the wiki now. Joe, can we commit this to 6? > Yes! -Joe From lsliu0507 at gmail.com Fri Apr 17 13:56:53 2009 From: lsliu0507 at gmail.com (lianshun Liu) Date: Fri, 17 Apr 2009 21:56:53 +0800 Subject: building problems about hotspot Message-ID: <28C1886B59324DBB9E4154594B8BB195@AAA> Hello, I build hotspot under Cygwin+VS2008, the following are the environment variables I set: _________________________________________________________ set PATH=C:\Progra~1\MSVC9\VC\bin;c:\cygwin\bin;C:\WINDOWS\system32;C:\WINDOWS;C:\WINDOWS\System32\Wbem set ANT_Home=C:/Progra~1/apache-ant-1.7.1 set ALT_BOOTDIR=C:/Progra~1/Java/jdk1.6.0 set ALT_BINARY_PLUGS_PATH=C:/Progra~1/JDK7/Plug/openjdk-binary-plugs set ALT_JDK_IMPORT_PATH=E:/OpenJDK/openjdk/build/windows-i586/j2sdk-image set ALT_DXSDK_PATH=C:/Progra~1/DXSDK set VC=C:/Progra~1/MSVC9 set ALT_COMPILER_PATH=%VC%/VC/bin set ALT_MSDEVTOOLS_PATH=C:/PROGRA~1/MI2578~1/Windows/v6.0A/bin set ALT_MSVCR90_DLL_PATH=%VC%/VC/redist/x86/Microsoft.VC90.CRT set ALT_MSVCRNN_DLL_PATH=%VC%/VC/redist/x86/Microsoft.VC90.CRT set ALT_FREETYPE_LIB_PATH=C:/Progra~1/Freetype/lib set ALT_FREETYPE_HEADERS_PATH=C:/Progra~1/Freetype/include rem I set CC_INTERP=true to use C++-interpreter, is it right? set CC_INTERP=true call C:\Progra~1\MSVC9\Common7\Tools\vsvars32.bat bash ________________________________________________________ then, I use "make" command to build hotspot. In order to build the C++-interpreter, not template-interpreter, I set CC_INTERP=true. But it didn't work. Is there anything wrong? Or how can I do? Thanks a lot. Best wishes Lianshun Liu -------------- next part -------------- An HTML attachment was scrubbed... URL: From aph at redhat.com Fri Apr 17 14:42:23 2009 From: aph at redhat.com (aph at redhat.com) Date: Fri, 17 Apr 2009 14:42:23 +0000 Subject: hg: jdk7/build: 6829575: 100028: Debug information is incomplete or missing Message-ID: <20090417144223.6E0B9EFE0@hg.openjdk.java.net> Changeset: a942ea653d97 Author: aph Date: 2009-04-17 15:37 +0100 URL: http://hg.openjdk.java.net/jdk7/build/rev/a942ea653d97 6829575: 100028: Debug information is incomplete or missing Summary: Enable debugging in many places Reviewed-by: ohair Contributed-by: Andrew Haley ! make/sanity-rules.gmk From aph at redhat.com Fri Apr 17 14:55:12 2009 From: aph at redhat.com (aph at redhat.com) Date: Fri, 17 Apr 2009 14:55:12 +0000 Subject: hg: jdk7/build/hotspot: 6829575: 100028: Debug information is incomplete or missing Message-ID: <20090417145517.E3226EFEB@hg.openjdk.java.net> Changeset: 5d4dd2f5f6a1 Author: aph Date: 2009-04-17 15:50 +0100 URL: http://hg.openjdk.java.net/jdk7/build/hotspot/rev/5d4dd2f5f6a1 6829575: 100028: Debug information is incomplete or missing Summary: Enable debugging in many places Reviewed-by: ohair Contributed-by: Andrew Haley ! make/linux/makefiles/gcc.make ! make/linux/makefiles/jsig.make ! make/linux/makefiles/saproc.make From aph at redhat.com Fri Apr 17 15:01:20 2009 From: aph at redhat.com (aph at redhat.com) Date: Fri, 17 Apr 2009 15:01:20 +0000 Subject: hg: jdk7/build/jaxp: 6829575: 100028: Debug information is incomplete or missing Message-ID: <20090417150122.509D2E008@hg.openjdk.java.net> Changeset: 19c316392d9e Author: aph Date: 2009-04-17 15:55 +0100 URL: http://hg.openjdk.java.net/jdk7/build/jaxp/rev/19c316392d9e 6829575: 100028: Debug information is incomplete or missing Summary: Enable debugging in many places Reviewed-by: ohair Contributed-by: Andrew Haley ! make/Makefile ! make/build.xml From aph at redhat.com Fri Apr 17 15:05:10 2009 From: aph at redhat.com (aph at redhat.com) Date: Fri, 17 Apr 2009 15:05:10 +0000 Subject: hg: jdk7/build/jaxws: 6829575: 100028: Debug information is incomplete or missing Message-ID: <20090417150511.D944DE00D@hg.openjdk.java.net> Changeset: a92183572d99 Author: aph Date: 2009-04-17 15:56 +0100 URL: http://hg.openjdk.java.net/jdk7/build/jaxws/rev/a92183572d99 6829575: 100028: Debug information is incomplete or missing Summary: Enable debugging in many places Reviewed-by: ohair Contributed-by: Andrew Haley ! make/Makefile ! make/build.xml From aph at redhat.com Fri Apr 17 15:09:15 2009 From: aph at redhat.com (aph at redhat.com) Date: Fri, 17 Apr 2009 15:09:15 +0000 Subject: hg: jdk7/build/jdk: 6829575: 100028: Debug information is incomplete or missing Message-ID: <20090417150955.BCE79E012@hg.openjdk.java.net> Changeset: 9ad7e6462145 Author: aph Date: 2009-04-17 15:56 +0100 URL: http://hg.openjdk.java.net/jdk7/build/jdk/rev/9ad7e6462145 6829575: 100028: Debug information is incomplete or missing Summary: Enable debugging in many places Reviewed-by: ohair Contributed-by: Andrew Haley ! make/common/Defs-linux.gmk ! make/sun/awt/mawt.gmk From aph at redhat.com Fri Apr 17 15:15:39 2009 From: aph at redhat.com (aph at redhat.com) Date: Fri, 17 Apr 2009 15:15:39 +0000 Subject: hg: jdk7/build/langtools: 6829575: 100028: Debug information is incomplete or missing Message-ID: <20090417151544.791CEE017@hg.openjdk.java.net> Changeset: 4b72c2556789 Author: aph Date: 2009-04-17 15:56 +0100 URL: http://hg.openjdk.java.net/jdk7/build/langtools/rev/4b72c2556789 6829575: 100028: Debug information is incomplete or missing Summary: Enable debugging in many places Reviewed-by: ohair Contributed-by: Andrew Haley ! make/Makefile From Jonathan.Gibbons at Sun.COM Fri Apr 17 16:01:26 2009 From: Jonathan.Gibbons at Sun.COM (Jonathan Gibbons) Date: Fri, 17 Apr 2009 09:01:26 -0700 Subject: Fwd: hg: jdk7/build/langtools: 6829575: 100028: Debug information is incomplete or missing References: <20090417151544.791CEE017@hg.openjdk.java.net> Message-ID: <5CF068B6-DF5C-4EAF-9BA8-750C418CE929@sun.com> Andrew, It's one thing to be enabling more debug information if you set flags, and/or making it more consistent, but I'm not happy with you removing debug information by default. At least from reading the changeset diff, it seems there is no way to get what was previously the default amount of debug info, which is source,lines (but not vars). Source and lines are good to get useful stack traces in the face of exceptions, even if var information is not present. var information is typically not required in product builds. -- Jon Begin forwarded message: > From: aph at redhat.com > Date: April 17, 2009 8:15:39 AM PDT > To: jdk7-changes at openjdk.java.net, build-dev at openjdk.java.net > Subject: hg: jdk7/build/langtools: 6829575: 100028: Debug > information is incomplete or missing > > Changeset: 4b72c2556789 > Author: aph > Date: 2009-04-17 15:56 +0100 > URL: http://hg.openjdk.java.net/jdk7/build/langtools/rev/4b72c2556789 > > 6829575: 100028: Debug information is incomplete or missing > Summary: Enable debugging in many places > Reviewed-by: ohair > Contributed-by: Andrew Haley > > ! make/Makefile > -------------- next part -------------- An HTML attachment was scrubbed... URL: From aph at redhat.com Fri Apr 17 16:11:23 2009 From: aph at redhat.com (Andrew Haley) Date: Fri, 17 Apr 2009 17:11:23 +0100 Subject: Fwd: hg: jdk7/build/langtools: 6829575: 100028: Debug information is incomplete or missing In-Reply-To: <5CF068B6-DF5C-4EAF-9BA8-750C418CE929@sun.com> References: <20090417151544.791CEE017@hg.openjdk.java.net> <5CF068B6-DF5C-4EAF-9BA8-750C418CE929@sun.com> Message-ID: <49E8AA2B.4090101@redhat.com> Jonathan Gibbons wrote: > It's one thing to be enabling more debug information if you set flags, > and/or making it more consistent, but I'm not happy with you removing > debug information by default. At least from reading the changeset diff, > it seems there is no way to get what was previously the default amount > of debug info, which is source,lines (but not vars). > > Source and lines are good to get useful stack traces in the face of > exceptions, even if var information is not present. var information is > typically not required in product builds. Oh dear. I discussed this at considerable length with Kelly, whose suggestion it was to change ifeq ($(DEBUG_CLASSFILES), true) > ANT_OPTIONS += -Djavac.debug=true > ANT_OPTIONS += -Djavac.debuglevel=source,lines,vars > endif to be > ifeq ($(DEBUG_CLASSFILES), true) > ANT_OPTIONS += -Djavac.debug=true > ANT_OPTIONS += -Djavac.debuglevel=source,lines,vars > else > ANT_OPTIONS += -Djavac.debug=false > ANT_OPTIONS += -Djavac.debuglevel= > endif It was not my intention to break anything that already existed, but simply to add debuginfo where it was disabled. Can you please point me to exactly which hunks of my diff are problematic? The only place I can see that might be a problem is javac. Thanks, Andrew. From Kelly.Ohair at Sun.COM Fri Apr 17 16:13:00 2009 From: Kelly.Ohair at Sun.COM (Kelly O'Hair) Date: Fri, 17 Apr 2009 09:13:00 -0700 Subject: Fwd: hg: jdk7/build/langtools: 6829575: 100028: Debug information is incomplete or missing In-Reply-To: <5CF068B6-DF5C-4EAF-9BA8-750C418CE929@sun.com> References: <20090417151544.791CEE017@hg.openjdk.java.net> <5CF068B6-DF5C-4EAF-9BA8-750C418CE929@sun.com> Message-ID: <49E8AA8C.2010107@sun.com> My fault. I reviewed this and it didn't dawn on me what this did until your email. Yes, the default production builds with javac should be source,lines. Sorry, I had native code on the brain and was thinking 'debug off' :^( -kto Jonathan Gibbons wrote: > Andrew, > > It's one thing to be enabling more debug information if you set flags, > and/or making it more consistent, but I'm not happy with you removing > debug information by default. At least from reading the changeset diff, > it seems there is no way to get what was previously the default amount > of debug info, which is source,lines (but not vars). > > Source and lines are good to get useful stack traces in the face of > exceptions, even if var information is not present. var information is > typically not required in product builds. > > -- Jon > > > > Begin forwarded message: > >> *From: *aph at redhat.com >> *Date: *April 17, 2009 8:15:39 AM PDT >> *To: *jdk7-changes at openjdk.java.net >> , build-dev at openjdk.java.net >> >> *Subject: **hg: jdk7/build/langtools: 6829575: 100028: Debug >> information is incomplete or missing* >> >> Changeset: 4b72c2556789 >> Author: aph >> Date: 2009-04-17 15:56 +0100 >> URL: >> http://hg.openjdk.java.net/jdk7/build/langtools/rev/4b72c2556789 >> >> 6829575: 100028: Debug information is incomplete or missing >> Summary: Enable debugging in many places >> Reviewed-by: ohair >> Contributed-by: Andrew Haley > >> >> ! make/Makefile >> > From aph at redhat.com Fri Apr 17 16:15:54 2009 From: aph at redhat.com (Andrew Haley) Date: Fri, 17 Apr 2009 17:15:54 +0100 Subject: Fwd: hg: jdk7/build/langtools: 6829575: 100028: Debug information is incomplete or missing In-Reply-To: <49E8AA8C.2010107@sun.com> References: <20090417151544.791CEE017@hg.openjdk.java.net> <5CF068B6-DF5C-4EAF-9BA8-750C418CE929@sun.com> <49E8AA8C.2010107@sun.com> Message-ID: <49E8AB3A.4050708@redhat.com> Kelly O'Hair wrote: > My fault. I reviewed this and it didn't dawn on me what this did > until your email. > > Yes, the default production builds with javac should be source,lines. > Sorry, I had native code on the brain and was thinking 'debug off' :^( How about if I do ifeq ($(DEBUG_CLASSFILES), true) ANT_OPTIONS += -Djavac.debug=true ANT_OPTIONS += -Djavac.debuglevel=source,lines,vars endif instead of ifeq ($(DEBUG_CLASSFILES), true) ANT_OPTIONS += -Djavac.debug=true ANT_OPTIONS += -Djavac.debuglevel=source,lines,vars else ANT_OPTIONS += -Djavac.debug=false ANT_OPTIONS += -Djavac.debuglevel= endif I think that answers Jonathan's objection... Andrew. From Jonathan.Gibbons at Sun.COM Fri Apr 17 16:23:54 2009 From: Jonathan.Gibbons at Sun.COM (Jonathan Gibbons) Date: Fri, 17 Apr 2009 09:23:54 -0700 Subject: hg: jdk7/build/langtools: 6829575: 100028: Debug information is incomplete or missing In-Reply-To: <49E8AA2B.4090101@redhat.com> References: <20090417151544.791CEE017@hg.openjdk.java.net> <5CF068B6-DF5C-4EAF-9BA8-750C418CE929@sun.com> <49E8AA2B.4090101@redhat.com> Message-ID: <8EFEE7E6-5229-42BA-8BC6-E3320657FB3A@Sun.COM> On Apr 17, 2009, at 9:11 AM, Andrew Haley wrote: > Jonathan Gibbons wrote: > >> It's one thing to be enabling more debug information if you set >> flags, >> and/or making it more consistent, but I'm not happy with you removing >> debug information by default. At least from reading the changeset >> diff, >> it seems there is no way to get what was previously the default >> amount >> of debug info, which is source,lines (but not vars). >> >> Source and lines are good to get useful stack traces in the face of >> exceptions, even if var information is not present. var >> information is >> typically not required in product builds. > > Oh dear. I discussed this at considerable length with Kelly, whose > suggestion it was to change > > ifeq ($(DEBUG_CLASSFILES), true) >> ANT_OPTIONS += -Djavac.debug=true >> ANT_OPTIONS += -Djavac.debuglevel=source,lines,vars >> endif > > to be > >> ifeq ($(DEBUG_CLASSFILES), true) >> ANT_OPTIONS += -Djavac.debug=true >> ANT_OPTIONS += -Djavac.debuglevel=source,lines,vars >> else >> ANT_OPTIONS += -Djavac.debug=false >> ANT_OPTIONS += -Djavac.debuglevel= >> endif > > It was not my intention to break anything that already existed, but > simply to add debuginfo where it was disabled. > > Can you please point me to exactly which hunks of my diff are > problematic? > The only place I can see that might be a problem is javac. If your intention was to ensure that debug info was added, then the changeset for langtools (which you summarise above) would not seem to be necessary, because the old code honored setting DEBUG_CLASSFILES to true. It is the new "else" branch that disables debug info if DEBUG_CLASSFILES is not set that is problematic. I accept this changeset is part of an overall larger set of changesets across all repositories. What exactly were the goals? It seems to me it is arguably desirable to have three settings (not two). All debugging on (source,lines,vars) Basic debugging on (source,lines) No debugging There is arguably a fourth candidate for consideration, which is "local default" which allows the choice to be made on a more fine-grained (albeit inconsistent) basis. -- Jon > > > Thanks, > Andrew. From Kelly.Ohair at Sun.COM Fri Apr 17 16:29:37 2009 From: Kelly.Ohair at Sun.COM (Kelly O'Hair) Date: Fri, 17 Apr 2009 09:29:37 -0700 Subject: Fwd: hg: jdk7/build/langtools: 6829575: 100028: Debug information is incomplete or missing In-Reply-To: <49E8AB3A.4050708@redhat.com> References: <20090417151544.791CEE017@hg.openjdk.java.net> <5CF068B6-DF5C-4EAF-9BA8-750C418CE929@sun.com> <49E8AA8C.2010107@sun.com> <49E8AB3A.4050708@redhat.com> Message-ID: <49E8AE71.7070909@sun.com> Yes, I think you are right. Sorry, I think I sent you on this dead goose chase. :^( If this is in the jaxp and jaxws repositories, we need to fix those too. -kto Andrew Haley wrote: > Kelly O'Hair wrote: >> My fault. I reviewed this and it didn't dawn on me what this did >> until your email. >> >> Yes, the default production builds with javac should be source,lines. >> Sorry, I had native code on the brain and was thinking 'debug off' :^( > > How about if I do > > ifeq ($(DEBUG_CLASSFILES), true) > ANT_OPTIONS += -Djavac.debug=true > ANT_OPTIONS += -Djavac.debuglevel=source,lines,vars > endif > > instead of > > ifeq ($(DEBUG_CLASSFILES), true) > ANT_OPTIONS += -Djavac.debug=true > ANT_OPTIONS += -Djavac.debuglevel=source,lines,vars > else > ANT_OPTIONS += -Djavac.debug=false > ANT_OPTIONS += -Djavac.debuglevel= > endif > > I think that answers Jonathan's objection... > > Andrew. From aph at redhat.com Fri Apr 17 16:31:47 2009 From: aph at redhat.com (Andrew Haley) Date: Fri, 17 Apr 2009 17:31:47 +0100 Subject: hg: jdk7/build/langtools: 6829575: 100028: Debug information is incomplete or missing In-Reply-To: <8EFEE7E6-5229-42BA-8BC6-E3320657FB3A@Sun.COM> References: <20090417151544.791CEE017@hg.openjdk.java.net> <5CF068B6-DF5C-4EAF-9BA8-750C418CE929@sun.com> <49E8AA2B.4090101@redhat.com> <8EFEE7E6-5229-42BA-8BC6-E3320657FB3A@Sun.COM> Message-ID: <49E8AEF3.9020007@redhat.com> Jonathan Gibbons wrote: > > On Apr 17, 2009, at 9:11 AM, Andrew Haley wrote: > >> Jonathan Gibbons wrote: >> >>> It's one thing to be enabling more debug information if you set flags, >>> and/or making it more consistent, but I'm not happy with you removing >>> debug information by default. At least from reading the changeset diff, >>> it seems there is no way to get what was previously the default amount >>> of debug info, which is source,lines (but not vars). >>> >>> Source and lines are good to get useful stack traces in the face of >>> exceptions, even if var information is not present. var information is >>> typically not required in product builds. >> >> Oh dear. I discussed this at considerable length with Kelly, whose >> suggestion it was to change >> >> ifeq ($(DEBUG_CLASSFILES), true) >>> ANT_OPTIONS += -Djavac.debug=true >>> ANT_OPTIONS += -Djavac.debuglevel=source,lines,vars >>> endif >> >> to be >> >>> ifeq ($(DEBUG_CLASSFILES), true) >>> ANT_OPTIONS += -Djavac.debug=true >>> ANT_OPTIONS += -Djavac.debuglevel=source,lines,vars >>> else >>> ANT_OPTIONS += -Djavac.debug=false >>> ANT_OPTIONS += -Djavac.debuglevel= >>> endif >> >> It was not my intention to break anything that already existed, but >> simply to add debuginfo where it was disabled. >> >> Can you please point me to exactly which hunks of my diff are >> problematic? >> The only place I can see that might be a problem is javac. > > If your intention was to ensure that debug info was added, then the changeset > for langtools (which you summarise above) would not seem to be necessary, > because the old code honored setting DEBUG_CLASSFILES to true. OK. I'm surprised, but I'll pull out that hunk and give it a try. I think this may be a clash between the way that I needed to do it in JDK 6 and 7. (I tested the patches on 6 first, and then moved to 7.) > It is the new "else" branch that disables debug info if > DEBUG_CLASSFILES is not set that is problematic. > I accept this changeset is part of an overall larger set of > changesets across all repositories. What exactly were the goals? All I need is a simple way to turn on full debugging information everywhere. The problem was that there was no single way to do it. > It seems to me it is arguably desirable to have three settings (not > two). All debugging on (source,lines,vars) Basic debugging on > (source,lines) No debugging There is arguably a fourth candidate for > consideration, which is "local default" which allows the choice to > be made on a more fine-grained (albeit inconsistent) basis. Sure. That's not something I need, but I'm happy to work with you to get it done. Andrew. From aph at redhat.com Fri Apr 17 16:34:47 2009 From: aph at redhat.com (Andrew Haley) Date: Fri, 17 Apr 2009 17:34:47 +0100 Subject: Fwd: hg: jdk7/build/langtools: 6829575: 100028: Debug information is incomplete or missing In-Reply-To: <49E8AE71.7070909@sun.com> References: <20090417151544.791CEE017@hg.openjdk.java.net> <5CF068B6-DF5C-4EAF-9BA8-750C418CE929@sun.com> <49E8AA8C.2010107@sun.com> <49E8AB3A.4050708@redhat.com> <49E8AE71.7070909@sun.com> Message-ID: <49E8AFA7.40709@redhat.com> Kelly O'Hair wrote: > Yes, I think you are right. Sorry, I think I sent you on this dead goose > chase. :^( > > If this is in the jaxp and jaxws repositories, we need to fix those too. Alright. I'll test a new patch and submit it here. Part of the problem is, I think, that we took this discussion offline. Andrew. From Kelly.Ohair at Sun.COM Fri Apr 17 17:17:21 2009 From: Kelly.Ohair at Sun.COM (Kelly O'Hair) Date: Fri, 17 Apr 2009 10:17:21 -0700 Subject: Fwd: hg: jdk7/build/langtools: 6829575: 100028: Debug information is incomplete or missing In-Reply-To: <49E8AFA7.40709@redhat.com> References: <20090417151544.791CEE017@hg.openjdk.java.net> <5CF068B6-DF5C-4EAF-9BA8-750C418CE929@sun.com> <49E8AA8C.2010107@sun.com> <49E8AB3A.4050708@redhat.com> <49E8AE71.7070909@sun.com> <49E8AFA7.40709@redhat.com> Message-ID: <49E8B9A1.8010600@sun.com> Andrew Haley wrote: > Kelly O'Hair wrote: >> Yes, I think you are right. Sorry, I think I sent you on this dead goose >> chase. :^( >> >> If this is in the jaxp and jaxws repositories, we need to fix those too. > > Alright. I'll test a new patch and submit it here. > > Part of the problem is, I think, that we took this discussion offline. Agreed. > > Andrew. --- A little background... With native code the historic position on debug has been between two extremes: debug builds - full debug information production builds - no debug information at all, and stripped ELF symbols Functionality wise, everything worked fine in all cases. But stripping out all the ELF symbols meant that a native stack trace would only have the global exported function names, not a very helpful stack trace. So we stopped stripping all the ELF symbols on most libraries so that a native stack trace at least had all the native function names, on our jdk production builds. Not sure how this lines up with common Linux conventions. With Java code it has been my experience that having literally no debug information in the class files just isn't very common, or helpful and actually starts creeping into 'lost functionality' if the Java exceptions don't provide source files names and line numbers. I should have caught this issue, sorry. -kto From aph at redhat.com Fri Apr 17 17:38:46 2009 From: aph at redhat.com (Andrew Haley) Date: Fri, 17 Apr 2009 18:38:46 +0100 Subject: hg: jdk7/build/langtools: 6829575: 100028: Debug information is incomplete or missing In-Reply-To: <49E8AEF3.9020007@redhat.com> References: <20090417151544.791CEE017@hg.openjdk.java.net> <5CF068B6-DF5C-4EAF-9BA8-750C418CE929@sun.com> <49E8AA2B.4090101@redhat.com> <8EFEE7E6-5229-42BA-8BC6-E3320657FB3A@Sun.COM> <49E8AEF3.9020007@redhat.com> Message-ID: <49E8BEA6.3020204@redhat.com> Andrew Haley wrote: > Jonathan Gibbons wrote: >> On Apr 17, 2009, at 9:11 AM, Andrew Haley wrote: >> >>> Jonathan Gibbons wrote: >>> >>>> It's one thing to be enabling more debug information if you set flags, >>>> and/or making it more consistent, but I'm not happy with you removing >>>> debug information by default. At least from reading the changeset diff, >>>> it seems there is no way to get what was previously the default amount >>>> of debug info, which is source,lines (but not vars). >>>> >>>> Source and lines are good to get useful stack traces in the face of >>>> exceptions, even if var information is not present. var information is >>>> typically not required in product builds. >>> Oh dear. I discussed this at considerable length with Kelly, whose >>> suggestion it was to change >>> >>> ifeq ($(DEBUG_CLASSFILES), true) >>>> ANT_OPTIONS += -Djavac.debug=true >>>> ANT_OPTIONS += -Djavac.debuglevel=source,lines,vars >>>> endif >>> to be >>> >>>> ifeq ($(DEBUG_CLASSFILES), true) >>>> ANT_OPTIONS += -Djavac.debug=true >>>> ANT_OPTIONS += -Djavac.debuglevel=source,lines,vars >>>> else >>>> ANT_OPTIONS += -Djavac.debug=false >>>> ANT_OPTIONS += -Djavac.debuglevel= >>>> endif >>> It was not my intention to break anything that already existed, but >>> simply to add debuginfo where it was disabled. >>> >>> Can you please point me to exactly which hunks of my diff are >>> problematic? >>> The only place I can see that might be a problem is javac. >> If your intention was to ensure that debug info was added, then the changeset >> for langtools (which you summarise above) would not seem to be necessary, >> because the old code honored setting DEBUG_CLASSFILES to true. > > OK. I'm surprised, but I'll pull out that hunk and give it a try. I tried removing that hunk entirely for langtools, and it doesn't work: I get missing local variable data. I'm going to change langtools/jaxp/jaxws to ifeq ($(DEBUG_CLASSFILES), true) ANT_OPTIONS += -Djavac.debug=true ANT_OPTIONS += -Djavac.debuglevel=source,lines,vars endif and retest. Andrew. From aph at redhat.com Fri Apr 17 18:53:21 2009 From: aph at redhat.com (Andrew Haley) Date: Fri, 17 Apr 2009 19:53:21 +0100 Subject: Fwd: hg: jdk7/build/langtools: 6829575: 100028: Debug information is incomplete or missing In-Reply-To: <49E8B9A1.8010600@sun.com> References: <20090417151544.791CEE017@hg.openjdk.java.net> <5CF068B6-DF5C-4EAF-9BA8-750C418CE929@sun.com> <49E8AA8C.2010107@sun.com> <49E8AB3A.4050708@redhat.com> <49E8AE71.7070909@sun.com> <49E8AFA7.40709@redhat.com> <49E8B9A1.8010600@sun.com> Message-ID: <49E8D021.2030803@redhat.com> Kelly O'Hair wrote: > > > Andrew Haley wrote: >> Kelly O'Hair wrote: >>> Yes, I think you are right. Sorry, I think I sent you on this dead goose >>> chase. :^( >>> >>> If this is in the jaxp and jaxws repositories, we need to fix those too. >> >> Alright. I'll test a new patch and submit it here. And here it is. Unless DEBUG_CLASSFILES is set in the environment, this patch will have no effect. OK to push? If so, I'll do that and modify the jdk6 patch accordingly. Andrew. --- old/jaxp/make/Makefile 2009-04-17 19:48:31.000000000 +0100 +++ new/jaxp/make/Makefile 2009-04-17 19:48:31.000000000 +0100 @@ -72,9 +72,6 @@ ifeq ($(DEBUG_CLASSFILES), true) ANT_OPTIONS += -Djavac.debug=true ANT_OPTIONS += -Djavac.debuglevel=source,lines,vars -else - ANT_OPTIONS += -Djavac.debug=false - ANT_OPTIONS += -Djavac.debuglevel= endif # Note: jdk/make/common/Defs.gmk uses LANGUAGE_VERSION (-source NN) --- old/jaxws/make/Makefile 2009-04-17 19:48:31.000000000 +0100 +++ new/jaxws/make/Makefile 2009-04-17 19:48:31.000000000 +0100 @@ -72,9 +72,6 @@ ifeq ($(DEBUG_CLASSFILES), true) ANT_OPTIONS += -Djavac.debug=true ANT_OPTIONS += -Djavac.debuglevel=source,lines,vars -else - ANT_OPTIONS += -Djavac.debug=false - ANT_OPTIONS += -Djavac.debuglevel= endif # Note: jdk/make/common/Defs.gmk uses LANGUAGE_VERSION (-source NN) --- old/langtools/make/Makefile 2009-04-17 19:48:32.000000000 +0100 +++ new/langtools/make/Makefile 2009-04-17 19:48:31.000000000 +0100 @@ -108,9 +108,6 @@ ifeq ($(DEBUG_CLASSFILES), true) ANT_OPTIONS += -Djavac.debug=true ANT_OPTIONS += -Djavac.debuglevel=source,lines,vars -else - ANT_OPTIONS += -Djavac.debug=false - ANT_OPTIONS += -Djavac.debuglevel= endif # Note: jdk/make/common/Defs.gmk uses LANGUAGE_VERSION (-source NN) From aph at redhat.com Fri Apr 17 19:03:44 2009 From: aph at redhat.com (Andrew Haley) Date: Fri, 17 Apr 2009 20:03:44 +0100 Subject: Fwd: hg: jdk7/build/langtools: 6829575: 100028: Debug information is incomplete or missing In-Reply-To: <49E8D021.2030803@redhat.com> References: <20090417151544.791CEE017@hg.openjdk.java.net> <5CF068B6-DF5C-4EAF-9BA8-750C418CE929@sun.com> <49E8AA8C.2010107@sun.com> <49E8AB3A.4050708@redhat.com> <49E8AE71.7070909@sun.com> <49E8AFA7.40709@redhat.com> <49E8B9A1.8010600@sun.com> <49E8D021.2030803@redhat.com> Message-ID: <49E8D290.3030905@redhat.com> Andrew Haley wrote: > Kelly O'Hair wrote: >> >> Andrew Haley wrote: >>> Kelly O'Hair wrote: >>>> Yes, I think you are right. Sorry, I think I sent you on this dead goose >>>> chase. :^( >>>> >>>> If this is in the jaxp and jaxws repositories, we need to fix those too. >>> Alright. I'll test a new patch and submit it here. > > And here it is. Unless DEBUG_CLASSFILES is set in the environment, > this patch will have no effect. To be precise: this patch modifies my earlier change so that unless DEBUG_CLASSFILES is set in the environment, the builds are not affected. Andrew. From martinrb at google.com Fri Apr 17 19:55:33 2009 From: martinrb at google.com (Martin Buchholz) Date: Fri, 17 Apr 2009 12:55:33 -0700 Subject: New project: getting rid of IcedTea local patches In-Reply-To: <49DDF4C6.1070602@redhat.com> References: <49D3917B.2010907@redhat.com> <49DDF4C6.1070602@redhat.com> Message-ID: <1ccfd1c10904171255u7063d007ra14860e535e5c7b8@mail.gmail.com> On Thu, Apr 9, 2009 at 06:14, Andrew Haley wrote: > Andrew Haley wrote: >> We at Red Hat have noticed that the list of IcedTea local patches has >> been getting large, with some local patches that should have been >> pushed upstream. ?Also, some IcedTea patches have been committed to >> OpenJDK 7 but not OpenJDK 6. >> >> So, we're going to have a serious attempt to minimize the number of >> IcedTea patches. ?We'll create a Wiki page at icedtea.classpath.org >> that is a list of the patches, and for every one we're going to >> discuss whether it should stay IcedTea local, be pushed upstream to >> OpenJDK, or be deleted altogether. ?Then we will create OpenJDK >> bugzilla entries for the patches that we think should be integrated >> upstream and work with Sun engineers to get that done. > > The page is at http://icedtea.classpath.org/wiki/IcedTea_JDK6_Patches > These are the patches in icedtea/patches and icedtea/patches/hotspot. IcedTea folk and especially Andrew, thank you very much for this effort. Here at Google, we also have some local patches and we have a similar effort to push changes upstream. It is probably a common experience that patches are developed in a hurry to meet some release date, and the upstream push effort is deferred to post-release. This may result in a delay before the rest of the openjdk community shares the patch, but has the advantage that the patch is much more likely to be correct, since it will already have had real users. It occurs to me that there is a new reason to maintain a "buffer" forest that contains patches on their way into Sun's master forest, namely the periodic stabilization for jdk7 milestone releases. It may make sense for Google (i.e. me) to push changes into the icedtea upstream-directed forest if openjdk forests are in quiescent mode. Martin From Jonathan.Gibbons at Sun.COM Sat Apr 18 01:00:23 2009 From: Jonathan.Gibbons at Sun.COM (Jonathan Gibbons) Date: Fri, 17 Apr 2009 18:00:23 -0700 Subject: hg: jdk7/build/langtools: 6829575: 100028: Debug information is incomplete or missing In-Reply-To: <49E8BEA6.3020204@redhat.com> References: <20090417151544.791CEE017@hg.openjdk.java.net> <5CF068B6-DF5C-4EAF-9BA8-750C418CE929@sun.com> <49E8AA2B.4090101@redhat.com> <8EFEE7E6-5229-42BA-8BC6-E3320657FB3A@Sun.COM> <49E8AEF3.9020007@redhat.com> <49E8BEA6.3020204@redhat.com> Message-ID: <49E92627.7040405@sun.com> Andrew Haley wrote: > Andrew Haley wrote: > >> Jonathan Gibbons wrote: >> >>> On Apr 17, 2009, at 9:11 AM, Andrew Haley wrote: >>> >>> >>>> Jonathan Gibbons wrote: >>>> >>>> >>>>> It's one thing to be enabling more debug information if you set flags, >>>>> and/or making it more consistent, but I'm not happy with you removing >>>>> debug information by default. At least from reading the changeset diff, >>>>> it seems there is no way to get what was previously the default amount >>>>> of debug info, which is source,lines (but not vars). >>>>> >>>>> Source and lines are good to get useful stack traces in the face of >>>>> exceptions, even if var information is not present. var information is >>>>> typically not required in product builds. >>>>> >>>> Oh dear. I discussed this at considerable length with Kelly, whose >>>> suggestion it was to change >>>> >>>> ifeq ($(DEBUG_CLASSFILES), true) >>>> >>>>> ANT_OPTIONS += -Djavac.debug=true >>>>> ANT_OPTIONS += -Djavac.debuglevel=source,lines,vars >>>>> endif >>>>> >>>> to be >>>> >>>> >>>>> ifeq ($(DEBUG_CLASSFILES), true) >>>>> ANT_OPTIONS += -Djavac.debug=true >>>>> ANT_OPTIONS += -Djavac.debuglevel=source,lines,vars >>>>> else >>>>> ANT_OPTIONS += -Djavac.debug=false >>>>> ANT_OPTIONS += -Djavac.debuglevel= >>>>> endif >>>>> >>>> It was not my intention to break anything that already existed, but >>>> simply to add debuginfo where it was disabled. >>>> >>>> Can you please point me to exactly which hunks of my diff are >>>> problematic? >>>> The only place I can see that might be a problem is javac. >>>> >>> If your intention was to ensure that debug info was added, then the changeset >>> for langtools (which you summarise above) would not seem to be necessary, >>> because the old code honored setting DEBUG_CLASSFILES to true. >>> >> OK. I'm surprised, but I'll pull out that hunk and give it a try. >> > > I tried removing that hunk entirely for langtools, and it doesn't work: I > get missing local variable data. > > I'm going to change langtools/jaxp/jaxws to > > ifeq ($(DEBUG_CLASSFILES), true) > ANT_OPTIONS += -Djavac.debug=true > ANT_OPTIONS += -Djavac.debuglevel=source,lines,vars > endif > > and retest. > > Andrew. > > Yes. If all you want to do is to provide a consistent way of enabling all debug info in classfiles, then I agree with this proposed change. I'm sorry, I misread the earlier email and confused Kelly's proposed change with your actual changeset. -- Jon -------------- next part -------------- An HTML attachment was scrubbed... URL: From lsliu0507 at gmail.com Sat Apr 18 04:05:56 2009 From: lsliu0507 at gmail.com (lianshun Liu) Date: Sat, 18 Apr 2009 12:05:56 +0800 Subject: c++ interpreter on Windows Message-ID: <4CE8BFA95C9A4C49AA97A40D7FFE6275@AAA> Hi, Recently I am doing some experiment with the c++ interpreter. I bulid hotspot on Windows 32-bit, use VS2008 as the compiler. Before starting to make, I add "/D CC_INTERP" to CPP_FLAGS which locates at hotspot\make\windows\makefiles\compile.make. After setting the environment as follows: ----------------------------------------------------------------------------------- set PATH=C:\Progra~1\MSVC9\VC\bin;c:\cygwin\bin;C:\WINDOWS\system32;C:\WINDOWS;C:\WINDOWS\System32\Wbem set ANT_Home=C:/Progra~1/apache-ant-1.7.1 set ALT_BOOTDIR=C:/Progra~1/Java/jdk1.6.0 set ALT_BINARY_PLUGS_PATH=C:/Progra~1/JDK7/Plug/openjdk-binary-plugs set ALT_DXSDK_PATH=C:/Progra~1/DXSDK set VC=C:/Progra~1/MSVC9 set ALT_COMPILER_PATH=%VC%/VC/bin set ALT_MSDEVTOOLS_PATH=C:/PROGRA~1/MI2578~1/Windows/v6.0A/bin set ALT_MSVCR90_DLL_PATH=%VC%/VC/redist/x86/Microsoft.VC90.CRT set ALT_MSVCRNN_DLL_PATH=%VC%/VC/redist/x86/Microsoft.VC90.CRT set ALT_FREETYPE_LIB_PATH=C:/Progra~1/Freetype/lib set ALT_FREETYPE_HEADERS_PATH=C:/Progra~1/Freetype/include call C:\Progra~1\MSVC9\Common7\Tools\vsvars32.bat bash ----------------------------------------------------------------------------------- I start the make. Nearly 40 minutes later, hotspot was successfully built. Then I copy hotspot\build\windows\export-windows-i586\jre\bin\client\jvm.dll to openjdk\build\windows-i586\j2sdk-image\jre\bin\client, and start the java -version, the following error occurs: --------------------------------------------------------------------- E:\openjdk\build\windows-i586\j2sdk-image\jre\bin>java -version Error occurred during initialization of VM java.lang.ExceptionInInitializerError at java.lang.System.initializeSystemClass(System.java:1107) Caused by: java.lang.ArrayIndexOutOfBoundsException: 85 at java.util.Properties.(Properties.java:1109) at java.lang.System.initializeSystemClass(System.java:1107) --------------------------------------------------------------------- So, I want to know that is it possible to use c++ interpreter on IA32? If so, what else to be done? If not, where is the bytecode interpreted in template interpreter, I know in c++ interpreter, bytecode is executed in bytecodeInterpreter::run(). Thanks a lot. Best regards Lianshun Liu -------------- next part -------------- An HTML attachment was scrubbed... URL: From aph at redhat.com Sat Apr 18 09:50:08 2009 From: aph at redhat.com (Andrew Haley) Date: Sat, 18 Apr 2009 10:50:08 +0100 Subject: New project: getting rid of IcedTea local patches In-Reply-To: <1ccfd1c10904171255u7063d007ra14860e535e5c7b8@mail.gmail.com> References: <49D3917B.2010907@redhat.com> <49DDF4C6.1070602@redhat.com> <1ccfd1c10904171255u7063d007ra14860e535e5c7b8@mail.gmail.com> Message-ID: <49E9A250.1080605@redhat.com> Martin Buchholz wrote: > On Thu, Apr 9, 2009 at 06:14, Andrew Haley wrote: >> Andrew Haley wrote: >>> We at Red Hat have noticed that the list of IcedTea local patches has >>> been getting large, with some local patches that should have been >>> pushed upstream. Also, some IcedTea patches have been committed to >>> OpenJDK 7 but not OpenJDK 6. >>> >>> So, we're going to have a serious attempt to minimize the number of >>> IcedTea patches. We'll create a Wiki page at icedtea.classpath.org >>> that is a list of the patches, and for every one we're going to >>> discuss whether it should stay IcedTea local, be pushed upstream to >>> OpenJDK, or be deleted altogether. Then we will create OpenJDK >>> bugzilla entries for the patches that we think should be integrated >>> upstream and work with Sun engineers to get that done. >> The page is at http://icedtea.classpath.org/wiki/IcedTea_JDK6_Patches >> These are the patches in icedtea/patches and icedtea/patches/hotspot. > > IcedTea folk and especially Andrew, thank you very much for this effort. > > Here at Google, we also have some local patches and we have a similar > effort to push changes upstream. It is probably a common experience > that patches are developed in a hurry to meet some release date, > and the upstream push effort is deferred to post-release. This may result > in a delay before the rest of the openjdk community shares the patch, > but has the advantage that the patch is much more likely to be correct, > since it will already have had real users. > > It occurs to me that there is a new reason to maintain a "buffer" forest > that contains patches on their way into Sun's master forest, namely > the periodic stabilization for jdk7 milestone releases. It may make sense > for Google (i.e. me) to push changes > into the icedtea upstream-directed forest > if openjdk forests are in quiescent mode. Well, maintaining this "buffer" forest is, more or less, what IcedTea does. I'm not sure that we need another one. Check out the IcedTea project at http://openjdk.java.net/projects/icedtea/. Isn't that where our patches should go? Andrew. From aph at redhat.com Sat Apr 18 09:58:45 2009 From: aph at redhat.com (Andrew Haley) Date: Sat, 18 Apr 2009 10:58:45 +0100 Subject: hg: jdk7/build/langtools: 6829575: 100028: Debug information is incomplete or missing In-Reply-To: <49E92627.7040405@sun.com> References: <20090417151544.791CEE017@hg.openjdk.java.net> <5CF068B6-DF5C-4EAF-9BA8-750C418CE929@sun.com> <49E8AA2B.4090101@redhat.com> <8EFEE7E6-5229-42BA-8BC6-E3320657FB3A@Sun.COM> <49E8AEF3.9020007@redhat.com> <49E8BEA6.3020204@redhat.com> <49E92627.7040405@sun.com> Message-ID: <49E9A455.4060808@redhat.com> Jonathan Gibbons wrote: > Andrew Haley wrote: >> I'm going to change langtools/jaxp/jaxws to >> >> ifeq ($(DEBUG_CLASSFILES), true) >> ANT_OPTIONS += -Djavac.debug=true >> ANT_OPTIONS += -Djavac.debuglevel=source,lines,vars >> endif > > Yes. If all you want to do is to provide a consistent way of enabling > all debug info in classfiles, then I agree with this proposed change. > I'm sorry, I misread the earlier email and confused Kelly's proposed > change with your actual changeset. I cannot tell whether this reply from Jonathan is sufficient permission for me to commit this change. I guess it is, but as this is my first commit I'm not sure exactly what the policy is. I know that my previous patch somewhat broke debuginfo, so I want to fix it ASAP, but I don't want to break approval policy. Damned if I do, and damned if I don't... Andrew. From Jonathan.Gibbons at Sun.COM Sat Apr 18 11:53:32 2009 From: Jonathan.Gibbons at Sun.COM (Jonathan Gibbons) Date: Sat, 18 Apr 2009 04:53:32 -0700 Subject: hg: jdk7/build/langtools: 6829575: 100028: Debug information is incomplete or missing In-Reply-To: <49E9A455.4060808@redhat.com> References: <20090417151544.791CEE017@hg.openjdk.java.net> <5CF068B6-DF5C-4EAF-9BA8-750C418CE929@sun.com> <49E8AA2B.4090101@redhat.com> <8EFEE7E6-5229-42BA-8BC6-E3320657FB3A@Sun.COM> <49E8AEF3.9020007@redhat.com> <49E8BEA6.3020204@redhat.com> <49E92627.7040405@sun.com> <49E9A455.4060808@redhat.com> Message-ID: Andrew. Earlier this week, Mark announced that Release Team approval was required for the final M3 builds for JDK7. [1] Even without that, jcheck would require that you have another BugTraq CR for this issue, even though it is just a modification of a recent fix. I didn't see a new CR get created yet; is that right? -- Jon [1] http://mail.openjdk.java.net/pipermail/jdk7-dev/2009-April/000527.html On Apr 18, 2009, at 2:58 AM, Andrew Haley wrote: > Jonathan Gibbons wrote: >> Andrew Haley wrote: >>> I'm going to change langtools/jaxp/jaxws to >>> >>> ifeq ($(DEBUG_CLASSFILES), true) >>> ANT_OPTIONS += -Djavac.debug=true >>> ANT_OPTIONS += -Djavac.debuglevel=source,lines,vars >>> endif >> >> Yes. If all you want to do is to provide a consistent way of >> enabling >> all debug info in classfiles, then I agree with this proposed change. >> I'm sorry, I misread the earlier email and confused Kelly's proposed >> change with your actual changeset. > > I cannot tell whether this reply from Jonathan is sufficient > permission > for me to commit this change. I guess it is, but as this is my first > commit I'm not sure exactly what the policy is. > > I know that my previous patch somewhat broke debuginfo, so I want to > fix > it ASAP, but I don't want to break approval policy. Damned if I do, > and > damned if I don't... > > Andrew. From martinrb at google.com Sat Apr 18 21:30:41 2009 From: martinrb at google.com (Martin Buchholz) Date: Sat, 18 Apr 2009 14:30:41 -0700 Subject: New project: getting rid of IcedTea local patches In-Reply-To: <49E9A250.1080605@redhat.com> References: <49D3917B.2010907@redhat.com> <49DDF4C6.1070602@redhat.com> <1ccfd1c10904171255u7063d007ra14860e535e5c7b8@mail.gmail.com> <49E9A250.1080605@redhat.com> Message-ID: <1ccfd1c10904181430w5477c238w8094a511cc8eb548@mail.gmail.com> On Sat, Apr 18, 2009 at 02:50, Andrew Haley wrote: > Martin Buchholz wrote: > Well, maintaining this "buffer" forest is, more or less, what IcedTea does. > I'm not sure that we need another one. I wasn't suggesting we start a new buffer forest. I was suggesting we (Google + IcedTea) consider sharing the forest at http://openjdk.java.net/projects/icedtea/. even though Google's patches didn't originate in IcedTea proper. Martin From aph at redhat.com Sat Apr 18 23:00:34 2009 From: aph at redhat.com (Andrew Haley) Date: Sun, 19 Apr 2009 00:00:34 +0100 Subject: New project: getting rid of IcedTea local patches In-Reply-To: <1ccfd1c10904181430w5477c238w8094a511cc8eb548@mail.gmail.com> References: <49D3917B.2010907@redhat.com> <49DDF4C6.1070602@redhat.com> <1ccfd1c10904171255u7063d007ra14860e535e5c7b8@mail.gmail.com> <49E9A250.1080605@redhat.com> <1ccfd1c10904181430w5477c238w8094a511cc8eb548@mail.gmail.com> Message-ID: <49EA5B92.2090700@redhat.com> Martin Buchholz wrote: > On Sat, Apr 18, 2009 at 02:50, Andrew Haley wrote: >> Martin Buchholz wrote: >> Well, maintaining this "buffer" forest is, more or less, what IcedTea does. >> I'm not sure that we need another one. > > I wasn't suggesting we start a new buffer forest. > I was suggesting we (Google + IcedTea) > consider sharing the forest at http://openjdk.java.net/projects/icedtea/. > even though Google's patches didn't originate in IcedTea proper. That's an excellent plan. Andrew. From aph at redhat.com Mon Apr 20 09:06:18 2009 From: aph at redhat.com (Andrew Haley) Date: Mon, 20 Apr 2009 10:06:18 +0100 Subject: hg: jdk7/build/langtools: 6829575: 100028: Debug information is incomplete or missing In-Reply-To: References: <20090417151544.791CEE017@hg.openjdk.java.net> <5CF068B6-DF5C-4EAF-9BA8-750C418CE929@sun.com> <49E8AA2B.4090101@redhat.com> <8EFEE7E6-5229-42BA-8BC6-E3320657FB3A@Sun.COM> <49E8AEF3.9020007@redhat.com> <49E8BEA6.3020204@redhat.com> <49E92627.7040405@sun.com> <49E9A455.4060808@redhat.com> Message-ID: <49EC3B0A.9060408@redhat.com> Jonathan Gibbons wrote: > Andrew. > > Earlier this week, Mark announced that Release Team approval was required > for the final M3 builds for JDK7. [1] Glad I asked. > Even without that, jcheck would require that you have another BugTraq CR > for this issue, even though it is just a modification of a recent fix. I > didn't see > a new CR get created yet; is that right? https://bugs.openjdk.java.net/show_bug.cgi?id=100045 Andrew. From aph at redhat.com Mon Apr 20 09:09:19 2009 From: aph at redhat.com (Andrew Haley) Date: Mon, 20 Apr 2009 10:09:19 +0100 Subject: Request for approval: file fallout from 100028 patch Message-ID: <49EC3BBF.3000504@redhat.com> https://bugs.openjdk.java.net/show_bug.cgi?id=100045 Andrew. From martinrb at google.com Mon Apr 20 15:52:39 2009 From: martinrb at google.com (Martin Buchholz) Date: Mon, 20 Apr 2009 08:52:39 -0700 Subject: hg: jdk7/build/langtools: 6829575: 100028: Debug information is incomplete or missing In-Reply-To: <49EC3B0A.9060408@redhat.com> References: <20090417151544.791CEE017@hg.openjdk.java.net> <5CF068B6-DF5C-4EAF-9BA8-750C418CE929@sun.com> <49E8AA2B.4090101@redhat.com> <8EFEE7E6-5229-42BA-8BC6-E3320657FB3A@Sun.COM> <49E8AEF3.9020007@redhat.com> <49E8BEA6.3020204@redhat.com> <49E92627.7040405@sun.com> <49E9A455.4060808@redhat.com> <49EC3B0A.9060408@redhat.com> Message-ID: <1ccfd1c10904200852m19adc3f0o584e2041e9eae908@mail.gmail.com> On Mon, Apr 20, 2009 at 02:06, Andrew Haley wrote: > Jonathan Gibbons wrote: >> Andrew. >> >> Earlier this week, Mark announced that Release Team approval was required >> for the final M3 builds for JDK7. [1] > > Glad I asked. > >> Even without that, jcheck would require that you have another BugTraq CR >> for this issue, even though it is just a modification of a recent fix. I >> didn't see >> a new CR get created yet; is that right? > > https://bugs.openjdk.java.net/show_bug.cgi?id=100045 I believe that openjdk infrastructure has not yet advanced to the point where it can use bugzilla bugs for commits. All of my own commits have had actual bugs.sun.com bugs filed on my behalf. Martin > Andrew. > From Xiomara.Jayasena at Sun.COM Mon Apr 20 15:56:01 2009 From: Xiomara.Jayasena at Sun.COM (Xiomara Jayasena) Date: Mon, 20 Apr 2009 08:56:01 -0700 Subject: hg: jdk7/build/langtools: 6829575: 100028: Debug information is incomplete or missing In-Reply-To: <49E9A455.4060808@redhat.com> References: <20090417151544.791CEE017@hg.openjdk.java.net> <5CF068B6-DF5C-4EAF-9BA8-750C418CE929@sun.com> <49E8AA2B.4090101@redhat.com> <8EFEE7E6-5229-42BA-8BC6-E3320657FB3A@Sun.COM> <49E8AEF3.9020007@redhat.com> <49E8BEA6.3020204@redhat.com> <49E92627.7040405@sun.com> <49E9A455.4060808@redhat.com> Message-ID: <49EC9B11.9020103@sun.com> End of today is the code freeze for the build integration area. The last putback (Bug ID: 6829575) broke the windows builds. Chris Hegarty's (SCTP feature) is in the build integration area so the changes from there need to be pushed to the master prior to build 56. Please address the above problem by the end of today, otherwise the original code for 6829575 would need to be backed out. Thanks, -Xiomara Andrew Haley wrote: > Jonathan Gibbons wrote: > >> Andrew Haley wrote: >> >>> I'm going to change langtools/jaxp/jaxws to >>> >>> ifeq ($(DEBUG_CLASSFILES), true) >>> ANT_OPTIONS += -Djavac.debug=true >>> ANT_OPTIONS += -Djavac.debuglevel=source,lines,vars >>> endif >>> >> Yes. If all you want to do is to provide a consistent way of enabling >> all debug info in classfiles, then I agree with this proposed change. >> I'm sorry, I misread the earlier email and confused Kelly's proposed >> change with your actual changeset. >> > > I cannot tell whether this reply from Jonathan is sufficient permission > for me to commit this change. I guess it is, but as this is my first > commit I'm not sure exactly what the policy is. > > I know that my previous patch somewhat broke debuginfo, so I want to fix > it ASAP, but I don't want to break approval policy. Damned if I do, and > damned if I don't... > > Andrew. > -------------- next part -------------- An HTML attachment was scrubbed... URL: From aph at redhat.com Mon Apr 20 16:28:13 2009 From: aph at redhat.com (Andrew Haley) Date: Mon, 20 Apr 2009 17:28:13 +0100 Subject: hg: jdk7/build/langtools: 6829575: 100028: Debug information is incomplete or missing In-Reply-To: <49EC9B11.9020103@sun.com> References: <20090417151544.791CEE017@hg.openjdk.java.net> <5CF068B6-DF5C-4EAF-9BA8-750C418CE929@sun.com> <49E8AA2B.4090101@redhat.com> <8EFEE7E6-5229-42BA-8BC6-E3320657FB3A@Sun.COM> <49E8AEF3.9020007@redhat.com> <49E8BEA6.3020204@redhat.com> <49E92627.7040405@sun.com> <49E9A455.4060808@redhat.com> <49EC9B11.9020103@sun.com> Message-ID: <49ECA29D.6070502@redhat.com> Xiomara Jayasena wrote: > End of today is the code freeze for the build integration area. The > last putback (Bug ID: 6829575) broke the windows builds. Kelly, please help me out here, my understanding is that my patch was tested on all the platforms before I pushed it. If my patch really broke the Windows build, how did that happen? > Chris Hegarty's (SCTP feature) is in the build integration area so the > changes from there need to be pushed to the master prior to build 56. > Please address the above problem by the end of today, otherwise the > original code for 6829575 would need to be backed out. I don't understand what broke, sorry. Obviously I'll do everything that I can but right now I just don't have the information. Andrew. From Dalibor.Topic at Sun.COM Mon Apr 20 17:27:20 2009 From: Dalibor.Topic at Sun.COM (Dalibor Topic) Date: Mon, 20 Apr 2009 19:27:20 +0200 Subject: hg: jdk7/build/langtools: 6829575: 100028: Debug information is incomplete or missing In-Reply-To: References: <20090417151544.791CEE017@hg.openjdk.java.net> <5CF068B6-DF5C-4EAF-9BA8-750C418CE929@sun.com> <49E8AA2B.4090101@redhat.com> <8EFEE7E6-5229-42BA-8BC6-E3320657FB3A@Sun.COM> <49E8AEF3.9020007@redhat.com> <49E8BEA6.3020204@redhat.com> <49E92627.7040405@sun.com> <49E9A455.4060808@redhat.com> Message-ID: <49ECB078.7040501@sun.com> Jonathan Gibbons wrote: > Andrew. > > Earlier this week, Mark announced that Release Team approval was required > for the final M3 builds for JDK7. [1] > > Even without that, jcheck would require that you have another BugTraq CR > for this issue, even though it is just a modification of a recent fix. I > didn't see > a new CR get created yet; is that right? I just created 6832112 for https://bugs.openjdk.java.net/show_bug.cgi?id=100045. cheers, dalibor topic -- ******************************************************************* Dalibor Topic Tel: (+49 40) 23 646 738 Java F/OSS Ambassador AIM: robiladonaim Sun Microsystems GmbH Mobile: (+49 177) 2664 192 Nagelsweg 55 http://openjdk.java.net D-20097 Hamburg mailto:Dalibor.Topic at sun.com Sitz der Gesellschaft: Sonnenallee 1, D-85551 Kirchheim-Heimstetten Amtsgericht M?nchen: HRB 161028 Gesch?ftsf?hrer: Thomas Schr?der, Wolfgang Engels, Dr. Roland B?mer Vorsitzender des Aufsichtsrates: Martin H?ring From Dalibor.Topic at Sun.COM Mon Apr 20 17:28:47 2009 From: Dalibor.Topic at Sun.COM (Dalibor Topic) Date: Mon, 20 Apr 2009 19:28:47 +0200 Subject: hg: jdk7/build/langtools: 6829575: 100028: Debug information is incomplete or missing In-Reply-To: References: <20090417151544.791CEE017@hg.openjdk.java.net> <5CF068B6-DF5C-4EAF-9BA8-750C418CE929@sun.com> <49E8AA2B.4090101@redhat.com> <8EFEE7E6-5229-42BA-8BC6-E3320657FB3A@Sun.COM> <49E8AEF3.9020007@redhat.com> <49E8BEA6.3020204@redhat.com> <49E92627.7040405@sun.com> <49E9A455.4060808@redhat.com> Message-ID: <49ECB0CF.8010904@sun.com> Jonathan Gibbons wrote: > Andrew. > > Earlier this week, Mark announced that Release Team approval was required > for the final M3 builds for JDK7. [1] > > Even without that, jcheck would require that you have another BugTraq CR > for this issue, even though it is just a modification of a recent fix. I > didn't see > a new CR get created yet; is that right? I just created 6832112 for https://bugs.openjdk.java.net/show_bug.cgi?id=100045. cheers, dalibor topic -- ******************************************************************* Dalibor Topic Tel: (+49 40) 23 646 738 Java F/OSS Ambassador AIM: robiladonaim Sun Microsystems GmbH Mobile: (+49 177) 2664 192 Nagelsweg 55 http://openjdk.java.net D-20097 Hamburg mailto:Dalibor.Topic at sun.com Sitz der Gesellschaft: Sonnenallee 1, D-85551 Kirchheim-Heimstetten Amtsgericht M?nchen: HRB 161028 Gesch?ftsf?hrer: Thomas Schr?der, Wolfgang Engels, Dr. Roland B?mer Vorsitzender des Aufsichtsrates: Martin H?ring From Jonathan.Gibbons at Sun.COM Mon Apr 20 17:42:00 2009 From: Jonathan.Gibbons at Sun.COM (Jonathan Gibbons) Date: Mon, 20 Apr 2009 10:42:00 -0700 Subject: hg: jdk7/build/langtools: 6829575: 100028: Debug information is incomplete or missing In-Reply-To: <49ECB078.7040501@sun.com> References: <20090417151544.791CEE017@hg.openjdk.java.net> <5CF068B6-DF5C-4EAF-9BA8-750C418CE929@sun.com> <49E8AA2B.4090101@redhat.com> <8EFEE7E6-5229-42BA-8BC6-E3320657FB3A@Sun.COM> <49E8AEF3.9020007@redhat.com> <49E8BEA6.3020204@redhat.com> <49E92627.7040405@sun.com> <49E9A455.4060808@redhat.com> <49ECB078.7040501@sun.com> Message-ID: <49ECB3E8.3040501@sun.com> Dalibor, I'd suggest raising this to P2, since I think it's a serious regression. -- Jon Dalibor Topic wrote: > Jonathan Gibbons wrote: > >> Andrew. >> >> Earlier this week, Mark announced that Release Team approval was required >> for the final M3 builds for JDK7. [1] >> >> Even without that, jcheck would require that you have another BugTraq CR >> for this issue, even though it is just a modification of a recent fix. I >> didn't see >> a new CR get created yet; is that right? >> > > I just created 6832112 for https://bugs.openjdk.java.net/show_bug.cgi?id=100045. > > cheers, > dalibor topic > > -------------- next part -------------- An HTML attachment was scrubbed... URL: From Kelly.Ohair at Sun.COM Mon Apr 20 17:47:58 2009 From: Kelly.Ohair at Sun.COM (Kelly O'Hair) Date: Mon, 20 Apr 2009 10:47:58 -0700 Subject: Request for approval: file fallout from 100028 patch In-Reply-To: <49EC3BBF.3000504@redhat.com> References: <49EC3BBF.3000504@redhat.com> Message-ID: <49ECB54E.2010301@sun.com> I created the sun bug for this. (Sure wish someone would fix jcheck... ;^) 6832141: Bug 100045 - Fix for 100028 breaks debug info for class files Looks ok to me. Xiomara would like to integrate the build forest to jdk7/jdk7 (master forest) today or tomorrow, so we'll need this fix in for that. Is that a problem? -kto Andrew Haley wrote: > https://bugs.openjdk.java.net/show_bug.cgi?id=100045 > > Andrew. From Kelly.Ohair at Sun.COM Mon Apr 20 17:51:39 2009 From: Kelly.Ohair at Sun.COM (Kelly O'Hair) Date: Mon, 20 Apr 2009 10:51:39 -0700 Subject: hg: jdk7/build/langtools: 6829575: 100028: Debug information is incomplete or missing In-Reply-To: <49EC3B0A.9060408@redhat.com> References: <20090417151544.791CEE017@hg.openjdk.java.net> <5CF068B6-DF5C-4EAF-9BA8-750C418CE929@sun.com> <49E8AA2B.4090101@redhat.com> <8EFEE7E6-5229-42BA-8BC6-E3320657FB3A@Sun.COM> <49E8AEF3.9020007@redhat.com> <49E8BEA6.3020204@redhat.com> <49E92627.7040405@sun.com> <49E9A455.4060808@redhat.com> <49EC3B0A.9060408@redhat.com> Message-ID: <49ECB62B.1030407@sun.com> I created 6832141: Bug 100045 - Fix for 100028 breaks debug info for class files -kto Andrew Haley wrote: > Jonathan Gibbons wrote: >> Andrew. >> >> Earlier this week, Mark announced that Release Team approval was required >> for the final M3 builds for JDK7. [1] > > Glad I asked. > >> Even without that, jcheck would require that you have another BugTraq CR >> for this issue, even though it is just a modification of a recent fix. I >> didn't see >> a new CR get created yet; is that right? > > https://bugs.openjdk.java.net/show_bug.cgi?id=100045 > > Andrew. From aph at redhat.com Mon Apr 20 17:52:53 2009 From: aph at redhat.com (Andrew Haley) Date: Mon, 20 Apr 2009 18:52:53 +0100 Subject: Request for approval: file fallout from 100028 patch In-Reply-To: <49ECB54E.2010301@sun.com> References: <49EC3BBF.3000504@redhat.com> <49ECB54E.2010301@sun.com> Message-ID: <49ECB675.6050404@redhat.com> Kelly O'Hair wrote: > > I created the sun bug for this. (Sure wish someone would fix jcheck... ;^) > > 6832141: Bug 100045 - Fix for 100028 breaks debug info for class files > > Looks ok to me. > > Xiomara would like to integrate the build forest to jdk7/jdk7 (master > forest) > today or tomorrow, so we'll need this fix in for that. > Is that a problem? Not at all. I'll push it now. I am assuming that "Looks ok to me" is approval for this fix. Andrew. From Kelly.Ohair at Sun.COM Mon Apr 20 17:55:44 2009 From: Kelly.Ohair at Sun.COM (Kelly O'Hair) Date: Mon, 20 Apr 2009 10:55:44 -0700 Subject: Request for approval: file fallout from 100028 patch In-Reply-To: <49ECB675.6050404@redhat.com> References: <49EC3BBF.3000504@redhat.com> <49ECB54E.2010301@sun.com> <49ECB675.6050404@redhat.com> Message-ID: <49ECB720.60406@sun.com> Andrew Haley wrote: > Kelly O'Hair wrote: >> I created the sun bug for this. (Sure wish someone would fix jcheck... ;^) >> >> 6832141: Bug 100045 - Fix for 100028 breaks debug info for class files >> >> Looks ok to me. >> >> Xiomara would like to integrate the build forest to jdk7/jdk7 (master >> forest) >> today or tomorrow, so we'll need this fix in for that. >> Is that a problem? > > Not at all. I'll push it now. > > I am assuming that "Looks ok to me" is approval for this fix. Yup. ;^) -kto > > Andrew. From aph at redhat.com Mon Apr 20 18:10:01 2009 From: aph at redhat.com (Andrew Haley) Date: Mon, 20 Apr 2009 19:10:01 +0100 Subject: Request for approval: file fallout from 100028 patch In-Reply-To: <49ECB675.6050404@redhat.com> References: <49EC3BBF.3000504@redhat.com> <49ECB54E.2010301@sun.com> <49ECB675.6050404@redhat.com> Message-ID: <49ECBA79.8070204@redhat.com> Andrew Haley wrote: > Kelly O'Hair wrote: >> I created the sun bug for this. (Sure wish someone would fix jcheck... ;^) >> >> 6832141: Bug 100045 - Fix for 100028 breaks debug info for class files >> >> Looks ok to me. >> >> Xiomara would like to integrate the build forest to jdk7/jdk7 (master >> forest) >> today or tomorrow, so we'll need this fix in for that. >> Is that a problem? > > Not at all. I'll push it now. Pushed. I have no idea whether this fixes Xiomara's Windows problem or not. Andrew. From aph at redhat.com Mon Apr 20 18:17:34 2009 From: aph at redhat.com (Andrew Haley) Date: Mon, 20 Apr 2009 19:17:34 +0100 Subject: Request for approval: file fallout from 100028 patch In-Reply-To: <49ECBA79.8070204@redhat.com> References: <49EC3BBF.3000504@redhat.com> <49ECB54E.2010301@sun.com> <49ECB675.6050404@redhat.com> <49ECBA79.8070204@redhat.com> Message-ID: <49ECBC3E.7050407@redhat.com> Andrew Haley wrote: > Andrew Haley wrote: >> Kelly O'Hair wrote: >>> I created the sun bug for this. (Sure wish someone would fix jcheck... ;^) >>> >>> 6832141: Bug 100045 - Fix for 100028 breaks debug info for class files >>> >>> Looks ok to me. >>> >>> Xiomara would like to integrate the build forest to jdk7/jdk7 (master >>> forest) >>> today or tomorrow, so we'll need this fix in for that. >>> Is that a problem? >> Not at all. I'll push it now. > > Pushed. I have no idea whether this fixes Xiomara's Windows problem or not. Still pushing, incredibly slow. I have no idea how long this will take... Andrew. From aph at redhat.com Mon Apr 20 18:17:46 2009 From: aph at redhat.com (aph at redhat.com) Date: Mon, 20 Apr 2009 18:17:46 +0000 Subject: hg: jdk7/build/jaxp: 6832141: Bug 100045 - Fix for 100028 breaks debug info for class files Message-ID: <20090420181748.5D9C8E30D@hg.openjdk.java.net> Changeset: 7967d26b229c Author: aph Date: 2009-04-20 19:00 +0100 URL: http://hg.openjdk.java.net/jdk7/build/jaxp/rev/7967d26b229c 6832141: Bug 100045 - Fix for 100028 breaks debug info for class files Summary: Correct fallout from 100028 patch Reviewed-by: ohair Contributed-by: Andrew Haley ! make/Makefile From aph at redhat.com Mon Apr 20 18:23:30 2009 From: aph at redhat.com (aph at redhat.com) Date: Mon, 20 Apr 2009 18:23:30 +0000 Subject: hg: jdk7/build/jaxws: 6832141: Bug 100045 - Fix for 100028 breaks debug info for class files Message-ID: <20090420182332.A4094E312@hg.openjdk.java.net> Changeset: ab30d5761947 Author: aph Date: 2009-04-20 19:01 +0100 URL: http://hg.openjdk.java.net/jdk7/build/jaxws/rev/ab30d5761947 6832141: Bug 100045 - Fix for 100028 breaks debug info for class files Summary: Correct fallout from 100028 patch Reviewed-by: ohair Contributed-by: Andrew Haley ! make/Makefile From aph at redhat.com Mon Apr 20 18:29:27 2009 From: aph at redhat.com (aph at redhat.com) Date: Mon, 20 Apr 2009 18:29:27 +0000 Subject: hg: jdk7/build/langtools: 6832141: Bug 100045 - Fix for 100028 breaks debug info for class files Message-ID: <20090420182930.9D101E31F@hg.openjdk.java.net> Changeset: 321854d9ab19 Author: aph Date: 2009-04-20 19:01 +0100 URL: http://hg.openjdk.java.net/jdk7/build/langtools/rev/321854d9ab19 6832141: Bug 100045 - Fix for 100028 breaks debug info for class files Summary: Correct fallout from 100028 patch Reviewed-by: ohair Contributed-by: Andrew Haley ! make/Makefile From Xiomara.Jayasena at Sun.COM Mon Apr 20 23:17:01 2009 From: Xiomara.Jayasena at Sun.COM (Xiomara.Jayasena at Sun.COM) Date: Mon, 20 Apr 2009 16:17:01 -0700 Subject: Request for approval: file fallout from 100028 patch In-Reply-To: <49ECBA79.8070204@redhat.com> References: <49EC3BBF.3000504@redhat.com> <49ECB54E.2010301@sun.com> <49ECB675.6050404@redhat.com> <49ECBA79.8070204@redhat.com> Message-ID: <49ED026D.4080700@Sun.COM> On 04/20/09 11:10, Andrew Haley wrote: > Andrew Haley wrote: > >> Kelly O'Hair wrote: >> >>> I created the sun bug for this. (Sure wish someone would fix jcheck... ;^) >>> >>> 6832141: Bug 100045 - Fix for 100028 breaks debug info for class files >>> >>> Looks ok to me. >>> >>> Xiomara would like to integrate the build forest to jdk7/jdk7 (master >>> forest) >>> today or tomorrow, so we'll need this fix in for that. >>> Is that a problem? >>> >> Not at all. I'll push it now. >> > > Pushed. I have no idea whether this fixes Xiomara's Windows problem or not. > Those last putbacks broke the build at a different point :-(. Maybe we should wait until Kelly can take a look before trying another push again. # Java sources to be compiled: (listed in file C:/BUILD_AREA/jdk7/build/windows-i586-fastdebug/tmp/sun/sun.tracing/.classes.list) ../../../src/share/classes/sun/tracing/MultiplexProviderFactory.java ../../../src/share/classes/sun/tracing/NullProviderFactory.java ../../../src/share/classes/sun/tracing/PrintStreamProviderFactory.java ../../../src/share/classes/sun/tracing/ProbeSkeleton.java ../../../src/share/classes/sun/tracing/ProviderSkeleton.java ../../../src/share/classes/sun/tracing/dtrace/Activation.java ../../../src/share/classes/sun/tracing/dtrace/DTraceProbe.java ../../../src/share/classes/sun/tracing/dtrace/DTraceProvider.java ../../../src/share/classes/sun/tracing/dtrace/DTraceProviderFactory.java ../../../src/share/classes/sun/tracing/dtrace/JVM.java ../../../src/share/classes/sun/tracing/package-info.java # Running javac: C:/jdk1.6.0/bin/javac -J-XX:ThreadStackSize=768 -J-XX:-PrintVMOptions -J-XX:+UnlockDiagnosticVMOptions -J-XX:-LogVMOutput -J-client -J-Xmx896m -J-Xms128m -J-XX:PermSize=32m -J-XX:MaxPermSize=160m -g -source 1.5 -target 5 -encoding ascii -Xbootclasspath:C:/BUILD_AREA/jdk7/build/windows-i586-fastdebug/classes -sourcepath ../../../src/closed/windows/classes;../../../src/closed/share/classes;C:/BUILD_AREA/jdk7/build/windows-i586-fastdebug/gensrc;../../../src/windows/classes;../../../src/share/classes -d C:/BUILD_AREA/jdk7/build/windows-i586-fastdebug/classes @C:/BUILD_AREA/jdk7/build/windows-i586-fastdebug/tmp/sun/sun.tracing/.classes.list.filtered ..\..\..\src\share\classes\sun\tracing\MultiplexProviderFactory.java:75: type parameters of T cannot be determined; no unique maximal instance exists for type variable T with upper bounds T,com.sun.tracing.Provider return provider.newProxyInstance(); ^ ..\..\..\src\share\classes\sun\tracing\NullProviderFactory.java:63: type parameters of T cannot be determined; no unique maximal instance exists for type variable T with upper bounds T,com.sun.tracing.Provider return provider.newProxyInstance(); ^ ..\..\..\src\share\classes\sun\tracing\PrintStreamProviderFactory.java:64: type parameters of T cannot be determined; no unique maximal instance exists for type variable T with upper bounds T,com.sun.tracing.Provider return provider.newProxyInstance(); ^ ..\..\..\src\share\classes\sun\tracing\dtrace\DTraceProviderFactory.java:81: type parameters of T cannot be determined; no unique maximal instance exists for type variable T with upper bounds T,com.sun.tracing.Provider T proxy = jsdt.newProxyInstance(); ^ 4 errors gnumake[5]: *** [.compile.classlist] Error 1 gnumake[5]: Leaving directory `C:/BUILD_AREA/jdk7/jdk/make/sun/tracing' gnumake[4]: *** [all] Error 1 gnumake[4]: Leaving directory `C:/BUILD_AREA/jdk7/jdk/make/sun' gnumake[3]: *** [all] Error 1 gnumake[3]: Leaving directory `C:/BUILD_AREA/jdk7/jdk/make' -Xiomara > Andrew. > -------------- next part -------------- An HTML attachment was scrubbed... URL: From aph at redhat.com Tue Apr 21 09:49:40 2009 From: aph at redhat.com (Andrew Haley) Date: Tue, 21 Apr 2009 10:49:40 +0100 Subject: Request for approval: file fallout from 100028 patch In-Reply-To: <49ED026D.4080700@Sun.COM> References: <49EC3BBF.3000504@redhat.com> <49ECB54E.2010301@sun.com> <49ECB675.6050404@redhat.com> <49ECBA79.8070204@redhat.com> <49ED026D.4080700@Sun.COM> Message-ID: <49ED96B4.5020904@redhat.com> Xiomara.Jayasena at Sun.COM wrote: > On 04/20/09 11:10, Andrew Haley wrote: >> Andrew Haley wrote: >> >>> Kelly O'Hair wrote: >>> >>>> I created the sun bug for this. (Sure wish someone would fix >>>> jcheck... ;^) >>>> >>>> 6832141: Bug 100045 - Fix for 100028 breaks debug info for class files >>>> >>>> Looks ok to me. >>>> >>>> Xiomara would like to integrate the build forest to jdk7/jdk7 (master >>>> forest) >>>> today or tomorrow, so we'll need this fix in for that. >>>> Is that a problem? >>>> >>> Not at all. I'll push it now. >>> >> >> Pushed. I have no idea whether this fixes Xiomara's Windows problem >> or not. >> > > Those last putbacks broke the build at a different point :-(. I have no idea how my patch could have caused that error. > Maybe we > should wait until Kelly can take a look before trying another push again. Definitely. It is very odd. My last push only touched jaxp, jaxws, and langtools; the error appears in jdk. Andrew. From Anthony.Petrov at Sun.COM Wed Apr 22 14:53:47 2009 From: Anthony.Petrov at Sun.COM (Anthony Petrov) Date: Wed, 22 Apr 2009 18:53:47 +0400 Subject: _BOOTDIR1 on MS Windows platform Message-ID: <49EF2F7B.4020504@sun.com> Hello, Back in 2007 we already discussed this issue with Kelly, but transitioning to Mercurial just stopped the work. So, I would like to revive this now. Here's a part of the output generated by `grep -r BOOTDIR make/*`: > make/common/shared/Defs-solaris.gmk: _BOOTDIR1 =$(SLASH_JAVA)/re/jdk/$(PREVIOUS_JDK_VERSION)/archive/fcs/binaries/$(PLATFORM)-$(ARCH) > make/common/shared/Defs-solaris.gmk: _BOOTDIR2 =$(USRJDKINSTANCES_PATH)/jdk$(PREVIOUS_JDK_VERSION) > make/common/shared/Defs-windows.gmk: _BOOTDIR1 =$(_system_drive)/jdk$(PREVIOUS_JDK_VERSION) > make/common/shared/Defs-windows.gmk: _BOOTDIR2 =$(USRJDKINSTANCES_PATH)/jdk$(PREVIOUS_JDK_VERSION) > make/common/shared/Defs-linux.gmk: _BOOTDIR1 =$(SLASH_JAVA)/re/jdk/$(PREVIOUS_JDK_VERSION)/archive/fcs/binaries/$(PLATFORM)-$(ARCH) > make/common/shared/Defs-linux.gmk: _BOOTDIR2 =$(USRJDKINSTANCES_PATH)/jdk$(PREVIOUS_JDK_VERSION) One can notice that the _BOOTDIR1 is defined differently on MS Windows platform. I would like to propose a change so that its value would be the same as on other platforms. The SLASH_JAVA on MS Windows equals to the J: drive. So one could setup the same directory tree as on Linux/Solaris, use the subst command to make the directory the J: drive, and be able to build the jdk w/o specifying the ALT_BOOTDIR variable manually. Is there any objection to removing the $(_system_drive)/jdk$(PREVIOUS_JDK_VERSION) default path? -- best regards, Anthony From Anthony.Petrov at Sun.COM Thu Apr 23 14:12:25 2009 From: Anthony.Petrov at Sun.COM (Anthony Petrov) Date: Thu, 23 Apr 2009 18:12:25 +0400 Subject: Review request: 6833444 (_BOOTDIR1/_BOOTDIR2 on MS Windows should be consistent with other platforms) Message-ID: <49F07749.9050702@sun.com> Please review the fix for the CR mentioned in the subject. The webrev: http://cr.openjdk.java.net/~anthony/webrev-6833444.0/ I verified the fix on MS Windows platform, and it works pretty well. -- best regards, Anthony From Anthony.Petrov at Sun.COM Thu Apr 23 16:31:41 2009 From: Anthony.Petrov at Sun.COM (Anthony Petrov) Date: Thu, 23 Apr 2009 20:31:41 +0400 Subject: Review request: 6833444 (_BOOTDIR1/_BOOTDIR2 on MS Windows should be consistent with other platforms) In-Reply-To: <49F07AE8.4050909@sun.com> References: <49F07AE8.4050909@sun.com> Message-ID: <49F097ED.7070105@sun.com> Hi Xiomara, Thank you for the comments! On 4/23/2009 6:27 PM Xiomara Jayasena wrote: > Release Engineering uses c:\jdk ... when building on windows. We will > still need that. Ups. I'm sorry about that, I really didn't know you use this path. This was the reason I initiated the discussion on the build-dev@ yesterday. Since I didn't receive any feedback, I assumed nobody cares about c:\jdk. > I am understanding that, that is being removed? > > - _BOOTDIR1 =$(_system_drive)/jdk$(PREVIOUS_JDK_VERSION) > + _BOOTDIR1 =$(SLASH_JAVA)/re/jdk/$(PREVIOUS_JDK_VERSION)/archiv Yes, this is correct. Well, then perhaps I'll go and add the _BOOTDIR3 then. So, on Windows we will have three options: c:\jdk, c:\program files\java, and finally the standard j: approach introduced with the fix. Does it sound good? > RE tries to localized all the software we use in the local build system. So do I on my local Windows build machine. And it seems that maintaining a local copy of the standard directory tree (/java --> j:) is *way* simpler than inventing something new. I just sync my local directory with the /java network share, and use the 'subst' command to make the J: disk out of the directory. With this configuration all the default options in the makefiles make sense, and I don't need to define any additional environment variables prior to running make (well, excluding the vsvars32.bat, of course, but that's another story). PS. I moved the discussion to the build-dev@, since it is basically the fix reviewing. -- best regards, Anthony From Kelly.Ohair at Sun.COM Thu Apr 23 18:15:27 2009 From: Kelly.Ohair at Sun.COM (Kelly O'Hair) Date: Thu, 23 Apr 2009 11:15:27 -0700 Subject: _BOOTDIR1 on MS Windows platform In-Reply-To: <49EF2F7B.4020504@sun.com> References: <49EF2F7B.4020504@sun.com> Message-ID: <49F0B03F.4000305@sun.com> Sorry I'm so slow in responding to this... The primary reason for the special case on Windows is the unreliability and slowness of the network connections. Builds using a local jdk vs. a J:/ mapped can be 5 hours long when they might normally be 1hr or less. These just come from reports I have gotten over the years, and it's really depends on the Windows machine, the network, etc. Bottom line, builds are always faster and more reliable when all components are stored on local disk, and this is particularly true on Windows. Having said all that, I ALWAYS set ALT_BOOTDIR to my local copy (and ALT_JDK_IMPORT_PATH too). So I probably would not be impacted by this change, but I bet quite a few people rely on this c:/jdk1.6.0 default. With enough warning you might be able to change this. --- I have been recently working on the JavaFX build dependency issues and although it's more ant based, some of the techniques could apply to making OpenJDK builds easier. Unfortunately, there is only 24hrs in a day. :^{ -kto Anthony Petrov wrote: > Hello, > > Back in 2007 we already discussed this issue with Kelly, but > transitioning to Mercurial just stopped the work. So, I would like to > revive this now. > > Here's a part of the output generated by `grep -r BOOTDIR make/*`: > >> make/common/shared/Defs-solaris.gmk: _BOOTDIR1 >> =$(SLASH_JAVA)/re/jdk/$(PREVIOUS_JDK_VERSION)/archive/fcs/binaries/$(PLATFORM)-$(ARCH) >> >> make/common/shared/Defs-solaris.gmk: _BOOTDIR2 >> =$(USRJDKINSTANCES_PATH)/jdk$(PREVIOUS_JDK_VERSION) >> make/common/shared/Defs-windows.gmk: _BOOTDIR1 >> =$(_system_drive)/jdk$(PREVIOUS_JDK_VERSION) >> make/common/shared/Defs-windows.gmk: _BOOTDIR2 >> =$(USRJDKINSTANCES_PATH)/jdk$(PREVIOUS_JDK_VERSION) >> make/common/shared/Defs-linux.gmk: _BOOTDIR1 >> =$(SLASH_JAVA)/re/jdk/$(PREVIOUS_JDK_VERSION)/archive/fcs/binaries/$(PLATFORM)-$(ARCH) >> >> make/common/shared/Defs-linux.gmk: _BOOTDIR2 >> =$(USRJDKINSTANCES_PATH)/jdk$(PREVIOUS_JDK_VERSION) > > One can notice that the _BOOTDIR1 is defined differently on MS Windows > platform. I would like to propose a change so that its value would be > the same as on other platforms. The SLASH_JAVA on MS Windows equals to > the J: drive. So one could setup the same directory tree as on > Linux/Solaris, use the subst command to make the directory the J: drive, > and be able to build the jdk w/o specifying the ALT_BOOTDIR variable > manually. > > Is there any objection to removing the > $(_system_drive)/jdk$(PREVIOUS_JDK_VERSION) default path? > > -- > best regards, > Anthony From Xiomara.Jayasena at Sun.COM Thu Apr 23 18:31:40 2009 From: Xiomara.Jayasena at Sun.COM (Xiomara.Jayasena at Sun.COM) Date: Thu, 23 Apr 2009 11:31:40 -0700 Subject: Review request: 6833444 (_BOOTDIR1/_BOOTDIR2 on MS Windows should be consistent with other platforms) In-Reply-To: <49F097ED.7070105@sun.com> References: <49F07AE8.4050909@sun.com> <49F097ED.7070105@sun.com> Message-ID: <49F0B40C.8040904@Sun.COM> Hi Anthony, We do set ALT_BOOTDIR all the time. From Kelly: > Having said all that, I ALWAYS set ALT_BOOTDIR to my local copy > (and ALT_JDK_IMPORT_PATH too). So I probably would not be impacted > by this change, but I bet quite a few people rely on this c:/jdk1.6.0 > default. With enough warning you might be able to change this. It's OK with me, if you remove c:/jdk ... Thanks, -Xiomara On 04/23/09 09:31, Anthony Petrov wrote: > Hi Xiomara, > > Thank you for the comments! > > On 4/23/2009 6:27 PM Xiomara Jayasena wrote: >> Release Engineering uses c:\jdk ... when building on windows. We >> will still need that. > Ups. I'm sorry about that, I really didn't know you use this path. > This was the reason I initiated the discussion on the build-dev@ > yesterday. Since I didn't receive any feedback, I assumed nobody cares > about c:\jdk. > >> I am understanding that, that is being removed? >> >> - _BOOTDIR1 =$(_system_drive)/jdk$(PREVIOUS_JDK_VERSION) >> + _BOOTDIR1 =$(SLASH_JAVA)/re/jdk/$(PREVIOUS_JDK_VERSION)/archiv > Yes, this is correct. > Well, then perhaps I'll go and add the _BOOTDIR3 then. So, on Windows > we will have three options: c:\jdk, c:\program files\java, and finally > the standard j: approach introduced with the fix. Does it sound good? > >> RE tries to localized all the software we use in the local build system. > So do I on my local Windows build machine. And it seems that > maintaining a local copy of the standard directory tree (/java --> j:) > is *way* simpler than inventing something new. I just sync my local > directory with the /java network share, and use the 'subst' command to > make the J: disk out of the directory. With this configuration all the > default options in the makefiles make sense, and I don't need to > define any additional environment variables prior to running make > (well, excluding the vsvars32.bat, of course, but that's another story). > > PS. I moved the discussion to the build-dev@, since it is basically > the fix reviewing. > > -- > best regards, > Anthony From Kelly.Ohair at Sun.COM Thu Apr 23 18:40:24 2009 From: Kelly.Ohair at Sun.COM (Kelly O'Hair) Date: Thu, 23 Apr 2009 11:40:24 -0700 Subject: Review request: 6833444 (_BOOTDIR1/_BOOTDIR2 on MS Windows should be consistent with other platforms) In-Reply-To: <49F07749.9050702@sun.com> References: <49F07749.9050702@sun.com> Message-ID: <49F0B618.4020508@sun.com> As I emailed earlier, I'd be ok with this change but only if RE (Xiomara) was ok with it, and we made sure everyone was warned well in advance. Also, the change is incomplete because the README-builds.html file probably would need to change too. -kto Anthony Petrov wrote: > Please review the fix for the CR mentioned in the subject. The webrev: > > http://cr.openjdk.java.net/~anthony/webrev-6833444.0/ > > I verified the fix on MS Windows platform, and it works pretty well. > > -- > best regards, > Anthony From Jonathan.Gibbons at Sun.COM Thu Apr 23 18:48:10 2009 From: Jonathan.Gibbons at Sun.COM (Jonathan Gibbons) Date: Thu, 23 Apr 2009 11:48:10 -0700 Subject: _BOOTDIR1 on MS Windows platform In-Reply-To: <49F0B03F.4000305@sun.com> References: <49EF2F7B.4020504@sun.com> <49F0B03F.4000305@sun.com> Message-ID: <49F0B7EA.5050802@sun.com> Kelly, Perhaps "make sanity" on Windows could give a warning about the use of network paths, if such is detected. -- Jon Kelly O'Hair wrote: > Sorry I'm so slow in responding to this... > > The primary reason for the special case on Windows is the unreliability > and slowness of the network connections. > Builds using a local jdk vs. a J:/ mapped can be 5 hours long when > they might normally be 1hr or less. These just come from reports I > have gotten over the years, and it's really depends on the Windows > machine, the network, etc. > > Bottom line, builds are always faster and more reliable when all > components > are stored on local disk, and this is particularly true on Windows. > > Having said all that, I ALWAYS set ALT_BOOTDIR to my local copy > (and ALT_JDK_IMPORT_PATH too). So I probably would not be impacted > by this change, but I bet quite a few people rely on this c:/jdk1.6.0 > default. With enough warning you might be able to change this. > > --- > > I have been recently working on the JavaFX build dependency issues > and although it's more ant based, some of the techniques could apply > to making OpenJDK builds easier. Unfortunately, there is only 24hrs > in a day. :^{ > > -kto > > > Anthony Petrov wrote: >> Hello, >> >> Back in 2007 we already discussed this issue with Kelly, but >> transitioning to Mercurial just stopped the work. So, I would like to >> revive this now. >> >> Here's a part of the output generated by `grep -r BOOTDIR make/*`: >> >>> make/common/shared/Defs-solaris.gmk: _BOOTDIR1 >>> =$(SLASH_JAVA)/re/jdk/$(PREVIOUS_JDK_VERSION)/archive/fcs/binaries/$(PLATFORM)-$(ARCH) >>> >>> make/common/shared/Defs-solaris.gmk: _BOOTDIR2 >>> =$(USRJDKINSTANCES_PATH)/jdk$(PREVIOUS_JDK_VERSION) >>> make/common/shared/Defs-windows.gmk: _BOOTDIR1 >>> =$(_system_drive)/jdk$(PREVIOUS_JDK_VERSION) >>> make/common/shared/Defs-windows.gmk: _BOOTDIR2 >>> =$(USRJDKINSTANCES_PATH)/jdk$(PREVIOUS_JDK_VERSION) >>> make/common/shared/Defs-linux.gmk: _BOOTDIR1 >>> =$(SLASH_JAVA)/re/jdk/$(PREVIOUS_JDK_VERSION)/archive/fcs/binaries/$(PLATFORM)-$(ARCH) >>> >>> make/common/shared/Defs-linux.gmk: _BOOTDIR2 >>> =$(USRJDKINSTANCES_PATH)/jdk$(PREVIOUS_JDK_VERSION) >> >> One can notice that the _BOOTDIR1 is defined differently on MS >> Windows platform. I would like to propose a change so that its value >> would be the same as on other platforms. The SLASH_JAVA on MS Windows >> equals to the J: drive. So one could setup the same directory tree as >> on Linux/Solaris, use the subst command to make the directory the J: >> drive, and be able to build the jdk w/o specifying the ALT_BOOTDIR >> variable manually. >> >> Is there any objection to removing the >> $(_system_drive)/jdk$(PREVIOUS_JDK_VERSION) default path? >> >> -- >> best regards, >> Anthony From Kelly.Ohair at Sun.COM Thu Apr 23 18:54:59 2009 From: Kelly.Ohair at Sun.COM (Kelly O'Hair) Date: Thu, 23 Apr 2009 11:54:59 -0700 Subject: _BOOTDIR1 on MS Windows platform In-Reply-To: <49F0B7EA.5050802@sun.com> References: <49EF2F7B.4020504@sun.com> <49F0B03F.4000305@sun.com> <49F0B7EA.5050802@sun.com> Message-ID: <49F0B983.50508@sun.com> Adding a sanity check warning about J:/ usage would be a nice addition to this change. -kto Jonathan Gibbons wrote: > Kelly, > > Perhaps "make sanity" on Windows could give a warning about the use > of network paths, if such is detected. > > -- Jon > > > Kelly O'Hair wrote: >> Sorry I'm so slow in responding to this... >> >> The primary reason for the special case on Windows is the unreliability >> and slowness of the network connections. >> Builds using a local jdk vs. a J:/ mapped can be 5 hours long when >> they might normally be 1hr or less. These just come from reports I >> have gotten over the years, and it's really depends on the Windows >> machine, the network, etc. >> >> Bottom line, builds are always faster and more reliable when all >> components >> are stored on local disk, and this is particularly true on Windows. >> >> Having said all that, I ALWAYS set ALT_BOOTDIR to my local copy >> (and ALT_JDK_IMPORT_PATH too). So I probably would not be impacted >> by this change, but I bet quite a few people rely on this c:/jdk1.6.0 >> default. With enough warning you might be able to change this. >> >> --- >> >> I have been recently working on the JavaFX build dependency issues >> and although it's more ant based, some of the techniques could apply >> to making OpenJDK builds easier. Unfortunately, there is only 24hrs >> in a day. :^{ >> >> -kto >> >> >> Anthony Petrov wrote: >>> Hello, >>> >>> Back in 2007 we already discussed this issue with Kelly, but >>> transitioning to Mercurial just stopped the work. So, I would like to >>> revive this now. >>> >>> Here's a part of the output generated by `grep -r BOOTDIR make/*`: >>> >>>> make/common/shared/Defs-solaris.gmk: _BOOTDIR1 >>>> =$(SLASH_JAVA)/re/jdk/$(PREVIOUS_JDK_VERSION)/archive/fcs/binaries/$(PLATFORM)-$(ARCH) >>>> >>>> make/common/shared/Defs-solaris.gmk: _BOOTDIR2 >>>> =$(USRJDKINSTANCES_PATH)/jdk$(PREVIOUS_JDK_VERSION) >>>> make/common/shared/Defs-windows.gmk: _BOOTDIR1 >>>> =$(_system_drive)/jdk$(PREVIOUS_JDK_VERSION) >>>> make/common/shared/Defs-windows.gmk: _BOOTDIR2 >>>> =$(USRJDKINSTANCES_PATH)/jdk$(PREVIOUS_JDK_VERSION) >>>> make/common/shared/Defs-linux.gmk: _BOOTDIR1 >>>> =$(SLASH_JAVA)/re/jdk/$(PREVIOUS_JDK_VERSION)/archive/fcs/binaries/$(PLATFORM)-$(ARCH) >>>> >>>> make/common/shared/Defs-linux.gmk: _BOOTDIR2 >>>> =$(USRJDKINSTANCES_PATH)/jdk$(PREVIOUS_JDK_VERSION) >>> >>> One can notice that the _BOOTDIR1 is defined differently on MS >>> Windows platform. I would like to propose a change so that its value >>> would be the same as on other platforms. The SLASH_JAVA on MS Windows >>> equals to the J: drive. So one could setup the same directory tree as >>> on Linux/Solaris, use the subst command to make the directory the J: >>> drive, and be able to build the jdk w/o specifying the ALT_BOOTDIR >>> variable manually. >>> >>> Is there any objection to removing the >>> $(_system_drive)/jdk$(PREVIOUS_JDK_VERSION) default path? >>> >>> -- >>> best regards, >>> Anthony > From Anthony.Petrov at Sun.COM Thu Apr 23 19:25:42 2009 From: Anthony.Petrov at Sun.COM (Anthony Petrov) Date: Thu, 23 Apr 2009 23:25:42 +0400 Subject: Review request: 6833444 (_BOOTDIR1/_BOOTDIR2 on MS Windows should be consistent with other platforms) In-Reply-To: <49F0B40C.8040904@Sun.COM> References: <49F07AE8.4050909@sun.com> <49F097ED.7070105@sun.com> <49F0B40C.8040904@Sun.COM> Message-ID: <49F0C0B6.9040209@sun.com> On 4/23/2009 10:31 PM Xiomara.Jayasena at Sun.COM wrote: > We do set ALT_BOOTDIR all the time. > > From Kelly: >> Having said all that, I ALWAYS set ALT_BOOTDIR to my local copy >> (and ALT_JDK_IMPORT_PATH too). So I probably would not be impacted >> by this change, but I bet quite a few people rely on this c:/jdk1.6.0 >> default. With enough warning you might be able to change this. > > It's OK with me, if you remove c:/jdk ... Great to hear that! Thanks! -- best regards, Anthony > > Thanks, > -Xiomara > > > On 04/23/09 09:31, Anthony Petrov wrote: >> Hi Xiomara, >> >> Thank you for the comments! >> >> On 4/23/2009 6:27 PM Xiomara Jayasena wrote: >>> Release Engineering uses c:\jdk ... when building on windows. We >>> will still need that. >> Ups. I'm sorry about that, I really didn't know you use this path. >> This was the reason I initiated the discussion on the build-dev@ >> yesterday. Since I didn't receive any feedback, I assumed nobody cares >> about c:\jdk. >> >>> I am understanding that, that is being removed? >>> >>> - _BOOTDIR1 =$(_system_drive)/jdk$(PREVIOUS_JDK_VERSION) >>> + _BOOTDIR1 =$(SLASH_JAVA)/re/jdk/$(PREVIOUS_JDK_VERSION)/archiv >> Yes, this is correct. >> Well, then perhaps I'll go and add the _BOOTDIR3 then. So, on Windows >> we will have three options: c:\jdk, c:\program files\java, and finally >> the standard j: approach introduced with the fix. Does it sound good? >> >>> RE tries to localized all the software we use in the local build system. >> So do I on my local Windows build machine. And it seems that >> maintaining a local copy of the standard directory tree (/java --> j:) >> is *way* simpler than inventing something new. I just sync my local >> directory with the /java network share, and use the 'subst' command to >> make the J: disk out of the directory. With this configuration all the >> default options in the makefiles make sense, and I don't need to >> define any additional environment variables prior to running make >> (well, excluding the vsvars32.bat, of course, but that's another story). >> >> PS. I moved the discussion to the build-dev@, since it is basically >> the fix reviewing. >> >> -- >> best regards, >> Anthony > From Anthony.Petrov at Sun.COM Thu Apr 23 19:28:28 2009 From: Anthony.Petrov at Sun.COM (Anthony Petrov) Date: Thu, 23 Apr 2009 23:28:28 +0400 Subject: Review request: 6833444 (_BOOTDIR1/_BOOTDIR2 on MS Windows should be consistent with other platforms) In-Reply-To: <49F0B618.4020508@sun.com> References: <49F07749.9050702@sun.com> <49F0B618.4020508@sun.com> Message-ID: <49F0C15C.5040400@sun.com> On 4/23/2009 10:40 PM Kelly O'Hair wrote: > As I emailed earlier, I'd be ok with this change but only if RE (Xiomara) > was ok with it, and we made sure everyone was warned well in advance. Thanks! > Also, the change is incomplete because the README-builds.html file probably > would need to change too. I verified this file already and found no remarks about the default BOOTDIR locations on Windows. There's only a remark about Solaris/Linux regarding the possibility of using the /usr/java/ by default - but I don't change this. So there's no need to update any readme's. -- best regards, Anthony > > -kto > > > Anthony Petrov wrote: >> Please review the fix for the CR mentioned in the subject. The webrev: >> >> http://cr.openjdk.java.net/~anthony/webrev-6833444.0/ >> >> I verified the fix on MS Windows platform, and it works pretty well. >> >> -- >> best regards, >> Anthony From Anthony.Petrov at Sun.COM Thu Apr 23 19:37:37 2009 From: Anthony.Petrov at Sun.COM (Anthony Petrov) Date: Thu, 23 Apr 2009 23:37:37 +0400 Subject: _BOOTDIR1 on MS Windows platform In-Reply-To: <49F0B03F.4000305@sun.com> References: <49EF2F7B.4020504@sun.com> <49F0B03F.4000305@sun.com> Message-ID: <49F0C381.10106@sun.com> On 4/23/2009 10:15 PM Kelly O'Hair wrote: > The primary reason for the special case on Windows is the unreliability > and slowness of the network connections. > Builds using a local jdk vs. a J:/ mapped can be 5 hours long when > they might normally be 1hr or less. These just come from reports I > have gotten over the years, and it's really depends on the Windows > machine, the network, etc. > > Bottom line, builds are always faster and more reliable when all components > are stored on local disk, and this is particularly true on Windows. I totally agree with that. That's why my J: disk is NOT a network share, but a local directory that is mapped on the J: drive using the 'subst' command. This directory, however, gets synced with the real /java network share from time to time. So not setting the ALT_BOOTDIR does not slows down my builds in any way. What's more, it enables me to build by just issuing the make command, w/o setting ANY ALT_ variables in most cases. > Having said all that, I ALWAYS set ALT_BOOTDIR to my local copy > (and ALT_JDK_IMPORT_PATH too). So I probably would not be impacted > by this change, but I bet quite a few people rely on this c:/jdk1.6.0 > default. With enough warning you might be able to change this. I believe most people that might possibly be affected by this change reside on this mailing list. Who isn't - they probably either use the ALT_BOOTDIR, or, in the worst case, will be able to easily identify the problem since the reported error will include the /NO_BOOTDIR/ path to the javac compiler. -- best regards, Anthony > > --- > > I have been recently working on the JavaFX build dependency issues > and although it's more ant based, some of the techniques could apply > to making OpenJDK builds easier. Unfortunately, there is only 24hrs > in a day. :^{ > > -kto > > > Anthony Petrov wrote: >> Hello, >> >> Back in 2007 we already discussed this issue with Kelly, but >> transitioning to Mercurial just stopped the work. So, I would like to >> revive this now. >> >> Here's a part of the output generated by `grep -r BOOTDIR make/*`: >> >>> make/common/shared/Defs-solaris.gmk: _BOOTDIR1 >>> =$(SLASH_JAVA)/re/jdk/$(PREVIOUS_JDK_VERSION)/archive/fcs/binaries/$(PLATFORM)-$(ARCH) >>> >>> make/common/shared/Defs-solaris.gmk: _BOOTDIR2 >>> =$(USRJDKINSTANCES_PATH)/jdk$(PREVIOUS_JDK_VERSION) >>> make/common/shared/Defs-windows.gmk: _BOOTDIR1 >>> =$(_system_drive)/jdk$(PREVIOUS_JDK_VERSION) >>> make/common/shared/Defs-windows.gmk: _BOOTDIR2 >>> =$(USRJDKINSTANCES_PATH)/jdk$(PREVIOUS_JDK_VERSION) >>> make/common/shared/Defs-linux.gmk: _BOOTDIR1 >>> =$(SLASH_JAVA)/re/jdk/$(PREVIOUS_JDK_VERSION)/archive/fcs/binaries/$(PLATFORM)-$(ARCH) >>> >>> make/common/shared/Defs-linux.gmk: _BOOTDIR2 >>> =$(USRJDKINSTANCES_PATH)/jdk$(PREVIOUS_JDK_VERSION) >> >> One can notice that the _BOOTDIR1 is defined differently on MS Windows >> platform. I would like to propose a change so that its value would be >> the same as on other platforms. The SLASH_JAVA on MS Windows equals to >> the J: drive. So one could setup the same directory tree as on >> Linux/Solaris, use the subst command to make the directory the J: >> drive, and be able to build the jdk w/o specifying the ALT_BOOTDIR >> variable manually. >> >> Is there any objection to removing the >> $(_system_drive)/jdk$(PREVIOUS_JDK_VERSION) default path? >> >> -- >> best regards, >> Anthony From Anthony.Petrov at Sun.COM Thu Apr 23 19:42:32 2009 From: Anthony.Petrov at Sun.COM (Anthony Petrov) Date: Thu, 23 Apr 2009 23:42:32 +0400 Subject: _BOOTDIR1 on MS Windows platform In-Reply-To: <49F0B983.50508@sun.com> References: <49EF2F7B.4020504@sun.com> <49F0B03F.4000305@sun.com> <49F0B7EA.5050802@sun.com> <49F0B983.50508@sun.com> Message-ID: <49F0C4A8.1050604@sun.com> Jon, Kelly, Then what about the default builds on Linux/Solaris that do use the /java share and do not issue any warning message? I agree that these builds are generally much faster than on Windows, but still. Besides, as I mentioned before, on my local systems the /java directory and the J: disk are local directories that just get occasionally synced. So the warning would be meaningless for such configurations... -- best regards, Anthony On 4/23/2009 10:54 PM Kelly O'Hair wrote: > Adding a sanity check warning about J:/ usage would be a nice addition > to this change. > > -kto > > Jonathan Gibbons wrote: >> Kelly, >> >> Perhaps "make sanity" on Windows could give a warning about the use >> of network paths, if such is detected. >> >> -- Jon >> >> >> Kelly O'Hair wrote: >>> Sorry I'm so slow in responding to this... >>> >>> The primary reason for the special case on Windows is the unreliability >>> and slowness of the network connections. >>> Builds using a local jdk vs. a J:/ mapped can be 5 hours long when >>> they might normally be 1hr or less. These just come from reports I >>> have gotten over the years, and it's really depends on the Windows >>> machine, the network, etc. >>> >>> Bottom line, builds are always faster and more reliable when all >>> components >>> are stored on local disk, and this is particularly true on Windows. >>> >>> Having said all that, I ALWAYS set ALT_BOOTDIR to my local copy >>> (and ALT_JDK_IMPORT_PATH too). So I probably would not be impacted >>> by this change, but I bet quite a few people rely on this c:/jdk1.6.0 >>> default. With enough warning you might be able to change this. >>> >>> --- >>> >>> I have been recently working on the JavaFX build dependency issues >>> and although it's more ant based, some of the techniques could apply >>> to making OpenJDK builds easier. Unfortunately, there is only 24hrs >>> in a day. :^{ >>> >>> -kto >>> >>> >>> Anthony Petrov wrote: >>>> Hello, >>>> >>>> Back in 2007 we already discussed this issue with Kelly, but >>>> transitioning to Mercurial just stopped the work. So, I would like >>>> to revive this now. >>>> >>>> Here's a part of the output generated by `grep -r BOOTDIR make/*`: >>>> >>>>> make/common/shared/Defs-solaris.gmk: _BOOTDIR1 >>>>> =$(SLASH_JAVA)/re/jdk/$(PREVIOUS_JDK_VERSION)/archive/fcs/binaries/$(PLATFORM)-$(ARCH) >>>>> >>>>> make/common/shared/Defs-solaris.gmk: _BOOTDIR2 >>>>> =$(USRJDKINSTANCES_PATH)/jdk$(PREVIOUS_JDK_VERSION) >>>>> make/common/shared/Defs-windows.gmk: _BOOTDIR1 >>>>> =$(_system_drive)/jdk$(PREVIOUS_JDK_VERSION) >>>>> make/common/shared/Defs-windows.gmk: _BOOTDIR2 >>>>> =$(USRJDKINSTANCES_PATH)/jdk$(PREVIOUS_JDK_VERSION) >>>>> make/common/shared/Defs-linux.gmk: _BOOTDIR1 >>>>> =$(SLASH_JAVA)/re/jdk/$(PREVIOUS_JDK_VERSION)/archive/fcs/binaries/$(PLATFORM)-$(ARCH) >>>>> >>>>> make/common/shared/Defs-linux.gmk: _BOOTDIR2 >>>>> =$(USRJDKINSTANCES_PATH)/jdk$(PREVIOUS_JDK_VERSION) >>>> >>>> One can notice that the _BOOTDIR1 is defined differently on MS >>>> Windows platform. I would like to propose a change so that its value >>>> would be the same as on other platforms. The SLASH_JAVA on MS >>>> Windows equals to the J: drive. So one could setup the same >>>> directory tree as on Linux/Solaris, use the subst command to make >>>> the directory the J: drive, and be able to build the jdk w/o >>>> specifying the ALT_BOOTDIR variable manually. >>>> >>>> Is there any objection to removing the >>>> $(_system_drive)/jdk$(PREVIOUS_JDK_VERSION) default path? >>>> >>>> -- >>>> best regards, >>>> Anthony >> From Jonathan.Gibbons at Sun.COM Thu Apr 23 19:53:57 2009 From: Jonathan.Gibbons at Sun.COM (Jonathan Gibbons) Date: Thu, 23 Apr 2009 12:53:57 -0700 Subject: _BOOTDIR1 on MS Windows platform In-Reply-To: <49F0C4A8.1050604@sun.com> References: <49EF2F7B.4020504@sun.com> <49F0B03F.4000305@sun.com> <49F0B7EA.5050802@sun.com> <49F0B983.50508@sun.com> <49F0C4A8.1050604@sun.com> Message-ID: <49F0C755.1060002@sun.com> Anthony, On pretty much any system you can tell if a drive is local or not, albeit in a system specific way. -- Jon Anthony Petrov wrote: > Jon, Kelly, > > Then what about the default builds on Linux/Solaris that do use the > /java share and do not issue any warning message? I agree that these > builds are generally much faster than on Windows, but still. Besides, > as I mentioned before, on my local systems the /java directory and the > J: disk are local directories that just get occasionally synced. So > the warning would be meaningless for such configurations... > > -- > best regards, > Anthony > > On 4/23/2009 10:54 PM Kelly O'Hair wrote: >> Adding a sanity check warning about J:/ usage would be a nice addition >> to this change. >> >> -kto >> >> Jonathan Gibbons wrote: >>> Kelly, >>> >>> Perhaps "make sanity" on Windows could give a warning about the use >>> of network paths, if such is detected. >>> >>> -- Jon >>> >>> >>> Kelly O'Hair wrote: >>>> Sorry I'm so slow in responding to this... >>>> >>>> The primary reason for the special case on Windows is the >>>> unreliability >>>> and slowness of the network connections. >>>> Builds using a local jdk vs. a J:/ mapped can be 5 hours long when >>>> they might normally be 1hr or less. These just come from reports I >>>> have gotten over the years, and it's really depends on the Windows >>>> machine, the network, etc. >>>> >>>> Bottom line, builds are always faster and more reliable when all >>>> components >>>> are stored on local disk, and this is particularly true on Windows. >>>> >>>> Having said all that, I ALWAYS set ALT_BOOTDIR to my local copy >>>> (and ALT_JDK_IMPORT_PATH too). So I probably would not be impacted >>>> by this change, but I bet quite a few people rely on this c:/jdk1.6.0 >>>> default. With enough warning you might be able to change this. >>>> >>>> --- >>>> >>>> I have been recently working on the JavaFX build dependency issues >>>> and although it's more ant based, some of the techniques could apply >>>> to making OpenJDK builds easier. Unfortunately, there is only 24hrs >>>> in a day. :^{ >>>> >>>> -kto >>>> >>>> >>>> Anthony Petrov wrote: >>>>> Hello, >>>>> >>>>> Back in 2007 we already discussed this issue with Kelly, but >>>>> transitioning to Mercurial just stopped the work. So, I would like >>>>> to revive this now. >>>>> >>>>> Here's a part of the output generated by `grep -r BOOTDIR make/*`: >>>>> >>>>>> make/common/shared/Defs-solaris.gmk: _BOOTDIR1 >>>>>> =$(SLASH_JAVA)/re/jdk/$(PREVIOUS_JDK_VERSION)/archive/fcs/binaries/$(PLATFORM)-$(ARCH) >>>>>> >>>>>> make/common/shared/Defs-solaris.gmk: _BOOTDIR2 >>>>>> =$(USRJDKINSTANCES_PATH)/jdk$(PREVIOUS_JDK_VERSION) >>>>>> make/common/shared/Defs-windows.gmk: _BOOTDIR1 >>>>>> =$(_system_drive)/jdk$(PREVIOUS_JDK_VERSION) >>>>>> make/common/shared/Defs-windows.gmk: _BOOTDIR2 >>>>>> =$(USRJDKINSTANCES_PATH)/jdk$(PREVIOUS_JDK_VERSION) >>>>>> make/common/shared/Defs-linux.gmk: _BOOTDIR1 >>>>>> =$(SLASH_JAVA)/re/jdk/$(PREVIOUS_JDK_VERSION)/archive/fcs/binaries/$(PLATFORM)-$(ARCH) >>>>>> >>>>>> make/common/shared/Defs-linux.gmk: _BOOTDIR2 >>>>>> =$(USRJDKINSTANCES_PATH)/jdk$(PREVIOUS_JDK_VERSION) >>>>> >>>>> One can notice that the _BOOTDIR1 is defined differently on MS >>>>> Windows platform. I would like to propose a change so that its >>>>> value would be the same as on other platforms. The SLASH_JAVA on >>>>> MS Windows equals to the J: drive. So one could setup the same >>>>> directory tree as on Linux/Solaris, use the subst command to make >>>>> the directory the J: drive, and be able to build the jdk w/o >>>>> specifying the ALT_BOOTDIR variable manually. >>>>> >>>>> Is there any objection to removing the >>>>> $(_system_drive)/jdk$(PREVIOUS_JDK_VERSION) default path? >>>>> >>>>> -- >>>>> best regards, >>>>> Anthony >>> From Kelly.Ohair at Sun.COM Thu Apr 23 20:35:13 2009 From: Kelly.Ohair at Sun.COM (Kelly O'Hair) Date: Thu, 23 Apr 2009 13:35:13 -0700 Subject: _BOOTDIR1 on MS Windows platform In-Reply-To: <49F0C4A8.1050604@sun.com> References: <49EF2F7B.4020504@sun.com> <49F0B03F.4000305@sun.com> <49F0B7EA.5050802@sun.com> <49F0B983.50508@sun.com> <49F0C4A8.1050604@sun.com> Message-ID: <49F0D101.7090406@sun.com> This sanity check would be a "nice to have" thing, but it it can't be done in a simple way I'm not sure I want to see a bunch of convoluted logic added, we have too much of that already :^( And it does go beyond your intended change. Maybe a separate bug for another time, like a "sanity warnings on common build performance situations"? On Solaris/Linux I have never seen a performance issue with reading networked files, maybe a reliability issue when machines go down. But writing to a network drive is more expensive, so if OUTPUTDIR was a network drive, that might justify some kind of warning for all platforms. On the otherhand, I'm not sure I want to drive people too crazy with warnings like this... I'd like to hear some more opinions on this. -kto Anthony Petrov wrote: > Jon, Kelly, > > Then what about the default builds on Linux/Solaris that do use the > /java share and do not issue any warning message? I agree that these > builds are generally much faster than on Windows, but still. Besides, as > I mentioned before, on my local systems the /java directory and the J: > disk are local directories that just get occasionally synced. So the > warning would be meaningless for such configurations... > > -- > best regards, > Anthony > > On 4/23/2009 10:54 PM Kelly O'Hair wrote: >> Adding a sanity check warning about J:/ usage would be a nice addition >> to this change. >> >> -kto >> >> Jonathan Gibbons wrote: >>> Kelly, >>> >>> Perhaps "make sanity" on Windows could give a warning about the use >>> of network paths, if such is detected. >>> >>> -- Jon >>> >>> >>> Kelly O'Hair wrote: >>>> Sorry I'm so slow in responding to this... >>>> >>>> The primary reason for the special case on Windows is the unreliability >>>> and slowness of the network connections. >>>> Builds using a local jdk vs. a J:/ mapped can be 5 hours long when >>>> they might normally be 1hr or less. These just come from reports I >>>> have gotten over the years, and it's really depends on the Windows >>>> machine, the network, etc. >>>> >>>> Bottom line, builds are always faster and more reliable when all >>>> components >>>> are stored on local disk, and this is particularly true on Windows. >>>> >>>> Having said all that, I ALWAYS set ALT_BOOTDIR to my local copy >>>> (and ALT_JDK_IMPORT_PATH too). So I probably would not be impacted >>>> by this change, but I bet quite a few people rely on this c:/jdk1.6.0 >>>> default. With enough warning you might be able to change this. >>>> >>>> --- >>>> >>>> I have been recently working on the JavaFX build dependency issues >>>> and although it's more ant based, some of the techniques could apply >>>> to making OpenJDK builds easier. Unfortunately, there is only 24hrs >>>> in a day. :^{ >>>> >>>> -kto >>>> >>>> >>>> Anthony Petrov wrote: >>>>> Hello, >>>>> >>>>> Back in 2007 we already discussed this issue with Kelly, but >>>>> transitioning to Mercurial just stopped the work. So, I would like >>>>> to revive this now. >>>>> >>>>> Here's a part of the output generated by `grep -r BOOTDIR make/*`: >>>>> >>>>>> make/common/shared/Defs-solaris.gmk: _BOOTDIR1 >>>>>> =$(SLASH_JAVA)/re/jdk/$(PREVIOUS_JDK_VERSION)/archive/fcs/binaries/$(PLATFORM)-$(ARCH) >>>>>> >>>>>> make/common/shared/Defs-solaris.gmk: _BOOTDIR2 >>>>>> =$(USRJDKINSTANCES_PATH)/jdk$(PREVIOUS_JDK_VERSION) >>>>>> make/common/shared/Defs-windows.gmk: _BOOTDIR1 >>>>>> =$(_system_drive)/jdk$(PREVIOUS_JDK_VERSION) >>>>>> make/common/shared/Defs-windows.gmk: _BOOTDIR2 >>>>>> =$(USRJDKINSTANCES_PATH)/jdk$(PREVIOUS_JDK_VERSION) >>>>>> make/common/shared/Defs-linux.gmk: _BOOTDIR1 >>>>>> =$(SLASH_JAVA)/re/jdk/$(PREVIOUS_JDK_VERSION)/archive/fcs/binaries/$(PLATFORM)-$(ARCH) >>>>>> >>>>>> make/common/shared/Defs-linux.gmk: _BOOTDIR2 >>>>>> =$(USRJDKINSTANCES_PATH)/jdk$(PREVIOUS_JDK_VERSION) >>>>> >>>>> One can notice that the _BOOTDIR1 is defined differently on MS >>>>> Windows platform. I would like to propose a change so that its >>>>> value would be the same as on other platforms. The SLASH_JAVA on MS >>>>> Windows equals to the J: drive. So one could setup the same >>>>> directory tree as on Linux/Solaris, use the subst command to make >>>>> the directory the J: drive, and be able to build the jdk w/o >>>>> specifying the ALT_BOOTDIR variable manually. >>>>> >>>>> Is there any objection to removing the >>>>> $(_system_drive)/jdk$(PREVIOUS_JDK_VERSION) default path? >>>>> >>>>> -- >>>>> best regards, >>>>> Anthony >>> From Kelly.Ohair at Sun.COM Thu Apr 23 20:35:52 2009 From: Kelly.Ohair at Sun.COM (Kelly O'Hair) Date: Thu, 23 Apr 2009 13:35:52 -0700 Subject: Review request: 6833444 (_BOOTDIR1/_BOOTDIR2 on MS Windows should be consistent with other platforms) In-Reply-To: <49F0C15C.5040400@sun.com> References: <49F07749.9050702@sun.com> <49F0B618.4020508@sun.com> <49F0C15C.5040400@sun.com> Message-ID: <49F0D128.2000709@sun.com> Anthony Petrov wrote: > On 4/23/2009 10:40 PM Kelly O'Hair wrote: >> As I emailed earlier, I'd be ok with this change but only if RE (Xiomara) >> was ok with it, and we made sure everyone was warned well in advance. > Thanks! > >> Also, the change is incomplete because the README-builds.html file >> probably >> would need to change too. > I verified this file already and found no remarks about the default > BOOTDIR locations on Windows. There's only a remark about Solaris/Linux > regarding the possibility of using the /usr/java/ by default - but I > don't change this. So there's no need to update any readme's. Ok. then consider it reviewed. -kto > > -- > best regards, > Anthony > >> >> -kto >> >> >> Anthony Petrov wrote: >>> Please review the fix for the CR mentioned in the subject. The webrev: >>> >>> http://cr.openjdk.java.net/~anthony/webrev-6833444.0/ >>> >>> I verified the fix on MS Windows platform, and it works pretty well. >>> >>> -- >>> best regards, >>> Anthony From Anthony.Petrov at Sun.COM Fri Apr 24 13:23:20 2009 From: Anthony.Petrov at Sun.COM (Anthony Petrov) Date: Fri, 24 Apr 2009 17:23:20 +0400 Subject: Request for review: 6833444 version 2 Message-ID: <49F1BD48.1020703@sun.com> Jon, Kelly, Xiomara, Thank you very much for your feedback. I decided to revise the fix to: 1. Leave the current c:\jdk default path for those who still uses it. 2. Issue a warning message on MS Windows platform if the BOOTDIR is located on the J: drive (that is assumed to be mapped over network). Here's the updated webrev: http://cr.openjdk.java.net/~anthony/webrev-6833444.1/ Please review. Some comments: On 04/23/2009 11:53 PM, Jonathan Gibbons wrote: > On pretty much any system you can tell if a drive is local or not, albeit in a system specific way. That would be cool. However I don't see much justification around verifying for sure if a path is on the network. After all it's just a warning message, not a error. -- best regards, Anthony From Kelly.Ohair at Sun.COM Sat Apr 25 17:59:32 2009 From: Kelly.Ohair at Sun.COM (Kelly O'Hair) Date: Sat, 25 Apr 2009 10:59:32 -0700 Subject: Request for review: 6833444 version 2 In-Reply-To: <49F1BD48.1020703@sun.com> References: <49F1BD48.1020703@sun.com> Message-ID: <49F34F84.80107@sun.com> Looks ok to me. -kto Anthony Petrov wrote: > Jon, Kelly, Xiomara, > > Thank you very much for your feedback. I decided to revise the fix to: > 1. Leave the current c:\jdk default path for those who still uses it. > 2. Issue a warning message on MS Windows platform if the BOOTDIR is > located on the J: drive (that is assumed to be mapped over network). > > Here's the updated webrev: > > http://cr.openjdk.java.net/~anthony/webrev-6833444.1/ > > Please review. > > Some comments: > > On 04/23/2009 11:53 PM, Jonathan Gibbons wrote: >> On pretty much any system you can tell if a drive is local or not, >> albeit in a system specific way. > That would be cool. However I don't see much justification around > verifying for sure if a path is on the network. After all it's just a > warning message, not a error. > > -- > best regards, > Anthony From Dmitri.Trembovetski at Sun.COM Mon Apr 27 15:56:38 2009 From: Dmitri.Trembovetski at Sun.COM (Dmitri Trembovetski) Date: Mon, 27 Apr 2009 08:56:38 -0700 Subject: Request for review: 6833444 version 2 In-Reply-To: <49F1BD48.1020703@sun.com> References: <49F1BD48.1020703@sun.com> Message-ID: <49F5D5B6.2040404@Sun.COM> Anthony Petrov wrote: > Jon, Kelly, Xiomara, > > Thank you very much for your feedback. I decided to revise the fix to: > 1. Leave the current c:\jdk default path for those who still uses it. > 2. Issue a warning message on MS Windows platform if the BOOTDIR is > located on the J: drive (that is assumed to be mapped over network). > > Here's the updated webrev: > > http://cr.openjdk.java.net/~anthony/webrev-6833444.1/ > > Please review. > > Some comments: > > On 04/23/2009 11:53 PM, Jonathan Gibbons wrote: >> On pretty much any system you can tell if a drive is local or not, >> albeit in a system specific way. > That would be cool. However I don't see much justification around > verifying for sure if a path is on the network. After all it's just a > warning message, not a error. It's very easy to check on windows (in shell, adjust appropriately for makefile): net use j: > /dev/null 2>&1 if [ $? -ne 0 ]; then # local drive else # remote drive fi If you want to be fancy you could grep the output of net use for "Remote Resource" or something.. Thanks, Dmitri From Anthony.Petrov at Sun.COM Mon Apr 27 16:56:38 2009 From: Anthony.Petrov at Sun.COM (Anthony Petrov) Date: Mon, 27 Apr 2009 20:56:38 +0400 Subject: Request for review: 6833444 version 2 In-Reply-To: <49F5D5B6.2040404@Sun.COM> References: <49F1BD48.1020703@sun.com> <49F5D5B6.2040404@Sun.COM> Message-ID: <49F5E3C6.90604@sun.com> On 4/27/2009 7:56 PM Dmitri Trembovetski wrote: >>> On pretty much any system you can tell if a drive is local or not, >>> albeit in a system specific way. >> That would be cool. However I don't see much justification around >> verifying for sure if a path is on the network. After all it's just a >> warning message, not a error. > > It's very easy to check on windows (in shell, adjust appropriately for > makefile): > net use j: > /dev/null 2>&1 > if [ $? -ne 0 ]; then > # local drive > else > # remote drive > fi > > If you want to be fancy you could grep the output of net use for > "Remote Resource" or something.. Thanks Dmitri. That's totally correct. But still I don't consider it as a requirement. If we were to prohibit using a network-located BOOTDIR, then this would be a must. Currently this just seems like an overkill for such a tiny fix. -- best regards, Anthony From martinrb at google.com Tue Apr 28 23:27:01 2009 From: martinrb at google.com (Martin Buchholz) Date: Tue, 28 Apr 2009 16:27:01 -0700 Subject: PATCH: Tired of waiting for rt.jar to build? In-Reply-To: <1ccfd1c10904271754s6f56feafub82c97c80109f023@mail.gmail.com> References: <1ccfd1c10904271754s6f56feafub82c97c80109f023@mail.gmail.com> Message-ID: <1ccfd1c10904281627s7aa853a8l630c642054958bf9@mail.gmail.com> On Mon, Apr 27, 2009 at 17:54, Martin Buchholz wrote: > Someone who cares about the Makefiles can also try to remove the > 16000 gratuitous -C flags that makes jar's life "jar hell". Hmmm.... Apparently I care enough. Kelly (or Tim?), please review. diff --git a/make/common/Release.gmk b/make/common/Release.gmk --- a/make/common/Release.gmk +++ b/make/common/Release.gmk @@ -644,7 +644,7 @@ @$(java-vm-cleanup) # Create the manifest file. -JAR_MANIFEST_FILE=$(TEMPDIR)/manifest.tmp +JAR_MANIFEST_FILE=$(ABS_TEMPDIR)/manifest.tmp $(JAR_MANIFEST_FILE): $(MAINMANIFEST) $(BEANMANIFEST) $(prep-target) $(SED) -e "s/@@RELEASE@@/$(RELEASE)/" $(MAINMANIFEST) >> $@ @@ -652,25 +652,22 @@ $(CAT) $(BEANMANIFEST) >> $@ # Create resources.jar containing non-class files -RESOURCES_JAR=$(TEMPDIR)/resources-orig.jar -RES_JAR_ARGLIST=$(RES_JAR_FILELIST)_args -$(RES_JAR_ARGLIST): $(RES_JAR_FILELIST) +RESOURCES_JAR=$(ABS_TEMPDIR)/resources-orig.jar +$(RESOURCES_JAR): $(RES_JAR_FILELIST) $(JAR_MANIFEST_FILE) $(prep-target) - $(SED) -e "s@^@-C $(CLASSBINDIR) @" $< > $@ -$(RESOURCES_JAR): $(RES_JAR_ARGLIST) $(JAR_MANIFEST_FILE) - $(prep-target) - $(BOOT_JAR_CMD) c0mf $(JAR_MANIFEST_FILE) $@ \ - @$(RES_JAR_ARGLIST) $(BOOT_JAR_JFLAGS) - @$(java-vm-cleanup) + $(CD) $(CLASSBINDIR) && \ + $(BOOT_JAR_CMD) c0mf $(JAR_MANIFEST_FILE) $@ \ + @$(RES_JAR_FILELIST) $(BOOT_JAR_JFLAGS) + @$(CD) $(CLASSBINDIR) && $(java-vm-cleanup) # Create jsse.jar containing SunJSSE implementation classes -JSSE_JAR=$(TEMPDIR)/jsse-orig.jar +JSSE_JAR=$(ABS_TEMPDIR)/jsse-orig.jar $(JSSE_JAR): $(JAR_MANIFEST_FILE) $(prep-target) - $(BOOT_JAR_CMD) c0mf $(JAR_MANIFEST_FILE) $@ \ - $(JSSE_CLASSES_DIRS:%=-C $(CLASSBINDIR) %) \ - $(BOOT_JAR_JFLAGS) - @$(java-vm-cleanup) + $(CD) $(CLASSBINDIR) && \ + $(BOOT_JAR_CMD) c0mf $(JAR_MANIFEST_FILE) $@ \ + $(JSSE_CLASSES_DIRS) $(BOOT_JAR_JFLAGS) + @$(CD) $(CLASSBINDIR) && $(java-vm-cleanup) # Create sec-bin.zip SEC_FILES_ZIP=$(ABS_TEMPDIR)/sec-bin.zip @@ -712,15 +709,12 @@ # Create rt.jar RT_JAR=$(ABS_TEMPDIR)/rt-orig.jar -RT_JAR_ARGLIST=$(RT_JAR_FILELIST)_args -$(RT_JAR_ARGLIST): $(RT_JAR_FILELIST) +$(RT_JAR): $(RT_JAR_FILELIST) $(JAR_MANIFEST_FILE) $(prep-target) - $(SED) -e "s@^@-C $(CLASSBINDIR) @" $< > $@ -$(RT_JAR): $(RT_JAR_ARGLIST) $(JAR_MANIFEST_FILE) - $(prep-target) - $(BOOT_JAR_CMD) c0mf $(JAR_MANIFEST_FILE) $@ \ - @$(RT_JAR_ARGLIST) $(BOOT_JAR_JFLAGS) - @$(java-vm-cleanup) + $(CD) $(CLASSBINDIR) && \ + $(BOOT_JAR_CMD) c0mf $(JAR_MANIFEST_FILE) $@ \ + @$(RT_JAR_FILELIST) $(BOOT_JAR_JFLAGS) + @$(CD) $(CLASSBINDIR) && $(java-vm-cleanup) # Meta-index construction to make core class loaders lazier @@ -943,10 +937,10 @@ @# @# lib/tools.jar @# - $(BOOT_JAR_CMD) c0f $(LIBDIR)/tools.jar $(addprefix \ - -C $(CLASSBINDIR) , $(TOOLS)) \ - $(BOOT_JAR_JFLAGS) - @$(java-vm-cleanup) + $(CD) $(CLASSBINDIR) && \ + $(BOOT_JAR_CMD) c0f $(ABS_LIBDIR)/tools.jar \ + $(TOOLS) $(BOOT_JAR_JFLAGS) + @$(CD) $(CLASSBINDIR) && $(java-vm-cleanup) $(CP) $(LIBDIR)/tools.jar $(JDK_IMAGE_DIR)/lib/tools.jar @# @# lib/ct.sym (martinrb at suttles) ~/ws/logging $ cat .hg/patches/dashJ diff --git a/make/common/Release.gmk b/make/common/Release.gmk --- a/make/common/Release.gmk +++ b/make/common/Release.gmk @@ -94,7 +94,7 @@ ifeq ($(PLATFORM), windows) LICENSE_DOCLIST_JDK = $(subst $(LICENSE_VERSION),,\ $(shell $(CD) $(SHARE_JDK_DOC_SRC) && \ - $(LS) *LICENSE*$(LICENSE_VERSION))) + $(LS) *LICENSE*$(LICENSE_VERSION))) LICENSE_DOCLIST_JRE = $(subst $(LICENSE_VERSION),,\ $(shell $(CD) $(SHARE_JRE_DOC_SRC) && \ $(LS) *LICENSE*$(LICENSE_VERSION))) @@ -399,7 +399,7 @@ sun/tools/jstack \ sun/tools/jinfo \ sun/tools/jmap - + # classes that go into jsse.jar JSSE_CLASSES_DIRS = \ sun/security/provider/Sun.class \ @@ -644,7 +644,7 @@ @$(java-vm-cleanup) # Create the manifest file. -JAR_MANIFEST_FILE=$(TEMPDIR)/manifest.tmp +JAR_MANIFEST_FILE=$(ABS_TEMPDIR)/manifest.tmp $(JAR_MANIFEST_FILE): $(MAINMANIFEST) $(BEANMANIFEST) $(prep-target) $(SED) -e "s/@@RELEASE@@/$(RELEASE)/" $(MAINMANIFEST) >> $@ @@ -652,25 +652,22 @@ $(CAT) $(BEANMANIFEST) >> $@ # Create resources.jar containing non-class files -RESOURCES_JAR=$(TEMPDIR)/resources-orig.jar -RES_JAR_ARGLIST=$(RES_JAR_FILELIST)_args -$(RES_JAR_ARGLIST): $(RES_JAR_FILELIST) +RESOURCES_JAR=$(ABS_TEMPDIR)/resources-orig.jar +$(RESOURCES_JAR): $(RES_JAR_FILELIST) $(JAR_MANIFEST_FILE) $(prep-target) - $(SED) -e "s@^@-C $(CLASSBINDIR) @" $< > $@ -$(RESOURCES_JAR): $(RES_JAR_ARGLIST) $(JAR_MANIFEST_FILE) - $(prep-target) - $(BOOT_JAR_CMD) c0mf $(JAR_MANIFEST_FILE) $@ \ - @$(RES_JAR_ARGLIST) $(BOOT_JAR_JFLAGS) - @$(java-vm-cleanup) + $(CD) $(CLASSBINDIR) && \ + $(BOOT_JAR_CMD) c0mf $(JAR_MANIFEST_FILE) $@ \ + @$(RES_JAR_FILELIST) $(BOOT_JAR_JFLAGS) + @$(CD) $(CLASSBINDIR) && $(java-vm-cleanup) # Create jsse.jar containing SunJSSE implementation classes -JSSE_JAR=$(TEMPDIR)/jsse-orig.jar +JSSE_JAR=$(ABS_TEMPDIR)/jsse-orig.jar $(JSSE_JAR): $(JAR_MANIFEST_FILE) $(prep-target) - $(BOOT_JAR_CMD) c0mf $(JAR_MANIFEST_FILE) $@ \ - $(JSSE_CLASSES_DIRS:%=-C $(CLASSBINDIR) %) \ - $(BOOT_JAR_JFLAGS) - @$(java-vm-cleanup) + $(CD) $(CLASSBINDIR) && \ + $(BOOT_JAR_CMD) c0mf $(JAR_MANIFEST_FILE) $@ \ + $(JSSE_CLASSES_DIRS) $(BOOT_JAR_JFLAGS) + @$(CD) $(CLASSBINDIR) && $(java-vm-cleanup) # Create sec-bin.zip SEC_FILES_ZIP=$(ABS_TEMPDIR)/sec-bin.zip @@ -712,15 +709,12 @@ # Create rt.jar RT_JAR=$(ABS_TEMPDIR)/rt-orig.jar -RT_JAR_ARGLIST=$(RT_JAR_FILELIST)_args -$(RT_JAR_ARGLIST): $(RT_JAR_FILELIST) +$(RT_JAR): $(RT_JAR_FILELIST) $(JAR_MANIFEST_FILE) $(prep-target) - $(SED) -e "s@^@-C $(CLASSBINDIR) @" $< > $@ -$(RT_JAR): $(RT_JAR_ARGLIST) $(JAR_MANIFEST_FILE) - $(prep-target) - $(BOOT_JAR_CMD) c0mf $(JAR_MANIFEST_FILE) $@ \ - @$(RT_JAR_ARGLIST) $(BOOT_JAR_JFLAGS) - @$(java-vm-cleanup) + $(CD) $(CLASSBINDIR) && \ + $(BOOT_JAR_CMD) c0mf $(JAR_MANIFEST_FILE) $@ \ + @$(RT_JAR_FILELIST) $(BOOT_JAR_JFLAGS) + @$(CD) $(CLASSBINDIR) && $(java-vm-cleanup) # Meta-index construction to make core class loaders lazier @@ -943,10 +937,10 @@ @# @# lib/tools.jar @# - $(BOOT_JAR_CMD) c0f $(LIBDIR)/tools.jar $(addprefix \ - -C $(CLASSBINDIR) , $(TOOLS)) \ - $(BOOT_JAR_JFLAGS) - @$(java-vm-cleanup) + $(CD) $(CLASSBINDIR) && \ + $(BOOT_JAR_CMD) c0f $(ABS_LIBDIR)/tools.jar \ + $(TOOLS) $(BOOT_JAR_JFLAGS) + @$(CD) $(CLASSBINDIR) && $(java-vm-cleanup) $(CP) $(LIBDIR)/tools.jar $(JDK_IMAGE_DIR)/lib/tools.jar @# @# lib/ct.sym From martinrb at google.com Tue Apr 28 23:30:09 2009 From: martinrb at google.com (Martin Buchholz) Date: Tue, 28 Apr 2009 16:30:09 -0700 Subject: PATCH: Tired of waiting for rt.jar to build? In-Reply-To: <1ccfd1c10904281627s7aa853a8l630c642054958bf9@mail.gmail.com> References: <1ccfd1c10904271754s6f56feafub82c97c80109f023@mail.gmail.com> <1ccfd1c10904281627s7aa853a8l630c642054958bf9@mail.gmail.com> Message-ID: <1ccfd1c10904281630r765086a4u8e9d880e7881bd5b@mail.gmail.com> On Tue, Apr 28, 2009 at 16:27, Martin Buchholz wrote: > On Mon, Apr 27, 2009 at 17:54, Martin Buchholz wrote: >> Someone who cares about the Makefiles can also try to remove the >> 16000 gratuitous -C flags that makes jar's life "jar hell". > > Hmmm.... Apparently I care enough. > > Kelly (or Tim?), please review. Let's try that again. http://cr.openjdk.java.net/~martin/dashJ diff --git a/make/common/Release.gmk b/make/common/Release.gmk --- a/make/common/Release.gmk +++ b/make/common/Release.gmk @@ -94,7 +94,7 @@ ifeq ($(PLATFORM), windows) LICENSE_DOCLIST_JDK = $(subst $(LICENSE_VERSION),,\ $(shell $(CD) $(SHARE_JDK_DOC_SRC) && \ - $(LS) *LICENSE*$(LICENSE_VERSION))) + $(LS) *LICENSE*$(LICENSE_VERSION))) LICENSE_DOCLIST_JRE = $(subst $(LICENSE_VERSION),,\ $(shell $(CD) $(SHARE_JRE_DOC_SRC) && \ $(LS) *LICENSE*$(LICENSE_VERSION))) @@ -399,7 +399,7 @@ sun/tools/jstack \ sun/tools/jinfo \ sun/tools/jmap - + # classes that go into jsse.jar JSSE_CLASSES_DIRS = \ sun/security/provider/Sun.class \ @@ -644,7 +644,7 @@ @$(java-vm-cleanup) # Create the manifest file. -JAR_MANIFEST_FILE=$(TEMPDIR)/manifest.tmp +JAR_MANIFEST_FILE=$(ABS_TEMPDIR)/manifest.tmp $(JAR_MANIFEST_FILE): $(MAINMANIFEST) $(BEANMANIFEST) $(prep-target) $(SED) -e "s/@@RELEASE@@/$(RELEASE)/" $(MAINMANIFEST) >> $@ @@ -652,25 +652,22 @@ $(CAT) $(BEANMANIFEST) >> $@ # Create resources.jar containing non-class files -RESOURCES_JAR=$(TEMPDIR)/resources-orig.jar -RES_JAR_ARGLIST=$(RES_JAR_FILELIST)_args -$(RES_JAR_ARGLIST): $(RES_JAR_FILELIST) +RESOURCES_JAR=$(ABS_TEMPDIR)/resources-orig.jar +$(RESOURCES_JAR): $(RES_JAR_FILELIST) $(JAR_MANIFEST_FILE) $(prep-target) - $(SED) -e "s@^@-C $(CLASSBINDIR) @" $< > $@ -$(RESOURCES_JAR): $(RES_JAR_ARGLIST) $(JAR_MANIFEST_FILE) - $(prep-target) - $(BOOT_JAR_CMD) c0mf $(JAR_MANIFEST_FILE) $@ \ - @$(RES_JAR_ARGLIST) $(BOOT_JAR_JFLAGS) - @$(java-vm-cleanup) + $(CD) $(CLASSBINDIR) && \ + $(BOOT_JAR_CMD) c0mf $(JAR_MANIFEST_FILE) $@ \ + @$(RES_JAR_FILELIST) $(BOOT_JAR_JFLAGS) + @$(CD) $(CLASSBINDIR) && $(java-vm-cleanup) # Create jsse.jar containing SunJSSE implementation classes -JSSE_JAR=$(TEMPDIR)/jsse-orig.jar +JSSE_JAR=$(ABS_TEMPDIR)/jsse-orig.jar $(JSSE_JAR): $(JAR_MANIFEST_FILE) $(prep-target) - $(BOOT_JAR_CMD) c0mf $(JAR_MANIFEST_FILE) $@ \ - $(JSSE_CLASSES_DIRS:%=-C $(CLASSBINDIR) %) \ - $(BOOT_JAR_JFLAGS) - @$(java-vm-cleanup) + $(CD) $(CLASSBINDIR) && \ + $(BOOT_JAR_CMD) c0mf $(JAR_MANIFEST_FILE) $@ \ + $(JSSE_CLASSES_DIRS) $(BOOT_JAR_JFLAGS) + @$(CD) $(CLASSBINDIR) && $(java-vm-cleanup) # Create sec-bin.zip SEC_FILES_ZIP=$(ABS_TEMPDIR)/sec-bin.zip @@ -712,15 +709,12 @@ # Create rt.jar RT_JAR=$(ABS_TEMPDIR)/rt-orig.jar -RT_JAR_ARGLIST=$(RT_JAR_FILELIST)_args -$(RT_JAR_ARGLIST): $(RT_JAR_FILELIST) +$(RT_JAR): $(RT_JAR_FILELIST) $(JAR_MANIFEST_FILE) $(prep-target) - $(SED) -e "s@^@-C $(CLASSBINDIR) @" $< > $@ -$(RT_JAR): $(RT_JAR_ARGLIST) $(JAR_MANIFEST_FILE) - $(prep-target) - $(BOOT_JAR_CMD) c0mf $(JAR_MANIFEST_FILE) $@ \ - @$(RT_JAR_ARGLIST) $(BOOT_JAR_JFLAGS) - @$(java-vm-cleanup) + $(CD) $(CLASSBINDIR) && \ + $(BOOT_JAR_CMD) c0mf $(JAR_MANIFEST_FILE) $@ \ + @$(RT_JAR_FILELIST) $(BOOT_JAR_JFLAGS) + @$(CD) $(CLASSBINDIR) && $(java-vm-cleanup) # Meta-index construction to make core class loaders lazier @@ -943,10 +937,10 @@ @# @# lib/tools.jar @# - $(BOOT_JAR_CMD) c0f $(LIBDIR)/tools.jar $(addprefix \ - -C $(CLASSBINDIR) , $(TOOLS)) \ - $(BOOT_JAR_JFLAGS) - @$(java-vm-cleanup) + $(CD) $(CLASSBINDIR) && \ + $(BOOT_JAR_CMD) c0f $(ABS_LIBDIR)/tools.jar \ + $(TOOLS) $(BOOT_JAR_JFLAGS) + @$(CD) $(CLASSBINDIR) && $(java-vm-cleanup) $(CP) $(LIBDIR)/tools.jar $(JDK_IMAGE_DIR)/lib/tools.jar @# @# lib/ct.sym