New project: getting rid of IcedTea local patches

[Andrew John Hughes]

2009/4/9 Alan Bateman <Alan.Bateman at sun.com>:
> Andrew Haley wrote:
>>
>> :
>> The page is at http://icedtea.classpath.org/wiki/IcedTea_JDK6_Patches
>> These are the patches in icedtea/patches and icedtea/patches/hotspot.
>>
>>
>> * Every patch should be assigned to someone.
>>
>> * Every patch should be discussed.
>>
>> * If we can, we will push a patch upstream.  If we can't the discussion
>>  should explain why we can't.
>>
>> Here we go...
>>
>> Andrew.
>>
>
> I'm not very familiar with IcedTea but I cloned the repository to see what
> these patches are about. Here are a few comments:
>
> icedtea-6728542-epoll.patch seems to be a change-set I pushed to jdk7 last
> year. It seems very reasonable to push this into jdk6/jdk6/jdk. Go for it!
>

Yes, I've referenced the bug on the wiki now.  Joe, can we commit this to 6?

> icedtea-bytebuffer-compact.patch - this looks to be a partial fix to
> 6593946. If so, 6593946 is already in jdk6/jdk6/jdk
> (http://hg.openjdk.java.net/jdk6/jdk6/jdk/rev/3e7bfcdcf96f).
>

IcedTea6 is still based on the last build drop of jdk6, not the
Mercurial repository.  So this 6 week old patch won't be in the 25th
of November b14 tarball.
Interestingly, it also still exists in IcedTea7 as there were cases
covered by the patch which didn't make it into the commit.
I've attached that version.  It was originally added by Keith Seitz
while he was working on OpenJDK at Red Hat (according to the
ChangeLog).

> icedtea-io_util-overflow.patch - this looks like the initial fix for
> 6788196. Martin has already pushed this to jdk6/jdk7/jdk
> (http://hg.openjdk.java.net/jdk6/jdk6/jdk/rev/cc4d93e8ae7d).
>

Same case as the epoll patch, not in b14.

> icedtea-jvmtiEnv.patch - I thought JvmtiEnv::GetLineNumberTable already
> handled this case so I'm curious why this one is needed.
>

Added by Andrew Haley as part of work on Shark; perhaps he can explain.

> icedtea-network-unreachable.patch - I'm pretty sure net-dev would be open to
> this because it looks to be cases where the specific exceptions aren't
> thrown in the timed read case.
>

>From our intern, Omair so this is covered by the SCA.  Omair, maybe
you could file a bug report for this (or link to one here if there is
one)?

> icedtea-sunsrc.patch - I'm not sure what this is about but it looks like it
> removes the service configuration files. Does JDI still work?
>

Don't know about this one, all I can say is it was added by Joshua
Sumali in late 2007.  Perhaps someone at Red Hat then can shed some
light on it?

> icedtea-testenv.patch - the changes to
> test/sun/net/InetAddress/nameservice/dns/cname.sh seems reasonable (pilot
> error is why this one was missed when the other tests were updated).
>

Recent patch from Mark Wielaard.  Mark?

> icedtea-jtreg-hatrun.patch - I suspect this is 6545295. We should just fix
> this test (serviceability-dev).
>

Again, this one is from Omair, so he should be able to provide more detail.

> -Alan.
>
> PS: I'm not on distro-pkg-dev so this mail might need the moderator to
> approve.
>
>

Thanks again for the conf. call, very useful!

Cheers,
-- 
Andrew :-)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

Support Free Java!
Contribute to GNU Classpath and the OpenJDK
http://www.gnu.org/software/classpath
http://openjdk.java.net

PGP Key: 94EFD9D8 (http://subkeys.pgp.net)
Fingerprint: F8EF F1EA 401E 2E60 15FA  7927 142C 2591 94EF D9D8