hg: jdk7/build/langtools: 6829575: 100028: Debug information is incomplete or missing

[Jonathan Gibbons]

Andrew.

Earlier this week, Mark announced that Release Team approval was  
required
for the final M3 builds for JDK7. [1]

Even without that, jcheck would require that you have another BugTraq CR
for this issue, even though it is just a modification of a recent fix.  
I didn't see
a new CR get created yet; is that right?

-- Jon

[1]  http://mail.openjdk.java.net/pipermail/jdk7-dev/2009-April/000527.html


On Apr 18, 2009, at 2:58 AM, Andrew Haley wrote:

> Jonathan Gibbons wrote:
>> Andrew Haley wrote:
>>> I'm going to change langtools/jaxp/jaxws to
>>>
>>> ifeq ($(DEBUG_CLASSFILES), true)
>>>  ANT_OPTIONS += -Djavac.debug=true
>>>  ANT_OPTIONS += -Djavac.debuglevel=source,lines,vars
>>> endif
>>
>> Yes.  If all you want to do is to provide a consistent way of  
>> enabling
>> all debug info in classfiles, then I agree with this proposed change.
>> I'm sorry, I misread the earlier email and confused Kelly's proposed
>> change  with your actual changeset.
>
> I cannot tell whether this reply from Jonathan is sufficient  
> permission
> for me to commit this change.  I guess it is, but as this is my first
> commit I'm not sure exactly what the policy is.
>
> I know that my previous patch somewhat broke debuginfo, so I want to  
> fix
> it ASAP, but I don't want to break approval policy.  Damned if I do,  
> and
> damned if I don't...
>
> Andrew.