Request for review: 6833444 version 2

Anthony Petrov Anthony.Petrov at Sun.COM
Mon Apr 27 16:56:38 UTC 2009


On 4/27/2009 7:56 PM Dmitri Trembovetski wrote:
>>> On pretty much any system you can tell if a drive is local or not, 
>>> albeit in a system specific way.
>> That would be cool. However I don't see much justification around 
>> verifying for sure if a path is on the network. After all it's just a 
>> warning message, not a error.
> 
>   It's very easy to check on windows (in shell, adjust appropriately for 
> makefile):
>    net use j: > /dev/null 2>&1
>    if [ $? -ne 0 ]; then
>      # local drive
>    else
>      # remote drive
>    fi
> 
>    If you want to be fancy you could grep the output of net use for 
> "Remote Resource" or something..
Thanks Dmitri. That's totally correct. But still I don't consider it as 
a requirement. If we were to prohibit using a network-located BOOTDIR, 
then this would be a must. Currently this just seems like an overkill 
for such a tiny fix.

--
best regards,
Anthony



More information about the build-dev mailing list