[PATCH FOR REVIEW]: Make source/target options explicit for CORBA bootstrap tools

[Kelly O'Hair]

I also prefer Jon's suggested change.

I was going to suggest the same thing.

-kto

Jonathan Gibbons wrote:
> Andrew,
> 
> If this is a patch for jdk7, it does not appear to be a patch to a 
> recent copy
> of 7. Specifically, you do not seem to have the recent changeset  to set
> the source/target used to compile JDK to 7. [1]
> 
> While your patch does not directly conflict with any edits in that 
> patch, and
> while the effect of your patch looks OK, in that patch I was extending the
> precedent of TARGET_CLASS_VERSION to have an explicit macro for
> (just) the version number, so that it is easy to change the value of (just)
> the version number from the command line.
> 
> With that in mind, I would suggest something like the following for your
> patch:
> 
> BOOT_SOURCE_LANGUAGE_VERSION = 6
> BOOT_TARGET_CLASS_VERSION = 6
> BOOT_JAVACFLAGS  += -encoding ascii -source 
> $(BOOT_SOURCE_LANGUAGE_VERSION) -target $(BOOT_TARGET_CLASS_VERSION)
> 
> -- Jon
> 
> [1] 
> http://mail.openjdk.java.net/pipermail/compiler-dev/2009-July/001286.html
> 
> 
> On Aug 18, 2009, at 5:24 AM, Andrew John Hughes wrote:
> 
>> Currently the javac calls for building the bootstrap tools (not the
>> classes for the final JDK, which correctly now use source and target
>> 7) don't set an explicit source and target version.
>>
>> The webrev:
>>
>> http://cr.openjdk.java.net/~andrew/ecj/02/webrev.01/
>>
>> sets these to 6 explicitly, as happens in the Ant builds performed by
>> langtools/jaxp/jaxws.  This is noticeable especially when using ecj as
>> the bootstrap javac as it defaults to a version < 1.5, and the build
>> fails.
>>
>> Ok to push?
>>
>> Thanks,
>> -- 
>> Andrew :-)
>>
>> Free Java Software Engineer
>> Red Hat, Inc. (http://www.redhat.com)
>>
>> Support Free Java!
>> Contribute to GNU Classpath and the OpenJDK
>> http://www.gnu.org/software/classpath
>> http://openjdk.java.net
>>
>> PGP Key: 94EFD9D8 (http://subkeys.pgp.net)
>> Fingerprint: F8EF F1EA 401E 2E60 15FA  7927 142C 2591 94EF D9D8
>