Need reviewer - minor top level make changes

Andrew John Hughes gnu_andrew at member.fsf.org
Mon Dec 21 16:45:01 UTC 2009


2009/11/19 Kelly O'Hair <Kelly.Ohair at sun.com>:
>
> Need reviewer. Some very minor top level make file changes.
>
> 6727046: Add message when docs are skipped in control build
> 6864011: typo? in top level Makefile: DAYE_STAMP
>
> http://cr.openjdk.java.net/~ohair/openjdk7/top-make-fixes/webrev/
>
> -kto
>
>

This is a bit more than just adding a message.  It also adds:

+  # No DOCS build when JDK_UPDATE_VERSION set
+  ifdef JDK_UPDATE_VERSION
+    GENERATE_DOCS=false
+  endif

JDK_UPDATE_VERSION has to be set for IcedTea to deal with broken
plugins which expect this (such as
http://www.java.com/en/download/help/testvm.xml).  I don't think it
follows that turning on a version setting forces documentation off.
Can we make this an #ifndef OPENJDK block?
-- 
Andrew :-)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

Support Free Java!
Contribute to GNU Classpath and the OpenJDK
http://www.gnu.org/software/classpath
http://openjdk.java.net

PGP Key: 94EFD9D8 (http://subkeys.pgp.net)
Fingerprint: F8EF F1EA 401E 2E60 15FA  7927 142C 2591 94EF D9D8



More information about the build-dev mailing list