[Fwd: Please review fix for 6819847 [Re: [Fwd: Problems with building jmx for OpenJDK.]]]

[Tim Bell]

Clearly this review is of interest to a wider audience.

This fixes the build problem Jon found and reported as 6819847

Until the fix is approved and pushed, the workaround is to add:

    IMPORT_BINARY_PLUGS=true

to your build environment.
Tim

-------- Original Message --------
Subject: Please review fix for 6819847 [Re: [Fwd: Problems with building 
jmx for OpenJDK.]]
Date: Tue, 31 Mar 2009 07:08:41 -0700
From: Tim Bell <tim.bell at sun.com>

Kelly O'Hair wrote:
> I didn't think openjdk7 could build without binary plugs.
> But I've been a bit disconnected from the jdk work lately.

[... snip ...]

> I think I had on my list of things to do:
>   * Change binary plugs default for openjdk6 to 'not use them'
>   * Make sure openjdk7 builds without binary plugs 
> IMPORT_BINARY_PLUGS=false

Please take a look at this fix:

    http://cr.openjdk.java.net/~tbell/6819847/

This implements Kelly's wish "Change binary plugs default for openjdk6
to 'not use them'".  Well - for OpenJDK7, it does.  I'll have to check,
but I think OpenJDK6 is already doing this.

This builds OK with OPENJDK=true and:

1) No setting for IMPORT_BINARY_PLUGS at all.  This works, and it
did NOT import anything.  I expect the Linux distros build this way.
    2009-03-31-003747.tbell.6819847

2) IMPORT_BINARY_PLUGS=false  [Same as 1) above]
    2009-03-31-002722.tbell.6819847

3) IMPORT_BINARY_PLUGS=true   [PLUG IMPORT successful]
    2009-03-31-020718.tbell.6819847

4) Nothing set  [nothing imported]
    2009-03-31-045710.tbell.6819847


JPRT job-IDs are included here so I could keep track and make sure I
looked at the log files.

One question - if the user goes to the trouble to set any of
ALT_BINARY_PLUGS_JARFILE, ALT_BINARY_PLUGS_PATH,
ALT_BUILD_BINARY_PLUGS_PATH, ALT_CLOSED_JDK_IMPORT_PATH
(See the comments in jdk/make/common/Defs.gmk starting at line 127),
should we assume they must really, really want the binary plugs and
force IMPORT_BINARY_PLUGS=true?  Or have them set it as well?

I am thinking we shouldn't do this automatically.  I notice in the logs
that JPRT is setting these even when IMPORT_BINARY_PLUGS=false.

Otherwise, I think we are covered.

Tim