Round two Re: Please review fix for 6819847 [Re: [Fwd: Problems with building jmx for OpenJDK.]]

[Dalibor Topic]

Tim Bell wrote:
> Review feedback convinced me to reverse that last statement.
> 
> Here is round two - please take a look:
> 
>   http://cr.openjdk.java.net/~tbell/6819847/webrev.01/
> 
> With these changes the default behavior is as if IMPORT_BINARY_PLUGS=false

Thanks Tim, the change looks good to me.

> Unless the user explicitly sets any of the PLUGS variables:
>   ALT_BINARY_PLUGS_JARFILE, ALT_BINARY_PLUGS_PATH,
>   ALT_BUILD_BINARY_PLUGS_PATH, ALT_CLOSED_JDK_IMPORT_PATH
> 
> Setting these will force IMPORT_BINARY_PLUGS=true

Nice catch. I like the bit making the binary plugs check optional, too.

cheers,
dalibor topic
-- 
*******************************************************************
Dalibor Topic                   Tel: (+49 40) 23 646 738
Java F/OSS Ambassador           AIM: robiladonaim
Sun Microsystems GmbH           Mobile: (+49 177) 2664 192
Nagelsweg 55                    http://openjdk.java.net
D-20097 Hamburg                 mailto:Dalibor.Topic at sun.com
Sitz der Gesellschaft: Sonnenallee 1, D-85551 Kirchheim-Heimstetten
Amtsgericht München: HRB 161028
Geschäftsführer: Thomas Schröder, Wolfgang Engels, Dr. Roland Bömer
Vorsitzender des Aufsichtsrates: Martin Häring