6856630: Restructure jaxp/jaxws repository
Kelly O'Hair
Kelly.Ohair at Sun.COM
Wed Nov 4 17:50:25 UTC 2009
I'm basically ok with this, but have one concern.
There is no longer a default ant value for drops.dir, it is only
set via the Makefile. Maybe that's ok, just not sure.
I think it means that a plain 'ant' command will always download
from the url. Again, maybe that's fine. So I'm ok with the push.
I've learned to keep ant scripts out of the environment variable
business if at all possible, so leaving any env var logic in
the makefiles may be fine.
Keeping the ant<->make boundaries simple seems like an essential
thing to do, sigh, but is anything "simple" with ant scripts or
Makefiles... :^(
-kto
Andrew John Hughes wrote:
> 2009/10/28 Andrew John Hughes <gnu_andrew at member.fsf.org>:
>
> snip..
>
>> Well spotted; revised version here:
>>
>> http://cr.openjdk.java.net/~andrew/drops/webrev.03/
>
> Does this look ok to push?
More information about the build-dev
mailing list