Review request: Zero ARM and IA-64 fixes

Gary Benson gbenson at redhat.com
Mon Nov 23 10:32:05 UTC 2009


Thanks, pushed.

Cheers,
Gary

Kelly O'Hair wrote:
> Here you go:
>
> 6903453: Zero build on ARM and IA-64
>
> -kto
>
>
> Gary Benson wrote:
> > A new bug is probably better.  Can you file one for me please?
> >
> > Cheers,
> > Gary
> >
> > Kelly O'Hair wrote:
> > > If that bugid makes sense, and has not been used in the repository
> > > before, then it's ok to use it. Seems like a hotspot bug, but should
> > > be ok.
> > >
> > > If you need a new bug filed, I can do that for you. Just let me
> > > know.
> > >
> > > -kto
> > >
> > > Gary Benson wrote:
> > > > Ah, good idea with the ArchFilter :)
> > > >
> > > > I've not exercised my push privileges yet, so I'm not 100%
> > > > sure what to do now.  I need a bug ID first do I not?
> > > > I have http://bugs.sun.com/view_bug.do?bug_id=6896043 for
> > > > a bunch of HotSpot changes I'm working on right now; is it
> > > > possible to piggy-back onto that one or do I need a fresh
> > > > one?
> > > >
> > > > Cheers,
> > > > Gary
> > > >
> > > > Kelly O'Hair wrote:
> > > > > Looks ok to me.
> > > > >
> > > > > I may have some restructuring/simplification coming soon in
> > > > > jdk/make/common/shared/Platform.gmk, so I'll make sure these
> > > > > changes are mimic'd in my new stuff.
> > > > >
> > > > > I'm changing it to have an ArchFilter define, see line 90 in:
> > > > >   http://cr.openjdk.java.net/~ohair/openjdk7/jdk7-build-cygwin-6892741/webrev/make/common/shared/Platform.gmk.html
> > > > >
> > > > > But go ahead with your change, I'll deal with the merge when
> > > > > I get it.
> > > > >
> > > > > -kto
> > > > >
> > > > > Gary Benson wrote:
> > > > > > Hi all,
> > > > > >
> > > > > > This webrev contains fixes to allow OpenJDK with Zero to build
> > > > > > correctly on ARM and IA-64.
> > > > > >
> > > > > >   http://cr.openjdk.java.net/~gbenson/zero-fixes-01/
> > > > > >
> > > > > > Cheers,
> > > > > > Gary

-- 
http://gbenson.net/



More information about the build-dev mailing list