Need reviewer

Mark Reinhold mr at sun.com
Mon Oct 12 05:26:37 UTC 2009


> Date: Sun, 11 Oct 2009 17:35:31 -0700
> From: kelly.ohair at sun.com

> 6888701: Change all template java source files to a .java.template file suffix
> 
> http://cr.openjdk.java.net/~ohair/openjdk7/jdk7-build-template-6888701/webrev/

Most of the files you are renaming in this change are in NIO, and the
names of those files were carefully chosen so as to be invalid Java
class names -- they all contain at least one dash character.

This approach has the advantage that when you visit the files in an
editor or IDE they're treated as Java source files without any further
effort.  This is a feature, not a bug as claimed in 6888701.

I'd like to understand more about the complications in Makefile logic
claimed in 6888701.  If this is such a problem then why are we just
now getting around to fixing it?

- Mark



More information about the build-dev mailing list