Need reviewer - Fixing -D quotes
Kelly O'Hair
Kelly.Ohair at Sun.COM
Mon Oct 12 18:35:51 UTC 2009
Jonathan Gibbons wrote:
> Kelly O'Hair wrote:
>>
>> 6888709: Change use of -DX=\""Y\"" to -DX='"Y"', consistently for all
>> platforms
>>
>> http://cr.openjdk.java.net/~ohair/openjdk7/jdk7-build-quotes-6888709/webrev/
>>
>>
>> -kto
>
> For the record, you changed some quoting of { } as well, but still looks
> good to me.
Mea culpa. Yes, when I got into the -DJAVA_ARGS= stuff, and the launcher
magic, I simplified it a bit so the '' happened with the -D.
---
How old is 'sh' now? I think 30 years from now we will still be dealing
with quoting nightmares. :^(
-kto
>
> -- Jon
More information about the build-dev
mailing list