Need Reviewer: OpenJDK7 Windows VS2010 warning silencing

[John Yeary]

Looks OK to me.

On Tue, Dec 28, 2010 at 6:19 PM, Kelly O'Hair <kelly.ohair at oracle.com>wrote:

> Need Reviewer: Windows VS2010 warning silencing
>
> With Windows VS2010 compilers, we started seeing many warnings about
> supposedly insecure function usage.
> These are not actually detecting errors as much as indicating that certain
> functions used have been known to
> cause security issues when used improperly, so all uses will create a
> warning error.
>
> As much as I agree that some of these functions should not be used
> (sprintf,...), I don't entirely agree with some
> of these warnings, especially when the supposedly insecure function is used
> safely.
> The change below should silence the bulk of these warnings, allowing us to
> see the more critical warnings that
> we really need to fix, not sure what the future setting will be for this.
>
> Expect some efforts in the coming months to reduce warnings, and also
> reduce the use of selected 'banned functions'.
>
> 6991482: Add global jdk makefile options to silence some VS2010 warnings
> http://cr.openjdk.java.net/~ohair/openjdk7/jdk7-build-WIN_WARN/webrev/<http://cr.openjdk.java.net/%7Eohair/openjdk7/jdk7-build-WIN_WARN/webrev/>
>
> -kto
>
> P.S. For more on the Windows Banned functions, see:
>  http://msdn.microsoft.com/en-us/library/bb288454.aspx
>
>


-- 
John Yeary
--
http://javaevangelist.blogspot.com
http://www.johnyeary.com

"Far better it is to dare mighty things, to win glorious triumphs, even
though checkered by failure, than to take rank with those poor spirits who
neither enjoy much nor suffer much, because they live in the gray twilight
that knows not victory nor defeat."
-- Theodore Roosevelt
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.org/pipermail/build-dev/attachments/20101229/3c303012/attachment.htm>