Need reviewer: old echo -e issue and some sanity check cleanup

[Andrew John Hughes]

On 16 June 2010 00:41, Kelly O'Hair <kelly.ohair at oracle.com> wrote:
>
> On Jun 15, 2010, at 4:36 AM, Andrew John Hughes wrote:
>
>> On 15 June 2010 01:47, Kelly O'Hair <kelly.ohair at oracle.com> wrote:
>>>
>>> Need reviewer, had this change sitting around and forgot about it.
>>>
>>> 6535379: Restructure echo messages in makefiles, avoid echo -e
>>>
>>> http://cr.openjdk.java.net/~ohair/openjdk7/sanitycleanup/webrev/
>>>
>>> Creates some common patterns for sanity errors into make macros, and
>>> changes
>>> from
>>> "echo" to "printf" to avoid the dependence on 'echo -e'.
>>>
>>> Let me know what you think.
>>>
>>> -kto
>>>
>>
>>
>> This breaks the build:
>>
>> WARNING: Unknown is not the required Fedora
>
> Humm...  maybe these changes are two stale..  I'll re-review and look into
> it.
>
>>
>>
>> ERROR: You appear to be using C/C++ compiler  which is a missing version.
>>      The official linux builds use C/C++ compiler 4.5.0.
>>      This may produce binaries incorrectly or cause the build to fail.
>>      4.3.0
>> Exiting because of the above error(s).
>>
>> and the messages don't even make sense.
>
> Well, some may have never made sense.
>
> Let me look into it more.
>

Yeah, that output scared me to tell the truth... :-)

Most of the changes look good.  I'd suggest separating out the
non-controversial stuff (like the echo changes) and leaving the
stronger checks for further discussion.

I'm certainly opposed to anything which tells me which distro and GCC
I should be using, especially when it's known to work!

Is the distro identification used for anything but this check?  It at
least needs updating to check /etc/debian_version and
/etc/gentoo-release, though it's never going to work as a sanity check
because there are literally hundreds of distros.

> -kto
>
>> --
>> Andrew :-)
>>
>> Free Java Software Engineer
>> Red Hat, Inc. (http://www.redhat.com)
>>
>> Support Free Java!
>> Contribute to GNU Classpath and the OpenJDK
>> http://www.gnu.org/software/classpath
>> http://openjdk.java.net
>>
>> PGP Key: 94EFD9D8 (http://subkeys.pgp.net)
>> Fingerprint: F8EF F1EA 401E 2E60 15FA  7927 142C 2591 94EF D9D8
>
>



-- 
Andrew :-)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

Support Free Java!
Contribute to GNU Classpath and the OpenJDK
http://www.gnu.org/software/classpath
http://openjdk.java.net

PGP Key: 94EFD9D8 (http://subkeys.pgp.net)
Fingerprint: F8EF F1EA 401E 2E60 15FA  7927 142C 2591 94EF D9D8