Fixes for sanity-compiler-gcc and detection of linux variant

[David Holmes]

Hi Mike,

On 6/11/2010 9:07 AM, Mike Duigou wrote:
> Hi all;
>
> Two minor fixes for review:
>
> 6998014: Use /etc/lsb-release, when available, to detect linux variant and version

Can't comment on this part.

> 6998016: Incorrect ifdef nesting in sane-gcc-compiler rule
>
> http://cr.openjdk.java.net/~mduigou/6998016.0/webrev/

In Defs-linux.gmk I must be missing something:

  ifneq "$(origin ALT_GCC29_COMPILER_PATH)" "undefined"

and

  ifdef ALT_GCC29_COMPILER_PATH

seem completely equivalent. The latter is simpler of course.


In Sanity.gmk ... when I reported this problem it was stated that the 
correct fix was to swap the order of these two lines:

1486 ifeq ($(PLATFORM), solaris)
1487   ifndef OPENJDK

Not saying what you have is wrong, just different to what was stated previously.

Also note the comment at 1483 is out of date as it only refers to Solaris.

Cheers,
David