Need reviewer: NONFCS_BUILD_INFO to add to the non-fcs version string

[Kelly O'Hair]

On Nov 24, 2010, at 12:03 PM, Dr Andrew John Hughes wrote:

> On 11:36 Wed 24 Nov     , Kelly O'Hair wrote:
>> Dang... just shoot me now. :^(
>>
>> Try this:
>>   http://cr.openjdk.java.net/~ohair/openjdk7/nonfcs-version/webrev/
>>
>> Sorry about that.
>>
>
> Looks ok to me.
>
> I assume the motivation is so that MILESTONE doesn't have to be  
> duplicated
> in setting JPRT_BUILD_VERSION?  You can instead now just set  
> NONFCS_BUILD_INFO
> to replace the autogenerated user/date stuff without getting rid of  
> MILESTONE.

Yup. Basically. We have various build systems doing non-fcs builds and  
I wanted a generic
way to add to the version string on those builds so they can be  
identified.

-kto

>
>> -kto
>>
>> On Nov 24, 2010, at 11:28 AM, Mark Wielaard wrote:
>>
>>> On Wed, 2010-11-24 at 11:19 -0800, Kelly O'Hair wrote:
>>>> I need a reviewer for this change:
>>>>
>>>> 6987107: Add NONFCS_BUILD_INFO variable to add to but not modify
>>>> MILESTONE in version string
>>>> http://javaweb.sfbay.sun.com/~ohair/webrevs/jdk7/nonfcs-version/webrev/
>>>
>>> Bit hard to review if the host isn't reachable :)
>>> Could you just attach the patch to your email,
>>> or post it on some publicly reachable machine?
>>>
>>> Thanks,
>>>
>>> Mark
>>>
>>
>
> -- 
> Andrew :)
>
> Free Java Software Engineer
> Red Hat, Inc. (http://www.redhat.com)
>
> Support Free Java!
> Contribute to GNU Classpath and the OpenJDK
> http://www.gnu.org/software/classpath
> http://openjdk.java.net
> PGP Key: 94EFD9D8 (http://subkeys.pgp.net)
> Fingerprint = F8EF F1EA 401E 2E60 15FA  7927 142C 2591 94EF D9D8