Need reviewer: Copyright year updates

David Holmes David.Holmes at oracle.com
Wed Apr 6 21:34:51 UTC 2011


Kelly O'Hair said the following on 04/07/11 02:57:
> I'll reply to myself and see if that email shows up.  :^(
> 
> David, you ok with these changes?

Sure. I only took a cursory look. There's very little that can be 
spotted in such a review as there's no way to know that the file should 
be updated, nor whether other files are missing. Simply checking 
everything says 2011 isn't useful when some should only be 2010.

David

> -kto
> 
> On Apr 6, 2011, at 8:15 AM, Kelly O'Hair wrote:
> 
>> Correct. I ran this first, to make sure some of the last 2010 changesets pushed in were covered for 2010:
>>   sh ./make/scripts/update_copyright_year.sh 2010
>> Then I ran
>>   sh ./make/scripts/update_copyright_year.sh 2011
>> To catch all the 2011 changesets.
>>
>> So I would expect a few to be updates to 2010.  Sorry, I should have made that clear.
>>
>> -kto
>>
>> On Apr 5, 2011, at 10:38 PM, David Holmes wrote:
>>
>>> Hi Kelly,
>>>
>>> There are a bunch of xml files only changed to 2010 not 2011. Doing a grep for all the + lines that don't have 2011 on them there are 15 changes that are only 2010.
>>>
>>> David
>>>
>>>
>>> --- old/jaxp/build-defs.xml	2011-04-05 18:25:26.000000000 -0700
>>> +++ new/jaxp/build-defs.xml	2011-04-05 18:25:26.000000000 -0700
>>> @@ -1,6 +1,6 @@
>>> <?xml version="1.0"?>
>>> <!--
>>> - Copyright (c) 2009, Oracle and/or its affiliates. All rights reserved.
>>> + Copyright (c) 2009, 2010, Oracle and/or its affiliates. All rights reserved.
>>> DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
>>>
>>> This code is free software; you can redistribute it and/or modify it
>>> --- old/jaxp/build-drop-template.xml	2011-04-05 18:25:26.000000000 -0700
>>> +++ new/jaxp/build-drop-template.xml	2011-04-05 18:25:26.000000000 -0700
>>> @@ -1,6 +1,6 @@
>>> <?xml version="1.0"?>
>>> <!--
>>> - Copyright (c) 2009, Oracle and/or its affiliates. All rights reserved.
>>> + Copyright (c) 2009, 2010, Oracle and/or its affiliates. All rights reserved.
>>> DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
>>>
>>> This code is free software; you can redistribute it and/or modify it
>>> --- old/jaxp/build.xml	2011-04-05 18:25:27.000000000 -0700
>>> +++ new/jaxp/build.xml	2011-04-05 18:25:27.000000000 -0700
>>> @@ -1,6 +1,6 @@
>>> <?xml version="1.0"?>
>>> <!--
>>> - Copyright (c) 2009, Oracle and/or its affiliates. All rights reserved.
>>> + Copyright (c) 2009, 2010, Oracle and/or its affiliates. All rights reserved.
>>> DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
>>> -- old/jaxws/build-defs.xml	2011-04-05 18:25:29.000000000 -0700
>>> +++ new/jaxws/build-defs.xml	2011-04-05 18:25:29.000000000 -0700
>>> @@ -1,6 +1,6 @@
>>> <?xml version="1.0"?>
>>> <!--
>>> - Copyright (c) 2009, Oracle and/or its affiliates. All rights reserved.
>>> + Copyright (c) 2009, 2010, Oracle and/or its affiliates. All rights reserved.
>>> --- old/jaxws/build-drop-template.xml	2011-04-05 18:25:30.000000000 -0700
>>> +++ new/jaxws/build-drop-template.xml	2011-04-05 18:25:29.000000000 -0700
>>> @@ -1,6 +1,6 @@
>>> <?xml version="1.0"?>
>>> <!--
>>> - Copyright (c) 2009, Oracle and/or its affiliates. All rights reserved.
>>> + Copyright (c) 2009, 2010, Oracle and/or its affiliates. All rights reserved.
>>> DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
>>>
>>> This code is free software; you can redistribute it and/or modify it
>>> --- old/jaxws/build.xml	2011-04-05 18:25:30.000000000 -0700
>>> +++ new/jaxws/build.xml	2011-04-05 18:25:30.000000000 -0700
>>> @@ -1,6 +1,6 @@
>>> <?xml version="1.0"?>
>>> <!--
>>> - Copyright (c) 2009, Oracle and/or its affiliates. All rights reserved.
>>> + Copyright (c) 2009, 2010, Oracle and/or its affiliates. All rights reserved.
>>>
>>>
>>>
>>> Kelly O'Hair said the following on 04/06/11 15:09:
>>>> Need review of tedious copyright changes....  created using make/scripts/update_copyright_year.sh
>>>> 7033660: Update copyright year to 2011 on any files changed in 2011
>>>> http://cr.openjdk.java.net/~ohair/openjdk7/jdk7-build-copyright-years/webrev/
>>>> Easiest to just scan:
>>>> http://cr.openjdk.java.net/~ohair/openjdk7/jdk7-build-copyright-years/webrev/jdk7-build-copyright-years.patch
>>>> -kto
> 



More information about the build-dev mailing list