Need Reviewer: change MAX_VM_MEMORY to 512

[suchen.chien@oracle.com]

Hi Kumar,

Thanks again for the review and suggestion.  I've updated the code,  
ran test builds on all platforms and update the webrev:

http://cr.openjdk.java.net/~schien/CR6903609/webrev/

Regards,
Su-Chen

On Apr 15, 2011, at 9:39 AM, Kumar Srinivasan wrote:

> Hi,
>
> Sorry if I am jumping in late, but if we are hard-coding  
> MAX_VM_MEMORY to 512,
> the logic just below sets MIN_VM_MEMORY and it checks if it is 128  
> etc. etc.
>
> Why not set MIN_VM_MEMORY = MAX_VM_MEMORY and remove
> all that logic, this will simplify things
> OR
> simply allow the VM to start with its minimum heap and allow it to  
> resize when the
> demand actually arises.
>
> Kumar
>
> ----- SUCHEN.CHIEN at oracle.com wrote:
> > From: SUCHEN.CHIEN at oracle.com
> > To: kelly.ohair at oracle.com
> > Cc: build-dev at openjdk.java.net, david.katleman at oracle.com
> > Sent: Friday, April 15, 2011 9:17:15 AM GMT -08:00 US/Canada Pacific
> > Subject: Re: Need Reviewer: change MAX_VM_MEMORY to 512
> >
> >
> > Hi Kelly,
>
> >
> Thanks for reviewing and providing the suggestion.  I've tested with  
> the suggested codes and updated the webrev.
>
> >
> Regards,
> Su-Chen
> >
> On Apr 12, 2011, at 4:47 PM, Kelly O'Hair wrote:
>
> >
>
> >
> I think we have a problem with this, I've looked at this before, but  
> something is wrong here.
> The end result could be a negative number if the max memory was say,  
> 256Mb RAM, and
> 0 if the machine has 512Mb of RAM.
> >
>
> >
> I'm thinking that this:
>  443     MAX_VM_MEMORY := $(shell \
>  444       if [ $(MB_OF_MEMORY) -le 1024 ] ; then \
>  445         expr $(MB_OF_MEMORY) '-' 512 2> $(DEV_NULL) ; \
>  446       else \
>  447         echo "512"; \
>  448       fi)
> Should just be:
>  443     MAX_VM_MEMORY := 512
>
> >
> To avoid a negative or 0 result. And we should delete all the  
> comments about subtracting.
> Any machine doing a build with less than 512Mb is very very  
> questionable.
> -kto
>
> >
> On Apr 12, 2011, at 4:29 PM, SUCHEN.CHIEN at ORACLE.COM wrote:
>
> >
> Need Reviewer: change MAX_VM_MEMORY to 512
> Windows systems may not be able to handle 896 max memory on every  
> java app started up. Depends on what the system is running, even on  
> a 2Gb system.
>
> Recommend lowering the 896 to 640 or maybe even 512 if possible.
>
> >
> > 6903609: Max memory of 896 may be too large for typical windows  
> developer environment
> > http://cr.openjdk.java.net/~schien/CR6903609/webrev/
> >
> >
> >
> >
> > Su-Chen
>
> >
>
> >

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.org/pipermail/build-dev/attachments/20110427/28ff59f7/attachment.htm>