please review 7122061: enable -Werror in various jdk build steps

[Alan Bateman]

On 16/12/2011 02:59, Stuart Marks wrote:
> The webrev is here:
>
> http://cr.openjdk.java.net/~smarks/reviews/7122061/webrev.0/
>
> This defines the JAVAC_MAX_WARNINGS and JAVAC_WARNINGS_FATAL variables 
> in a variety of Makefiles within the jdk repository. This essentially 
> adds -Xlint:all -Werror to the javac command lines, so that henceforth 
> if any lint warnings are introduced, the build will fail.
>
> I'm applying these flags only to build steps that are already warnings 
> free. (Last week's warnings cleanup effort cleared warnings from four 
> build steps, in addition to knocking off a couple thousand warnings 
> across the build.) I've applied this change and have built 
> successfully on all platforms.
>
> With this change, 57 of the 93 javac build steps in the jdk repo are 
> now lint warning free, and are protected from the introduction of new 
> errors through the use of -Werror.
>
> Thanks,
>
> s'marks
Stuart - the changes look okay to me but it would be good to get 
confirmation that you've done both full and partial builds with these 
changes. Also I think we need confirmation that incremental builds in 
each of these areas isn't impacted. My concern is implicit compilation 
where compiling code in warning free areas may compile code in areas 
that are not warning free yet. Sasha did great work over the summer and 
part of his approach was to make warnings fatal in the errors that he 
cleaned up. On a couple of occasions we ran into issues where implicit 
compilation caused code in areas with warnings to be compiled. Such 
issues are usually quick to fix but I'm sure you get my concern.

-Ala