please review 7122061: enable -Werror in various jdk build steps

[Stuart Marks]

On 12/22/11 1:51 PM, Kelly O'Hair wrote:
> On Dec 22, 2011, at 12:46 PM, Joe Darcy wrote:
>> As an aside, I've thought it was a bit of design error that implicit
>> compilation was the default.
>
> Me too.
>
>> Since JDK 6 there has been a javac option that can be used to disable
>> implicit compilation, -implicit:none.
>>
>> Perhaps this option could be used in some portion of the JDK build.
>
> The build infrastructure work will be using that. No more implicit compilations.
>
> In the existing Makefiles, adding in -implicit:none might break some of them,
> the Makefiles have relied on this
> implicit compilation for a while now.

Yeah I've always been surprised by implicit compilation.

Unfortunately -implicit:none doesn't really help the warnings case. All it does 
is control whether .class files are generated. Even if -implicit:none is given, 
javac will still parse, syntax-check, and issue warnings for implicitly 
depended-upon files, possibly stopping the build if -Werror is present.

s'marks